rails_bootstrap_form 0.9.8 → 0.9.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 73b8b86f78e40f77d36ba3857ef15c9efe939480d327011ba083132d48668654
-  data.tar.gz: 897ed641bdc6147d29698901a0b9f37ce71a46d0581734a844cf03666fbf5c20
+  metadata.gz: 4d162d5f0c75c1cb4197b2a39c2a97507701b9551a36ed8dec2d0c854d1f1765
+  data.tar.gz: ed59ebe1781a986acaa02e21d58a0de124bd28db51416ab95651394bd77c3c60
 SHA512:
-  metadata.gz: 0b5ee6a90da2f11246c01c6f41f01d0fe067cd07ba26b56773e50b6c67c3b87e67d8714694c0c11240d31cb8d58255c58610dbf6304cea21fd547abdc718f8db
-  data.tar.gz: 1554395fcabb6df7f38722c5a26eb680b8436c7bd54f9567477db6b302208872d53417abca1d219a89f48c7fcff8ff8b22e9c26aafa194c79bd683eb83a2ed85
+  metadata.gz: ce0eb94537c026a961c5323567e150c4c3c962252d6e670317a08176d6dc70c65aca0c70ea66dbf1ab90b874f25363218fc6fe084d819282b9310618e9853a2f
+  data.tar.gz: 5b7c554cc34e2e9d603f623a263bef1ad019fe2e9ff0c27a276e2c2196a92502d28d1a123e0c9ec93d38115e4c78c0174b8ef6500d3278e86908c25e094dfba6

data/CHANGELOG.md

@@ -4,6 +4,10 @@ You can find recent releases with docs in GitHub:
 
 https://github.com/shivam091/rails_bootstrap_form/releases
 
+## [0.9.9](https://github.com/shivam091/rails_bootstrap_form/compare/v0.9.8...v0.9.9) - 2023-07-02
+
+- Code smell fixes and removed `role="form"` from demo application and readme.
+
 ## [0.9.8](https://github.com/shivam091/rails_bootstrap_form/compare/v0.9.7...v0.9.8) - 2023-07-01
 
 ### What's fixed

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails_bootstrap_form (0.9.8)
+    rails_bootstrap_form (0.9.9)
       actionpack (~> 7.0)
       activemodel (~> 7.0)
 

data/README.md

@@ -97,7 +97,7 @@ To get started, use the `bootstrap_form_for` helper in place of the Rails [`form
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <label class="form-label required" for="user_email">Email address</label>
     <input class="form-control" aria-required="true" required="required" type="email" name="user[email]" id="user_email">
@@ -135,7 +135,7 @@ To get started, use the `bootstrap_form_with` helper in place of the Rails [`for
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <label class="form-label required" for="user_email">Email address</label>
     <input class="form-control" aria-required="true" required="required" type="email" name="user[email]" id="user_email">
@@ -203,7 +203,7 @@ Here's an example of a form where one field uses different layout:
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <label class="form-label required" for="user_name">Name</label>
     <input class="form-control" aria-required="true" required="required" type="text" name="user[name]" id="user_name">
@@ -346,7 +346,7 @@ Here's an example of how it looks like:
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <label class="form-label required" for="user_email">Email address</label>
     <input class="form-control" aria-required="true" required="required" type="email" name="user[email]" id="user_email">
@@ -379,7 +379,7 @@ Here's an example of how it looks like by default:
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="row mb-3">
     <label class="col-form-label col-sm-2 required" for="user_email">Email address</label>
     <div class="col-sm-10">
@@ -416,7 +416,7 @@ The `label_col_wrapper_class` and `field_col_wrapper_class` css classes can also
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="row mb-3">
     <label class="col-form-label col-sm-2 required" for="user_name">Name</label>
     <div class="col-sm-10">
@@ -470,7 +470,7 @@ Here's an example of how it looks like:
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user row row-cols-lg-auto g-3 align-items-center" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user row row-cols-lg-auto g-3 align-items-center" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="col-12">
     <label class="form-label visually-hidden required" for="user_email">Email address</label>
     <input class="form-control" aria-required="true" required="required" placeholder="Email address" type="email" name="user[email]" id="user_email">
@@ -921,7 +921,7 @@ Our `fields_for` helper accepts the same arguments as the [default Rails helper]
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <label class="form-label required" for="user_email">Email address</label>
     <input autocomplete="new-email" class="form-control" aria-required="true" required="required" type="email" name="user[email]" id="user_email">
@@ -984,7 +984,7 @@ By setting `bootstrap` option on `bootstrap_form_for` or `bootstrap_form_with`,
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="row mb-3">
     <label class="col-form-label col-sm-2 required" for="user_email">Email address</label>
     <div class="col-sm-10">
@@ -1930,7 +1930,7 @@ The `floating` option can be used to enable Bootstrap floating labels. This opti
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <div class="form-floating">
       <input class="form-control" aria-required="true" required="required" placeholder="Name" type="text" name="user[name]" id="user_name">
@@ -1994,7 +1994,7 @@ By default, fields that have validation errors will be outlined in red and the e
 This generates the following HTML:
 
 ```html
-<form role="form" novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
+<form novalidate="novalidate" class="new_user" id="new_user" action="/users" accept-charset="UTF-8" method="post">
   <div class="mb-3">
     <label class="form-label required is-invalid" for="user_email">Email address</label>
     <input class="form-control is-invalid" aria-required="true" required="required" type="email" name="user[email]" id="user_email">

data/demo/config/initializers/rails_bootstrap_form.rb

@@ -6,5 +6,5 @@
 
 RailsBootstrapForm.configure do |config|
   # to make forms non-compliant with W3C.
-  config.default_form_attributes = {role: "form", novalidate: true}
+  config.default_form_attributes = {novalidate: true}
 end

data/lib/rails_bootstrap_form/action_view_extensions/bootstrap_form_helper.rb

@@ -36,6 +36,8 @@ module RailsBootstrapForm
         end
       end
 
+      private
+
       def supress_form_field_errors
         original_proc = ActionView::Base.field_error_proc
         ActionView::Base.field_error_proc = RailsBootstrapForm.field_error_proc
@@ -43,8 +45,6 @@ module RailsBootstrapForm
       ensure
         ActionView::Base.field_error_proc = original_proc
       end
-
-      private :supress_form_field_errors
     end
   end
 end

data/lib/rails_bootstrap_form/bootstrap_form_builder.rb

@@ -30,6 +30,8 @@ module RailsBootstrapForm
       super(record_name, record_object, fields_options, &block)
     end
 
+    private
+
     def apply_default_form_options(options)
       options[:html] ||= {}
       options[:html].reverse_merge!(RailsBootstrapForm.config.default_form_attributes)
@@ -49,7 +51,5 @@ module RailsBootstrapForm
       fields_options = bootstrap.deep_merge!(fields_options)
       fields_options
     end
-
-    private :apply_default_form_options, :fields_for_options, :apply_default_form_classes
   end
 end

data/lib/rails_bootstrap_form/bootstrap_form_options.rb

@@ -177,6 +177,8 @@ module RailsBootstrapForm
       self.field_class ||= css_class
     end
 
+    private
+
     def set_defaults
       @disabled = false
 
@@ -216,7 +218,5 @@ module RailsBootstrapForm
 
       @render_as_button = false
     end
-
-    private :set_defaults
   end
 end

data/lib/rails_bootstrap_form/helpers.rb

@@ -21,37 +21,29 @@ module RailsBootstrapForm
     include Buttons
     include Choice
 
-    def self.included(base_class)
-      def sanitized_tag_name(attribute, value)
-        # label's `for` attribute needs to match checkbox/radio button tag's id, IE sanitized value, IE
-        # https://github.com/rails/rails/blob/5-0-stable/actionview/lib/action_view/helpers/tags/base.rb#L123-L125
-        "#{@object_name}_#{attribute}_#{value.to_s.gsub(/\s/, "_").gsub(/[^-[[:word:]]]/, "").mb_chars.downcase}"
-      end
-
-      def control_specific_class(field_tag_name)
-        "rails-bootstrap-forms-#{field_tag_name.to_s.tr("_", "-")}"
-      end
-
-      def is_size_valid?(bootstrap)
-        bootstrap.size && %i(sm lg).include?(bootstrap.size)
-      end
-
-      def field_offset_class(label_col_wrapper_class)
-        label_col_wrapper_class.gsub(/\bcol-(\w+)-(\d)\b/, 'offset-\1-\2')
-      end
-
-      def add_css_class!(options, css_class)
-        the_class = [options[:class], css_class].compact
-        options[:class] = the_class if the_class.present?
-      end
-
-      # def remove_css_class!(options, css_class)
-      #   the_class = options[:class].to_s.split(" ")
-      #   options[:class] = (the_class - [css_class]).compact.join(" ")
-      #   options.delete(:class) if options[:class].blank?
-      # end
-
-      private :control_specific_class, :is_size_valid?, :add_css_class!
+    private
+
+    def sanitized_tag_name(attribute, value)
+      # label's `for` attribute needs to match checkbox/radio button tag's id, IE sanitized value, IE
+      # https://github.com/rails/rails/blob/5-0-stable/actionview/lib/action_view/helpers/tags/base.rb#L123-L125
+      "#{@object_name}_#{attribute}_#{value.to_s.gsub(/\s/, "_").gsub(/[^-[[:word:]]]/, "").mb_chars.downcase}"
+    end
+
+    def field_offset_class(label_col_wrapper_class)
+      label_col_wrapper_class.gsub(/\bcol-(\w+)-(\d)\b/, 'offset-\1-\2')
+    end
+
+    def add_css_class!(options, css_class)
+      the_class = [options[:class], css_class].compact
+      options[:class] = the_class if the_class.present?
+    end
+
+    def control_specific_class(field_tag_name)
+      "rails-bootstrap-forms-#{field_tag_name.to_s.tr("_", "-")}"
+    end
+
+    def is_size_valid?(bootstrap)
+      bootstrap.size && %i(sm lg).include?(bootstrap.size)
     end
   end
 end

data/lib/rails_bootstrap_form/version.rb

@@ -3,6 +3,6 @@
 # -*- warn_indent: true -*-
 
 module RailsBootstrapForm
-  VERSION = "0.9.8".freeze
+  VERSION = "0.9.9".freeze
   REQUIRED_RAILS_VERSION = "~> 7.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_bootstrap_form
 version: !ruby/object:Gem::Version
-  version: 0.9.8
+  version: 0.9.9
 platform: ruby
 authors:
 - Harshal LADHE (shivam091)
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-07-01 00:00:00.000000000 Z
+date: 2023-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: generator_spec