rails_best_practices 1.7.0 → 1.7.1
Sign up to get free protection for your applications and to get access to all the features.
data/Gemfile.lock
CHANGED
data/README.md
CHANGED
@@ -7,15 +7,17 @@ rails_best_practices
|
|
7
7
|
|
8
8
|
rails_best_practices is a code metric tool to check the quality of rails codes.
|
9
9
|
|
10
|
-
|
10
|
+
it supports following ORM/ODMs:
|
11
11
|
|
12
|
-
activerecord
|
13
|
-
mongoid
|
14
|
-
mongomapper
|
12
|
+
* activerecord
|
13
|
+
* mongoid
|
14
|
+
* mongomapper
|
15
15
|
|
16
|
-
|
17
|
-
|
18
|
-
|
16
|
+
following template engines:
|
17
|
+
|
18
|
+
* erb
|
19
|
+
* haml
|
20
|
+
* slim
|
19
21
|
|
20
22
|
Usage
|
21
23
|
-----
|
@@ -31,6 +31,8 @@ module RailsBestPractices
|
|
31
31
|
else
|
32
32
|
if :bare_assoc_hash == first_argument.sexp_type
|
33
33
|
route_node = first_argument.hash_values.first
|
34
|
+
# do not parse redirect block
|
35
|
+
return if :method_add_arg == route_node.sexp_type
|
34
36
|
controller_name, action_name = route_node.to_s.split('#')
|
35
37
|
else
|
36
38
|
controller_name, action_name = first_argument.to_s.split('/')
|
@@ -39,18 +41,26 @@ module RailsBestPractices
|
|
39
41
|
end
|
40
42
|
when "match", "root"
|
41
43
|
options = node.arguments.all.last
|
42
|
-
|
43
|
-
|
44
|
-
|
45
|
-
|
46
|
-
|
47
|
-
|
48
|
-
|
49
|
-
|
50
|
-
|
51
|
-
|
52
|
-
|
44
|
+
case options.sexp_type
|
45
|
+
when :bare_assoc_hash
|
46
|
+
if options.hash_value("controller").present?
|
47
|
+
return if :regexp_literal == options.hash_value("controller").sexp_type
|
48
|
+
controller_name = options.hash_value("controller").to_s
|
49
|
+
action_name = options.hash_value("action").present? ? options.hash_value("action").to_s : "*"
|
50
|
+
@routes.add_route(current_namespaces, controller_name, action_name)
|
51
|
+
else
|
52
|
+
route_node = options.hash_values.find { |value_node| :string_literal == value_node.sexp_type && value_node.to_s.include?('#') }
|
53
|
+
if route_node.present?
|
54
|
+
controller_name, action_name = route_node.to_s.split('#')
|
55
|
+
@routes.add_route(current_namespaces, controller_name.underscore, action_name)
|
56
|
+
end
|
57
|
+
end
|
58
|
+
when :string_literal, :symbol_literal
|
59
|
+
if current_controller_name
|
60
|
+
@routes.add_route(current_namespaces, current_controller_name, options.to_s)
|
53
61
|
end
|
62
|
+
else
|
63
|
+
# do nothing
|
54
64
|
end
|
55
65
|
else
|
56
66
|
# nothing to do
|
@@ -78,20 +88,34 @@ module RailsBestPractices
|
|
78
88
|
|
79
89
|
# remember the namespace.
|
80
90
|
def start_method_add_block(node)
|
81
|
-
|
91
|
+
case node.message.to_s
|
92
|
+
when "namespace"
|
82
93
|
@namespaces << node.arguments.all.first.to_s
|
83
|
-
|
94
|
+
when "scope"
|
95
|
+
if node.arguments.all.last.hash_value("module").present?
|
96
|
+
@namespaces << node.arguments.all.last.hash_value("module").to_s
|
97
|
+
end
|
98
|
+
when "with_options"
|
84
99
|
argument = node.arguments.all.last
|
85
100
|
if :bare_assoc_hash == argument.sexp_type && argument.hash_value("controller").present?
|
86
101
|
@controller_name = argument.hash_value("controller").to_s
|
87
102
|
end
|
103
|
+
else
|
104
|
+
# do nothing
|
88
105
|
end
|
89
106
|
end
|
90
107
|
|
91
108
|
# end of namespace call.
|
92
109
|
def end_method_add_block(node)
|
93
|
-
|
110
|
+
case node.message.to_s
|
111
|
+
when "namespace"
|
94
112
|
@namespaces.pop
|
113
|
+
when "scope"
|
114
|
+
if node.arguments.all.last.hash_value("module").present?
|
115
|
+
@namespaces.pop
|
116
|
+
end
|
117
|
+
else
|
118
|
+
# do nothing
|
95
119
|
end
|
96
120
|
end
|
97
121
|
|
@@ -102,6 +126,9 @@ module RailsBestPractices
|
|
102
126
|
resource_names.each do |resource_name|
|
103
127
|
@controller_name = node.arguments.all.first.to_s
|
104
128
|
options = node.arguments.all.last
|
129
|
+
if options.hash_value("module").present?
|
130
|
+
@namespaces << options.hash_value("module").to_s
|
131
|
+
end
|
105
132
|
if options.hash_value("controller").present?
|
106
133
|
@controller_name = options.hash_value("controller").to_s
|
107
134
|
end
|
@@ -131,6 +158,9 @@ module RailsBestPractices
|
|
131
158
|
@routes.add_route(current_namespaces, current_controller_name, action_name)
|
132
159
|
end
|
133
160
|
end
|
161
|
+
if options.hash_value("module").present?
|
162
|
+
@namespaces.pop
|
163
|
+
end
|
134
164
|
end
|
135
165
|
end
|
136
166
|
|
@@ -438,16 +438,21 @@ describe RailsBestPractices::Prepares::RoutePrepare do
|
|
438
438
|
RailsBestPracticesCom::Application.routes.draw do
|
439
439
|
resources :posts, :only => [:show] do
|
440
440
|
get :list, :on => :collection
|
441
|
+
collection do
|
442
|
+
get :search
|
443
|
+
match :available
|
444
|
+
end
|
441
445
|
post :create, :on => :member
|
442
|
-
|
443
|
-
|
446
|
+
member do
|
447
|
+
put :update
|
448
|
+
end
|
444
449
|
end
|
445
450
|
end
|
446
451
|
EOF
|
447
452
|
runner.prepare('config/routes.rb', content)
|
448
453
|
routes = RailsBestPractices::Prepares.routes
|
449
|
-
routes.size.should ==
|
450
|
-
routes.map(&:to_s).should == ["PostsController#show", "PostsController#list", "PostsController#
|
454
|
+
routes.size.should == 6
|
455
|
+
routes.map(&:to_s).should == ["PostsController#show", "PostsController#list", "PostsController#search", "PostsController#available", "PostsController#create", "PostsController#update"]
|
451
456
|
end
|
452
457
|
|
453
458
|
it "should add route with nested routes" do
|
@@ -477,6 +482,23 @@ describe RailsBestPractices::Prepares::RoutePrepare do
|
|
477
482
|
routes = RailsBestPractices::Prepares.routes
|
478
483
|
routes.map(&:to_s).should == ["Admin::Test::PostsController#index"]
|
479
484
|
end
|
485
|
+
|
486
|
+
it "should add route with scope" do
|
487
|
+
content =<<-EOF
|
488
|
+
RailsBestPracticesCom::Application.routes.draw do
|
489
|
+
scope :module => "admin" do
|
490
|
+
resources :posts, :only => [:index]
|
491
|
+
end
|
492
|
+
resources :discussions, :only => [:index], :module => "admin"
|
493
|
+
scope "/admin" do
|
494
|
+
resources :comments, :only => [:index]
|
495
|
+
end
|
496
|
+
end
|
497
|
+
EOF
|
498
|
+
runner.prepare('config/routes.rb', content)
|
499
|
+
routes = RailsBestPractices::Prepares.routes
|
500
|
+
routes.map(&:to_s).should == ["Admin::PostsController#index", "Admin::DiscussionsController#index", "CommentsController#index"]
|
501
|
+
end
|
480
502
|
end
|
481
503
|
|
482
504
|
it "should add route for direct get/post" do
|
@@ -538,5 +560,17 @@ describe RailsBestPractices::Prepares::RoutePrepare do
|
|
538
560
|
routes = RailsBestPractices::Prepares.routes
|
539
561
|
routes.size.should == 0
|
540
562
|
end
|
563
|
+
|
564
|
+
it "should do nothing for redirect" do
|
565
|
+
content =<<-EOF
|
566
|
+
RailsBestPracticesCom::Application.routes.draw do
|
567
|
+
match "/stories/:name" => redirect("/posts/%{name}")
|
568
|
+
match "/stories" => redirect {|p, req| "/posts/\#{req.subdomain}" }
|
569
|
+
end
|
570
|
+
EOF
|
571
|
+
runner.prepare('config/routes.rb', content)
|
572
|
+
routes = RailsBestPractices::Prepares.routes
|
573
|
+
routes.size.should == 0
|
574
|
+
end
|
541
575
|
end
|
542
576
|
end
|
metadata
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: rails_best_practices
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 1.7.
|
4
|
+
version: 1.7.1
|
5
5
|
prerelease:
|
6
6
|
platform: ruby
|
7
7
|
authors:
|
@@ -9,11 +9,11 @@ authors:
|
|
9
9
|
autorequire:
|
10
10
|
bindir: bin
|
11
11
|
cert_chain: []
|
12
|
-
date: 2011-12-
|
12
|
+
date: 2011-12-17 00:00:00.000000000Z
|
13
13
|
dependencies:
|
14
14
|
- !ruby/object:Gem::Dependency
|
15
15
|
name: sexp_processor
|
16
|
-
requirement: &
|
16
|
+
requirement: &70129980375200 !ruby/object:Gem::Requirement
|
17
17
|
none: false
|
18
18
|
requirements:
|
19
19
|
- - ! '>='
|
@@ -21,10 +21,10 @@ dependencies:
|
|
21
21
|
version: '0'
|
22
22
|
type: :runtime
|
23
23
|
prerelease: false
|
24
|
-
version_requirements: *
|
24
|
+
version_requirements: *70129980375200
|
25
25
|
- !ruby/object:Gem::Dependency
|
26
26
|
name: progressbar
|
27
|
-
requirement: &
|
27
|
+
requirement: &70129980374200 !ruby/object:Gem::Requirement
|
28
28
|
none: false
|
29
29
|
requirements:
|
30
30
|
- - ! '>='
|
@@ -32,10 +32,10 @@ dependencies:
|
|
32
32
|
version: '0'
|
33
33
|
type: :runtime
|
34
34
|
prerelease: false
|
35
|
-
version_requirements: *
|
35
|
+
version_requirements: *70129980374200
|
36
36
|
- !ruby/object:Gem::Dependency
|
37
37
|
name: colored
|
38
|
-
requirement: &
|
38
|
+
requirement: &70129980372820 !ruby/object:Gem::Requirement
|
39
39
|
none: false
|
40
40
|
requirements:
|
41
41
|
- - ! '>='
|
@@ -43,10 +43,10 @@ dependencies:
|
|
43
43
|
version: '0'
|
44
44
|
type: :runtime
|
45
45
|
prerelease: false
|
46
|
-
version_requirements: *
|
46
|
+
version_requirements: *70129980372820
|
47
47
|
- !ruby/object:Gem::Dependency
|
48
48
|
name: erubis
|
49
|
-
requirement: &
|
49
|
+
requirement: &70129980371640 !ruby/object:Gem::Requirement
|
50
50
|
none: false
|
51
51
|
requirements:
|
52
52
|
- - ! '>='
|
@@ -54,10 +54,10 @@ dependencies:
|
|
54
54
|
version: '0'
|
55
55
|
type: :runtime
|
56
56
|
prerelease: false
|
57
|
-
version_requirements: *
|
57
|
+
version_requirements: *70129980371640
|
58
58
|
- !ruby/object:Gem::Dependency
|
59
59
|
name: i18n
|
60
|
-
requirement: &
|
60
|
+
requirement: &70129980371140 !ruby/object:Gem::Requirement
|
61
61
|
none: false
|
62
62
|
requirements:
|
63
63
|
- - ! '>='
|
@@ -65,10 +65,10 @@ dependencies:
|
|
65
65
|
version: '0'
|
66
66
|
type: :runtime
|
67
67
|
prerelease: false
|
68
|
-
version_requirements: *
|
68
|
+
version_requirements: *70129980371140
|
69
69
|
- !ruby/object:Gem::Dependency
|
70
70
|
name: activesupport
|
71
|
-
requirement: &
|
71
|
+
requirement: &70129980370380 !ruby/object:Gem::Requirement
|
72
72
|
none: false
|
73
73
|
requirements:
|
74
74
|
- - ! '>='
|
@@ -76,10 +76,10 @@ dependencies:
|
|
76
76
|
version: '0'
|
77
77
|
type: :runtime
|
78
78
|
prerelease: false
|
79
|
-
version_requirements: *
|
79
|
+
version_requirements: *70129980370380
|
80
80
|
- !ruby/object:Gem::Dependency
|
81
81
|
name: rake
|
82
|
-
requirement: &
|
82
|
+
requirement: &70129980369260 !ruby/object:Gem::Requirement
|
83
83
|
none: false
|
84
84
|
requirements:
|
85
85
|
- - ! '>='
|
@@ -87,10 +87,10 @@ dependencies:
|
|
87
87
|
version: '0'
|
88
88
|
type: :development
|
89
89
|
prerelease: false
|
90
|
-
version_requirements: *
|
90
|
+
version_requirements: *70129980369260
|
91
91
|
- !ruby/object:Gem::Dependency
|
92
92
|
name: rspec
|
93
|
-
requirement: &
|
93
|
+
requirement: &70129980368480 !ruby/object:Gem::Requirement
|
94
94
|
none: false
|
95
95
|
requirements:
|
96
96
|
- - ! '>='
|
@@ -98,10 +98,10 @@ dependencies:
|
|
98
98
|
version: '0'
|
99
99
|
type: :development
|
100
100
|
prerelease: false
|
101
|
-
version_requirements: *
|
101
|
+
version_requirements: *70129980368480
|
102
102
|
- !ruby/object:Gem::Dependency
|
103
103
|
name: haml
|
104
|
-
requirement: &
|
104
|
+
requirement: &70129980367900 !ruby/object:Gem::Requirement
|
105
105
|
none: false
|
106
106
|
requirements:
|
107
107
|
- - ! '>='
|
@@ -109,10 +109,10 @@ dependencies:
|
|
109
109
|
version: '0'
|
110
110
|
type: :development
|
111
111
|
prerelease: false
|
112
|
-
version_requirements: *
|
112
|
+
version_requirements: *70129980367900
|
113
113
|
- !ruby/object:Gem::Dependency
|
114
114
|
name: slim
|
115
|
-
requirement: &
|
115
|
+
requirement: &70129980367200 !ruby/object:Gem::Requirement
|
116
116
|
none: false
|
117
117
|
requirements:
|
118
118
|
- - ! '>='
|
@@ -120,10 +120,10 @@ dependencies:
|
|
120
120
|
version: '0'
|
121
121
|
type: :development
|
122
122
|
prerelease: false
|
123
|
-
version_requirements: *
|
123
|
+
version_requirements: *70129980367200
|
124
124
|
- !ruby/object:Gem::Dependency
|
125
125
|
name: bundler
|
126
|
-
requirement: &
|
126
|
+
requirement: &70129980366380 !ruby/object:Gem::Requirement
|
127
127
|
none: false
|
128
128
|
requirements:
|
129
129
|
- - ! '>='
|
@@ -131,7 +131,7 @@ dependencies:
|
|
131
131
|
version: '0'
|
132
132
|
type: :development
|
133
133
|
prerelease: false
|
134
|
-
version_requirements: *
|
134
|
+
version_requirements: *70129980366380
|
135
135
|
description: a code metric tool for rails codes, written in Ruby.
|
136
136
|
email:
|
137
137
|
- flyerhzm@gmail.com
|
@@ -303,7 +303,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
|
|
303
303
|
version: '0'
|
304
304
|
segments:
|
305
305
|
- 0
|
306
|
-
hash: -
|
306
|
+
hash: -1979137183600671453
|
307
307
|
required_rubygems_version: !ruby/object:Gem::Requirement
|
308
308
|
none: false
|
309
309
|
requirements:
|