rails_best_practices 1.5.2 → 1.5.3

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails_best_practices (1.5.2)
+    rails_best_practices (1.5.3)
       activesupport
       colored
       erubis

data/README.md

@@ -28,6 +28,7 @@ By default rails_best_practices will do parse codes in vendor, spec, test and fe
             --with-textmate              open file by textmate in html format
             --with-mvim                  open file by mvim in html format
             --with-git                   display git commit and git username in html format
+            --with-hg                    display hg commit and hg username in html format
             --vendor                     include vendor files
             --spec                       include spec files
             --test                       include test files

data/assets/result.html.erb

@@ -73,7 +73,10 @@
         <th>Filename</th>
         <th>Line Number</th>
         <th>Warning Message</th>
-        <% if @git %>
+        <% if @hg %>
+          <th>Hg Commit</th>
+          <th>Hg Username</th>
+        <% elsif @git %>
           <th>Git Commit</th>
           <th>Git Username</th>
         <% end %>
@@ -93,7 +96,10 @@
           <td class='message'>
             <a href='<%= error.url %>' target='_blank'><%= error.message %></a>
           </td>
-          <% if @git %>
+          <% if @hg %>
+            <td class='hg_commit'><%= error.hg_commit %></td>
+            <td class='hg_usename'><%= error.hg_username %></td>
+          <% elsif @git %>
             <td class='git_commit'><%= error.git_commit %></td>
             <td class='git_usename'><%= error.git_username %></td>
           <% end %>

data/lib/rails_best_practices.rb

@@ -22,227 +22,11 @@
 # OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
-require 'fileutils'
-
-require 'progressbar'
-require 'colored'
-
 require 'rails_best_practices/lexicals'
 require 'rails_best_practices/prepares'
 require 'rails_best_practices/reviews'
 require 'rails_best_practices/core'
+require 'rails_best_practices/analyzer'
 
-# RailsBestPractices helps you to analyze your rails code, according to best practices on http://rails-bestpractices.
-# if it finds any violatioins to best practices, it will give you some readable suggestions.
-#
-# The analysis process is partitioned into two parts,
-#
-# 1. prepare process, it checks only model and mailer files, do some preparations, such as remember model names and associations.
-# 2. review process, it checks all files, according to configuration, it really check if codes violate the best practices, if so, remember the violations.
-#
-# After analyzing, output the violations.
 module RailsBestPractices
-
-  DEFAULT_CONFIG = File.join(File.dirname(__FILE__), "..", "rails_best_practices.yml")
-
-  class <<self
-    attr_writer :runner
-
-    # generate configuration yaml file.
-    #
-    # @param [String] path where to generate the configuration yaml file
-    def generate(path)
-      @path =  path || '.'
-      FileUtils.cp DEFAULT_CONFIG, File.join(@path, 'config/rails_best_practices.yml')
-    end
-
-    # start checking rails codes.
-    #
-    # there are two steps to check rails codes,
-    #
-    # 1. prepare process, check all model and mailer files.
-    # 2. review process, check all files.
-    #
-    # if there are violations to rails best practices, output them.
-    #
-    # @param [String] path the directory of rails project
-    # @param [Hash] options
-    def start(path, options)
-      @path = path || '.'
-      @options = options
-      @options[:exclude] ||= []
-
-      Core::Runner.base_path = @path
-      @runner = Core::Runner.new
-      @runner.debug = true if @options['debug']
-      @runner.color = !options['without-color']
-
-      if @runner.checks.find { |check| check.is_a? Reviews::AlwaysAddDbIndexReview } &&
-         !parse_files.find { |file| file.index "db\/schema.rb" }
-        plain_output("AlwaysAddDbIndexReview is disabled as there is no db/schema.rb file in your rails project.", 'blue')
-      end
-
-      @bar = ProgressBar.new('Source Codes', parse_files.size * 3)
-      ["lexical", "prepare", "review"].each { |process| send(:process, process) }
-      @runner.on_complete
-      @bar.finish
-
-      if @options['format'] == 'html'
-        load_git_info if @options["with-git"]
-        output_html_errors
-      else
-        output_terminal_errors
-      end
-      exit @runner.errors.size
-    end
-
-    # process lexical, prepare or reivew.
-    #
-    # get all files for the process, analyze each file,
-    # and increment progress bar unless debug.
-    #
-    # @param [String] process the process name, lexical, prepare or review.
-    def process(process)
-      parse_files.each do |file|
-        @runner.send("#{process}_file", file)
-        @bar.inc unless @options['debug']
-      end
-    end
-
-    # get all files for parsing.
-    #
-    # @return [Array] all files for parsing
-    def parse_files
-      @parse_files ||= begin
-        files = expand_dirs_to_files(@path)
-        files = file_sort(files)
-
-        # By default, tmp, vender, spec, test, features are ignored.
-        ['vendor', 'spec', 'test', 'features', 'tmp'].each do |pattern|
-          files = file_ignore(files, "#{pattern}/") unless @options[pattern]
-        end
-
-        # Exclude files based on exclude regexes if the option is set.
-        @options[:exclude].each do |pattern|
-          files = file_ignore(files, pattern)
-        end
-
-        files.compact
-      end
-    end
-
-    # expand all files with extenstion rb, erb, haml and builder under the dirs
-    #
-    # @param [Array] dirs what directories to expand
-    # @return [Array] all files expanded
-    def expand_dirs_to_files *dirs
-      extensions = ['rb', 'erb', 'rake', 'rhtml', 'haml', 'builder']
-
-      dirs.flatten.map { |entry|
-        next unless File.exist? entry
-        if File.directory? entry
-          Dir[File.join(entry, '**', "*.{#{extensions.join(',')}}")]
-        else
-          entry
-        end
-      }.flatten
-    end
-
-
-    # sort files, models first, then mailers, and sort other files by characters.
-    #
-    # models and mailers first as for prepare process.
-    #
-    # @param [Array] files
-    # @return [Array] sorted files
-    def file_sort files
-      models = []
-      mailers = []
-      files.each do |a|
-        if a =~ Core::Check::MODEL_FILES
-          models << a
-        end
-      end
-      files.each do |a|
-        if a =~ Core::Check::MAILER_FILES
-          mailers << a
-        end
-      end
-      files.collect! do |a|
-        if a =~ Core::Check::MAILER_FILES || a =~ Core::Check::MODEL_FILES
-          #nil
-        else
-          a
-        end
-      end
-      files.compact!
-      models.sort
-      mailers.sort
-      files.sort
-      return models + mailers + files
-    end
-
-    # ignore specific files.
-    #
-    # @param [Array] files
-    # @param [Regexp] pattern files match the pattern will be ignored
-    # @return [Array] files that not match the pattern
-    def file_ignore files, pattern
-      files.reject { |file| file.index(pattern) }
-    end
-
-    # output errors on terminal.
-    def output_terminal_errors
-      @runner.errors.each { |error| plain_output(error.to_s, 'red') }
-      plain_output("\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.", 'green')
-      if @runner.errors.empty?
-        plain_output("\nNo warning found. Cool!", 'green')
-      else
-        plain_output("\nFound #{@runner.errors.size} warnings.", 'red')
-      end
-    end
-
-    # load git commit and git username info.
-    def load_git_info
-      git_progressbar = ProgressBar.new('Git Info', @runner.errors.size)
-      @runner.errors.each do |error|
-        git_info = `cd #{@runner.class.base_path}; git blame #{error.filename[@runner.class.base_path.size..-1]} | sed -n #{error.line_number.split(',').first}p`
-        unless git_info == ""
-          git_commit, git_username = git_info.split(/\d{4}-\d{2}-\d{2}/).first.split("(")
-          error.git_commit = git_commit.split(" ").first.strip
-          error.git_username = git_username.strip
-        end
-        git_progressbar.inc unless @options['debug']
-      end
-      git_progressbar.finish
-    end
-
-    # output errors with html format.
-    def output_html_errors
-      require 'erubis'
-      template = File.read(File.join(File.dirname(__FILE__), "..", "assets", "result.html.erb"))
-
-      File.open("rails_best_practices_output.html", "w+") do |file|
-        eruby = Erubis::Eruby.new(template)
-        file.puts eruby.evaluate(:errors => @runner.errors, :error_types => error_types, :textmate => @options["with-textmate"], :mvim => @options["with-mvim"], :git => @options["with-git"])
-      end
-    end
-
-    # plain output with color.
-    #
-    # @param [String] message to output
-    # @param [String] color
-    def plain_output(message, color)
-      if @options["without-color"]
-        puts message
-      else
-        puts message.send(color)
-      end
-    end
-
-    # unique error types.
-    def error_types
-      @runner.errors.map(&:type).uniq
-    end
-  end
 end

data/lib/rails_best_practices/analyzer.rb

@@ -0,0 +1,239 @@
+# encoding: utf-8
+require 'fileutils'
+
+require 'progressbar'
+require 'colored'
+
+module RailsBestPractices
+  # RailsBestPractices Analyzer helps you to analyze your rails code, according to best practices on http://rails-bestpractices.
+  # if it finds any violatioins to best practices, it will give you some readable suggestions.
+  #
+  # The analysis process is partitioned into two parts,
+  #
+  # 1. prepare process, it checks only model and mailer files, do some preparations, such as remember model names and associations.
+  # 2. review process, it checks all files, according to configuration, it really check if codes violate the best practices, if so, remember the violations.
+  #
+  # After analyzing, output the violations.
+  class Analyzer
+    attr_accessor :runner
+
+    DEFAULT_CONFIG = File.join(File.dirname(__FILE__), "..", "..", "rails_best_practices.yml")
+
+    # initialize
+    #
+    # @param [String] path where to generate the configuration yaml file
+    # @param [Hash] options
+    def initialize(path, options={})
+      @path = path || "."
+      @options = options
+    end
+
+    # generate configuration yaml file.
+    def generate
+      FileUtils.cp DEFAULT_CONFIG, File.join(@path, 'config/rails_best_practices.yml')
+    end
+
+    # Analyze rails codes.
+    #
+    # there are two steps to check rails codes,
+    #
+    # 1. prepare process, check all model and mailer files.
+    # 2. review process, check all files.
+    #
+    # if there are violations to rails best practices, output them.
+    #
+    # @param [String] path the directory of rails project
+    # @param [Hash] options
+    def analyze
+      @options[:exclude] ||= []
+
+      Core::Runner.base_path = @path
+      @runner = Core::Runner.new
+      @runner.debug = true if @options['debug']
+      @runner.color = !@options['without-color']
+
+      @bar = ProgressBar.new('Source Codes', parse_files.size * 3)
+      ["lexical", "prepare", "review"].each { |process| send(:process, process) }
+      @runner.on_complete
+      @bar.finish
+    end
+
+    # Output the analyze result.
+    def output
+      if @options['format'] == 'html'
+        if @options["with-hg"]
+          load_hg_info
+        elsif @options["with-git"]
+          load_git_info
+        end
+        output_html_errors
+      else
+        output_terminal_errors
+      end
+    end
+
+    # process lexical, prepare or reivew.
+    #
+    # get all files for the process, analyze each file,
+    # and increment progress bar unless debug.
+    #
+    # @param [String] process the process name, lexical, prepare or review.
+    def process(process)
+      parse_files.each do |file|
+        @runner.send("#{process}_file", file)
+        @bar.inc unless @options['debug']
+      end
+    end
+
+    # get all files for parsing.
+    #
+    # @return [Array] all files for parsing
+    def parse_files
+      @parse_files ||= begin
+        files = expand_dirs_to_files(@path)
+        files = file_sort(files)
+
+        # By default, tmp, vender, spec, test, features are ignored.
+        ['vendor', 'spec', 'test', 'features', 'tmp'].each do |pattern|
+          files = file_ignore(files, "#{pattern}/") unless @options[pattern]
+        end
+
+        # Exclude files based on exclude regexes if the option is set.
+        @options[:exclude].each do |pattern|
+          files = file_ignore(files, pattern)
+        end
+
+        files.compact
+      end
+    end
+
+    # expand all files with extenstion rb, erb, haml and builder under the dirs
+    #
+    # @param [Array] dirs what directories to expand
+    # @return [Array] all files expanded
+    def expand_dirs_to_files *dirs
+      extensions = ['rb', 'erb', 'rake', 'rhtml', 'haml', 'builder']
+
+      dirs.flatten.map { |entry|
+        next unless File.exist? entry
+        if File.directory? entry
+          Dir[File.join(entry, '**', "*.{#{extensions.join(',')}}")]
+        else
+          entry
+        end
+      }.flatten
+    end
+
+
+    # sort files, models first, then mailers, and sort other files by characters.
+    #
+    # models and mailers first as for prepare process.
+    #
+    # @param [Array] files
+    # @return [Array] sorted files
+    def file_sort files
+      models = []
+      mailers = []
+      files.each do |a|
+        if a =~ Core::Check::MODEL_FILES
+          models << a
+        end
+      end
+      files.each do |a|
+        if a =~ Core::Check::MAILER_FILES
+          mailers << a
+        end
+      end
+      files.collect! do |a|
+        if a =~ Core::Check::MAILER_FILES || a =~ Core::Check::MODEL_FILES
+          #nil
+        else
+          a
+        end
+      end
+      files.compact!
+      models.sort
+      mailers.sort
+      files.sort
+      return models + mailers + files
+    end
+
+    # ignore specific files.
+    #
+    # @param [Array] files
+    # @param [Regexp] pattern files match the pattern will be ignored
+    # @return [Array] files that not match the pattern
+    def file_ignore files, pattern
+      files.reject { |file| file.index(pattern) }
+    end
+
+    # output errors on terminal.
+    def output_terminal_errors
+      @runner.errors.each { |error| plain_output(error.to_s, 'red') }
+      plain_output("\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.", 'green')
+      if @runner.errors.empty?
+        plain_output("\nNo warning found. Cool!", 'green')
+      else
+        plain_output("\nFound #{@runner.errors.size} warnings.", 'red')
+      end
+    end
+
+    # load hg commit and hg username info.
+    def load_hg_info
+      hg_progressbar = ProgressBar.new('Hg Info', @runner.errors.size)
+      @runner.errors.each do |error|
+        hg_info = `cd #{@runner.class.base_path}; hg blame -lvcu #{error.filename[@runner.class.base_path.size..-1].gsub(/^\//, "")} | sed -n /:#{error.line_number.split(',').first}:/p`
+        unless hg_info == ""
+          hg_commit_username = hg_info.split(':')[0].strip
+          error.hg_username = hg_commit_username.split(/\ /)[0..-2].join(' ')
+          error.hg_commit = hg_commit_username.split(/\ /)[-1]
+        end
+        hg_progressbar.inc unless @options['debug']
+      end
+      hg_progressbar.finish
+    end
+
+    # load git commit and git username info.
+    def load_git_info
+      git_progressbar = ProgressBar.new('Git Info', @runner.errors.size)
+      @runner.errors.each do |error|
+        git_info = `cd #{@runner.class.base_path}; git blame #{error.filename[@runner.class.base_path.size..-1]} | sed -n #{error.line_number.split(',').first}p`
+        unless git_info == ""
+          git_commit, git_username = git_info.split(/\d{4}-\d{2}-\d{2}/).first.split("(")
+          error.git_commit = git_commit.split(" ").first.strip
+          error.git_username = git_username.strip
+        end
+        git_progressbar.inc unless @options['debug']
+      end
+      git_progressbar.finish
+    end
+
+    # output errors with html format.
+    def output_html_errors
+      require 'erubis'
+      template = File.read(File.join(File.dirname(__FILE__), "..", "..", "assets", "result.html.erb"))
+
+      File.open("rails_best_practices_output.html", "w+") do |file|
+        eruby = Erubis::Eruby.new(template)
+        file.puts eruby.evaluate(:errors => @runner.errors, :error_types => error_types, :textmate => @options["with-textmate"], :mvim => @options["with-mvim"], :git => @options["with-git"], :hg => @options["with-hg"])
+      end
+    end
+
+    # plain output with color.
+    #
+    # @param [String] message to output
+    # @param [String] color
+    def plain_output(message, color)
+      if @options["without-color"]
+        puts message
+      else
+        puts message.send(color)
+      end
+    end
+
+    # unique error types.
+    def error_types
+      @runner.errors.map(&:type).uniq
+    end
+  end
+end

data/lib/rails_best_practices/command.rb

@@ -40,6 +40,10 @@ OptionParser.new do |opts|
     options["with-mvim"] = true
   end
 
+  opts.on("--with-hg", "display hg commit and username, only support html format") do
+    options["with-hg"] = true
+  end
+
   opts.on("--with-git", "display git commit and username, only support html format") do
     options["with-git"] = true
   end
@@ -77,7 +81,10 @@ OptionParser.new do |opts|
 end
 
 if options[:generate]
-  RailsBestPractices.generate(ARGV.first)
+  RailsBestPractices::Analyzer.new(ARGV.first).generate
 else
-  RailsBestPractices.start(ARGV.first, options)
+  analyzer = RailsBestPractices::Analyzer.new(ARGV.first, options)
+  analyzer.analyze
+  analyzer.output
+  exit analyzer.runner.errors.size
 end

data/lib/rails_best_practices/core/error.rb

@@ -6,7 +6,7 @@ module RailsBestPractices
     # it indicates the filenname, line number and error message for the violation.
     class Error
       attr_reader :filename, :line_number, :message, :type, :url
-      attr_accessor :git_commit, :git_username
+      attr_accessor :git_commit, :git_username, :hg_commit, :hg_username
 
       def initialize(filename, line_number, message, type, url = nil)
         @filename = filename

data/lib/rails_best_practices/core/runner.rb

@@ -35,7 +35,7 @@ module RailsBestPractices
       # @param [Hash] options pass the prepares and reviews.
       def initialize(options={})
         custom_config = File.join(Runner.base_path, 'config/rails_best_practices.yml')
-        @config = File.exists?(custom_config) ? custom_config : RailsBestPractices::DEFAULT_CONFIG
+        @config = File.exists?(custom_config) ? custom_config : RailsBestPractices::Analyzer::DEFAULT_CONFIG
 
         lexicals = Array(options[:lexicals])
         prepares = Array(options[:prepares])

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.5.2"
+  VERSION = "1.5.3"
 end

data/rails_best_practices.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
-  s.require_paths = ["lib"]
+  s.require_paths = ["lib", "assets"]
 
   s.post_install_message = <<-POST_INSTALL_MESSAGE
 #{"*" * 80}

data/spec/rails_best_practices/analyzer_spec.rb

@@ -0,0 +1,45 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Analyzer do
+  subject { RailsBestPractices::Analyzer.new(".") }
+
+  describe "expand_dirs_to_files" do
+    it "should expand all files in spec directory" do
+      dir = File.dirname(__FILE__)
+      subject.expand_dirs_to_files(dir).should be_include(dir + '/analyzer_spec.rb')
+    end
+  end
+
+  describe "file_sort" do
+    it "should get models first, then mailers" do
+      files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "lib/user.rb"]
+      subject.file_sort(files).should == ["app/models/user.rb", "app/mailers/user_mailer.rb", "app/controllers/users_controller.rb", "app/views/users/index.html.haml", "lib/user.rb"]
+    end
+  end
+
+  describe "file_ignore" do
+    it "should ignore lib" do
+      files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "lib/user.rb"]
+      subject.file_ignore(files, 'lib/').should == ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml"]
+    end
+  end
+
+  describe "output_terminal_errors" do
+    it "should output errors in terminal" do
+      check1 = RailsBestPractices::Reviews::LawOfDemeterReview.new
+      check2 = RailsBestPractices::Reviews::UseQueryAttributeReview.new
+      runner = RailsBestPractices::Core::Runner.new(:reviews => [check1, check2])
+      check1.add_error "law of demeter", "app/models/user.rb", 10
+      check2.add_error "use query attribute", "app/models/post.rb", 100
+      subject.runner = runner
+      subject.instance_variable_set("@options", {"without-color" => false})
+
+      $origin_stdout = $stdout
+      $stdout = StringIO.new
+      subject.output_terminal_errors
+      result = $stdout.string
+      $stdout = $origin_stdout
+      result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 warnings.".red].join("\n") + "\n"
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.5.2
+  version: 1.5.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-29 00:00:00.000000000Z
+date: 2011-11-30 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor
-  requirement: &70267317549760 !ruby/object:Gem::Requirement
+  requirement: &70221608963020 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70267317549760
+  version_requirements: *70221608963020
 - !ruby/object:Gem::Dependency
   name: progressbar
-  requirement: &70267317548420 !ruby/object:Gem::Requirement
+  requirement: &70221608962100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70267317548420
+  version_requirements: *70221608962100
 - !ruby/object:Gem::Dependency
   name: colored
-  requirement: &70267317547260 !ruby/object:Gem::Requirement
+  requirement: &70221608961120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70267317547260
+  version_requirements: *70221608961120
 - !ruby/object:Gem::Dependency
   name: erubis
-  requirement: &70267317545680 !ruby/object:Gem::Requirement
+  requirement: &70221608960060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70267317545680
+  version_requirements: *70221608960060
 - !ruby/object:Gem::Dependency
   name: i18n
-  requirement: &70267317544620 !ruby/object:Gem::Requirement
+  requirement: &70221608959000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70267317544620
+  version_requirements: *70221608959000
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70267313985300 !ruby/object:Gem::Requirement
+  requirement: &70221608958140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70267313985300
+  version_requirements: *70221608958140
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70267313984500 !ruby/object:Gem::Requirement
+  requirement: &70221608957540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70267313984500
+  version_requirements: *70221608957540
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70267313983680 !ruby/object:Gem::Requirement
+  requirement: &70221608956760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +98,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70267313983680
+  version_requirements: *70221608956760
 - !ruby/object:Gem::Dependency
   name: haml
-  requirement: &70267313982720 !ruby/object:Gem::Requirement
+  requirement: &70221608955200 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -109,10 +109,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70267313982720
+  version_requirements: *70221608955200
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70267313981720 !ruby/object:Gem::Requirement
+  requirement: &70221608954440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -120,7 +120,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70267313981720
+  version_requirements: *70221608954440
 description: a code metric tool for rails codes, written in Ruby.
 email:
 - flyerhzm@gmail.com
@@ -148,6 +148,7 @@ files:
 - bin/rails_best_practices
 - install_supported_rubies.sh
 - lib/rails_best_practices.rb
+- lib/rails_best_practices/analyzer.rb
 - lib/rails_best_practices/command.rb
 - lib/rails_best_practices/core.rb
 - lib/rails_best_practices/core/check.rb
@@ -211,6 +212,7 @@ files:
 - rails_best_practices.yml
 - rake_rubies.sh
 - spec/fixtures/lib/rails_best_practices/plugins/reviews/not_use_rails_root_review.rb
+- spec/rails_best_practices/analyzer_spec.rb
 - spec/rails_best_practices/core/check_spec.rb
 - spec/rails_best_practices/core/checking_visitor_spec.rb
 - spec/rails_best_practices/core/controllers_spec.rb
@@ -263,7 +265,6 @@ files:
 - spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb
 - spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
-- spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb
 homepage: http://rails-bestpractices.com
 licenses: []
@@ -274,6 +275,7 @@ post_install_message: ! "*******************************************************
 rdoc_options: []
 require_paths:
 - lib
+- assets
 required_ruby_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -282,7 +284,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2291926494779234111
+      hash: 1044082634186330916
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -297,6 +299,7 @@ specification_version: 3
 summary: a code metric tool for rails codes.
 test_files:
 - spec/fixtures/lib/rails_best_practices/plugins/reviews/not_use_rails_root_review.rb
+- spec/rails_best_practices/analyzer_spec.rb
 - spec/rails_best_practices/core/check_spec.rb
 - spec/rails_best_practices/core/checking_visitor_spec.rb
 - spec/rails_best_practices/core/controllers_spec.rb
@@ -349,5 +352,4 @@ test_files:
 - spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/use_say_with_time_in_migrations_review_spec.rb
 - spec/rails_best_practices/reviews/use_scope_access_review_spec.rb
-- spec/rails_best_practices_spec.rb
 - spec/spec_helper.rb

data/spec/rails_best_practices_spec.rb

@@ -1,43 +0,0 @@
-require 'spec_helper'
-
-describe RailsBestPractices do
-
-  describe "expand_dirs_to_files" do
-    require 'find'
-    it "should expand all files in spec directory" do
-      dir = File.dirname(__FILE__)
-      RailsBestPractices.expand_dirs_to_files(dir).should be_include(dir + '/rails_best_practices_spec.rb')
-    end
-  end
-
-  describe "file_sort" do
-    it "should get models first, then mailers" do
-      files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "lib/user.rb"]
-      RailsBestPractices.file_sort(files).should == ["app/models/user.rb", "app/mailers/user_mailer.rb", "app/controllers/users_controller.rb", "app/views/users/index.html.haml", "lib/user.rb"]
-    end
-  end
-
-  describe "file_ignore" do
-    it "should ignore lib" do
-      files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "lib/user.rb"]
-      RailsBestPractices.file_ignore(files, 'lib/').should == ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml"]
-    end
-  end
-
-  describe "output_terminal_errors" do
-    check1 = RailsBestPractices::Reviews::LawOfDemeterReview.new
-    check2 = RailsBestPractices::Reviews::UseQueryAttributeReview.new
-    runner = RailsBestPractices::Core::Runner.new(:reviews => [check1, check2])
-    check1.add_error "law of demeter", "app/models/user.rb", 10
-    check2.add_error "use query attribute", "app/models/post.rb", 100
-    RailsBestPractices.runner = runner
-    RailsBestPractices.instance_variable_set("@options", {"without-color" => false})
-
-    $origin_stdout = $stdout
-    $stdout = StringIO.new
-    RailsBestPractices.output_terminal_errors
-    result = $stdout.string
-    $stdout = $origin_stdout
-    result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 warnings.".red].join("\n") + "\n"
-  end
-end