rails_best_practices 1.19.4 → 1.19.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5465e0c3226433bf68485822ab52b54993f334c4
-  data.tar.gz: 05650ce6bef4b2c0bd89ac24401d3119c708313f
+SHA256:
+  metadata.gz: ce639228ddc1497545e69b3ce97cd43b4832a5e9ebba9cf69e26c01c21831768
+  data.tar.gz: 9ea6a9454fbc1cd32c2b924066667e418448fea6c823c045bf7853bc0ea05c63
 SHA512:
-  metadata.gz: 514d93fb5333c09d93b65838aeaa3942d693c1e8c1e7b7bf388d198c5b2aca36be0820a97abf29825ef4e127233d1af0d7b911f3968f54e388530cc3e19c08f7
-  data.tar.gz: f502d73f187def721cbcb7df9c09fc2652b23cdd80f082b96a6301d1a3733f0dceafe0dd1c8c87dd089fcf678761c36aa7f81431908c44f2b9eb2b14a7014858
+  metadata.gz: e89e188603ede56c8f538f1415c352aa477fa8c3b591363380c1603dbbe301af6b0f5b29d834bd3b2e90525eb3418eda50508bdd7fc5a81a40aaf4c75f4e0cab
+  data.tar.gz: d318bb1faf3c574f8a88e59a54893af1ff1ffadd5e5542d1243b340bd07d72125214c8d4c9343c47ca32777fe8379ffb0f035093a51abe6a583ef3d80820ac97

data/.travis.yml

@@ -1,5 +1,3 @@
-sudo: false
 language: ruby
-cache: bundler
 rvm:
-  - 2.3.3
+  - 2.6.4

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Next Release
 
+## 1.19.5
+
+* Add the link format for vscode
+* Use code_analyzer 0.5.1
+
 ## 1.19.4
 
 * Add cli class

data/Gemfile.lock

@@ -1,43 +1,44 @@
 PATH
   remote: .
   specs:
-    rails_best_practices (1.19.4)
+    rails_best_practices (1.19.5)
       activesupport
-      code_analyzer (>= 0.4.8)
+      code_analyzer (>= 0.5.1)
       erubis
       i18n
       json
-      require_all (~> 2.0)
+      require_all (~> 3.0)
       ruby-progressbar
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.2.1)
+    activesupport (6.0.2.1)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
-    awesome_print (1.6.1)
-    code_analyzer (0.4.8)
+      zeitwerk (~> 2.2)
+    awesome_print (1.8.0)
+    code_analyzer (0.5.1)
       sexp_processor
-    coderay (1.1.1)
-    concurrent-ruby (1.0.5)
-    coveralls (0.8.11)
-      json (~> 1.8)
-      simplecov (~> 0.11.0)
+    coderay (1.1.2)
+    concurrent-ruby (1.1.5)
+    coveralls (0.8.23)
+      json (>= 1.8, < 3)
+      simplecov (~> 0.16.1)
       term-ansicolor (~> 1.3)
-      thor (~> 0.19.1)
-      tins (~> 1.6.0)
-    diff-lcs (1.2.5)
-    docile (1.1.5)
+      thor (>= 0.19.4, < 2.0)
+      tins (~> 1.6)
+    diff-lcs (1.3)
+    docile (1.3.2)
     erubis (2.7.0)
-    ffi (1.9.10)
+    ffi (1.11.3)
     formatador (0.2.5)
-    guard (2.13.0)
+    guard (2.16.1)
       formatador (>= 0.2.4)
-      listen (>= 2.7, <= 4.0)
-      lumberjack (~> 1.0)
+      listen (>= 2.7, < 4.0)
+      lumberjack (>= 1.0.12, < 2.0)
       nenv (~> 0.1)
       notiffany (~> 0.0)
       pry (>= 0.9.12)
@@ -46,30 +47,30 @@ GEM
     guard-rspec (4.3.1)
       guard (~> 2.1)
       rspec (>= 2.14, < 4.0)
-    haml (4.0.7)
+    haml (5.1.2)
+      temple (>= 0.8.0)
       tilt
-    i18n (1.1.1)
+    i18n (1.7.0)
       concurrent-ruby (~> 1.0)
-    json (1.8.6)
-    listen (3.0.6)
-      rb-fsevent (>= 0.9.3)
-      rb-inotify (>= 0.9.7)
-    lumberjack (1.0.10)
-    method_source (0.8.2)
-    minitest (5.11.3)
+    json (2.3.0)
+    listen (3.2.1)
+      rb-fsevent (~> 0.10, >= 0.10.3)
+      rb-inotify (~> 0.9, >= 0.9.10)
+    lumberjack (1.0.13)
+    method_source (0.9.2)
+    minitest (5.13.0)
     nenv (0.3.0)
-    notiffany (0.0.8)
+    notiffany (0.1.3)
       nenv (~> 0.1)
       shellany (~> 0.0)
-    pry (0.10.3)
+    pry (0.12.2)
       coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
+      method_source (~> 0.9.0)
     rake (10.5.0)
-    rb-fsevent (0.9.7)
-    rb-inotify (0.9.7)
-      ffi (>= 0.5.0)
-    require_all (2.0.0)
+    rb-fsevent (0.10.3)
+    rb-inotify (0.10.1)
+      ffi (~> 1.0)
+    require_all (3.0.0)
     rspec (2.14.1)
       rspec-core (~> 2.14.0)
       rspec-expectations (~> 2.14.0)
@@ -78,27 +79,27 @@ GEM
     rspec-expectations (2.14.5)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.14.6)
-    ruby-progressbar (1.10.0)
-    sexp_processor (4.10.1)
+    ruby-progressbar (1.10.1)
+    sexp_processor (4.13.0)
     shellany (0.0.1)
-    simplecov (0.11.2)
-      docile (~> 1.1.0)
-      json (~> 1.8)
+    simplecov (0.16.1)
+      docile (~> 1.1)
+      json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
-    slim (3.0.6)
-      temple (~> 0.7.3)
-      tilt (>= 1.3.3, < 2.1)
-    slop (3.6.0)
-    temple (0.7.6)
-    term-ansicolor (1.3.2)
+    simplecov-html (0.10.2)
+    slim (4.0.1)
+      temple (>= 0.7.6, < 0.9)
+      tilt (>= 2.0.6, < 2.1)
+    temple (0.8.2)
+    term-ansicolor (1.7.1)
       tins (~> 1.0)
-    thor (0.19.1)
+    thor (1.0.1)
     thread_safe (0.3.6)
-    tilt (2.0.2)
-    tins (1.6.0)
-    tzinfo (1.2.5)
+    tilt (2.0.10)
+    tins (1.22.2)
+    tzinfo (1.2.6)
       thread_safe (~> 0.1)
+    zeitwerk (2.2.2)
 
 PLATFORMS
   ruby
@@ -117,4 +118,4 @@ DEPENDENCIES
   slim
 
 BUNDLED WITH
-   1.16.0
+   2.1.2

data/README.md

@@ -64,6 +64,7 @@ To see the full list of command-line options, run:
         -f, --format FORMAT              output format
             --without-color              only output plain text without color
             --with-textmate              open file by textmate in html format
+            --with-vscode                open file by vscode in html format
             --with-sublime               open file by sublime in html format (requires https://github.com/asuth/subl-handler)
             --with-mvim                  open file by mvim in html format
             --with-github GITHUB_NAME    open file on github in html format. GITHUB_NAME is like railsbp/rails-bestpractices OR full URL to GitHub:FI repo

data/assets/result.html.erb

@@ -121,6 +121,8 @@
                 <a href='subl://open?url=file://<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
               <% elsif @mvim %>
                 <a href='mvim://open/?url=file://<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
+              <% elsif @vscode %>
+                <a href='vscode://file/<%= File.expand_path(error.filename) %>:<%= error.line_number %>'><%= error.short_filename %></a>
               <% else %>
                 <%= error.short_filename %>
               <% end %>

data/lib/rails_best_practices/analyzer.rb

@@ -238,6 +238,7 @@ module RailsBestPractices
           errors: errors,
           error_types: error_types,
           textmate: @options['with-textmate'],
+          vscode: @options['with-vscode'],
           sublime: @options['with-sublime'],
           mvim: @options['with-mvim'],
           github: @options['with-github'],

data/lib/rails_best_practices/option_parser.rb

@@ -11,6 +11,7 @@ module RailsBestPractices
     #        --output-file FILE           output html file for the analyzing result
     #        --without-color              only output plain text without color
     #        --with-textmate              open file by textmate in html format
+    #        --with-vscode                open file by vscode in html format
     #        --with-sublime               open file by sublime in html format (requires subl-handler)
     #        --with-mvim                  open file by mvim in html format
     #        --with-github GITHUB_NAME    open file on github in html format, GITHUB_NAME is like railsbp/rails-bestpractices.com
@@ -52,6 +53,10 @@ module RailsBestPractices
           options['with-textmate'] = true
         end
 
+        opts.on('--with-vscode', 'open file by vscode in html format') do
+          options['with-vscode'] = true
+        end
+
         opts.on('--with-sublime', 'open file by sublime in html format') do
           options['with-sublime'] = true
         end

data/lib/rails_best_practices/reviews/always_add_db_index_review.rb

@@ -11,7 +11,7 @@ module RailsBestPractices
     # Review process:
     #   only check the command and command_calls nodes and at the end of review process,
     #   if the receiver of command node is "create_table", then remember the table names
-    #   if the receiver of command_call node is "integer" or "string" and suffix with _id, then remember it as foreign key
+    #   if the receiver of command_call node is "integer" or "string" or "bigint" and suffix with _id, then remember it as foreign key
     #   if the receiver of command_call node is "string", the name of it is _type suffixed and there is an integer or string column _id suffixed, then remember it as polymorphic foreign key
     #   if the receiver of command_call node is remembered as foreign key and it have argument non-false "index", then remember the index columns
     #   if the receiver of command node is "add_index", then remember the index columns
@@ -40,7 +40,7 @@ module RailsBestPractices
       # if the message of command_call node is "create_table", then remember the table name.
       # if the message of command_call node is "add_index", then remember it as index columns.
       add_callback :start_command_call do |node|
-        if %w[integer string].include? node.message.to_s
+        if %w[integer string bigint].include? node.message.to_s
           remember_foreign_key_columns(node)
         elsif node.message.to_s == 'index'
           remember_index_columns_inside_table(node)

data/lib/rails_best_practices/reviews/replace_complex_creation_with_factory_method_review.rb

@@ -37,7 +37,7 @@ module RailsBestPractices
         node.recursive_children do |child_node|
           case child_node.sexp_type
           when :assign
-            if child_node.receiver[2] == :"."
+            if child_node.receiver[2].to_s == '.'
               remember_variable_use_count(child_node)
             end
           when :call

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsBestPractices
-  VERSION = '1.19.4'
+  VERSION = '1.19.5'
 end

data/rails_best_practices.gemspec

@@ -18,11 +18,11 @@ Gem::Specification.new do |s|
 
   s.add_dependency('activesupport')
   # TODO: add a dependency for Rails >= 3 ?
-  s.add_dependency('code_analyzer', '>= 0.4.8')
+  s.add_dependency('code_analyzer', '>= 0.5.1')
   s.add_dependency('erubis')
   s.add_dependency('i18n')
   s.add_dependency('json')
-  s.add_dependency('require_all', '~> 2.0')
+  s.add_dependency('require_all', '~> 3.0')
   s.add_dependency('ruby-progressbar')
 
   s.add_development_dependency('awesome_print')

data/spec/rails_best_practices/prepares/route_prepare_spec.rb

@@ -252,7 +252,9 @@ module RailsBestPractices
         it 'should add custom resources routes with {}' do
           content = <<-EOF
           RailsBestPracticesCom::Application.routes.draw do
-            resources :posts, only: [:show] { get :inactive, on: :collection }
+            resources :posts, only: [:show] do
+              get :inactive, on: :collection
+            end
           end
           EOF
           runner.prepare('config/routes.rb', content)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.19.4
+  version: 1.19.5
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-29 00:00:00.000000000 Z
+date: 2019-12-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.8
+        version: 0.5.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.4.8
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -399,8 +399,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: a code metric tool for rails codes.