rails_best_practices 1.18.0 → 1.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4eb57bfb18f02e91c08dbfef14f970acc55e3a3a
-  data.tar.gz: f7f14c66689cf3cc3bd3a1efd7ea1b533b41d2c7
+  metadata.gz: b28f335fee20969fe2276bdd1167772552262162
+  data.tar.gz: aff5bdb928fbae84063f42e0b79bc72c2766d11c
 SHA512:
-  metadata.gz: d2d1f2d5ed8eb36cdcdfb3936c81c6e75eb50565751d3489dac9f36aa6575715f8044c9728a3c1a33171d476d099f86fcfe7486ee7480d01073c5bfcd61d9553
-  data.tar.gz: 22aa1432ef5b0ce38a69f9ea2b14344e967a00b1f7f2ddbcc4c67ba7ee67e3dd657ba176acdd492185ec980345c03ef4c063c3791a8fb06ae6ac345462cec28c
+  metadata.gz: 9650af54486b7bf655ed79287e43e70c43314d2353a3a68680ff9a17a7c4548056b48b67e3e0ce7d4d9af76f5d087138d6119e6026c816f70e566e63b38883ca
+  data.tar.gz: ea4bb8533886d4bd11e25af6eb19c2a354aae861ccf7f9fba22636b0d78da6d97a15626984c9d7ec72b48440107a1766790845c4df8964621e9cbf7fb5811695

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Next Release
 
+## 1.18.1
+
+* Remove haml ugly option
+
 ## 1.18.0 (2017-03-01)
 
 * Add --config option

data/lib/rails_best_practices/core/runner.rb

@@ -128,7 +128,7 @@ module RailsBestPractices
           elsif filename =~ /.*\.haml$/
             begin
               require 'haml'
-              content = Haml::Engine.new(content, {ugly: true}).precompiled
+              content = Haml::Engine.new(content).precompiled
               # remove \xxx characters
               content.gsub!(/\\\d{3}/, '')
             rescue LoadError

data/lib/rails_best_practices/reviews/not_rescue_exception_review.rb

@@ -18,7 +18,7 @@ module RailsBestPractices
       # check rescue node to see if its type is Exception
       add_callback :start_rescue do |rescue_node|
         if rescue_node.exception_classes.any? { |rescue_class| "Exception" == rescue_class.to_s }
-          add_error "not rescue Exception", rescue_node.file, rescue_node.exception_classes.first.line_number
+          add_error "Don't rescue Exception", rescue_node.file, rescue_node.exception_classes.first.line_number
         end
       end
     end

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.18.0"
+  VERSION = "1.18.1"
 end

data/spec/rails_best_practices/reviews/not_rescue_exception_review_spec.rb

@@ -16,7 +16,7 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - not rescue Exception")
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
         it "should not rescue exception in method rescue without named var" do
@@ -29,7 +29,7 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - not rescue Exception")
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:3 - Don't rescue Exception")
         end
 
         it "should not rescue exception in block rescue with named var" do
@@ -44,7 +44,7 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - not rescue Exception")
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
         it "should not rescue exception in block rescue without named var" do
@@ -59,7 +59,7 @@ module RailsBestPractices
           EOF
           runner.review('app/helpers/posts_helper.rb', content)
           expect(runner.errors.size).to eq(1)
-          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - not rescue Exception")
+          expect(runner.errors[0].to_s).to eq("app/helpers/posts_helper.rb:4 - Don't rescue Exception")
         end
 
         it "should allow rescue implicit StandardError in block rescue without named var" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.18.0
+  version: 1.18.1
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-01 00:00:00.000000000 Z
+date: 2017-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -419,7 +419,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: a code metric tool for rails codes.