rails_best_practices 1.13.4 → 1.13.5

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: c85e47e8a7e3168810ac545ece3d4dd9074c8325
+  data.tar.gz: 969e22d76e6815743f3971e61d495c875f37d4fc
+SHA512:
+  metadata.gz: 4501aedb47b7c816495cda8936edd10a86d1f5025ac0dca814620d7a6cfedc7f7d3265540492d5fecdf332cd7e3cee908c08f5e1bef7b69b2d691e42acdb4c6f
+  data.tar.gz: d481948983897dc84fe224e4d2cea953123b9ad3838c0e0c619c24e93a78fe7c3973b68911871bbfaac95b06038f54a3db42a95efd2b2e435b59c617847cadcb

data/.coveralls.yml

@@ -0,0 +1 @@
+repo_token: HdiJjr0c7NCGp2GIL3areCAENLRMT21Er

data/.gitignore

@@ -8,3 +8,4 @@ rdoc/**
 doc/**
 .yardoc/**
 rails_best_practices_output.*
+coverage/

data/.travis.yml

@@ -2,3 +2,4 @@ language: ruby
 rvm:
   - 1.9.2
   - 1.9.3
+  - 2.0.0

data/Gemfile

@@ -1,6 +1,8 @@
-source "http://rubygems.org"
+source 'https://rubygems.org'
 gemspec
 
+gem 'coveralls', require: false
+
 if RUBY_PLATFORM =~ /darwin/i
   gem 'rb-fsevent'
   gem 'growl'

data/README.md

@@ -1,7 +1,8 @@
 # rails_best_practices
 
 [![Build Status](https://secure.travis-ci.org/railsbp/rails_best_practices.png)](http://travis-ci.org/railsbp/rails_best_practices)
-
+[![Coverage
+Status](https://coveralls.io/repos/railsbp/rails_best_practices/badge.png?branch=master)](https://coveralls.io/r/railsbp/rails_best_practices)
 [![Coderwall Endorse](http://api.coderwall.com/flyerhzm/endorsecount.png)](http://coderwall.com/flyerhzm)
 
 [![Click here to lend your support to: rails best practices and make a donation at www.pledgie.com !](http://www.pledgie.com/campaigns/12057.png?skin_name=chrome)](http://www.pledgie.com/campaigns/12057)
@@ -48,7 +49,7 @@ By default rails_best_practices will do parse codes in vendor, spec, test and fe
             --with-textmate              open file by textmate in html format
             --with-sublime               open file by sublime in html format (requires https://github.com/asuth/subl-handler)
             --with-mvim                  open file by mvim in html format
-            --with-github GITHUB_NAME    open file on github in html format. GITHUB_NAME is like railsbp/rails-bestpractices
+            --with-github GITHUB_NAME    open file on github in html format. GITHUB_NAME is like railsbp/rails-bestpractices OR full URL to GitHub:FI repo
             --with-hg                    display hg commit and username, only support html format
             --with-git                   display git commit and username, only support html format
             --template TEMPLATE          customize erb template
@@ -93,7 +94,7 @@ rails_best_practices gem is rewritten based on ripper instead of ruby_parser to
 or add in Gemfile
 
     gem "rails_best_practices"
-    
+
 #### --with-sublime
 
 Install <https://github.com/asuth/subl-handler>
@@ -122,7 +123,7 @@ Now you can customize this configuration file, the default configuration is as f
 
     AddModelVirtualAttributeCheck: { }
     AlwaysAddDbIndexCheck: { }
-    CheckSaveReturnValueCheck: { }
+    #CheckSaveReturnValueCheck: { }
     DryBundlerInCapistranoCheck: { }
     #HashSyntaxCheck: { }
     IsolateSeedDataCheck: { }

data/assets/result.html.erb

@@ -111,7 +111,7 @@
           <tr class="<%= error.type.split(':').last %>">
             <td class='filename'>
               <% if @github %>
-                <a href='https://github.com/<%= @github_name %>/blob/<%= @last_commit_id %>/<%= error.short_filename %>#L<%= error.first_line_number %>' target='_blank'><%= error.short_filename %></a>
+                <a href='<%= @github_name %>/blob/<%= @last_commit_id %>/<%= error.short_filename %>#L<%= error.first_line_number %>' target='_blank'><%= error.short_filename %></a>
               <% elsif @textmate %>
                 <a href='txmt://open/?url=file://<%= File.expand_path(error.filename) %>&amp;line=<%= error.line_number %>'><%= error.short_filename %></a>
               <% elsif @sublime %>

data/lib/rails_best_practices/analyzer.rb

@@ -18,16 +18,21 @@ module RailsBestPractices
   # After analyzing, output the violations.
   class Analyzer
     attr_accessor :runner
+    attr_reader :path
 
     DEFAULT_CONFIG = File.join(File.dirname(__FILE__), "..", "..", "rails_best_practices.yml")
+    GITHUB_URL = 'https://github.com/'
 
     # initialize
     #
     # @param [String] path where to generate the configuration yaml file
     # @param [Hash] options
     def initialize(path, options={})
-      @path = path || "."
+      @path = File.expand_path(path || ".")
+
       @options = options
+      @options["exclude"] ||= []
+      @options["only"] ||= []
     end
 
     # generate configuration yaml file.
@@ -47,9 +52,6 @@ module RailsBestPractices
     # @param [String] path the directory of rails project
     # @param [Hash] options
     def analyze
-      @options["exclude"] ||= []
-      @options["only"] ||= []
-
       Core::Runner.base_path = @path
       @runner = Core::Runner.new
 
@@ -105,8 +107,8 @@ module RailsBestPractices
         end
 
         # By default, tmp, vender, spec, test, features are ignored.
-        ["vendor", "spec", "test", "features", "tmp"].each do |pattern|
-          files = file_ignore(files, "#{pattern}/") unless @options[pattern]
+        ["vendor", "spec", "test", "features", "tmp"].each do |dir|
+          files = file_ignore(files, File.join(@path, dir)) unless @options[dir]
         end
 
         # Exclude files based on exclude regexes if the option is set.
@@ -219,6 +221,9 @@ module RailsBestPractices
 
       if @options["with-github"]
         last_commit_id = @options["last-commit-id"] ? @options["last-commit-id"] : `cd #{@runner.class.base_path} && git rev-parse HEAD`.chomp
+        unless @options["github-name"].start_with?('http')
+          @options["github-name"] = GITHUB_URL + @options["github-name"]
+        end
       end
       File.open(@options["output-file"], "w+") do |file|
         eruby = Erubis::Eruby.new(template)

data/lib/rails_best_practices/core/check.rb

@@ -118,11 +118,13 @@ module RailsBestPractices
             # remember the class anem
             add_callback :start_class do |node|
               @klass = Core::Klass.new(node.class_name.to_s, node.base_class.to_s, classable_modules)
+              klasses << @klass
             end
 
             # end of the class
             add_callback :end_class do |node|
-              #@klass = nil
+              klasses.pop
+              # @klass = nil
             end
           end
         end
@@ -141,6 +143,10 @@ module RailsBestPractices
         def classable_modules
           @class_moduels ||= []
         end
+
+        def klasses
+          @klasses ||= []
+        end
       end
 
       # Helper to parse the module name.

data/lib/rails_best_practices/prepares/model_prepare.rb

@@ -40,7 +40,9 @@ module RailsBestPractices
       #       }
       #     }
       add_callback :start_def do |node|
-        if @klass && "ActionMailer::Base" != current_extend_class_name
+        if @klass &&
+            "ActionMailer::Base" != current_extend_class_name &&
+            (classable_modules.empty? || klasses.any?)
           method_name = node.method_name.to_s
           @methods.add_method(current_class_name, method_name, {"file" => node.file, "line" => node.line}, current_access_control)
         end

data/lib/rails_best_practices/reviews/protect_mass_assignment_review.rb

@@ -20,13 +20,13 @@ module RailsBestPractices
       # we treat it as mass assignment by default.
       add_callback :start_class do |node|
         @mass_assignement = true
+        check_whitelist_attributes_config
       end
 
       # check if it is ActiveRecord::Base subclass and
       # if it sets config.active_record.whitelist_attributes to true.
       add_callback :end_class do |node|
         check_active_record(node)
-        check_whitelist_attributes_config
 
         add_error "protect mass assignment" if @mass_assignement
       end
@@ -54,12 +54,12 @@ module RailsBestPractices
       private
         def check_whitelist_attributes_config
           if "true" == Prepares.configs["config.active_record.whitelist_attributes"]
-            @mass_assignement = false
+            @whitelist_attributes = true
           end
         end
 
         def check_rails_builtin(node)
-          if [node.to_s, node.message.to_s].any? { |str| %w(attr_accessible attr_protected).include? str }
+          if @whitelist_attributes && [node.to_s, node.message.to_s].any? { |str| %w(attr_accessible attr_protected).include? str }
             @mass_assignement = false
           end
         end

data/lib/rails_best_practices/version.rb

@@ -1,4 +1,4 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "1.13.4"
+  VERSION = "1.13.5"
 end

data/rails_best_practices.yml

@@ -1,6 +1,6 @@
 AddModelVirtualAttributeCheck: { }
 AlwaysAddDbIndexCheck: { }
-CheckSaveReturnValueCheck: { }
+#CheckSaveReturnValueCheck: { }
 DryBundlerInCapistranoCheck: { }
 #HashSyntaxCheck: { }
 IsolateSeedDataCheck: { }

data/spec/rails_best_practices/analyzer_spec.rb

@@ -1,9 +1,16 @@
 require 'spec_helper'
+require 'tmpdir'
 
 module RailsBestPractices
   describe Analyzer do
     subject { Analyzer.new(".") }
 
+    describe '::new' do
+      it 'should expand a relative path to an absolute' do
+        subject.path.should eq File.expand_path('.')
+      end
+    end
+
     describe "expand_dirs_to_files" do
       it "should expand all files in spec directory" do
         dir = File.dirname(__FILE__)
@@ -19,9 +26,17 @@ module RailsBestPractices
     end
 
     describe "file_ignore" do
+      before do
+        @all = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim", "lib/user.rb"]
+        @filtered = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim"]
+      end
+
       it "should ignore lib" do
-        files = ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim", "lib/user.rb"]
-        subject.file_ignore(files, 'lib/').should == ["app/controllers/users_controller.rb", "app/mailers/user_mailer.rb", "app/models/user.rb", "app/views/users/index.html.haml", "app/views/users/show.html.slim"]
+        subject.file_ignore(@all, 'lib/').should == @filtered
+      end
+
+      it "should ignore regexp patterns" do
+        subject.file_ignore(@all, /lib/).should == @filtered
       end
     end
 
@@ -43,5 +58,60 @@ module RailsBestPractices
         result.should == ["app/models/user.rb:10 - law of demeter".red, "app/models/post.rb:100 - use query attribute".red, "\nPlease go to http://rails-bestpractices.com to see more useful Rails Best Practices.".green, "\nFound 2 warnings.".red].join("\n") + "\n"
       end
     end
+
+    describe 'parse_files' do
+
+      it 'should not filter out all files when the path contains "vendor"' do
+        Dir.mktmpdir { |random_dir|
+          Dir.mkdir(File.join(random_dir, 'vendor'))
+          Dir.mkdir(File.join(random_dir, 'vendor', 'my_project'))
+          File.open(File.join(random_dir, 'vendor', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
+          analyzer = Analyzer.new(File.join(random_dir, 'vendor', 'my_project'))
+          analyzer.parse_files.should be_include File.join(random_dir, 'vendor', 'my_project', 'my_file.rb')
+        }
+      end
+
+      it 'should not filter out all files when the path contains "spec"' do
+        Dir.mktmpdir { |random_dir|
+          Dir.mkdir(File.join(random_dir, 'spec'))
+          Dir.mkdir(File.join(random_dir, 'spec', 'my_project'))
+          File.open(File.join(random_dir, 'spec', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
+          analyzer = Analyzer.new(File.join(random_dir, 'spec', 'my_project'))
+          analyzer.parse_files.should be_include File.join(random_dir, 'spec', 'my_project', 'my_file.rb')
+        }
+      end
+
+      it 'should not filter out all files when the path contains "test"' do
+        Dir.mktmpdir { |random_dir|
+          Dir.mkdir(File.join(random_dir, 'test'))
+          Dir.mkdir(File.join(random_dir, 'test', 'my_project'))
+          File.open(File.join(random_dir, 'test', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
+          analyzer = Analyzer.new(File.join(random_dir, 'test', 'my_project'))
+          analyzer.parse_files.should be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
+        }
+      end
+
+      it 'should not filter out all files when the path contains "features"' do
+        Dir.mktmpdir { |random_dir|
+          Dir.mkdir(File.join(random_dir, 'test'))
+          Dir.mkdir(File.join(random_dir, 'test', 'my_project'))
+          File.open(File.join(random_dir, 'test', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
+          analyzer = Analyzer.new(File.join(random_dir, 'test', 'my_project'))
+          analyzer.parse_files.should be_include File.join(random_dir, 'test', 'my_project', 'my_file.rb')
+        }
+      end
+
+      it 'should not filter out all files when the path contains "tmp"' do
+        Dir.mktmpdir { |random_dir|
+          Dir.mkdir(File.join(random_dir, 'tmp'))
+          Dir.mkdir(File.join(random_dir, 'tmp', 'my_project'))
+          File.open(File.join(random_dir, 'tmp', 'my_project', 'my_file.rb'), "w") { |file| file << 'woot' }
+          analyzer = Analyzer.new(File.join(random_dir, 'tmp', 'my_project'))
+          analyzer.parse_files.should be_include File.join(random_dir, 'tmp', 'my_project', 'my_file.rb')
+        }
+      end
+
+    end
+
   end
 end

data/spec/rails_best_practices/prepares/model_prepare_spec.rb

@@ -257,6 +257,23 @@ module RailsBestPractices
           methods = Prepares.model_methods
           methods.get_methods("Admin::Blog::Post").map(&:method_name).should == ["save", "find"]
         end
+
+        it "should not add methods from module" do
+          content =<<-EOF
+            class Model < ActiveRecord::Base
+            end
+          EOF
+          runner.prepare("app/models/model.rb", content)
+          content =<<-EOF
+            module Mixin
+              def mixed_method
+              end
+            end
+          EOF
+          runner.prepare("app/models/mixins/mixin.rb", content)
+          methods = Prepares.model_methods
+          methods.get_methods('Model').should be_empty
+        end
       end
 
       context "scope" do

data/spec/rails_best_practices/reviews/protect_mass_assignment_review_spec.rb

@@ -15,7 +15,15 @@ module RailsBestPractices
         runner.errors[0].to_s.should == "app/models/user.rb:1 - protect mass assignment"
       end
 
-      it "should not protect mass assignment if attr_accessible is used with arguments" do
+      it "should not protect mass assignment if attr_accessible is used with arguments and user set config.active_record.whitelist_attributes" do
+        content =<<-EOF
+        module RailsBestPracticesCom
+          class Application < Rails::Application
+            config.active_record.whitelist_attributes = true
+          end
+        end
+        EOF
+        runner.prepare('config/application.rb', content)
         content =<<-EOF
         class User < ActiveRecord::Base
           attr_accessible :email, :password, :password_confirmation
@@ -25,7 +33,15 @@ module RailsBestPractices
         runner.should have(0).errors
       end
 
-      it "should not protect mass assignment if attr_accessible is used without arguments" do
+      it "should not protect mass assignment if attr_accessible is used without arguments and user set config.active_record.whitelist_attributes" do
+        content =<<-EOF
+        module RailsBestPracticesCom
+          class Application < Rails::Application
+            config.active_record.whitelist_attributes = true
+          end
+        end
+        EOF
+        runner.prepare('config/application.rb', content)
         content =<<-EOF
         class User < ActiveRecord::Base
           attr_accessible
@@ -35,7 +51,15 @@ module RailsBestPractices
         runner.should have(0).errors
       end
 
-      it "should not protect mass assignment with attr_protected" do
+      it "should not protect mass assignment with attr_protected if user set config.active_record.whitelist_attributes" do
+        content =<<-EOF
+        module RailsBestPracticesCom
+          class Application < Rails::Application
+            config.active_record.whitelist_attributes = true
+          end
+        end
+        EOF
+        runner.prepare('config/application.rb', content)
         content =<<-EOF
         class User < ActiveRecord::Base
           attr_protected :role
@@ -77,23 +101,6 @@ module RailsBestPractices
         runner.should have(0).errors
       end
 
-      it "should not protect mass assignment if user set config.active_record.whitelist_attributes" do
-        content =<<-EOF
-        module RailsBestPracticesCom
-          class Application < Rails::Application
-            config.active_record.whitelist_attributes = true
-          end
-        end
-        EOF
-        runner.prepare('config/application.rb', content)
-        content =<<-EOF
-        class User < ActiveRecord::Base
-        end
-        EOF
-        runner.review('app/models/user.rb', content)
-        runner.should have(0).errors
-      end
-
       it "should not protect mass assignment if checking non ActiveRecord::Base inherited model" do
         content =<<-EOF
         class User < Person

data/spec/spec_helper.rb

@@ -3,6 +3,8 @@ $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
 
 require 'rspec'
 require 'rails_best_practices'
+require 'coveralls'
+Coveralls.wear!
 
 RSpec.configure do |config|
   config.after do

metadata

@@ -1,206 +1,181 @@
 --- !ruby/object:Gem::Specification
 name: rails_best_practices
 version: !ruby/object:Gem::Version
-  version: 1.13.4
-  prerelease: 
+  version: 1.13.5
 platform: ruby
 authors:
 - Richard Huang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-08 00:00:00.000000000 Z
+date: 2013-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: code_analyzer
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: colored
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: i18n
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: awesome_print
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: haml
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: slim
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: a code metric tool for rails codes, written in Ruby.
@@ -211,6 +186,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gemtest
 - .gitignore
 - .rspec
@@ -369,32 +345,44 @@ files:
 - spec/spec_helper.rb
 homepage: http://rails-bestpractices.com
 licenses: []
-post_install_message: ! "********************************************************************************\n\n
-  \ rails_best_practices is a code metric tool to check the quality of rails codes.\n\n
-  \ I highly recommend you browse the Rails Best Practices website first.\n\n      http://rails-bestpractices.com\n\n
-  \ Please also try our online service\n\n      http://railsbp.com\n\n  Enjoy!\n\n
-  \     Richard Huang (flyerhzm@gmail.com)\n\n********************************************************************************\n"
+metadata: {}
+post_install_message: |
+  ********************************************************************************
+
+    rails_best_practices is a code metric tool to check the quality of rails codes.
+
+    I highly recommend you browse the Rails Best Practices website first.
+
+        http://rails-bestpractices.com
+
+    Please also try our online service
+
+        http://railsbp.com
+
+    Enjoy!
+
+        Richard Huang (flyerhzm@gmail.com)
+
+  ********************************************************************************
 rdoc_options: []
 require_paths:
 - lib
 - assets
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.0
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: a code metric tool for rails codes.
 test_files:
 - spec/fixtures/lib/rails_best_practices/plugins/reviews/not_use_rails_root_review.rb