rails_best_practices 0.8.0 → 0.8.1

data/lib/rails_best_practices/core.rb

@@ -8,5 +8,6 @@ require 'rails_best_practices/core/visitable_sexp'
 require 'rails_best_practices/core/models'
 require 'rails_best_practices/core/model_associations'
 require 'rails_best_practices/core/model_attributes'
+require 'rails_best_practices/core/mailers'
 
 require 'rails_best_practices/core_ext/enumerable'

data/lib/rails_best_practices/core/mailers.rb

@@ -0,0 +1,7 @@
+# encoding: utf-8
+module RailsBestPractices
+  module Core
+    class Mailers < Array
+    end
+  end
+end

data/lib/rails_best_practices/prepares.rb

@@ -6,14 +6,22 @@ require 'rails_best_practices/prepares/schema_prepare'
 module RailsBestPractices
   module Prepares
     class <<self
-      attr_writer :models, :model_associations, :model_attributes, :mailer_names
+      attr_writer :models, :model_associations, :model_attributes, :mailers
 
-      [:models, :model_associations, :model_attributes, :mailer_names].each do |method_name|
-        class_eval <<-EOS
-        def #{method_name}
-          @#{method_name} ||= []
-        end
-        EOS
+      def models
+        @models ||= Core::Models.new
+      end
+
+      def model_associations
+        @model_associations ||= Core::ModelAssociations.new
+      end
+
+      def model_attributes
+        @model_attributes ||= Core::ModelAttributes.new
+      end
+
+      def mailers
+        @mailers ||= Core::Mailers.new
       end
     end
   end

data/lib/rails_best_practices/prepares/mailer_prepare.rb

@@ -15,7 +15,7 @@ module RailsBestPractices
       end
 
       def initialize
-        @mailer_names = []
+        @mailers = Core::Mailers.new
       end
 
       # check class node.
@@ -24,8 +24,8 @@ module RailsBestPractices
       # then remember its class name.
       def start_class(class_node)
         if s(:colon2, s(:const, :ActionMailer), :Base) == class_node.base_class
-          @mailer_names << class_node.class_name
-          Prepares.mailer_names = @mailer_names
+          @mailers << class_node.class_name.to_s
+          Prepares.mailers = @mailers
         end
       end
     end

data/lib/rails_best_practices/reviews/use_observer_review.rb

@@ -112,15 +112,15 @@ module RailsBestPractices
         def deliver_mailer?(node)
           node.grep_nodes(:node_type => :call) do |child_node|
             # rails2 actionmailer deliver
-            return true if child_node.message.to_s =~ /^deliver_/ && mailer_names.include?(child_node.subject.to_s)
+            return true if child_node.message.to_s =~ /^deliver_/ && mailers.include?(child_node.subject.to_s)
             # rails3 actionmailer deliver
-            return true if :deliver == child_node.message && mailer_names.include?(child_node.subject.subject.to_s)
+            return true if :deliver == child_node.message && mailers.include?(child_node.subject.subject.to_s)
           end
           false
         end
 
-        def mailer_names
-          @mailer_names ||= Prepares.mailer_names.collect(&:to_s)
+        def mailers
+          @mailers ||= Prepares.mailers
         end
     end
   end

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "0.8.0"
+  VERSION = "0.8.1"
 end
 

data/spec/rails_best_practices/prepares/mailer_prepare_spec.rb

@@ -9,6 +9,6 @@ describe RailsBestPractices::Prepares::MailerPrepare do
     end
     EOF
     runner.prepare('app/mailers/project_mailer.rb', content)
-    RailsBestPractices::Prepares.mailer_names.should == [:ProjectMailer]
+    RailsBestPractices::Prepares.mailers.should == ["ProjectMailer"]
   end
 end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  hash: 63
+  hash: 61
   prerelease: 
   segments: 
   - 0
   - 8
-  - 0
-  version: 0.8.0
+  - 1
+  version: 0.8.1
 platform: ruby
 authors: 
 - Richard Huang
@@ -216,6 +216,7 @@ files:
 - lib/rails_best_practices/core/check.rb
 - lib/rails_best_practices/core/checking_visitor.rb
 - lib/rails_best_practices/core/error.rb
+- lib/rails_best_practices/core/mailers.rb
 - lib/rails_best_practices/core/model_associations.rb
 - lib/rails_best_practices/core/model_attributes.rb
 - lib/rails_best_practices/core/models.rb