rails_best_practices 0.7.3 → 0.7.4

data/lib/rails_best_practices/core/check.rb

@@ -12,7 +12,8 @@ module RailsBestPractices
       MAILER_FILES = /models\/.*mailer\.rb$|mailers\/.*mailer\.rb/
       VIEW_FILES = /views\/.*\.(erb|haml)$/
       PARTIAL_VIEW_FILES = /views\/.*\/_.*\.(erb|haml)$/
-      ROUTE_FILE = /config\/routes.rb/
+      ROUTE_FILE = /config\/routes\.rb/
+      SCHEMA_FILE = /db\/schema\.rb/
 
       attr_reader :errors
 

data/lib/rails_best_practices/core/model_associations.rb

@@ -22,4 +22,4 @@ module RailsBestPractices
       end
     end
   end
-end
+end

data/lib/rails_best_practices/core/model_attributes.rb

@@ -0,0 +1,25 @@
+# encoding: utf-8
+module RailsBestPractices
+  module Core
+    class ModelAttributes
+      def initialize
+        @attributes = {}
+      end
+
+      def add_attribute(model_name, attribute_name, attribute_type)
+        @attributes[model_name] ||= {}
+        @attributes[model_name][attribute_name] = attribute_type
+      end
+
+      def get_attribute_type(model_name, attribute_name)
+        @attributes[model_name] ||= {}
+        @attributes[model_name][attribute_name]
+      end
+
+      def is_attribute?(model_name, attribute_name)
+        @attributes[model_name] ||= {}
+        !!@attributes[model_name][attribute_name]
+      end
+    end
+  end
+end

data/lib/rails_best_practices/core/runner.rb

@@ -148,7 +148,7 @@ module RailsBestPractices
 
         # load all prepares.
         def load_prepares
-          [RailsBestPractices::Prepares::ModelPrepare.new, RailsBestPractices::Prepares::MailerPrepare.new]
+          [Prepares::ModelPrepare.new, Prepares::MailerPrepare.new, Prepares::SchemaPrepare.new]
         end
 
         # load all reviews according to configuration.

data/lib/rails_best_practices/core.rb

@@ -7,5 +7,6 @@ require 'rails_best_practices/core/nil'
 require 'rails_best_practices/core/visitable_sexp'
 require 'rails_best_practices/core/models'
 require 'rails_best_practices/core/model_associations'
+require 'rails_best_practices/core/model_attributes'
 
 require 'rails_best_practices/core_ext/enumerable'

data/lib/rails_best_practices/prepares/model_prepare.rb

@@ -25,7 +25,7 @@ module RailsBestPractices
         @models << @last_klazz
       end
 
-      # assign @model_associations to Prepare.model_associations.
+      # assign @model_associations to Prepares.model_associations.
       def end_class(class_node)
         Prepares.models = @models
         Prepares.model_associations = @model_associations

data/lib/rails_best_practices/prepares/schema_prepare.rb

@@ -0,0 +1,44 @@
+# encoding: utf-8
+require 'rails_best_practices/core/check'
+
+module RailsBestPractices
+  module Prepares
+    # Remember the model attributes.
+    class SchemaPrepare < Core::Check
+      # all attribute types
+      ATTRIBUTE_TYPES = [:integer, :float, :boolean, :string, :text, :date, :time, :datetime, :binary]
+
+      def interesting_nodes
+        [:call]
+      end
+
+      def interesting_files
+        SCHEMA_FILE
+      end
+
+      def initialize
+        @model_attributes = Core::ModelAttributes.new
+      end
+
+      # check call node to remember the model attributes.
+      def start_call(call_node)
+        case call_node.message
+        when :create_table
+          @last_klazz = call_node.arguments[1].to_s.classify
+        when *ATTRIBUTE_TYPES
+          attribute_name = call_node.arguments[1].to_s
+          @model_attributes.add_attribute(@last_klazz, attribute_name, call_node.message)
+        else
+          # nothing to do
+        end
+      end
+
+      # assign @model_attributes to Prepares.model_attributes.
+      def end_call(call_node)
+        if :create_table == call_node.message
+          Prepares.model_attributes = @model_attributes
+        end
+      end
+    end
+  end
+end

data/lib/rails_best_practices/prepares.rb

@@ -1,11 +1,12 @@
 # encoding: utf-8
 require 'rails_best_practices/prepares/model_prepare'
 require 'rails_best_practices/prepares/mailer_prepare'
+require 'rails_best_practices/prepares/schema_prepare'
 
 module RailsBestPractices
   module Prepares
     class <<self
-      attr_accessor :models, :model_associations, :mailer_names
+      attr_accessor :models, :model_associations, :model_attributes, :mailer_names
     end
   end
 end

data/lib/rails_best_practices/reviews/always_add_db_index_review.rb

@@ -33,7 +33,7 @@ module RailsBestPractices
       end
 
       def interesting_files
-        /db\/schema.rb/
+        SCHEMA_FILE
       end
 
       def initialize

data/lib/rails_best_practices/reviews/law_of_demeter_review.rb

@@ -63,14 +63,30 @@ module RailsBestPractices
         # and the message of subject of the call node is :user
         def need_delegate?(node)
           class_name = node.subject.subject.to_s(:remove_at => true).classify
-          association = model_associations.get_association(class_name, node.subject.message.to_s)
-          association && association_methods.include?(association[:meta])
+          association_name = node.subject.message.to_s
+          association = model_associations.get_association(class_name, association_name)
+          attribute_name = node.message.to_s
+          association && association_methods.include?(association[:meta]) &&
+            is_association_attribute?(association[:class_name], association_name, attribute_name)
         end
 
         # only check belongs_to and has_one association.
         def association_methods
           [:belongs_to, :has_one]
         end
+
+        def is_association_attribute?(association_class, association_name, attribute_name)
+          if association_name =~ /able$/
+            models.each do |class_name|
+              if model_associations.is_association?(class_name, association_name.sub(/able$/, '')) ||
+                model_associations.is_association?(class_name, association_name.sub(/able$/, 's'))
+                return true if model_attributes.is_attribute?(class_name, attribute_name)
+              end
+            end
+          else
+            model_attributes.is_attribute?(association_class, attribute_name)
+          end
+        end
     end
   end
 end

data/lib/rails_best_practices/reviews/move_code_into_helper_review.rb

@@ -47,32 +47,32 @@ module RailsBestPractices
 
       private
         # check if the arguments of options_for_select are complex.
-      #
-      # if the first argument is an array,
-      # and the size of array is greater than @array_count you defined,
-      # then it is complext, e.g.
-      #
-      #     s(:call, nil, :options_for_select,
-      #       s(:arglist,
-      #         s(:array,
-      #           s(:array,
-      #             s(:call, nil, :t, s(:arglist, s(:lit, :draft))),
-      #             s(:str, "draft")
-      #           ),
-      #           s(:array,
-      #             s(:call, nil, :t, s(:arglist, s(:lit, :published))),
-      #             s(:str, "published")
-      #           )
-      #         ),
-      #         s(:call,
-      #           s(:call, nil, :params, s(:arglist)),
-      #           :[],
-      #           s(:arglist, s(:lit, :default_state))
-      #         )
-      #       )
-      #     )
+        #
+        # if the first argument is an array,
+        # and the size of array is greater than @array_count you defined,
+        # then it is complext, e.g.
+        #
+        #     s(:call, nil, :options_for_select,
+        #       s(:arglist,
+        #         s(:array,
+        #           s(:array,
+        #             s(:call, nil, :t, s(:arglist, s(:lit, :draft))),
+        #             s(:str, "draft")
+        #           ),
+        #           s(:array,
+        #             s(:call, nil, :t, s(:arglist, s(:lit, :published))),
+        #             s(:str, "published")
+        #           )
+        #         ),
+        #         s(:call,
+        #           s(:call, nil, :params, s(:arglist)),
+        #           :[],
+        #           s(:arglist, s(:lit, :default_state))
+        #         )
+        #       )
+        #     )
         def complex_select_options?(node)
-          :options_for_select == node.message and :array == node.arguments[1].node_type and node.arguments[1].size > @array_count
+          :options_for_select == node.message && :array == node.arguments[1].node_type && node.arguments[1].size > @array_count
         end
     end
   end

data/lib/rails_best_practices/reviews/review.rb

@@ -74,6 +74,13 @@ module RailsBestPractices
         @model_associations ||= Prepares.model_associations
       end
 
+      # get the model attributes from Prepares.
+      #
+      # @return [Hash]
+      def model_attributes
+        @model_attributes ||= Prepares.model_attributes
+      end
+
       # compare two sexp nodes' to_s.
       #
       #     equal?(":test", :test) => true

data/lib/rails_best_practices/reviews/use_query_attribute_review.rb

@@ -65,7 +65,7 @@ module RailsBestPractices
         # if the node contains two method calls, e.g. @user.login.nil?
         #
         # for the first call, the subject should be one of the class names and
-        # the message should not be one of the association name and the message should not be pluralize.
+        # the message should be one of the attribute name.
         #
         # for the second call, the message should be one of nil?, blank? or present? or
         # it is compared with an empty string.
@@ -81,8 +81,8 @@ module RailsBestPractices
           return false unless subject
           message = node.subject.message
 
-          [:arglist] == node.subject.arguments && is_model?(subject) && !model_association?(subject, message) &&
-            !pluralize?(message.to_s) && (QUERY_METHODS.include?(node.message) || compare_with_empty_string?(node))
+          [:arglist] == node.subject.arguments && is_model?(subject) && model_attribute?(subject, message) &&
+            (QUERY_METHODS.include?(node.message) || compare_with_empty_string?(node))
         end
 
         # check if the subject is one of the models.
@@ -95,23 +95,18 @@ module RailsBestPractices
           models.include?(class_name)
         end
 
-        # check if the subject and message is one of the model's aassociation.
-        # the subject should match one of the class model name, and the message should match one of association name.
+        # check if the subject and message is one of the model's attribute.
+        # the subject should match one of the class model name, and the message should match one of attribute name.
         #
         #     subject, subject of call node, like
         #         s(:ivar, @user)
         #
         #     message, message of call node, like
         #         :login
-        def model_association?(subject, message)
+        def model_attribute?(subject, message)
           class_name = subject.to_s(:remove_at => true).classify
-          model_associations.is_association?(class_name, message.to_s)
-        end
-
-
-        # check if the str is a pluralize string.
-        def pluralize?(str)
-          str.pluralize == str
+          attribute_type = model_attributes.get_attribute_type(class_name, message.to_s)
+          attribute_type && ![:integer, :float].include?(attribute_type)
         end
 
         # check if the node is with node type :call, node message :== and node arguments {:arglist, (:str, "")}

data/lib/rails_best_practices/version.rb

@@ -1,5 +1,5 @@
 # encoding: utf-8
 module RailsBestPractices
-  VERSION = "0.7.3"
+  VERSION = "0.7.4"
 end
 

data/lib/rails_best_practices.rb

@@ -113,8 +113,8 @@ module RailsBestPractices
     # @return [Array] all files for prepare process
     def prepare_files
       @prepare_files ||= begin
-        ['models', 'mailers'].inject([]) { |files, name|
-          files += expand_dirs_to_files(File.join(@path, 'app', name))
+        ['app/models', 'app/mailers', 'db/schema.rb'].inject([]) { |files, name|
+          files += expand_dirs_to_files(File.join(@path, name))
         }.compact
       end
     end

data/spec/rails_best_practices/core/model_associations_spec.rb

@@ -15,8 +15,8 @@ describe RailsBestPractices::Core::ModelAssociations do
   end
 
   it "should check is model associatiosn" do
-    model_associations.get_association("Project", "project_manager").should be_true
-    model_associations.get_association("Project", "people").should be_true
-    model_associations.get_association("Project", "unknown").should be_false
+    model_associations.is_association?("Project", "project_manager").should be_true
+    model_associations.is_association?("Project", "people").should be_true
+    model_associations.is_association?("Project", "unknown").should be_false
   end
-end
+end

data/spec/rails_best_practices/core/model_attributes_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Core::ModelAttributes do
+  let(:model_attributes) { RailsBestPractices::Core::ModelAttributes.new }
+
+  before :each do
+    model_attributes.add_attribute("Post", "title", :string)
+    model_attributes.add_attribute("Post", "user_id", :integer)
+  end
+
+  it "should get model attributes" do
+    model_attributes.get_attribute_type("Post", "title").should == :string
+    model_attributes.get_attribute_type("Post", "user_id").should == :integer
+    model_attributes.get_attribute_type("Post", "unknonw").should be_nil
+  end
+
+  it "should check is model attributes" do
+    model_attributes.is_attribute?("Post", "title").should be_true
+    model_attributes.is_attribute?("Post", "user_id").should be_true
+    model_attributes.is_attribute?("Post", "unknonw").should be_false
+  end
+end

data/spec/rails_best_practices/prepares/schema_prepare_spec.rb

@@ -0,0 +1,28 @@
+require 'spec_helper'
+
+describe RailsBestPractices::Prepares::SchemaPrepare do
+  let(:runner) { RailsBestPractices::Core::Runner.new(:prepares => RailsBestPractices::Prepares::SchemaPrepare.new) }
+
+  it "should parse model attributes" do
+    content =<<-EOF
+    ActiveRecord::Schema.define(:version => 20110319172136) do
+      create_table "posts", :force => true do |t|
+        t.string   "title"
+        t.text     "body",           :limit => 16777215
+        t.datetime "created_at"
+        t.integer  "user_id"
+        t.integer  "comments_count",                     :default => 0
+        t.boolean  "published",                          :default => false, :null => false
+      end
+    end
+    EOF
+    runner.prepare("db/schema.rb", content)
+    model_attributes = RailsBestPractices::Prepares.model_attributes
+    model_attributes.get_attribute_type("Post", "title").should == :string
+    model_attributes.get_attribute_type("Post", "body").should == :text
+    model_attributes.get_attribute_type("Post", "created_at").should == :datetime
+    model_attributes.get_attribute_type("Post", "user_id").should == :integer
+    model_attributes.get_attribute_type("Post", "comments_count").should == :integer
+    model_attributes.get_attribute_type("Post", "published").should == :boolean
+  end
+end

data/spec/rails_best_practices/reviews/law_of_demeter_review_spec.rb

@@ -4,7 +4,7 @@ describe RailsBestPractices::Reviews::LawOfDemeterReview do
 
   let(:runner) {
     RailsBestPractices::Core::Runner.new(
-      :prepares => RailsBestPractices::Prepares::ModelPrepare.new,
+      :prepares => [RailsBestPractices::Prepares::ModelPrepare.new, RailsBestPractices::Prepares::SchemaPrepare.new],
       :reviews => RailsBestPractices::Reviews::LawOfDemeterReview.new
     )
   }
@@ -17,6 +17,17 @@ describe RailsBestPractices::Reviews::LawOfDemeterReview do
       end
       EOF
       runner.prepare('app/models/invoice.rb', content)
+
+      content = <<-EOF
+      ActiveRecord::Schema.define(:version => 20110216150853) do
+        create_table "users", force => true do |t|
+          t.string :name
+          t.string :address
+          t.string :cellphone
+        end
+      end
+      EOF
+      runner.prepare('db/schema.rb', content)
     end
 
     it "should law of demeter" do
@@ -60,6 +71,16 @@ describe RailsBestPractices::Reviews::LawOfDemeterReview do
       end
       EOF
       runner.prepare('app/models/invoice.rb', content)
+
+      content = <<-EOF
+      ActiveRecord::Schema.define(:version => 20110216150853) do
+        create_table "prices", force => true do |t|
+          t.string :currency
+          t.integer :number
+        end
+      end
+      EOF
+      runner.prepare('db/schema.rb', content)
     end
 
     it "should law of demeter" do
@@ -73,6 +94,42 @@ describe RailsBestPractices::Reviews::LawOfDemeterReview do
     end
   end
 
+  context "polymorphic association" do
+    before :each do
+      content = <<-EOF
+      class Comment < ActiveRecord::Base
+        belongs_to :commentable, :polymorphic => true
+      end
+      EOF
+      runner.prepare('app/models/comment.rb', content)
+
+      content = <<-EOF
+      class Post < ActiveRecord::Base
+        has_many :comments
+      end
+      EOF
+      runner.prepare('app/models/comment.rb', content)
+
+      content = <<-EOF
+      ActiveRecord::Schema.define(:version => 20110216150853) do
+        create_table "posts", force => true do |t|
+          t.string :title
+        end
+      end
+      EOF
+      runner.prepare('db/schema.rb', content)
+    end
+
+    it "should law of demeter" do
+      content = <<-EOF
+      <%= @comment.commentable.title %>
+      EOF
+      runner.review('app/views/comments/index.html.erb', content)
+      runner.should have(1).errors
+      runner.errors[0].to_s.should == "app/views/comments/index.html.erb:1 - law of demeter"
+    end
+  end
+
   it "should no law of demeter with method call" do
     content = <<-EOF
     class Question < ActiveRecord::Base

data/spec/rails_best_practices/reviews/use_query_attribute_review_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 describe RailsBestPractices::Reviews::UseQueryAttributeReview do
   let(:runner) {
     RailsBestPractices::Core::Runner.new(
-      :prepares => RailsBestPractices::Prepares::ModelPrepare.new,
+      :prepares => [RailsBestPractices::Prepares::ModelPrepare.new, RailsBestPractices::Prepares::SchemaPrepare.new],
       :reviews => RailsBestPractices::Reviews::UseQueryAttributeReview.new
     )
   }
@@ -19,6 +19,16 @@ describe RailsBestPractices::Reviews::UseQueryAttributeReview do
     end
     EOF
     runner.prepare('app/models/user.rb', content)
+
+    content = <<-EOF
+    ActiveRecord::Schema.define(:version => 20110216150853) do
+      create_table "users", force => true do |t|
+        t.string :login
+        t.integer :age
+      end
+    end
+    EOF
+    runner.prepare('db/schema.rb', content)
   end
 
   it "should use query attribute by blank call" do
@@ -97,6 +107,16 @@ describe RailsBestPractices::Reviews::UseQueryAttributeReview do
     runner.should have(0).errors
   end
 
+  it "should not use query attribute for number" do
+    content =<<-EOF
+    <% unless @user.age.blank? %>
+      <%= @user.age %>
+    <% end %>
+    EOF
+    runner.review('app/views/users/show.html.erb', content)
+    runner.should have(0).errors
+  end
+
   it "should not review for pluralize attribute" do
     content = <<-EOF
     <% if @user.roles.blank? %>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  hash: 5
+  hash: 11
   prerelease: 
   segments: 
   - 0
   - 7
-  - 3
-  version: 0.7.3
+  - 4
+  version: 0.7.4
 platform: ruby
 authors: 
 - Richard Huang
@@ -15,10 +15,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-23 00:00:00 +08:00
+date: 2011-03-25 00:00:00 +08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -30,11 +32,11 @@ dependencies:
         - 0
         - 4
         version: 2.0.4
-  prerelease: false
   version_requirements: *id001
-  type: :runtime
   name: ruby_parser
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -46,11 +48,11 @@ dependencies:
         - 0
         - 9
         version: 0.0.9
-  prerelease: false
   version_requirements: *id002
-  type: :runtime
   name: ruby-progressbar
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -61,11 +63,11 @@ dependencies:
         - 1
         - 2
         version: "1.2"
-  prerelease: false
   version_requirements: *id003
-  type: :runtime
   name: colored
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -77,11 +79,11 @@ dependencies:
         - 6
         - 6
         version: 2.6.6
-  prerelease: false
   version_requirements: *id004
-  type: :runtime
   name: erubis
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -93,11 +95,11 @@ dependencies:
         - 0
         - 18
         version: 3.0.18
-  prerelease: false
   version_requirements: *id005
-  type: :runtime
   name: haml
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -107,11 +109,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
   version_requirements: *id006
-  type: :runtime
   name: i18n
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :runtime
   requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -121,11 +123,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
   version_requirements: *id007
-  type: :runtime
   name: activesupport
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -135,11 +137,11 @@ dependencies:
         segments: 
         - 0
         version: "0"
-  prerelease: false
   version_requirements: *id008
-  type: :development
   name: rake
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -151,11 +153,11 @@ dependencies:
         - 4
         - 0
         version: 2.4.0
-  prerelease: false
   version_requirements: *id009
-  type: :development
   name: rspec
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -166,11 +168,11 @@ dependencies:
         - 0
         - 6
         version: "0.6"
-  prerelease: false
   version_requirements: *id010
-  type: :development
   name: watchr
 - !ruby/object:Gem::Dependency 
+  prerelease: false
+  type: :development
   requirement: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
@@ -182,9 +184,7 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  prerelease: false
   version_requirements: *id011
-  type: :development
   name: bundler
 description: a code metric tool for rails codes, written in Ruby.
 email: 
@@ -217,6 +217,7 @@ files:
 - lib/rails_best_practices/core/checking_visitor.rb
 - lib/rails_best_practices/core/error.rb
 - lib/rails_best_practices/core/model_associations.rb
+- lib/rails_best_practices/core/model_attributes.rb
 - lib/rails_best_practices/core/models.rb
 - lib/rails_best_practices/core/nil.rb
 - lib/rails_best_practices/core/runner.rb
@@ -227,6 +228,7 @@ files:
 - lib/rails_best_practices/prepares.rb
 - lib/rails_best_practices/prepares/mailer_prepare.rb
 - lib/rails_best_practices/prepares/model_prepare.rb
+- lib/rails_best_practices/prepares/schema_prepare.rb
 - lib/rails_best_practices/reviews.rb
 - lib/rails_best_practices/reviews/add_model_virtual_attribute_review.rb
 - lib/rails_best_practices/reviews/always_add_db_index_review.rb
@@ -260,6 +262,7 @@ files:
 - spec/rails_best_practices/core/checking_visitor_spec.rb
 - spec/rails_best_practices/core/error_spec.rb
 - spec/rails_best_practices/core/model_associations_spec.rb
+- spec/rails_best_practices/core/model_attributes_spec.rb
 - spec/rails_best_practices/core/models_spec.rb
 - spec/rails_best_practices/core/nil_spec.rb
 - spec/rails_best_practices/core/visitable_sexp_spec.rb
@@ -267,6 +270,7 @@ files:
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
+- spec/rails_best_practices/prepares/schema_prepare_spec.rb
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
 - spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb
@@ -339,7 +343,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.4.2
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: a code metric tool for rails codes.
@@ -348,6 +352,7 @@ test_files:
 - spec/rails_best_practices/core/checking_visitor_spec.rb
 - spec/rails_best_practices/core/error_spec.rb
 - spec/rails_best_practices/core/model_associations_spec.rb
+- spec/rails_best_practices/core/model_attributes_spec.rb
 - spec/rails_best_practices/core/models_spec.rb
 - spec/rails_best_practices/core/nil_spec.rb
 - spec/rails_best_practices/core/visitable_sexp_spec.rb
@@ -355,6 +360,7 @@ test_files:
 - spec/rails_best_practices/lexicals/remove_trailing_whitespace_check_spec.rb
 - spec/rails_best_practices/prepares/mailer_prepare_spec.rb
 - spec/rails_best_practices/prepares/model_prepare_spec.rb
+- spec/rails_best_practices/prepares/schema_prepare_spec.rb
 - spec/rails_best_practices/reviews/add_model_virtual_attribute_review_spec.rb
 - spec/rails_best_practices/reviews/always_add_db_index_review_spec.rb
 - spec/rails_best_practices/reviews/dry_bundler_in_capistrano_review_spec.rb