rails_best_practices 0.3.5 → 0.3.6

data/VERSION

@@ -1 +1 @@
-0.3.5
+0.3.6

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -82,7 +82,7 @@ module RailsBestPractices
         nodes.each do |node|
           begin
             eval(node.to_ruby)
-          rescue
+          rescue Exception
           end
         end
       end

data/rails_best_practices.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.5"
+  s.version = "0.3.6"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
-  s.date = %q{2009-11-22}
+  s.date = %q{2009-11-23}
   s.default_executable = %q{rails_best_practices}
   s.description = %q{check rails files according to ihower's presentation 'rails best practices'}
   s.email = %q{flyerhzm@gmail.com}

data/spec/rails_best_practices/checks/always_add_db_index_check_spec.rb

@@ -177,4 +177,20 @@ describe RailsBestPractices::Checks::AlwaysAddDbIndexCheck do
     @runner.check('db/migrate/20091111113612_add_indexes.rb', content)
     errors = @runner.errors
   end
+
+  it "should always add db index without error 2" do
+    content = <<-EOF
+    class MoveCategoriesToProfileArea < ActiveRecord::Migration
+      def self.up
+        CategoryArea.update_all({:name => "Profile"}, ["name IN (?)", %w(UserSite UserProfile Site)])
+      end
+
+      def self.down
+      end
+    end
+    EOF
+    @runner.check('db/migrate/20090706091635_move_categories_to_profile_area.rb', content)
+    @runner.check('db/migrate/20090706091635_move_categories_to_profile_area.rb', content)
+    errors = @runner.errors
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.3.5
+  version: 0.3.6
 platform: ruby
 authors: 
 - Richard Huang
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-22 00:00:00 +08:00
+date: 2009-11-23 00:00:00 +08:00
 default_executable: rails_best_practices
 dependencies: 
 - !ruby/object:Gem::Dependency