rails_best_practices 0.3.23 → 0.3.24

data/Rakefile

@@ -25,7 +25,7 @@ Jeweler::Tasks.new do |gemspec|
   gemspec.summary = "check rails files according to ihower's presentation 'rails best practices'"
   gemspec.description = "check rails files according to ihower's presentation 'rails best practices'"
   gemspec.email = "flyerhzm@gmail.com"
-  gemspec.homepage = "http://github.com/flyerhzm/rails_best_practices"
+  gemspec.homepage = "http://rails-bestpractices.com"
   gemspec.authors = ["Richard Huang"]
   gemspec.add_dependency 'ruby_parser', '>= 2.0.4'
   gemspec.add_dependency 'ruby2ruby', '>= 1.2.4'

data/VERSION

@@ -1 +1 @@
-0.3.23
+0.3.24

data/lib/rails_best_practices/checks/law_of_demeter_check.rb

@@ -5,8 +5,8 @@ module RailsBestPractices
     # Check to make sure not avoid the law of demeter.
     # 
     # Implementation: 
-    # 1. check all models to record belongs_to associations
-    # 2. check if calling belongs_to association's method or attribute
+    # 1. check all models to record belongs_to and has_one associations
+    # 2. check if calling belongs_to and has_one association's method or attribute
     class LawOfDemeterCheck < Check
       
       def interesting_nodes
@@ -20,7 +20,7 @@ module RailsBestPractices
 
       def evaluate_start(node)
         if node.node_type == :class
-          remember_belongs_to(node)
+          remember_association(node)
         elsif [:lvar, :ivar].include?(node.subject.node_type) and node.subject != s(:lvar, :_erbout)
           add_error "law of demeter" if need_delegate?(node)
         end
@@ -28,8 +28,9 @@ module RailsBestPractices
 
       private
 
-      def remember_belongs_to(node)
-        node.body.grep_nodes(:message => :belongs_to).collect do |body_node|
+      # remember belongs_to or has_one node
+      def remember_association(node)
+        (node.body.grep_nodes(:message => :belongs_to) + node.body.grep_nodes(:message => :has_one)).collect do |body_node|
           class_name = node.subject.to_s.underscore
           @associations[class_name] ||= []
           @associations[class_name] << body_node.arguments[1].to_ruby_string

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.3.23"
+  s.version = "0.3.24"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
@@ -85,7 +85,7 @@ Gem::Specification.new do |s|
      "spec/spec.opts",
      "spec/spec_helper.rb"
   ]
-  s.homepage = %q{http://github.com/flyerhzm/rails_best_practices}
+  s.homepage = %q{http://rails-bestpractices.com}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
   s.rubygems_version = %q{1.3.6}

data/spec/rails_best_practices/checks/law_of_demeter_check_spec.rb

@@ -1,49 +1,76 @@
 require File.join(File.dirname(__FILE__) + '/../../spec_helper')
 
 describe RailsBestPractices::Checks::LawOfDemeterCheck do
-  before(:each) do
-    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::LawOfDemeterCheck.new)
+  
+  describe "belongs_to" do
+    before(:each) do
+      @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::LawOfDemeterCheck.new)
 
-    content = <<-EOF
-    class Invoice < ActiveRecord::Base
-      belongs_to :user
+      content = <<-EOF
+      class Invoice < ActiveRecord::Base
+        belongs_to :user
+      end
+      EOF
+      @runner.check('app/models/invoice.rb', content)
     end
-    EOF
-    @runner.check('app/models/invoice.rb', content)
-  end
 
-  it "should law of demeter" do
-    content = <<-EOF
-    <%= @invoice.user.name %>
-    <%= @invoice.user.address %>
-    <%= @invoice.user.cellphone %>
-    EOF
-    @runner.check('app/views/invoices/show.html.erb', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
-  end
+    it "should law of demeter" do
+      content = <<-EOF
+      <%= @invoice.user.name %>
+      <%= @invoice.user.address %>
+      <%= @invoice.user.cellphone %>
+      EOF
+      @runner.check('app/views/invoices/show.html.erb', content)
+      errors = @runner.errors
+      errors.should_not be_empty
+      errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
+    end
 
-  it "should law of demeter" do
-    content = <<-EOF
+    it "should law of demeter" do
+      content = <<-EOF
 = @invoice.user.name
 = @invoice.user.address
 = @invoice.user.cellphone
-    EOF
-    @runner.check('app/views/invoices/show.html.haml', content)
-    errors = @runner.errors
-    errors.should_not be_empty
-    errors[0].to_s.should == "app/views/invoices/show.html.haml:1 - law of demeter"
+      EOF
+      @runner.check('app/views/invoices/show.html.haml', content)
+      errors = @runner.errors
+      errors.should_not be_empty
+      errors[0].to_s.should == "app/views/invoices/show.html.haml:1 - law of demeter"
+    end
+
+    it "should no law of demeter" do
+      content = <<-EOF
+      <%= @invoice.user_name %>
+      <%= @invoice.user_address %>
+      <%= @invoice.user_cellphone %>
+      EOF
+      @runner.check('app/views/invoices/show.html.erb', content)
+      errors = @runner.errors
+      errors.should be_empty
+    end
   end
 
-  it "should no law of demeter" do
-    content = <<-EOF
-    <%= @invoice.user_name %>
-    <%= @invoice.user_address %>
-    <%= @invoice.user_cellphone %>
-    EOF
-    @runner.check('app/views/invoices/show.html.erb', content)
-    errors = @runner.errors
-    errors.should be_empty
+  describe "has_one" do
+    before(:each) do
+      @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::LawOfDemeterCheck.new)
+
+      content = <<-EOF
+      class Invoice < ActiveRecord::Base
+        has_one :price
+      end
+      EOF
+      @runner.check('app/models/invoice.rb', content)
+    end
+
+    it "should law of demeter" do
+      content = <<-EOF
+      <%= @invoice.price.currency %>
+      <%= @invoice.price.number %>
+      EOF
+      @runner.check('app/views/invoices/show.html.erb', content)
+      errors = @runner.errors
+      errors.should_not be_empty
+      errors[0].to_s.should == "app/views/invoices/show.html.erb:1 - law of demeter"
+    end
   end
 end

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 3
-  - 23
-  version: 0.3.23
+  - 24
+  version: 0.3.24
 platform: ruby
 authors: 
 - Richard Huang
@@ -121,7 +121,7 @@ files:
 - spec/spec.opts
 - spec/spec_helper.rb
 has_rdoc: true
-homepage: http://github.com/flyerhzm/rails_best_practices
+homepage: http://rails-bestpractices.com
 licenses: []
 
 post_install_message: