rails_best_practices 0.2.16 → 0.3.0

data/README.textile

@@ -1,7 +1,7 @@
 h1. rails_best_practices
 
-rails_best_practices is a gem to check quality of rails app files according to ihower's presentation Rails Best Practices.
-rails_best_practices is a code static parser tool based on ruby_parser.
+rails_best_practices is a gem to check quality of rails app files according to ihower's presentation Rails Best Practices from Kungfu RailsConf in Shanghai China.
+rails_best_practices is a code static parser tool.
 
 *************************************************
 
@@ -104,8 +104,8 @@ h2. Progress
 ## Move code into model
 ## [-Move code into helper-]
 ## [-Replace instance variable with local variable-]
-## Use Form Builder
-## Organize Helper files
+## [-Use Form Builder-] # not implement, use http://github.com/justinfrench/formtastic
+## [-Organize Helper files-] # not implement, it's rails default behaviour
 
 *************************************************
 

data/VERSION

@@ -1 +1 @@
-0.2.16
+0.3.0

data/lib/rails_best_practices/checks/use_filter_check.rb

@@ -28,8 +28,10 @@ module RailsBestPractices
       def remember_method(method_node)
         method_name = method_node.message_name
         first_call = method_node.body[1]
-        @methods[first_call] ||= []
-        @methods[first_call] << method_name
+        unless first_call == s(:nil)
+          @methods[first_call] ||= []
+          @methods[first_call] << method_name
+        end
       end
     end
   end

data/lib/rails_best_practices/command.rb

@@ -69,6 +69,9 @@ end
 files.each { |file| runner.check_file(file) }
 
 runner.errors.each {|error| puts error}
-puts "\nFound #{runner.errors.size} errors."
+if runner.errors.size > 0
+  puts "\ngo to http://wiki.github.com/flyerhzm/rails_best_practices to see how to solve these errors."
+  puts "\nFound #{runner.errors.size} errors."
+end
 
 exit runner.errors.size

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.2.16"
+  s.version = "0.3.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]

data/spec/rails_best_practices/checks/use_filter_check_spec.rb

@@ -59,4 +59,27 @@ describe RailsBestPractices::Checks::UseFilterCheck do
     errors = @runner.errors
     errors.should be_empty
   end
+
+  it "should not use filter by nil" do
+    content = <<-EOF
+    class PostsController < ApplicationController
+
+      def show
+      end
+
+      def edit
+      end
+
+      def update
+      end
+
+      def destroy
+      end
+
+    end
+    EOF
+    @runner.check('app/controllers/posts_controller.rb', content)
+    errors = @runner.errors
+    errors.should be_empty
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.2.16
+  version: 0.3.0
 platform: ruby
 authors: 
 - Richard Huang