rails_best_practices 0.2.8 → 0.2.9

data/VERSION

@@ -1 +1 @@
-0.2.8
+0.2.9

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -51,22 +51,22 @@ module RailsBestPractices
       def remember_references(node)
         create_table_node = node.grep_nodes({:node_type => :call, :message => :create_table}).first
         if create_table_node
-          table_name = eval(create_table_node.arguments[1].to_ruby).to_s
+          table_name = create_table_node.arguments[1].to_ruby_string
           node.grep_nodes({:node_type => :call, :message => :integer}).each do |integer_node|
-            column_name = eval(integer_node.arguments[1].to_ruby).to_s
+            column_name = integer_node.arguments[1].to_ruby_string
             if column_name =~ /_id$/
               @references[table_name] ||= []
               @references[table_name] << column_name
             end
           end
           node.grep_nodes({:node_type => :call, :message => :references}).each do |references_node|
-            column_name = eval(references_node.arguments[1].to_ruby).to_s + "_id"
+            column_name = references_node.arguments[1].to_ruby_string + "_id"
             @references[table_name] ||= []
             @references[table_name] << column_name
           end
           node.grep_nodes({:node_type => :call, :message => :column}).each do |column_node|
-            if 'integer' == eval(column_node.arguments[2].to_ruby).to_s
-              column_name = eval(column_node.arguments[1].to_ruby).to_s
+            if 'integer' == column_node.arguments[2].to_ruby_string
+              column_name = column_node.arguments[1].to_ruby_string
               if column_name =~ /_id$/
                 @references[table_name] ||= []
                 @references[table_name] << column_name
@@ -79,8 +79,8 @@ module RailsBestPractices
       def remember_indexes(node)
         add_index_nodes = node.grep_nodes({:node_type => :call, :message => :add_index})
         add_index_nodes.each do |add_index_node|
-          table_name = eval(add_index_node.arguments[1].to_ruby).to_s
-          column_name = eval(add_index_node.arguments[2].to_ruby).to_s
+          table_name = add_index_node.arguments[1].to_ruby_string
+          column_name = add_index_node.arguments[2].to_ruby_string
           @indexes[table_name] ||= []
           @indexes[table_name] << column_name
         end

data/lib/rails_best_practices/checks/law_of_demeter_check.rb

@@ -32,7 +32,7 @@ module RailsBestPractices
         node.body.grep_nodes(:message => :belongs_to).collect do |body_node|
           class_name = node.subject.to_s.underscore
           @associations[class_name] ||= []
-          @associations[class_name] << eval(body_node.arguments[1].to_ruby).to_s
+          @associations[class_name] << body_node.arguments[1].to_ruby_string
         end
       end
 

data/lib/rails_best_practices/checks/use_observer_check.rb

@@ -34,7 +34,7 @@ module RailsBestPractices
 
       def remember_callbacks(node)
         node.arguments[1..-1].each do |argument|
-          @callbacks << eval(argument.to_ruby).to_s
+          @callbacks << argument.to_ruby_string
         end
       end
 

data/lib/rails_best_practices/core/visitable_sexp.rb

@@ -101,4 +101,9 @@ class Sexp
   def to_ruby
     Ruby2Ruby.new.process(self) unless self.empty?
   end
+  
+  def to_ruby_string
+    return nil if self.empty?
+    eval(Ruby2Ruby.new.process(self)).to_s
+  end
 end

data/rails_best_practices.gemspec

@@ -1,11 +1,11 @@
 # Generated by jeweler
-# DO NOT EDIT THIS FILE
-# Instead, edit Jeweler::Tasks in Rakefile, and run `rake gemspec`
+# DO NOT EDIT THIS FILE DIRECTLY
+# Instead, edit Jeweler::Tasks in Rakefile, and run the gemspec command
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.2.8"
+  s.version = "0.2.9"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
@@ -116,3 +116,4 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<ruby2ruby>, [">= 0"])
   end
 end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.2.8
+  version: 0.2.9
 platform: ruby
 authors: 
 - Richard Huang