rails_best_practices 0.2.14 → 0.2.15

data/README.textile

@@ -57,6 +57,7 @@ IsolateSeedDataCheck: { }
 AlwaysAddDbIndexCheck: { }
 UseFilterCheck: { }
 MoveCodeIntoControllerCheck: { }
+MoveCodeIntoHelperCheck: { }
 </code></pre>
 
 *************************************************
@@ -100,7 +101,7 @@ h2. Progress
 * Lesson 6. View
 ## [-Move code into controller-]
 ## Move code into model
-## Move code into helper
+## [-Move code into helper-]
 ## Replace instance variable with local variable
 ## Use Form Builder
 ## Organize Helper files

data/VERSION

@@ -1 +1 @@
-0.2.14
+0.2.15

data/lib/rails_best_practices/checks.rb

@@ -17,3 +17,4 @@ require 'rails_best_practices/checks/isolate_seed_data_check'
 require 'rails_best_practices/checks/always_add_db_index_check'
 require 'rails_best_practices/checks/use_filter_check'
 require 'rails_best_practices/checks/move_code_into_controller_check'
+require 'rails_best_practices/checks/move_code_into_helper_check'

data/lib/rails_best_practices/checks/move_code_into_helper_check.rb

@@ -0,0 +1,29 @@
+require 'rails_best_practices/checks/check'
+
+module RailsBestPractices
+  module Checks
+    # Check a view file to make sure there is no complex options_for_select message call.
+    #
+    # Implementation: Check if arguments of options_for_select message call contain more than 2 method call, then move it into helper.
+    class MoveCodeIntoHelperCheck < Check
+    
+      def interesting_nodes
+        [:call]
+      end
+    
+      def interesting_files
+        VIEW_FILES
+      end
+
+      def evaluate_start(node)
+        add_error "move code into helper" if complex_select_options?(node)
+      end
+      
+      private
+      
+      def complex_select_options?(node)
+        :options_for_select == node.message and node.arguments.grep_nodes(:node_type => :call).size > 2
+      end
+    end
+  end
+end

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.2.14"
+  s.version = "0.2.15"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
@@ -35,6 +35,7 @@ Gem::Specification.new do |s|
      "lib/rails_best_practices/checks/law_of_demeter_check.rb",
      "lib/rails_best_practices/checks/many_to_many_collection_check.rb",
      "lib/rails_best_practices/checks/move_code_into_controller_check.rb",
+     "lib/rails_best_practices/checks/move_code_into_helper_check.rb",
      "lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb",
      "lib/rails_best_practices/checks/move_model_logic_into_model_check.rb",
      "lib/rails_best_practices/checks/needless_deep_nesting_check.rb",
@@ -63,6 +64,7 @@ Gem::Specification.new do |s|
      "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
      "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
      "spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb",
      "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
      "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
      "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",
@@ -91,6 +93,7 @@ Gem::Specification.new do |s|
      "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
      "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
      "spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb",
      "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
      "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
      "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",

data/rails_best_practices.yml

@@ -17,3 +17,4 @@ IsolateSeedDataCheck: { }
 AlwaysAddDbIndexCheck: { }
 UseFilterCheck: { }
 MoveCodeIntoControllerCheck: { }
+MoveCodeIntoHelperCheck: { }

data/spec/rails_best_practices/checks/isolate_seed_data_check_spec.rb

@@ -28,7 +28,6 @@ describe RailsBestPractices::Checks::IsolateSeedDataCheck do
     errors = @runner.errors
     errors.should_not be_empty
     errors[0].to_s.should == "db/migrate/20090818130258_create_roles.rb:8 - isolate seed data"
-    puts errors.inspect
     errors.size.should == 1
   end
   

data/spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb

@@ -0,0 +1,28 @@
+require File.join(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe RailsBestPractices::Checks::MoveCodeIntoHelperCheck do
+  before(:each) do
+    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveCodeIntoHelperCheck.new)
+  end
+
+  it "should move code into helper" do
+    content = <<-EOF
+    <%= select_tag :state, options_for_select( [[t(:draft), "draft"],
+                                                [t(:published), "published"]],
+                                               params[:default_state] ) %>
+    
+    EOF
+    @runner.check('app/views/posts/show.html.erb', content)
+    errors = @runner.errors
+    errors.should_not be_empty
+  end
+
+  it "should not move code into helper with simple arguments" do
+    content = <<-EOF
+    <%= select_tag :state, options_for_select( Post.STATES ) %>
+    EOF
+    @runner.check('app/views/posts/show.html.erb', content)
+    errors = @runner.errors
+    errors.should be_empty
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.2.14
+  version: 0.2.15
 platform: ruby
 authors: 
 - Richard Huang
@@ -58,6 +58,7 @@ files:
 - lib/rails_best_practices/checks/law_of_demeter_check.rb
 - lib/rails_best_practices/checks/many_to_many_collection_check.rb
 - lib/rails_best_practices/checks/move_code_into_controller_check.rb
+- lib/rails_best_practices/checks/move_code_into_helper_check.rb
 - lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb
 - lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
 - lib/rails_best_practices/checks/needless_deep_nesting_check.rb
@@ -86,6 +87,7 @@ files:
 - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
 - spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
 - spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
 - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
 - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
@@ -136,6 +138,7 @@ test_files:
 - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
 - spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
 - spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_helper_check_spec.rb
 - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
 - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb