rails_best_practices 0.2.13 → 0.2.14

data/README.textile

@@ -28,6 +28,8 @@ at the root directory of rails app
 rails_best_practices .
 </code></pre>
 
+notice the period at the end, it can be the relative or absolute path of your rails app.
+
 *************************************************
 
 h2. Customize Configuration
@@ -54,6 +56,7 @@ UseObserverCheck: { }
 IsolateSeedDataCheck: { }
 AlwaysAddDbIndexCheck: { }
 UseFilterCheck: { }
+MoveCodeIntoControllerCheck: { }
 </code></pre>
 
 *************************************************
@@ -95,7 +98,7 @@ h2. Progress
 ## DRY Controller
 
 * Lesson 6. View
-## Move code into controller
+## [-Move code into controller-]
 ## Move code into model
 ## Move code into helper
 ## Replace instance variable with local variable

data/VERSION

@@ -1 +1 @@
-0.2.13
+0.2.14

data/lib/rails_best_practices/checks/add_model_virtual_attribute_check.rb

@@ -13,7 +13,7 @@ module RailsBestPractices
       end
       
       def interesting_files
-        /_controller.rb$/
+        CONTROLLER_FILES
       end
 
       def evaluate_start(node)

data/lib/rails_best_practices/checks/always_add_db_index_check.rb

@@ -15,7 +15,7 @@ module RailsBestPractices
       end
 
       def interesting_files
-        /db\/migrate\/.*rb/
+        MIGRATION_FILES
       end
 
       def initialize

data/lib/rails_best_practices/checks/check.rb

@@ -4,6 +4,11 @@ module RailsBestPractices
   module Checks
     class Check
       NODE_TYPES = [:call, :defn, :defs, :if, :unless, :class, :lasgn]
+      
+      CONTROLLER_FILES = /_controller.rb$/
+      MIGRATION_FILES = /db\/migrate\/.*rb/
+      MODLE_FILES = /models\/.*rb/
+      VIEW_FILES = /views\/.*erb/
 
       def initialize
         @errors = []

data/lib/rails_best_practices/checks/isolate_seed_data_check.rb

@@ -12,7 +12,7 @@ module RailsBestPractices
       end
 
       def interesting_files
-        /db\/migrate\/.*rb/
+        MIGRATION_FILES
       end
 
       def initialize

data/lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb

@@ -12,7 +12,7 @@ module RailsBestPractices
       end
 
       def interesting_files
-        /models\/.*rb/
+        MODLE_FILES
       end
 
       def evaluate_start(node)

data/lib/rails_best_practices/checks/move_code_into_controller_check.rb

@@ -0,0 +1,31 @@
+require 'rails_best_practices/checks/check'
+
+module RailsBestPractices
+  module Checks
+    # Check a view file to make sure there is no finder.
+    #
+    # Implementation: Check if view file contains finder, then the code should move to controller.
+    class MoveCodeIntoControllerCheck < Check
+      
+      FINDER = [:find, :all, :first, :last]
+      
+      def interesting_nodes
+        [:call]
+      end
+      
+      def interesting_files
+        VIEW_FILES
+      end
+      
+      def evaluate_start(node)
+        add_error "move code into controller" if finder?(node)
+      end
+      
+      private
+
+      def finder?(node)
+        node.subject.node_type == :const && FINDER.include?(node.message)
+      end
+    end
+  end
+end

data/lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb

@@ -16,7 +16,7 @@ module RailsBestPractices
       end
       
       def interesting_files
-        /_controller.rb$/
+        CONTROLLER_FILES
       end
 
       def evaluate_start(node)

data/lib/rails_best_practices/checks/move_model_logic_into_model_check.rb

@@ -13,7 +13,7 @@ module RailsBestPractices
       end
       
       def interesting_files
-        /_controller.rb$/
+        CONTROLLER_FILES
       end
 
       def initialize(options = {})

data/lib/rails_best_practices/checks/replace_complex_creation_with_factory_method_check.rb

@@ -13,7 +13,7 @@ module RailsBestPractices
       end
       
       def interesting_files
-        /_controller.rb$/
+        CONTROLLER_FILES
       end
       
       def initialize(options = {})

data/lib/rails_best_practices/checks/use_filter_check.rb

@@ -12,7 +12,7 @@ module RailsBestPractices
       end
 
       def interesting_files
-        /_controller.rb$/
+        CONTROLLER_FILES
       end
 
       def evaluate_start(node)

data/lib/rails_best_practices/checks/use_observer_check.rb

@@ -14,7 +14,7 @@ module RailsBestPractices
       end
 
       def interesting_files
-        /models\/.*rb/
+        MODLE_FILES
       end
 
       def initialize

data/lib/rails_best_practices/checks/use_scope_access_check.rb

@@ -12,7 +12,7 @@ module RailsBestPractices
       end
       
       def interesting_files
-        /_controller.rb$/
+        CONTROLLER_FILES
       end
       
       def evaluate_start(node)

data/lib/rails_best_practices/checks.rb

@@ -16,3 +16,4 @@ require 'rails_best_practices/checks/use_observer_check'
 require 'rails_best_practices/checks/isolate_seed_data_check'
 require 'rails_best_practices/checks/always_add_db_index_check'
 require 'rails_best_practices/checks/use_filter_check'
+require 'rails_best_practices/checks/move_code_into_controller_check'

data/rails_best_practices.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rails_best_practices}
-  s.version = "0.2.13"
+  s.version = "0.2.14"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Richard Huang"]
@@ -34,6 +34,7 @@ Gem::Specification.new do |s|
      "lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb",
      "lib/rails_best_practices/checks/law_of_demeter_check.rb",
      "lib/rails_best_practices/checks/many_to_many_collection_check.rb",
+     "lib/rails_best_practices/checks/move_code_into_controller_check.rb",
      "lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb",
      "lib/rails_best_practices/checks/move_model_logic_into_model_check.rb",
      "lib/rails_best_practices/checks/needless_deep_nesting_check.rb",
@@ -61,6 +62,7 @@ Gem::Specification.new do |s|
      "spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb",
      "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
      "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb",
      "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
      "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
      "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",
@@ -88,6 +90,7 @@ Gem::Specification.new do |s|
      "spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb",
      "spec/rails_best_practices/checks/law_of_demeter_check_spec.rb",
      "spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb",
+     "spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb",
      "spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb",
      "spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb",
      "spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb",

data/rails_best_practices.yml

@@ -16,3 +16,4 @@ UseObserverCheck: { }
 IsolateSeedDataCheck: { }
 AlwaysAddDbIndexCheck: { }
 UseFilterCheck: { }
+MoveCodeIntoControllerCheck: { }

data/spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb

@@ -0,0 +1,33 @@
+require File.join(File.dirname(__FILE__) + '/../../spec_helper')
+
+describe RailsBestPractices::Checks::MoveCodeIntoControllerCheck do
+  before(:each) do
+    @runner = RailsBestPractices::Core::Runner.new(RailsBestPractices::Checks::MoveCodeIntoControllerCheck.new)
+  end
+  
+  it "should move code into controller" do
+    content = <<-EOF
+    <% @posts = Post.find(:all) %>
+    <% @posts.each do |post| %>
+      <%=h post.title %>
+      <%=h post.content %>
+    <% end %>
+    EOF
+    @runner.check('app/views/posts/index.html.erb', content)
+    errors = @runner.errors
+    errors.should_not be_empty
+    errors[0].to_s.should == "app/views/posts/index.html.erb:1 - move code into controller"
+  end
+
+  it "should not move code into controller" do
+    content = <<-EOF
+    <% @posts.each do |post| %>
+      <%=h post.title %>
+      <%=h post.content %>
+    <% end %>
+    EOF
+    @runner.check('app/views/posts/index.html.erb', content)
+    errors = @runner.errors
+    errors.should be_empty
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rails_best_practices
 version: !ruby/object:Gem::Version 
-  version: 0.2.13
+  version: 0.2.14
 platform: ruby
 authors: 
 - Richard Huang
@@ -57,6 +57,7 @@ files:
 - lib/rails_best_practices/checks/keep_finders_on_their_own_model_check.rb
 - lib/rails_best_practices/checks/law_of_demeter_check.rb
 - lib/rails_best_practices/checks/many_to_many_collection_check.rb
+- lib/rails_best_practices/checks/move_code_into_controller_check.rb
 - lib/rails_best_practices/checks/move_finder_to_named_scope_check.rb
 - lib/rails_best_practices/checks/move_model_logic_into_model_check.rb
 - lib/rails_best_practices/checks/needless_deep_nesting_check.rb
@@ -84,6 +85,7 @@ files:
 - spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
 - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
 - spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
 - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
 - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb
@@ -133,6 +135,7 @@ test_files:
 - spec/rails_best_practices/checks/keep_finders_on_their_own_model_check_spec.rb
 - spec/rails_best_practices/checks/law_of_demeter_check_spec.rb
 - spec/rails_best_practices/checks/many_to_many_collection_check_spec.rb
+- spec/rails_best_practices/checks/move_code_into_controller_check_spec.rb
 - spec/rails_best_practices/checks/move_finder_to_named_scope_check_spec.rb
 - spec/rails_best_practices/checks/move_model_logic_into_model_check_spec.rb
 - spec/rails_best_practices/checks/needless_deep_nesting_check_spec.rb