rails_amp 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 41090d7cbfa0a001a9e1648ae23cd8597f10f571
-  data.tar.gz: 93b900a423f87244c74ac738b4cff363638858c8
+  metadata.gz: 0ad444c3a645c549cba96965c0ab6c46c93e80a4
+  data.tar.gz: 87e3891260c56b7034b8918815ec99e792a53efe
 SHA512:
-  metadata.gz: 42eeb0062a86bb316413c3fd9ab6ecef11ca34ba6d7f21fe4b47bfe6932f4db24dfa13ecfd3726f732ec4b3d05270ca4314675aede6fb529dc758037d2afeced
-  data.tar.gz: c08fe3e59be882193b4e9f6ba6b3be994aeb54607e34173dff1248294ca5a7f0e390348a0750c57e3813160b0a58d8cb1d2cced47a9318c4ac833e84949c0c3c
+  metadata.gz: 36f2877b2a096be0eb2a5cc83f7eaf1c77e90c8efa6a711f516df2f0a578f9e84bbe1bcffaa53e835e0ab9762749a1eaf715280a2396261bb7b4354f4c52a59e
+  data.tar.gz: 28f6848404a59db9e7f6fcdc8798bdcb7652b935b7430798a52743bf2531352a53aa01bf44a158e320aeabb813010d632b8985f0e9f39f2d8b8af25e5b11e8aa

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+sudo: false
+rvm:
+  - 2.3.1
+  - 2.2.3
+gemfile:
+  - Gemfile
+  - gemfiles/Gemfile-rails.4.2.x
+  - gemfiles/Gemfile-rails.4.1.x
+script:
+  - bundle exec rspec spec
+notifications:
+  email: false

data/README.md

@@ -1,4 +1,4 @@
-# RailsAmp
+# RailsAmp [![Build Status](https://travis-ci.org/takafumir/rails_amp.svg?branch=master)](https://travis-ci.org/takafumir/rails_amp)
 
 RailsAmp is a Ruby on Rails plugin that makes it easy to build views for AMP(Accelerated Mobile Pages).
 

data/gemfiles/Gemfile-rails.4.1.x

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 
-gem 'rails', '~> 4.1.0'
 gemspec path: '../'
+gem 'rails', '~> 4.1.0'

data/gemfiles/Gemfile-rails.4.2.x

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 
-gem 'rails', '~> 4.2.0'
 gemspec path: '../'
+gem 'rails', '~> 4.2.0'

data/lib/rails_amp/config.rb

@@ -1,3 +1,5 @@
+require 'yaml'
+
 module RailsAmp
   class Config
     # Return the current format, default is ''. The only configuration value that is not global.

data/lib/rails_amp/version.rb

@@ -1,3 +1,3 @@
 module RailsAmp
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/spec/controllers/application_controller_spec.rb

@@ -62,14 +62,14 @@ describe UsersController do
       it 'has normal image tag' do
         get 'index'
         expect(image_tag('rails.png', {size: '30x20', border: '0'})).to match(
-          %r(<img border="0" src="/(images|assets)/rails-?\w*?.jpg" alt="Rails" width="30" height="20" />)
+          %r{(<img border="0" src="/(images|assets)/rails-?\w*?.png" alt="Rails" width="30" height="20" />)|(<img alt="Rails" border="0" height="20" src="/(images|assets)/rails-?\w*?.png" width="30" />)}
         )
         expect(image_tag('rails.png')).to match(
-          %r(<img src="/(images|assets)/rails-?\w*?.jpg" alt="Rails" />)
+          %r{(<img src="/(images|assets)/rails-?\w*?.png" alt="Rails" />)|(<img alt="Rails" src="/(images|assets)/rails-?\w*?.png" />)}
         )
         # According to dummy app default view `home/_amp_info`
         expect(response.body).to match(
-          %r(<img border="0" src="/(images|assets)/rails-?\w*?.jpg" alt="Rails" width="30" height="20" />)
+          %r{(<img border="0" src="/(images|assets)/rails-?\w*?.png" alt="Rails" width="30" height="20" />)|(<img alt="Rails" border="0" height="20" src="/(images|assets)/rails-?\w*?.png" width="30" />)}
         )
       end
     end
@@ -83,37 +83,18 @@ describe UsersController do
       it 'has amp-img tag' do
         get 'index', format: RailsAmp.default_format.to_s
         expect(image_tag('rails.png', {size: '30x20', border: '0'})).to match(
-          %r(<amp-img src="/(images|assets)/rails-?\w*?.jpg" alt="Rails" layout="fixed" width="30" height="20" /></amp-img>)
+          %r{(<amp-img src="/(images|assets)/rails-?\w*?.png" alt="Rails" width="30" height="20" layout="fixed" /></amp-img>)|(<amp-img alt="Rails" height="20" layout="fixed" src="/(images|assets)/rails-?\w*?.png" width="30" /></amp-img>)}
         )
-        # `width="400" height="400"` is removed because request.base_url returns dummy url for test.
         expect(image_tag('rails.png')).to match(
-          %r(<amp-img src="/(images|assets)/rails-?\w*?.jpg" alt="Rails" layout="fixed" /></amp-img>)
+          %r{(<amp-img src="/(images|assets)/rails-?\w*?.png" alt="Rails" width="50" height="64" layout="fixed" /></amp-img>)|(<amp-img alt="Rails" height="64" layout="fixed" src="/(images|assets)/rails-?\w*?.png" width="50" /></amp-img>)}
         )
         # According to dummy app default view `home/_amp_info`
         expect(response.body).to match(
-          %r(<amp-img src="/(images|assets)/rails-?\w*?.jpg" alt="Rails" layout="fixed" width="30" height="20" /></amp-img>)
+          %r{(<amp-img src="/(images|assets)/rails-?\w*?.png" alt="Rails" width="30" height="20" layout="fixed" /></amp-img>)|(<amp-img alt="Rails" height="20" layout="fixed" src="/(images|assets)/rails-?\w*?.png" width="30" /></amp-img>)}
         )
       end
     end
   end
-
-  context '#show GET' do
-    let(:user) { User.create(name: 'Taro', email: 'taro@example.com') }
-
-    context 'with html format' do
-      it 'is not renderable by amp' do
-        get 'show', params: {id: user.id}
-        expect(amp_renderable?).to eq false
-      end
-    end
-
-    context 'with amp format' do
-      it 'is renderable by amp' do
-        get 'show', format: RailsAmp.default_format.to_s, params: {id: user.id}
-        expect(amp_renderable?).to eq true
-      end
-    end
-  end
 end
 
 describe HomeController do
@@ -135,7 +116,7 @@ describe HomeController do
       it 'is not renderable by amp' do
         expect do
           get 'help', format: RailsAmp.default_format.to_s
-        end.to raise_error(ActionController::UnknownFormat)
+        end.to raise_error(StandardError)  # ActionView::MissingTemplate or ActionController::UnknownFormat
       end
     end
   end

data/spec/dummy/app/assets/javascripts/cable.js

@@ -1,7 +1,6 @@
 // Action Cable provides the framework to deal with WebSockets in Rails.
 // You can generate new channels where WebSocket features live using the rails generate channel command.
 //
-//= require action_cable
 //= require_self
 //= require_tree ./channels
 

data/spec/dummy/app/controllers/users_controller.rb

@@ -1,11 +1,9 @@
 # Just for test.
 class UsersController < ApplicationController
   def index
-    @users = User.all
   end
 
   def show
-    @user = User.find(params[:id])
   end
 
   def new

data/spec/dummy/app/views/users/index.html.erb

@@ -1,11 +1,5 @@
 <%# Just for test. %>
 <h1>Users List</h1>
-<% @users.each do |user| %>
-  <p>id: <%= user.id %></p>
-  <p>name: <%= user.name %></p>
-  <p>email: <%= user.email %></p>
-  <hr />
-<% end %>
 
 <%# Just for test. %>
 <%= render 'home/amp_info' %>

data/spec/dummy/app/views/users/show.html.erb

@@ -1,7 +1,4 @@
 <%# Just for test. %>
 <h1>User Profile</h1>
-<p>id: <%= @user.id %></p>
-<p>name: <%= @user.name %></p>
-<p>email: <%= @user.email %></p>
 
 <%= render 'home/amp_info' %>

data/spec/dummy/config/application.rb

@@ -5,8 +5,8 @@ require "active_record/railtie"
 require "action_controller/railtie"
 require "action_view/railtie"
 require "action_mailer/railtie"
-require "active_job/railtie"
-require "action_cable/engine"
+# require "active_job/railtie"
+# require "action_cable/engine"
 # require "rails/test_unit/railtie"
 require "sprockets/railtie"
 

data/spec/dummy/config/environments/test.rb

@@ -13,10 +13,10 @@ Rails.application.configure do
   config.eager_load = false
 
   # Configure public file server for tests with Cache-Control for performance.
-  config.public_file_server.enabled = true
-  config.public_file_server.headers = {
-    'Cache-Control' => 'public, max-age=3600'
-  }
+  # config.public_file_server.enabled = true
+  # config.public_file_server.headers = {
+  #   'Cache-Control' => 'public, max-age=3600'
+  # }
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
@@ -27,7 +27,7 @@ Rails.application.configure do
 
   # Disable request forgery protection in test environment.
   config.action_controller.allow_forgery_protection = false
-  config.action_mailer.perform_caching = false
+  # config.action_mailer.perform_caching = false
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the

data/spec/dummy/config/initializers/new_framework_defaults.rb

@@ -5,20 +5,20 @@
 # Read the Guide for Upgrading Ruby on Rails for more info on each option.
 
 # Enable per-form CSRF tokens. Previous versions had false.
-Rails.application.config.action_controller.per_form_csrf_tokens = true
+# Rails.application.config.action_controller.per_form_csrf_tokens = true
 
 # Enable origin-checking CSRF mitigation. Previous versions had false.
-Rails.application.config.action_controller.forgery_protection_origin_check = true
+# Rails.application.config.action_controller.forgery_protection_origin_check = true
 
 # Make Ruby 2.4 preserve the timezone of the receiver when calling `to_time`.
 # Previous versions had false.
-ActiveSupport.to_time_preserves_timezone = true
+# ActiveSupport.to_time_preserves_timezone = true
 
 # Require `belongs_to` associations by default. Previous versions had false.
-Rails.application.config.active_record.belongs_to_required_by_default = true
+# Rails.application.config.active_record.belongs_to_required_by_default = true
 
 # Do not halt callback chains when a callback returns false. Previous versions had true.
-ActiveSupport.halt_callback_chains_on_return_false = false
+# ActiveSupport.halt_callback_chains_on_return_false = false
 
 # Configure SSL options to enable HSTS with subdomains. Previous versions had false.
-Rails.application.config.ssl_options = { hsts: { subdomains: true } }
+# Rails.application.config.ssl_options = { hsts: { subdomains: true } }

data/spec/dummy/config/initializers/wrap_parameters.rb

@@ -5,7 +5,7 @@
 
 # Enable parameter wrapping for JSON. You can disable this by setting :format to an empty array.
 ActiveSupport.on_load(:action_controller) do
-  wrap_parameters format: [:json]
+  wrap_parameters format: [:json] if respond_to?(:wrap_parameters)
 end
 
 # To enable root element in JSON for ActiveRecord objects.

data/spec/dummy/db/migrate/20170130074559_create_users.rb

@@ -1,4 +1,4 @@
-class CreateUsers < ActiveRecord::Migration[5.0]
+class CreateUsers < ActiveRecord::Migration
   def change
     create_table :users do |t|
       t.string :name

data/spec/dummy/db/schema.rb

@@ -15,8 +15,8 @@ ActiveRecord::Schema.define(version: 20170130074559) do
   create_table "users", force: :cascade do |t|
     t.string   "name"
     t.string   "email"
-    t.datetime "created_at", null: false
-    t.datetime "updated_at", null: false
+    t.datetime "created_at"
+    t.datetime "updated_at"
   end
 
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails_amp
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Takafumi Yamano
@@ -75,6 +75,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
 - Gemfile
 - MIT-LICENSE
 - README.md