rails3-jquery-autocomplete 1.0.11 → 1.0.12

data/README.md

@@ -1,3 +1,47 @@
+## Status
+
+As you may have noticed we are working through the backlog of issues and pull requests
+and trying to get those caught up.  Couple of quick notes related to this.
+
+1. A new gem with Rails 4 will be forthcoming so users on Rails 4 don't need to point to master.
+2. If there is a specific feature that is in master, but not in the gem I strongly suggest you
+   point to the specific changeset that addresses your issue rather than directly at master. There
+   are going to be a lot of changes going on here and while we will do our best; there will probably
+   be some breakage on master in the short term.  Use at your discretion!
+3. Some pull requests have been submitted to address the same functionality; in those cases we will try
+   to pick the best/optimal solution, accept that and close out the other tickets.
+4. Backwards compatibility is considered a high priority, so if a pull request is a great idea,
+   but it breaks backwards compatibility, it will be closed and noted that it causes breakage 
+   to backwards compatibility.  If anyone passionately wants the feature they are welcome to update 
+   in a way that maintiains backwards compatibility and issue new pull reqs.
+5. Performance is critical.  If a feature is a nice to have, but has been implemented in such a way that it causes
+   performance degradation to existing searches; it will be rejected.
+6. Thanks to everyone who is submitting pull requests, issues, comments, etc... I appreciate the help
+   from each one of you.  Sometimes it has to get worse before it gets better.  But I promise,
+   it will get better!
+
+-------
+
+Thanks to David @ crowdint for creating this gem and all of his hard
+work on it in the past.
+
+Just posting this update to let everyone know this project is still
+alive and has a new maintainer.  Over the next couple of weeks we will
+be reviewing existing pull requests and you will see updates shortly.
+
+Thanks for your patience.
+
+joiey-seeley@uiowa.edu
+
+-------
+
+Unfortunately, I don't have much time to work on this gem, I'm looking for
+someone to help with its maintenance. Send me an email if you are interested in
+getting push privileges to this repo.
+
+david@crowdint.com
+
+
 # rails3-jquery-autocomplete
 
 [![Build Status](https://secure.travis-ci.org/crowdint/rails3-jquery-autocomplete.png)](http://travis-ci.org/crowdint/rails3-jquery-autocomplete)
@@ -67,7 +111,7 @@ uncompressed version by running:
 
     rails generate autocomplete:uncompressed
 
-### Rails 3.1.x
+### Rails 3.1.x and higher
 
 Just add it to your app/assets/javascripts/application.js file
 
@@ -202,7 +246,7 @@ If you are not using a FormBuilder (form_for) or you just want to include an aut
 To generate an autocomplete input field that accepts multiple values separated by a given delimiter, add the `'data-delimiter'` and `:multiple` options:
 
     form_for @product do |f|
-      f.autocomplete_field :brand_names, autocomplete_brand_name_products_path, 
+      f.autocomplete_field :brand_names, autocomplete_brand_name_products_path,
       'data-delimiter' => ',', :multiple => true
     end
 
@@ -339,7 +383,7 @@ while you're developing, it is recommended that you run
 
     bundle exec guard
 
-to have the relevent test run every time you save a file.
+to have the relevant test run every time you save a file.
 
 ## Integration tests
 
@@ -357,7 +401,7 @@ integration folder:
 
 ## Where to test what
 
-If you're making or tweaking a plugin (such as the formastic plugin or
+If you're making or tweaking a plugin (such as the formtastic plugin or
 simple\_form plugin), check out the simple\_form\_plugin\_test for an
 example of how to test it as part of the main `rake test` run.
 Historically, plugins like these had been tested (shoddily) as part of

data/lib/assets/javascripts/autocomplete-rails-uncompressed.js

@@ -24,7 +24,7 @@
       }
     };
     if (jQuery.fn.on !== undefined) {
-      return $(document).on('focus',this.selector,handler);
+      return jQuery(document).on('focus',this.selector,handler);
     }
     else {
       return this.live('focus',handler);
@@ -73,14 +73,17 @@
         	  	return;
         	  }
             jQuery(jQuery(this).attr('data-id-element')).val(ui.item ? ui.item.id : "");
-            var update_elements = jQuery.parseJSON(jQuery(this).attr("data-update-elements"));
-            var data = ui.item ? jQuery(this).data(ui.item.id.toString()) : {};
-            if(update_elements && jQuery(update_elements['id']).val() == "") { 
-            	return; 
+            
+            if (jQuery(this).attr('data-update-elements')) {
+                var update_elements = jQuery.parseJSON(jQuery(this).attr("data-update-elements"));
+                var data = ui.item ? jQuery(this).data(ui.item.id.toString()) : {};
+                if(update_elements && jQuery(update_elements['id']).val() == "") {
+                	return;
+                }
+                for (var key in update_elements) {
+                    jQuery(update_elements[key]).val(ui.item ? data[key] : "");
+                }
             }
-            for (var key in update_elements) {
-                jQuery(update_elements[key]).val(ui.item ? data[key] : "");
-            }  
         },
         search: function() {
           // custom minLength
@@ -118,7 +121,7 @@
           }
           var remember_string = this.value;
           jQuery(this).bind('keyup.clearId', function(){
-            if(jQuery(this).val().trim() != remember_string.trim()){
+            if(jQuery.trim(jQuery(this).val()) != jQuery.trim(remember_string)){
               jQuery(jQuery(this).attr('data-id-element')).val("");
               jQuery(this).unbind('keyup.clearId');
             }

data/lib/assets/javascripts/autocomplete-rails.js

@@ -1,16 +1 @@
-/*
-* Unobtrusive autocomplete
-*
-* To use it, you just have to include the HTML attribute autocomplete
-* with the autocomplete URL as the value
-*
-*   Example:
-*       <input type="text" data-autocomplete="/url/to/autocomplete">
-*
-* Optionally, you can use a jQuery selector to specify a field that can
-* be updated with the element id whenever you find a matching value
-*
-*   Example:
-*       <input type="text" data-autocomplete="/url/to/autocomplete" data-id-element="#id_field">
-*/
-(function(e){var t=null;e.fn.railsAutocomplete=function(){var t=function(){this.railsAutoCompleter||(this.railsAutoCompleter=new e.railsAutocomplete(this))};return e.fn.on!==undefined?$(document).on("focus",this.selector,t):this.live("focus",t)},e.railsAutocomplete=function(e){_e=e,this.init(_e)},e.railsAutocomplete.fn=e.railsAutocomplete.prototype={railsAutocomplete:"0.0.1"},e.railsAutocomplete.fn.extend=e.railsAutocomplete.extend=e.extend,e.railsAutocomplete.fn.extend({init:function(t){function n(e){return e.split(t.delimiter)}function r(e){return n(e).pop().replace(/^\s+/,"")}t.delimiter=e(t).attr("data-delimiter")||null,e(t).autocomplete({source:function(n,i){e.getJSON(e(t).attr("data-autocomplete"),{term:r(n.term)},function(){arguments[0].length==0&&(arguments[0]=[],arguments[0][0]={id:"",label:"no existing match"}),e(arguments[0]).each(function(n,r){var i={};i[r.id]=r,e(t).data(i)}),i.apply(null,arguments)})},change:function(t,n){if(e(e(this).attr("data-id-element")).val()=="")return;e(e(this).attr("data-id-element")).val(n.item?n.item.id:"");var r=e.parseJSON(e(this).attr("data-update-elements")),i=n.item?e(this).data(n.item.id.toString()):{};if(r&&e(r["id"]).val()=="")return;for(var s in r)e(r[s]).val(n.item?i[s]:"")},search:function(){var e=r(this.value);if(e.length<2)return!1},focus:function(){return!1},select:function(r,i){var s=n(this.value);s.pop(),s.push(i.item.value);if(t.delimiter!=null)s.push(""),this.value=s.join(t.delimiter);else{this.value=s.join(""),e(this).attr("data-id-element")&&e(e(this).attr("data-id-element")).val(i.item.id);if(e(this).attr("data-update-elements")){var o=e(this).data(i.item.id.toString()),u=e.parseJSON(e(this).attr("data-update-elements"));for(var a in u)e(u[a]).val(o[a])}}var f=this.value;return e(this).bind("keyup.clearId",function(){e(this).val().trim()!=f.trim()&&(e(e(this).attr("data-id-element")).val(""),e(this).unbind("keyup.clearId"))}),e(t).trigger("railsAutocomplete.select",i),!1}})}}),e(document).ready(function(){e("input[data-autocomplete]").railsAutocomplete()})})(jQuery);
+(function(jQuery){var self=null;jQuery.fn.railsAutocomplete=function(){var handler=function(){if(!this.railsAutoCompleter){this.railsAutoCompleter=new jQuery.railsAutocomplete(this)}};if(jQuery.fn.on!==undefined){return jQuery(document).on("focus",this.selector,handler)}else{return this.live("focus",handler)}};jQuery.railsAutocomplete=function(e){_e=e;this.init(_e)};jQuery.railsAutocomplete.fn=jQuery.railsAutocomplete.prototype={railsAutocomplete:"0.0.1"};jQuery.railsAutocomplete.fn.extend=jQuery.railsAutocomplete.extend=jQuery.extend;jQuery.railsAutocomplete.fn.extend({init:function(e){e.delimiter=jQuery(e).attr("data-delimiter")||null;function split(val){return val.split(e.delimiter)}function extractLast(term){return split(term).pop().replace(/^\s+/,"")}jQuery(e).autocomplete({source:function(request,response){jQuery.getJSON(jQuery(e).attr("data-autocomplete"),{term:extractLast(request.term)},function(){if(arguments[0].length==0){arguments[0]=[];arguments[0][0]={id:"",label:"no existing match"}}jQuery(arguments[0]).each(function(i,el){var obj={};obj[el.id]=el;jQuery(e).data(obj)});response.apply(null,arguments)})},change:function(event,ui){if(jQuery(jQuery(this).attr("data-id-element")).val()==""){return}jQuery(jQuery(this).attr("data-id-element")).val(ui.item?ui.item.id:"");if(jQuery(this).attr("data-update-elements")){var update_elements=jQuery.parseJSON(jQuery(this).attr("data-update-elements"));var data=ui.item?jQuery(this).data(ui.item.id.toString()):{};if(update_elements&&jQuery(update_elements["id"]).val()==""){return}for(var key in update_elements){jQuery(update_elements[key]).val(ui.item?data[key]:"")}}},search:function(){var term=extractLast(this.value);if(term.length<2){return false}},focus:function(){return false},select:function(event,ui){var terms=split(this.value);terms.pop();terms.push(ui.item.value);if(e.delimiter!=null){terms.push("");this.value=terms.join(e.delimiter)}else{this.value=terms.join("");if(jQuery(this).attr("data-id-element")){jQuery(jQuery(this).attr("data-id-element")).val(ui.item.id)}if(jQuery(this).attr("data-update-elements")){var data=jQuery(this).data(ui.item.id.toString());var update_elements=jQuery.parseJSON(jQuery(this).attr("data-update-elements"));for(var key in update_elements){jQuery(update_elements[key]).val(data[key])}}}var remember_string=this.value;jQuery(this).bind("keyup.clearId",function(){if(jQuery.trim(jQuery(this).val())!=jQuery.trim(remember_string)){jQuery(jQuery(this).attr("data-id-element")).val("");jQuery(this).unbind("keyup.clearId")}});jQuery(e).trigger("railsAutocomplete.select",ui);return false}})}});jQuery(document).ready(function(){jQuery("input[data-autocomplete]").railsAutocomplete()})})(jQuery);

data/lib/rails3-jquery-autocomplete/version.rb

@@ -1,3 +1,3 @@
 module Rails3JQueryAutocomplete
-  VERSION = '1.0.11'
+  VERSION = '1.0.12'
 end

data/test/test_helper.rb

@@ -31,6 +31,6 @@ end
 ActionController::Base.send :include, Rails3JQueryAutocomplete::Application.routes.url_helpers
 
 class Test::Unit::TestCase
-  include RR::Adapters::TestUnit
+
 end
 

metadata

@@ -1,230 +1,171 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: rails3-jquery-autocomplete
-version: !ruby/object:Gem::Version
-  version: 1.0.11
+version: !ruby/object:Gem::Version 
   prerelease: 
+  version: 1.0.12
 platform: ruby
-authors:
+authors: 
 - David Padilla
+- Joiey Seeley
+- Manu S Ajith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-20 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2013-12-13 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rails
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :runtime
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '3.0'
-- !ruby/object:Gem::Dependency
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "3.0"
+  type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
   name: sqlite3-ruby
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: mongoid
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: 2.0.0
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
+  version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: mongoid
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
         version: 2.0.0
-- !ruby/object:Gem::Dependency
-  name: mongo_mapper
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0.9'
   type: :development
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: mongo_mapper
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: mongo
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.6.2
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0.9"
   type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: mongo
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: 1.6.2
-- !ruby/object:Gem::Dependency
-  name: bson_ext
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
         version: 1.6.2
   type: :development
+  version_requirements: *id005
+- !ruby/object:Gem::Dependency 
+  name: bson_ext
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
         version: 1.6.2
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: guard
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-test
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
+  version_requirements: *id007
+- !ruby/object:Gem::Dependency 
+  name: guard-test
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: test-unit
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 2.2.0
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
+  version_requirements: *id008
+- !ruby/object:Gem::Dependency 
+  name: test-unit
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
         version: 2.2.0
-- !ruby/object:Gem::Dependency
-  name: shoulda
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 3.0.1
   type: :development
+  version_requirements: *id009
+- !ruby/object:Gem::Dependency 
+  name: shoulda
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id010 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
+      - !ruby/object:Gem::Version 
         version: 3.0.1
-- !ruby/object:Gem::Dependency
-  name: uglifier
-  requirement: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   type: :development
+  version_requirements: *id010
+- !ruby/object:Gem::Dependency 
+  name: uglifier
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rr
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id011 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
+  version_requirements: *id011
+- !ruby/object:Gem::Dependency 
+  name: rr
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simple_form
-  requirement: !ruby/object:Gem::Requirement
+  requirement: &id012 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.5'
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
+  version_requirements: *id012
+- !ruby/object:Gem::Dependency 
+  name: simple_form
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
+  requirement: &id013 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.5'
+      - !ruby/object:Gem::Version 
+        version: "1.5"
+  type: :development
+  version_requirements: *id013
 description: Use jQuery's autocomplete plugin with Rails 3.
-email: david.padilla@crowdint.com
+email: david.padilla@crowdint.com joiey.seeley@gmail.com neo@codingarena.in
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - lib/assets/javascripts/autocomplete-rails-uncompressed.js
 - lib/assets/javascripts/autocomplete-rails.js
 - lib/cucumber/autocomplete.rb
@@ -259,36 +200,33 @@ files:
 - test/test_helper.rb
 - test/view_test_helper.rb
 homepage: http://github.com/crowdint/rails3-jquery-autocomplete
-licenses: []
+licenses: 
+- MIT
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: 3645478103120310427
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-      segments:
-      - 0
-      hash: 3645478103120310427
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 1.8.5
 signing_key: 
 specification_version: 3
 summary: Use jQuery's autocomplete plugin with Rails 3.
-test_files:
+test_files: 
 - test/form_helper_test.rb
 - test/generators/autocomplete/install_generator_test.rb
 - test/generators/autocomplete/uncompressed_generator_test.rb
@@ -300,3 +238,4 @@ test_files:
 - test/lib/rails3-jquery-autocomplete_test.rb
 - test/test_helper.rb
 - test/view_test_helper.rb
+has_rdoc: