rails3-jquery-autocomplete 0.3.4 → 0.3.5

data/README.markdown

@@ -151,7 +151,7 @@ I have created a step to test your autocomplete with Cucumber and Capybara, all
     
 Then you'll have access to the following step:
 
-    And I choose "Alpha" in the autocomplete list
+    I choose "([^"]*)" in the autocomplete list
 
 An example on how to use it:
 

data/lib/rails3-jquery-autocomplete.rb

@@ -31,7 +31,7 @@ module Rails3JQueryAutocomplete
       order = options[:order] || "#{method} ASC"
 
       define_method("autocomplete_#{object}_#{method}") do
-        unless params[:term] && params[:term].empty?
+        if params[:term] && !params[:term].empty?
           items = object.to_s.camelize.constantize.where(["LOWER(#{method}) LIKE ?", "#{(options[:full] ? '%' : '')}#{params[:term].downcase}%"]).limit(limit).order(order)
         else
           items = {}

data/test/autocomplete_generator_test.rb

@@ -19,4 +19,4 @@ class AutocompleteGeneratorTest < Test::Unit::TestCase
       File.read(File.join(@destination, 'public', 'javascripts', 'autocomplete-rails.js'))
     )
   end
-end
+end

data/test/controller_module_test.rb

@@ -36,6 +36,8 @@ def teardown_db
 end
 
 class ActorsControllerTest < ActionController::TestCase
+  require 'shoulda'
+  require 'redgreen'
   def setup
     setup_db
 
@@ -48,90 +50,89 @@ class ActorsControllerTest < ActionController::TestCase
     teardown_db
   end
 
-  def test_response_succesful
-    get :autocomplete_movie_name, :term => 'Al'
-    assert_response :success
-  end
-
-  def test_response_json
-    @movie = Movie.create(:name => 'Alpha')
-
-    get :autocomplete_movie_name, :term => 'Al'
-    json_response = JSON.parse(@response.body)
-    assert_equal(json_response.first["label"], @movie.name)
-    assert_equal(json_response.first["value"], @movie.name)
-    assert_equal(json_response.first["id"], @movie.id)
-  end
+  context "the autocomplete gem" do
+    setup do
+      @movie  = Movie.create(:name => 'Alpha')
+      @movie2 = Movie.create(:name => 'Alspha')
+      @movie3 = Movie.create(:name => 'Alzpha')
+    end
 
-  def test_alphabetic_order
-    @movie = Movie.create(:name => 'Alzpha')
-    @movie = Movie.create(:name => 'Alspha')
-    @movie = Movie.create(:name => 'Alpha')
+    should "be able to access the autocomplete action regardless of the quality of param[:term]" do
+      get :autocomplete_movie_name
+      assert_response :success
 
-    get :autocomplete_movie_name, :term => 'Al'
-    json_response = JSON.parse(@response.body)
-    assert_equal(json_response.first["label"], "Alpha")
-    assert_equal(json_response.last["label"], "Alzpha")
-  end
+      get :autocomplete_movie_name, :term => ''
+      assert_response :success
 
-  def test_alternative_sort_order
-    @movie = Movie.create(:name => 'Alzpha')
-    @movie = Movie.create(:name => 'Alspha')
-    @movie = Movie.create(:name => 'Alpha')
+      get :autocomplete_movie_name, :term => nil
+      assert_response :success
 
-    ActorsController.send(:autocomplete, :movie, :name, {:order => "name DESC"})
+      get :autocomplete_movie_name, :term => 'Al'
+      assert_response :success
+    end
 
-    get :autocomplete_movie_name, :term => 'Al'
-    json_response = JSON.parse(@response.body)
-    assert_equal(json_response.first["label"], "Alzpha")
-    assert_equal(json_response.last["label"], "Alpha")
-  end
+    should "respond with expected json" do
+      get :autocomplete_movie_name, :term => 'Al'
+      json_response = JSON.parse(@response.body)
+      assert_equal(json_response.first["label"], @movie.name)
+      assert_equal(json_response.first["value"], @movie.name)
+      assert_equal(json_response.first["id"], @movie.id)
+    end
 
-  def test_response_limit
-    @movie = Movie.create(:name => 'Alzpha')
-    @movie = Movie.create(:name => 'Alspha')
-    @movie = Movie.create(:name => 'Alpha')
+    should "return results in alphabetical order by default" do
+      get :autocomplete_movie_name, :term => 'Al'
+      json_response = JSON.parse(@response.body)
+      assert_equal(json_response.first["label"], "Alpha")
+      assert_equal(json_response.last["label"], "Alzpha")
+    end
 
-    ActorsController.send(:autocomplete, :movie, :name, {:limit => 1})
+    should "be able to sort in other ways if desired" do
+      ActorsController.send(:autocomplete, :movie, :name, {:order => "name DESC"})
 
-    get :autocomplete_movie_name, :term => 'Al'
-    json_response = JSON.parse(@response.body)
-    assert_equal(json_response.length, 1)
-  end
+      get :autocomplete_movie_name, :term => 'Al'
+      json_response = JSON.parse(@response.body)
+      assert_equal(json_response.first["label"], "Alzpha")
+      assert_equal(json_response.last["label"], "Alpha")
+    end
 
-  def test_downcase
-    @movie = Movie.create(:name => 'aLpHa')
+    should "be able to limit the results" do
+      ActorsController.send(:autocomplete, :movie, :name, {:limit => 1})
 
-    ActorsController.send(:autocomplete, :movie, :name)
+      get :autocomplete_movie_name, :term => 'Al'
+      json_response = JSON.parse(@response.body)
+      assert_equal(json_response.length, 1)
+    end
 
-    get :autocomplete_movie_name, :term => 'Al'
-    json_response = JSON.parse(@response.body)
-    assert_equal(json_response.length, 1)
-    assert_equal(json_response.first["label"], 'aLpHa')
-  end
+    should "ignore case of search term and results" do
+      @movie = Movie.create(:name => 'aLpHa')
 
-  def test_full_search
-    @movie = Movie.create(:name => 'aLpHa')
+      ActorsController.send(:autocomplete, :movie, :name)
 
-    ActorsController.send(:autocomplete, :movie, :name, {:full => true})
+      get :autocomplete_movie_name, :term => 'Al'
+      json_response = JSON.parse(@response.body)
+      assert_equal(json_response.length, Movie.count)
+      assert_equal(json_response.last["label"], 'aLpHa')
+    end
 
-    get :autocomplete_movie_name, :term => 'ph'
-    json_response = JSON.parse(@response.body)
-    assert_equal(json_response.length, 1)
-    assert_equal(json_response.first["label"], 'aLpHa')
-  end
+    should "match term to letters in middle of words when full-text search is on" do
+      ActorsController.send(:autocomplete, :movie, :name, {:full => true})
 
-  def test_value_option
-    ActorsController.send(:autocomplete, :movie, :name, {:display_value => :display_name})
+      get :autocomplete_movie_name, :term => 'ph'
+      json_response = JSON.parse(@response.body)
+      assert_equal(json_response.length, Movie.count)
+      assert_equal(json_response.first["label"], @movie.name)
+    end
 
-    @movie = Movie.create(:name => 'Alpha')
+    should "be able to customize what is displayed" do
+      ActorsController.send(:autocomplete, :movie, :name, {:display_value => :display_name})
 
-    get :autocomplete_movie_name, :term => 'Al'
+      get :autocomplete_movie_name, :term => 'Al'
 
-    json_response = JSON.parse(@response.body)
+      json_response = JSON.parse(@response.body)
 
-    assert_equal(@movie.display_name, json_response.first["label"])
-    assert_equal(@movie.display_name, json_response.first["value"])
-    assert_equal(@movie.id, json_response.first["id"])
+      assert_equal(@movie.display_name, json_response.first["label"])
+      assert_equal(@movie.display_name, json_response.first["value"])
+      assert_equal(@movie.id, json_response.first["id"])
+    end
   end
-end
+end

data/test/form_helper_test.rb

@@ -22,4 +22,4 @@ class FormHelperTest < ActionView::TestCase
     post= Post.new
     assert_match(/data-autocomplete=\"some\/path\"/, autocomplete_field(:post, :author, 'some/path'))
   end
-end
+end

data/test/test_helper.rb

@@ -31,4 +31,4 @@ class ActiveSupport::TestCase
   setup do
     @routes = Rails3JQueryAutocomplete::Routes
   end
-end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rails3-jquery-autocomplete
 version: !ruby/object:Gem::Version 
-  hash: 27
+  hash: 25
   prerelease: false
   segments: 
   - 0
   - 3
-  - 4
-  version: 0.3.4
+  - 5
+  version: 0.3.5
 platform: ruby
 authors: 
 - David Padilla
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-14 00:00:00 -07:00
+date: 2010-09-27 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency