rails-web-console 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fa19e8314b00a499b44bb23fb74a13f15b12487
-  data.tar.gz: 38d099883bde682147bd355230bfaafcb00e62fb
+  metadata.gz: c329cfda8e600624144d9ec01945ee6581aed4bd
+  data.tar.gz: 7c4086adfe3931c4d429dd69d39ed1c4da86a290
 SHA512:
-  metadata.gz: ca4bd951e2c8e4cdf64cf862d4890de72f4f029798916cc90fd04f134aeadb3255cf39c9893427cad7eff579541f2f49c72fa227d50dd88386bf684f2eeb9938
-  data.tar.gz: 393ad26b00ee08029127091a8d6fc0066ffb3411cb63710d2c6fb9c0845e1aa35eca71d47ea5a84d0bf5370eb837a3787fc75432b12158f1ed44974511519857
+  metadata.gz: 21abd1e7fb7e0bc395245d1d66c8da1c487645ee5443a1ea5f71ccdc9d0d82072a444d709164fb0f220420c02b7a4b3de99b9602da3c8b0ed29313e6223ca59a
+  data.tar.gz: c6e85625b053d725b51ff3d31cc26f894b06eeb92b09609b76ce337dcefa2d72255bfb9cd94bc8a90a4dc2422b7628071505a13903e0f747141f7269ec9ac44a

data/app/controllers/rails_web_console/console_controller.rb

@@ -11,16 +11,26 @@ module RailsWebConsole
     def index
     end
 
+    SCRIPT_LIMIT = defined?(::WEB_CONSOLE_SCRIPT_LIMIT) ? ::WEB_CONSOLE_SCRIPT_LIMIT : 1000
+    WARNING_LIMIT_MSG = "WARNING: stored script in session was limited to the first " +
+      "#{SCRIPT_LIMIT} chars to avoid issues with cookie overflow\n"
     def run
-      session[:script] = params[:script]
+      # we limit up to 1k to avoid ActionDispatch::Cookies::CookieOverflow (4k) which we 
+      # can't rescue since it happens in a middleware
+      script = params[:script]
+      # we allow users to ignore the limit if they are using another session storage mechanism
+      script = script[0...SCRIPT_LIMIT] unless defined?(::WEB_CONSOLE_IGNORE_SCRIPT_LIMIT)
+      session[:script] = script
       stdout_orig = $stdout
       $stdout = StringIO.new
       begin
+        puts WARNING_LIMIT_MSG if params[:script].size > SCRIPT_LIMIT &&
+          !defined?(::WEB_CONSOLE_IGNORE_SCRIPT_LIMIT)
         result_eval = eval params[:script], binding
         $stdout.rewind
         result = %Q{<div class="stdout">#{escape $stdout.read}</div>
           <div class="return">#{escape result_eval.inspect}</div>}
-      rescue => e
+      rescue Exception => e
         result = e.to_s
       end
       $stdout = stdout_orig

data/lib/rails_web_console/version.rb

@@ -1,3 +1,3 @@
 module RailsWebConsole
-  VERSION = "0.3.2"
+  VERSION = "0.4.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-web-console
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Rodrigo Rosenfeld Rosas
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-04 00:00:00.000000000 Z
+date: 2016-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties