rails-patch-json-encode 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8f6e4506779f59734a8f7e0de0e32a59972e963e
-  data.tar.gz: 8b0556765ad8e5ecd0ec80d379cf004c5e85a604
+  metadata.gz: cf3ccc8ec566598e89ac1b31698f4ec0d3292c93
+  data.tar.gz: 8e7e3f808aee6ad5ff41f6c526e3a86d85460abe
 SHA512:
-  metadata.gz: d2248a53df54b7dec6839db35aa736adb78772cb220a29295ecf73edb3b75bb2aae10f89b6c5c0ebf7c8d47e8ab535f548e965a5ac84c783d1a9fdf2176645ae
-  data.tar.gz: debf84761c18bc0c9d78aabccae3993146bc3959fee74738120d32778cf65e9c2ec11163d9e2d66c5e8676d47146e84d35075dafb0ac0b1820a059b646dbbddc
+  metadata.gz: 019d87cceca6d75fa582bfa7cb65975a2a8eac7fe4151dbb354e92b26b09ce3789b573232374ab7f2d89a09162904149f7b265f0b34b4ee2c202d4884da5f1e5
+  data.tar.gz: 7fe82b3585ac197c9f5f4ba923caa6ba90724cc67b08ba0a7a0bcdcfd08d4fa5e7676dc8609c3f26448194cb459be4745e4b9a9e25039bab7a562318fb1ee324

data/README.md

@@ -6,7 +6,7 @@ For full details please read Jason Hutchens' [blog post](http://devblog.agworld.
 
 All credits goes to [Jason Hutchens](https://github.com/jasonhutchens) for discovering the issue and providing the code for this monkey patch.
 
-## Usage
+## Installation
 
 First, go to your Rails console and type:
 
@@ -17,14 +17,23 @@ First, go to your Rails console and type:
     
 See how Rails performs before the patch.
 
-Then bundle install this gem with a fast JSON encoding gem in your Rails' Gemfile.
+Second, bundle install this gem with a fast JSON encoding gem in your Rails' Gemfile.
 
     gem 'rails-patch-json-encode'
     gem 'oj'
     
-In this case I choose the oj gem, but you can [choose a JSON gem that multi_json supports](https://github.com/intridea/multi_json#supported-json-engines).
+In this case I choose the oj gem, but you can [choose a json-encoder gem that multi_json supports](https://github.com/intridea/multi_json#supported-json-engines).
 
-Rails should now use the faster encoder. Now restart your console again and re-run the test to see how the performance changes.
+Last, there are two levels of patch available. You have to choose one and call it explictly:
+
+* `Rails::Patch::Json::Encode.patch_base_classes` patches all Ruby base classes.
+* `Rails::Patch::Json::Encode.patch_renderers` patches Rails' ActionController::Renderers only. This is for those who had issue with the JSON gem, as patching base classes cause infinite recursive loop. 
+
+Place one of them in Rails' initializers like config/initializers/rails_patch_json_encode.rb, and Rails should now use the faster encoder.
+
+## Benchmark
+
+For console benchmark comparison, restart console after the above installation. Call `Rails::Patch::Json::Encode.patch_base_classes` in console, then re-run the test to see how the performance changes.
 
 The actual performance boost on real-world applications will probably be less than that. For one of my page I see the rendering time dropped by 25%.
 

data/lib/rails/patch/json/encode.rb

@@ -1,11 +1,34 @@
 require "rails/patch/json/encode/version"
 
-# Code from http://devblog.agworld.com.au/post/42586025923/the-performance-of-to-json-in-rails-sucks-and-theres
-# essentially reversing Rails' hard-coded call to ActiveSupport::JSON.encode
-[Object, Array, FalseClass, Float, Hash, Integer, NilClass, String, TrueClass].each do |klass|
-  klass.class_eval do
-    def to_json(opts = {})
-      MultiJson::dump(self.as_json(opts), opts)
+module Rails::Patch::Json::Encode
+  # Use multi_json instead of Rails' to_json method (which calls ActiveSupport::JSON)
+  # when `render :json => @obj` is called.
+  def self.patch_renderers
+    ::ActionController::Renderers.module_eval do
+      # Override
+      add :json do |json, options|
+        json = MultiJson::dump(json.as_json(options), options) unless json.kind_of?(String)
+
+        if options[:callback].present?
+          self.content_type ||= Mime::JS
+          "#{options[:callback]}(#{json})"
+        else
+          self.content_type ||= Mime::JSON
+          json
+        end
+      end
+    end
+  end
+
+  # Code from http://devblog.agworld.com.au/post/42586025923/the-performance-of-to-json-in-rails-sucks-and-theres
+  # essentially reversing Rails' hard-coded call to ActiveSupport::JSON.encode
+  def self.patch_base_classes
+    [Object, Array, FalseClass, Float, Hash, Integer, NilClass, String, TrueClass].each do |klass|
+      klass.class_eval do
+        def to_json(opts = {})
+          MultiJson::dump(self.as_json(opts), opts)
+        end
+      end
     end
   end
 end

data/lib/rails/patch/json/encode/version.rb

@@ -2,7 +2,7 @@ module Rails
   module Patch
     module Json
       module Encode
-        VERSION = "0.0.1"
+        VERSION = "0.1.0"
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-patch-json-encode
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - lulalala
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-19 00:00:00.000000000 Z
+date: 2014-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -88,9 +88,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.5
+rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: A monkey patch to speed up Rails' JSON generation time.
 test_files: []
-has_rdoc: