rails-js-routes 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1cebb23dcc0242dba9c4c8de6a37f79737ef6199
-  data.tar.gz: f5437c7549d77798db7f435ada04920c62a58b7c
+  metadata.gz: 05194101dca7822c43e804d4c23755440cd34f55
+  data.tar.gz: 0f45584f2f67dc61e0dc08a175237fad3a2016d9
 SHA512:
-  metadata.gz: 0fccbf3b17c3c6c9f9517d618bbc2bba4a9dd96e34c9bdc220b359e4c0baa4d859f36081972f611e9a6c42c5298055e2c6568cfa08c4283948ad7e73c49a9ec3
-  data.tar.gz: 39a428a03ef6a41eaaf1a3e717e6e27bf3e772684b6dd3fd9664e7957a1fe07c9f0fbd696397ef287d25720ee0a13aed6c73466fc0f6ca7b54ceaeedfa94974c
+  metadata.gz: fe87c95f9a8027d253c5dc138c5911ef3945e97c74b6f9a30702ca17287a3c339d93c7d7f0d7a3e725645ee0e142d7e2be7a1ea360996cd8f4ef0424117c3e9a
+  data.tar.gz: 7924a3e4a26b2123becb4f00df5fc51bed87696d62ecc781792025e06630b687f2cb896752875b10c64c66d9f0e80114084e1022540bf02082d15c442de28f5e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rails-js-routes (0.2.0)
+    rails-js-routes (0.2.1)
       rails (~> 4)
 
 GEM
@@ -84,7 +84,7 @@ GEM
       activesupport (= 4.1.8)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rake (10.3.2)
+    rake (10.4.0)
     rest-client (1.6.7)
       mime-types (>= 1.16)
     simplecov (0.9.1)
@@ -97,7 +97,7 @@ GEM
       multi_json (~> 1.0)
       rack (~> 1.0)
       tilt (~> 1.1, != 1.3.0)
-    sprockets-rails (2.2.0)
+    sprockets-rails (2.2.1)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       sprockets (>= 2.8, < 4.0)

data/README.md

@@ -8,8 +8,7 @@ rails-js-routes
 
 [Check out the blog post!](http://finn.heemeyer.net/2014/10/18/rails-js/)
 
-NOTICE: We decided to rename this gem from ``rails-js`` to ``rails-js-routes`` as it was nearly impossible to find.
-The name may be somewhat long, but for us it describes the functionality appropriate.
+*NOTICE: We decided to rename this gem from ``rails-js`` to ``rails-js-routes`` as it was nearly impossible to find.*
 
 
 I worked on several Rails projects and there were many cases when it felt overkill to use a framework like ``Angular`` or ``Ember``, because javascript was only needed in some parts of the application.

data/app/assets/javascripts/routes.js

@@ -16,7 +16,7 @@
   Rails = window.Rails || {};
 
   /*
-   * For testing. We want to start each test with emtpiness.
+   * For testing. We want to start each test with emptiness.
    */
   Rails.clear = function() {
     controllers = {};
@@ -118,7 +118,7 @@
     /*
      * Execute beforeAll() hook if defined
      */
-    if (beforeAll && typeof(beforeAll) == 'function') {
+    if (beforeAll && typeof(beforeAll) === 'function') {
       beforeAll();
     }
 
@@ -132,7 +132,7 @@
        * Execute namespace hook if we defined one
        */
       namespaceHook = namespaceHooks[this.config.namespace];
-      if (namespaceHook && typeof(namespaceHook) == 'function') {
+      if (namespaceHook && typeof(namespaceHook) === 'function') {
         namespaceHook();
       }
     }
@@ -140,9 +140,9 @@
     /*
      * Find controller and execute method
      */
-    var controller = controllers[controllerName];
+    controller = controllers[controllerName];
     if (controller && controller[this.config.action] &&
-       typeof(controller[this.config.action]) == 'function') {
+       typeof(controller[this.config.action]) === 'function') {
 
       controller[this.config.action](controller.helpers);
     }
@@ -177,7 +177,8 @@
    * Also contains global helpers, so to prevent conflicts
    * we save global variables by using this singleton as a function.
    *
-   * R('foo'); // Gets window.R.data.foo
+   * R()              // Gets window.R.data
+   * R('foo');        // Gets window.R.data.foo
    * R('foo', 'bar'); // Sets window.R.data.foo
    */
   R = function(key, val) {
@@ -191,22 +192,22 @@
      * R('foo.bar.baz', 'foo');
      *
      */
-    var steps = key.split('.'),
-        step = data,
-        i;
-
-    if (arguments.length == 2) {
-      for (i = 0; i < steps.length-1; i++) {
-        if (!step[steps[i]]) {
-          step[steps[i]] = {};
-        }
 
-        step = step[steps[i]];
-      }
-
-      step[steps[steps.length -1]] = val;
+    var steps,
+        step,
+        i;
 
+    // Prepare arguments for find/set routine
+    // Expose private scoped data attribute, if no arguments provided
+    if (arguments.length) {
+      steps = key.split('.');
+      step = data;
     } else {
+      return data;
+    }
+
+    // Return value for `key`
+    if (arguments.length === 1) {
       for (i = 0; i < steps.length; i++) {
         step = step[steps[i]];
         if (!step) {
@@ -216,6 +217,21 @@
       }
       return step;
     }
+
+    // Set value for `key`
+    // NOTE: Currently non-existing steps are created
+    if (arguments.length === 2) {
+      for (i = 0; i < steps.length - 1; i++) {
+        if (!step[steps[i]]) {
+          step[steps[i]] = {};
+        }
+
+        step = step[steps[i]];
+      }
+
+      step[steps[steps.length - 1]] = val;
+      return val;
+    }
   };
 
   /*
@@ -228,15 +244,15 @@
    */
   R.helper = function(controllerName, helperName) {
 
-    var controller,
-        helper,
+    var args = Array.prototype.slice.call(arguments, 2),
+        controller,
         context,
-        args = Array.prototype.slice.call(arguments, 2);
+        helper;
 
     /*
      * Treat 3rd argument as arguments for helper if it is an Array
      */
-    if (args.length == 1 && args[0] instanceof Array) {
+    if (args.length === 1 && args[0] instanceof Array) {
       args = args[0];
     }
 
@@ -253,7 +269,7 @@
     /*
      * Make sure our helper exists
      */
-    if (!(helper && typeof(helper) == 'function')) {
+    if (!helper || typeof(helper) !== 'function') {
       if (controllerName) {
         throw ['Helper \'', helperName, '\' not defined for controller \'',
                controllerName, '\''].join('');
@@ -313,7 +329,7 @@
     if (!controller) {
         throw ['Attempting to call action \'', controllerName, '#', actionName,
                '\', but Controller \'', controllerName, '\' is not defined!'].join('');
-    } else if (!controller[actionName] || !(typeof(controller[actionName]) == 'function')) {
+    } else if (!controller[actionName] || typeof(controller[actionName]) !== 'function') {
         throw ['Attempting to call action \'', controllerName, '#', actionName,
                '\', but Action \'', actionName, '\' is not defined!'].join('');
     }

data/lib/rails/js/routes/version.rb

@@ -1,7 +1,7 @@
 module Rails
   module JS
     module Routes
-      VERSION = "0.2.0"
+      VERSION = "0.2.1"
     end
   end
 end

data/test/dummy/spec/javascripts/{route_dispatch_spec.js → js_routes_spec.js}

@@ -6,7 +6,7 @@
  */
 
 (function() {
-  describe('rails-js_route_dispatch', function() {
+  describe('rails-js-routes', function() {
 
     /*
      * define all functions spied on
@@ -73,11 +73,12 @@
     });
 
     it('must handle global variables', function() {
-      R('a.global.variable', 'foo');
+      expect(R('a.global.variable', 'foo')).toBe('foo');
 
       expect(R('a')).toBeDefined();
       expect(R('a.global')).toBeDefined();
       expect(R('a.global.variable')).toBe('foo');
+      expect(R()).toEqual({foo: 'bar', a: {global: {variable: 'foo'}}});
     });
 
     it('must be able to execute global helpers', function() {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-js-routes
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Finn-Lenanrt Heemeyer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-24 00:00:00.000000000 Z
+date: 2014-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -144,7 +144,7 @@ files:
 - test/dummy/public/422.html
 - test/dummy/public/500.html
 - test/dummy/public/favicon.ico
-- test/dummy/spec/javascripts/route_dispatch_spec.js
+- test/dummy/spec/javascripts/js_routes_spec.js
 - test/dummy/spec/javascripts/spec_helper.js
 - test/dummy/spec/teaspoon_env.rb
 - test/dummy/test/helpers/testing_helper_test.rb