rails-informant 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 485e2e93c123b0e19bdf0fead39f92d8043e16c14cf9eaf6bb22f60a71b49ad4
-  data.tar.gz: c4a3dd9090e8ce91b5d8cd161aafc5428971425e7690a17fe3ff2aa80ba1e31a
+  metadata.gz: 0efea7b3e9161f6868f46fa2996fc426ad132eb3cb0b5a814963447472ff83ff
+  data.tar.gz: 2b73bff8211ebd79de66056c91321ec3a79989c8f38f415235d2f9e0d49fdc4c
 SHA512:
-  metadata.gz: 6f029e95ff0427c4e08732693cfa63cdc452ced3643a0785235e8bb64e0ab11c9dd7f4657c3bbe3aa59e8c50cecdc08abc8bff530fa2d096348c2279255ccc57
-  data.tar.gz: 1f7d8a4a9da13db4fe53e2bff1a34e6b5147299c088e26e55d1ac80940982d7b2776f787456c5b20721601816a7163e9d58d3a5738dc1e8170e2d3b36b27419b
+  metadata.gz: f6b50ea3c2c678ae9239a89846bba3759bdfb57c08e2b12724c43125529a08892a6a45d9d5c1e9cfb5d72eac77dbd18534b075f4043a23cdcac184b7f1bde9c4
+  data.tar.gz: 8e9c3fcfea6562d5d925b6824a27d50da602c2a72c3f87e673aa74a0922ad9025e15da4f35df7adcefd88dc095c5c336f3c1601c9350290627d80989c957db9e

data/lib/generators/rails_informant/skill/templates/SKILL.md

@@ -27,7 +27,13 @@ When implementing a fix:
 5. Verify test passes
 6. Commit + open draft PR
 7. Call `mark_fix_pending` with fix_sha, original_sha, and fix_pr_url
-   (The server auto-resolves when the fix is deployed)
+
+## Verify Deployed Fixes
+
+After a deploy, run `verify_pending_fixes` to confirm fix_pending errors are resolved.
+This checks if each fix_sha is an ancestor of the deployed code using git locally.
+Check `get_informant_status` — if `deploy_sha` has changed since you last checked, a deploy has occurred.
+Ensure the local repo is up to date (`git fetch`) before running verification.
 
 ## Important Notes
 

data/lib/rails_informant/engine.rb

@@ -39,19 +39,14 @@ module RailsInformant
       )
     end
 
-    initializer "rails_informant.detect_deploy" do
+    initializer "rails_informant.log_pending_fixes" do
       config.after_initialize do
         next unless RailsInformant.server_mode?
 
-        current_sha = RailsInformant.current_git_sha
-        next unless current_sha
+        count = RailsInformant::ErrorGroup.where(status: "fix_pending").count
+        next if count.zero?
 
-        now = Time.current
-        RailsInformant::ErrorGroup
-          .where(status: "fix_pending")
-          .where.not(original_sha: current_sha)
-          .in_batches(of: 100)
-          .update_all(status: "resolved", resolved_at: now, fix_deployed_at: now, updated_at: now)
+        Rails.logger.info "[Informant] #{count} error(s) awaiting fix verification"
       rescue ActiveRecord::StatementInvalid
         # Table may not exist yet during initial migration
       end

data/lib/rails_informant/mcp/server.rb

@@ -6,10 +6,11 @@ module RailsInformant
 
         ## Triage Workflow
         1. Check `get_informant_status` for overview counts by status
-        2. List unresolved errors with `list_errors(status: "unresolved")`
-        3. Pick the highest-impact error
-        4. Investigate with `get_error` (includes up to 10 recent occurrences)
-        5. For errors with many occurrences, use `list_occurrences` to paginate through all of them
+        2. If fix_pending count > 0 in the status response, run `verify_pending_fixes` to check deployed fixes
+        3. List unresolved errors with `list_errors(status: "unresolved")`
+        4. Pick the highest-impact error
+        5. Investigate with `get_error` (includes up to 10 recent occurrences)
+        6. For errors with many occurrences, use `list_occurrences` to paginate through all of them
 
         ## Assessment Criteria
         Prioritize by: frequency (occurrence count), impact (affects critical paths),
@@ -23,7 +24,8 @@ module RailsInformant
         duplicate → unresolved
 
         ## Resolution Strategies
-        - Clear fix available → write fix, call `mark_fix_pending` with commit SHAs
+        - Clear fix available → write fix, call `mark_fix_pending` with commit SHAs. After deploy, run `verify_pending_fixes` to confirm and resolve.
+        - Pending fixes deployed → `verify_pending_fixes` checks git ancestry and resolves verified fixes
         - Not actionable → `annotate_error` with reason, then `ignore_error`
         - Same root cause as another → `mark_duplicate` with target ID
         - Needs context → `annotate_error` with findings
@@ -60,7 +62,8 @@ module RailsInformant
         Tools::MarkDuplicate,
         Tools::MarkFixPending,
         Tools::ReopenError,
-        Tools::ResolveError
+        Tools::ResolveError,
+        Tools::VerifyPendingFixes
       ].freeze
 
       def self.build(config)

data/lib/rails_informant/mcp/tools/get_informant_status.rb

@@ -13,7 +13,11 @@ module RailsInformant
 
         def self.call(server_context:, environment: nil)
           with_client(server_context:, environment:) do |client|
-            text_response(client.status)
+            result = client.status
+            if result["fix_pending_count"]&.positive?
+              result["hint"] = "#{result["fix_pending_count"]} error(s) awaiting fix verification. Run verify_pending_fixes to check if their fixes have been deployed."
+            end
+            text_response result
           end
         end
       end

data/lib/rails_informant/mcp/tools/mark_fix_pending.rb

@@ -3,7 +3,7 @@ module RailsInformant
     module Tools
       class MarkFixPending < BaseTool
         tool_name "mark_fix_pending"
-        description "Mark as fix_pending (unresolved → fix_pending) with the fix commit SHA, original SHA, and optional PR URL. The server auto-resolves when the fix is deployed. Valid from: unresolved."
+        description "Mark as fix_pending (unresolved → fix_pending) with the fix commit SHA, original SHA, and optional PR URL. After deploy, run verify_pending_fixes to confirm and resolve. Valid from: unresolved."
         input_schema(
           properties: {
             environment: { type: "string", description: "Target environment (defaults to first configured)" },

data/lib/rails_informant/mcp/tools/verify_pending_fixes.rb

@@ -0,0 +1,90 @@
+module RailsInformant
+  module Mcp
+    module Tools
+      class VerifyPendingFixes < BaseTool
+        tool_name "verify_pending_fixes"
+        description "Verify fix_pending errors by checking if their fix_sha is an ancestor of the deployed code. Resolves verified fixes. Requires git locally. Results reflect local git state — run git fetch first to ensure accuracy."
+        input_schema(
+          properties: {
+            auto_resolve: { type: "boolean", description: "Resolve verified fixes automatically (default: true)" },
+            environment: { type: "string", description: "Target environment (defaults to first configured)" },
+            target_ref: { type: "string", description: "Git ref to verify against (default: deploy_sha from status API)" }
+          }
+        )
+        annotations(read_only_hint: false, destructive_hint: false, idempotent_hint: true)
+
+        MAX_PAGES = 10
+
+        class << self
+          def call(server_context:, auto_resolve: true, environment: nil, target_ref: nil)
+            with_client(server_context:, environment:) do |client|
+              return error_response "git is not available. Run this tool from a machine with git installed." unless git_available?
+
+              ref = target_ref || fetch_deploy_sha(client)
+              return error_response "No deploy SHA available. Pass target_ref explicitly." unless ref
+              return error_response "Invalid target_ref" if ref.start_with?("-")
+
+              errors = fetch_all_fix_pending client
+              return text_response("message" => "No fix_pending errors found", "verified" => [], "pending" => []) if errors.empty?
+
+              verified = []
+              pending = []
+
+              errors.each do |error|
+                fix_sha = error["fix_sha"]
+                if fix_sha && ancestor?(fix_sha, ref)
+                  verified << error
+                else
+                  pending << error
+                end
+              end
+
+              if auto_resolve && verified.any?
+                verified.each { |error| client.update_error error["id"], status: "resolved" }
+              end
+
+              text_response(
+                "message" => "Verified #{verified.size} of #{errors.size} fix_pending error(s)",
+                "deploy_sha" => ref,
+                "resolved_count" => auto_resolve ? verified.size : 0,
+                "verified" => verified.map { summarize it },
+                "pending" => pending.map { summarize it }
+              )
+            end
+          end
+
+          private
+
+          def ancestor?(fix_sha, target_ref)
+            system "git", "merge-base", "--is-ancestor", fix_sha, target_ref, out: File::NULL, err: File::NULL
+          end
+
+          def fetch_all_fix_pending(client)
+            errors = []
+            page = 1
+            loop do
+              result = client.list_errors status: "fix_pending", page:, per_page: 100
+              errors.concat result["data"]
+              break unless result.dig("meta", "has_more")
+              page += 1
+              break if page > MAX_PAGES
+            end
+            errors
+          end
+
+          def fetch_deploy_sha(client)
+            client.status&.dig("deploy_sha")
+          end
+
+          def git_available?
+            system "git", "rev-parse", "--git-dir", out: File::NULL, err: File::NULL
+          end
+
+          def summarize(error)
+            { "id" => error["id"], "error_class" => error["error_class"], "message" => error["message"], "fix_sha" => error["fix_sha"], "fix_pr_url" => error["fix_pr_url"] }
+          end
+        end
+      end
+    end
+  end
+end

data/lib/rails_informant/mcp.rb

@@ -19,4 +19,5 @@ require_relative "mcp/tools/mark_duplicate"
 require_relative "mcp/tools/mark_fix_pending"
 require_relative "mcp/tools/reopen_error"
 require_relative "mcp/tools/resolve_error"
+require_relative "mcp/tools/verify_pending_fixes"
 require_relative "mcp/server"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-informant
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Daniel López Prat
@@ -159,6 +159,7 @@ files:
 - lib/rails_informant/mcp/tools/mark_fix_pending.rb
 - lib/rails_informant/mcp/tools/reopen_error.rb
 - lib/rails_informant/mcp/tools/resolve_error.rb
+- lib/rails_informant/mcp/tools/verify_pending_fixes.rb
 - lib/rails_informant/middleware/error_capture.rb
 - lib/rails_informant/middleware/rescued_exception_interceptor.rb
 - lib/rails_informant/notifiers/notification_policy.rb