rails-gp-webpay 0.2.5 → 0.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9c597464425c2927b468ae8c969fd4d2046060668df8f4c9793f7e74ab18712d
-  data.tar.gz: 7e67ac949546fb2ddc85a4ae551ac8d06b5e62e71811d0ded3ccfe197bc85a4f
+  metadata.gz: 557be3e38c554946e0fe2839549b752342205f2bfaa911a4861a3f1ea268c1a3
+  data.tar.gz: e48dd123da0ac8e2180d43917e3b3c2e63e8afe56cb17b08127824f65faf4f24
 SHA512:
-  metadata.gz: 36c914a4554ec7de7bce64c8da8e5eced4c4da6009f63b481aa4cf9cf562878f84e81dec3f6178d8a0dc2b1295172128a630b145b5826a6019e0db066a9d1fb4
-  data.tar.gz: '008e96b29024a860c39bd4d168492525d5e8abc481e97978a17b1705e5557853e21ef566498740567fd95fbdc8a7e3514758f4e242d62e895bd5eda8ce150b2d'
+  metadata.gz: ae3c2c5e04ae5cb2230e28a87d732f8769679b48f2ee0f1eb0f0c2b00e553a69cdaecad3201e0cf6368a0e359ca8f99b970939204160c4b98d1d6869af79ed7e
+  data.tar.gz: ce49aa4b92af16bfb9aff3cec47c2baf190c5361045bbf7acb134a61a2f93626c005725bc80cf854bb592ce3e109b35900234c6841bb365f7b2dc46faf8256fc

data/changelog.md

@@ -1,5 +1,8 @@
 # Changelog
 
+## 0.2.6
+Add merchant number to tests, add default attributes to requests
+
 ## 0.2.4
 Increase savon timeout to 5 minutes
 

data/lib/gp_webpay/configuration.rb

@@ -21,8 +21,7 @@ module GpWebpay
     end
 
     def find_configuration_by_merchant_number(merchant_number)
-
-      config = @configurations.find { |_key, value| puts _key;value.merchant_number.to_s == merchant_number.to_s }
+      config = @configurations.find { |_key, value| value.merchant_number.to_s == merchant_number.to_s }
       return nil if config.blank?
 
       config[-1]

data/lib/gp_webpay/mock/spec_helper.rb

@@ -1,5 +1,5 @@
 require 'savon/mock/spec_helper'
-
+# rubocop:disable Metrics/ParameterLists
 module GpWebpay
   module SpecHelper
     class Interface
@@ -45,15 +45,13 @@ module GpWebpay
         allow(GpWebpay::Ws::Services::ProcessUsageBasedPayment)
           .to receive(:call).with(
             hash_including(
-              {
-                message_id: anything,
+              { message_id: anything,
                 payment_number: anything,
                 order_number: anything,
                 currency_code: anything,
-                capture_flag: '1'
-              }.merge(attributes)
+                capture_flag: '1' }.merge(attributes)
             ),
-            merchant_number: merchant_number,
+            merchant_number: merchant_number
           ).and_return(instance_double(GpWebpay::Ws::WsResponse,
                                        valid?: valid, success?: success, status: status, result_text: result_text,
                                        pr_code: success ? '0' : '123', sr_code: success ? '0' : '4',
@@ -69,28 +67,28 @@ module GpWebpay
                                        pr_code: success ? '0' : '123', sr_code: success ? '0' : '4'))
       end
 
-      def stub_refund_payment(attributes, valid: true, success: true, status: '', result_text: 'OK')
+      def stub_refund_payment(attributes, merchant_number: nil, valid: true, success: true, status: '', result_text: 'OK')
         allow(GpWebpay::Ws::Services::ProcessRefundPayment)
           .to receive(:call).with(
-            hash_including({ message_id: anything }.merge(attributes))
+            hash_including({ message_id: anything }.merge(attributes)), merchant_number: merchant_number
           ).and_return(instance_double(GpWebpay::Ws::WsResponse,
                                        valid?: valid, success?: success, status: status, result_text: result_text,
                                        pr_code: success ? '0' : '123', sr_code: success ? '0' : '4'))
       end
 
-      def stub_capture_reverse(attributes, valid: true, success: true, status: '', result_text: 'OK')
+      def stub_capture_reverse(attributes, merchant_number: nil, valid: true, success: true, status: '', result_text: 'OK')
         allow(GpWebpay::Ws::Services::ProcessCaptureReverse)
           .to receive(:call).with(
-            hash_including({ message_id: anything }.merge(attributes))
+            hash_including({ message_id: anything }.merge(attributes)), merchant_number: merchant_number
           ).and_return(instance_double(GpWebpay::Ws::WsResponse,
                                        valid?: valid, success?: success, status: status, result_text: result_text,
                                        pr_code: success ? '0' : '123', sr_code: success ? '0' : '4'))
       end
 
-      def stub_cancel_capture(attributes, valid: true, success: true, status: '', result_text: 'OK')
+      def stub_cancel_capture(attributes, merchant_number: nil, valid: true, success: true, status: '', result_text: 'OK')
         allow(GpWebpay::Ws::Services::ProcessCancelCapture)
           .to receive(:call).with(
-            hash_including({ message_id: anything }.merge(attributes))
+            hash_including({ message_id: anything }.merge(attributes)), merchant_number: merchant_number
           ).and_return(instance_double(GpWebpay::Ws::WsResponse,
                                        valid?: valid, success?: success, status: status, result_text: result_text,
                                        pr_code: success ? '0' : '123', sr_code: success ? '0' : '4'))
@@ -102,3 +100,4 @@ module GpWebpay
     end
   end
 end
+# rubocop:enable Metrics/ParameterLists

data/lib/gp_webpay/version.rb

@@ -1,3 +1,3 @@
 module GpWebpay
-  VERSION = '0.2.5'.freeze
+  VERSION = '0.2.6'.freeze
 end

data/lib/gp_webpay/ws/base_signed_request.rb

@@ -23,6 +23,7 @@ module GpWebpay
       RESPONSE_NAME = 'override_me'.freeze
       RESPONSE_ENTITY_NAME = 'override_me'.freeze
       SERVICE_EXCEPTION = :service_exception
+      DEFAULT_ATTRIBUTES = {}.freeze
 
       def initialize(attributes, merchant_number: :default)
         @attributes = attributes
@@ -32,9 +33,10 @@ module GpWebpay
       end
 
       def call
-        attrs = WsRequest.new(attributes.merge(provider: config.provider, merchant_number: config.merchant_number)).to_gpwebpay
+        attrs = WsRequest.new(final_attributes).to_gpwebpay
 
-        res = client.call(self.class::OPERATION_NAME, message: { self.class::REQUEST_NAME => attributes_with_signature(attrs) })
+        Rails.logger.debug([self.class::OPERATION_NAME, { message: { self.class::REQUEST_NAME => attributes_with_signature(attrs) } }])
+        res = client.call(self.class::OPERATION_NAME, { message: { self.class::REQUEST_NAME => attributes_with_signature(attrs) } })
         WsResponse.from_success(res.body, self.class::RESPONSE_NAME, self.class::RESPONSE_ENTITY_NAME, config.merchant_number)
       rescue Savon::HTTPError => e
         rescue_from_http(e)
@@ -44,6 +46,12 @@ module GpWebpay
 
       protected
 
+      def final_attributes
+        {}.merge(self.class::DEFAULT_ATTRIBUTES,
+                 attributes,
+                 { provider: config.provider, merchant_number: config.merchant_number })
+      end
+
       def digest_text(attrs)
         attrs.values.join('|')
       end

data/lib/gp_webpay/ws/services/process_capture_reverse.rb

@@ -14,6 +14,7 @@ module GpWebpay
         REQUEST_NAME = :capture_reverse_request
         RESPONSE_NAME = :process_capture_reverse_response
         RESPONSE_ENTITY_NAME = :capture_reverse_response
+        DEFAULT_ATTRIBUTES = { capture_number: 1 }.freeze # 1 is recommended
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-gp-webpay
 version: !ruby/object:Gem::Version
-  version: 0.2.5
+  version: 0.2.6
 platform: ruby
 authors:
 - Lubomir Vnenk
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-06-22 00:00:00.000000000 Z
+date: 2021-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport