rails-futurizer 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 277ed0db943b5cb95f08c9441ca55db45a223cc3
-  data.tar.gz: 5e1f297e00b4976968f12d234906076aea95b177
+  metadata.gz: 4d19e7d09ac51d53ff271394258aca3679e60087
+  data.tar.gz: 6f6e61beb959e6a70b3c6345cd5bc652a8c54557
 SHA512:
-  metadata.gz: 2cb0b9105459eae395db0a24e0baa9df2edee9e8e71eea3bf3743d05599a4a2cf0fcbd7458822a12f0b5e334b8866ec29b07239775ceefcafb4c7bb54fc7c41b
-  data.tar.gz: 97753285dde6d7c0c4144bc20bd79ff99f8f0be7eb1da6003ada649639696ef1acca624d580e139180541f41481655f67bfd497b247d41b9bde5346b416d78a5
+  metadata.gz: 7f7e51aff9bba2aac642a2655c8c5db2cda6e11e8f50552d8fc2e2f7df81c427518e6d10009fdc9747e48463f4b241818fe93c874fb6621cc3aada09c8f7bbdb
+  data.tar.gz: f29d8b75ba98e6385cea3c71e2d16aaca23eaad36bb48cb6b92da57ac7983a393a3bc33e7e38f9cef48124fae5f9c7f72e1d679131a2e7c4f73a560d256ba93b

data/History.md

@@ -1,3 +1,8 @@
+### Version 1.0.1
+2014-3-11
+
+* Patch a bug that prevents saving has_many associations in Rails 2.2 - 3.0 with Ruby 2.
+
 ### Version 1.0.0
 2014-3-8
 

data/README.md

@@ -3,32 +3,71 @@
 [![Build Status](https://travis-ci.org/brianauton/rails-futurizer.png?branch=master)](https://travis-ci.org/brianauton/rails-futurizer)
 [![Code Climate](https://codeclimate.com/github/brianauton/rails-futurizer.png)](https://codeclimate.com/github/brianauton/rails-futurizer)
 
-Drag your legacy Rails apps into the future a little less painfully.
+Drag your legacy Rails apps into the future a little more easily.
+
+### Introduction
+
+Upgrading a legacy Rails app can be a frustrating process. Ideally,
+you'd like to break the upgrade up into as many discrete steps as
+possible: upgrade the Ruby version here, a couple gems there, and
+continually commit to master with all tests passing at each step.
+
+But these intermediate steps often involve version combinations that
+are not well supported or tested (e.g. Ruby 2 + Rails 2), and a lot of
+time is typically spent tracking down unexpected test failures and
+cryptic error messages that result from these dangerous version
+combinations.
+
+Rails-futurizer makes the upgrade process quicker and easier by
+automatically patching some of these bugs and giving clear warnings
+about the cause of others. See below for a list of all patches and
+warnings available.
+
+### What it doesn't do
+
+It doesn't backport any features or syntax from newer Ruby/Rails
+versions to older versions. Upgrade your apps; don't keep developing
+them against old versions.
 
 ### Requirements
 
   * Ruby 1.8.7 or greater
 
-  * RubyGems v1.1.0 or greater
+  * RubyGems 1.1.0 or greater
 
-  * Nothing else, although rails-futurizer won't do anything unless
+  * Nothing else. But rails-futurizer won't do anything unless
     it's installed alongside a version of Rails for which some
     applicable fixes are available.
 
-### Getting Started
+### Installation
 
-Install the rails-futurizer gem alongside rspec in your gemfile.
+If your app is using Bundler, add the rails-futurizer gem to the
+Gemfile.
 
     gem "rails-futurizer"
 
-That's it! Any applicable fixes will be activated automatically, and
-any that aren't applicable because of your current version of Rails,
-Ruby, etc. will be ignored.
+Then update your bundle.
+
+    $ bundle
+
+That's it! Rails-futurizer will automatically activate any fixes and
+warnings that are applicable to the currently installed versions of
+Ruby and Rails, and ignore those that are not applicable.
+
+(If your app is too old to be using Bundler, consider adding Bundler
+as the first step toward upgrading.)
+
+### Bugs Patched
+
+  The following bugs will be automatically patched when
+  rails-futurizer is loaded.
 
-### Fixes Included
+  * When Rails 2.3 or older is used with Ruby 2.0 or newer, parameter
+    log filtering in ActionController silently fails, causing all
+    parameters to be logged regardless of filter
+    settings. Patched for Rails 2.2.1 or newer.
 
-  * When using Rails 2.3 or older with Ruby 2.0 or newer,
-    ActionController's filter_parameters behavior will silently fail
-    and output all parameters to the log regardless of filtering
-    options selected. Rails-futurizer will automatically patch this
-    bug if you're using Rails 2.2.1 or newer.
+  * When Rails 2.2 - 3.0 is used with Ruby 2.0 or newer, saving an
+    ActiveRecord model that has an array assigned to one of its
+    has_many associations will raise the exception "undefined method
+    'insert_record' for Array". Patched for all affected versions.

data/lib/futurizer/patches/activerecord/association_proxy.rb

@@ -0,0 +1,18 @@
+if Futurizer.detected? :activerecord => [">= 2.2.0", "< 3.1"], :ruby => ">= 2"
+  Futurizer.require_dependency "active_record"
+
+  module ActiveRecord
+    module Associations
+      class AssociationProxy
+        def send(method, *args)
+          if proxy_respond_to?(method, true)
+            super
+          else
+            load_target
+            @target.send(method, *args)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/futurizer/system_info.rb

@@ -11,5 +11,9 @@ module Futurizer
     def self.ruby_version
       Gem.ruby_version
     end
+
+    def self.rubygems_version
+      Gem::Version.new Gem::VERSION
+    end
   end
 end

data/lib/futurizer/version.rb

@@ -1,3 +1,3 @@
 module Futurizer
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/futurizer/version_detection.rb

@@ -12,7 +12,13 @@ module Futurizer
     end
 
     def self.current_version(resource)
-      resource == :ruby ? SystemInfo.ruby_version : SystemInfo.gem_version(resource)
+      if resource == :ruby
+        SystemInfo.ruby_version
+      elsif resource == :rubygems
+        SystemInfo.rubygems_version
+      else
+        SystemInfo.gem_version resource
+      end
     end
   end
 end

data/lib/rails-futurizer.rb

@@ -7,6 +7,7 @@ module Futurizer
 
   def self.apply_patches
     require "futurizer/patches/actionpack/filter_parameters.rb"
+    require "futurizer/patches/activerecord/association_proxy.rb"
   end
 
   def self.require_dependency file

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-futurizer
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Brian Auton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-08 00:00:00.000000000 Z
+date: 2014-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -63,6 +63,7 @@ files:
 - License.txt
 - README.md
 - lib/futurizer/patches/actionpack/filter_parameters.rb
+- lib/futurizer/patches/activerecord/association_proxy.rb
 - lib/futurizer/system_info.rb
 - lib/futurizer/version.rb
 - lib/futurizer/version_detection.rb