rails-embryo 0.3.0 → 0.3.1

data/History.md

@@ -1,3 +1,10 @@
+### Version 0.3.1
+2014-10-14
+
+* Add controller generator
+* Configure RSpec in zero monkey patching mode
+* Bugfixes
+
 ### Version 0.3.0
 2014-09-14
 

data/README.md

@@ -80,6 +80,18 @@ Authenticated models will automatically have an `email` field added and configur
 authentication key. To customize this or any other Devise behavior, edit the generated
 `config/initializers/devise.rb` along with the class and migration files for the new model.
 
+#### Controllers
+
+To generate a controller and an associated spec file, run the `embryo:controller` generator
+with the name of the model.
+
+    rails generate embryo:controller user
+
+The above command will generate the files `app/models/users_controller.rb` and
+`spec/models/users_controller_spec.rb`. The generator assumes that the named model and other
+related elements (migration, factory, view templates, and routes) already exist, so the
+generated controller specs may fail if you haven't created those yet.
+
 ### Enhancements Added
 
 All of the following enhancements are added to new applications by

data/lib/generators/embryo/controller.rb

@@ -0,0 +1,44 @@
+require "rails/generators"
+require "rails-embryo/ruby_template/controller"
+require "rails-embryo/ruby_template/controller_spec"
+require "rails-embryo/ruby_template/action/index"
+require "rails-embryo/ruby_template/action/new"
+require "rails-embryo/ruby_template/action/create"
+require "rails-embryo/ruby_template/action/show"
+require "rails-embryo/ruby_template/action/update"
+require "rails-embryo/ruby_template/action/destroy"
+require "rails-embryo/ruby_template/model"
+
+module Embryo
+  class ControllerGenerator < Rails::Generators::NamedBase
+    def install
+      create_file controller_template.path, controller_template.text
+      create_file spec_template.path, spec_template.text
+    end
+
+    private
+
+    def controller_template
+      @controller_template ||= RubyTemplate::Controller.new model, action_templates
+    end
+
+    def spec_template
+      @spec_template ||= RubyTemplate::ControllerSpec.new model, action_templates
+    end
+
+    def model
+      @model ||= RubyTemplate::Model.new name
+    end
+
+    def action_templates
+      [
+        RubyTemplate::Action::Index.new(model),
+        RubyTemplate::Action::New.new(model),
+        RubyTemplate::Action::Create.new(model),
+        RubyTemplate::Action::Show.new(model),
+        RubyTemplate::Action::Update.new(model),
+        RubyTemplate::Action::Destroy.new(model),
+      ]
+    end
+  end
+end

data/lib/generators/embryo/default_view.rb

@@ -33,7 +33,7 @@ end
     def controller_spec_data
 'require "rails_helper.rb"
 
-describe DashboardController do
+RSpec.describe DashboardController do
   describe "#index" do
     it "succeeds" do
       get :index
@@ -47,7 +47,7 @@ end
     def feature_spec_data
 'require "rails_helper.rb"
 
-feature "Dashboard" do
+RSpec.feature "Dashboard" do
   scenario "index view", :js do
     visit "/"
     expect(page).to have_content "Welcome"

data/lib/generators/embryo/model.rb

@@ -22,7 +22,7 @@ end
     def spec_data
 'require "rails_helper"
 
-describe ' + class_name + ' do
+RSpec.describe ' + class_name + ' do
   it "initializes successfully" do
     expect(build :' + factory_name + ').to be_valid
   end

data/lib/generators/embryo/rspec.rb

@@ -5,7 +5,7 @@ module Embryo
     include GeneratorHelpers::Hidden
 
     def install
-      gem "rspec-rails", "~> 3.0", group: :test
+      gem "rspec-rails", "~> 3.0", group: [:development, :test]
       create_file "spec/spec_helper.rb", spec_helper_data
       create_file "spec/rails_helper.rb", rails_helper_data
       remove_dir "test"
@@ -17,6 +17,7 @@ module Embryo
 'RSpec.configure do |config|
   config.color = true
   config.order = :random
+  config.disable_monkey_patching!
   config.mock_with :rspec do |mocks|
     mocks.verify_partial_doubles = true
   end

data/lib/rails-embryo/ruby_template/action/create.rb

@@ -0,0 +1,25 @@
+require "rails-embryo/ruby_template/action"
+
+module Embryo
+  class RubyTemplate::Action::Create < RubyTemplate::Action
+    def controller_method_code
+      method_code :create,
+        "@#{model.singular} = #{model.class_name}.new #{model.singular}_params",
+        "if @#{model.singular}.save",
+        indent("redirect_to #{@model.plural_symbol}_path, notice: \"#{model.singular.capitalize} created.\""),
+        "else",
+        indent("render :new"),
+        "end"
+    end
+
+    def controller_spec_code
+      spec_group_code "#create",
+        spec_context_code("with valid attributes",
+          spec_before_code("post :create, #{model.singular}: attributes_for(:#{model.symbol})"),
+          spec_code("creates a new #{model.singular}",
+            "expect(assigns :#{model.singular}).to be_a #{model.class_name}"),
+          spec_code("redirects to the index on success",
+            "expect(response).to redirect_to #{model.plural_symbol}_path"))
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/action/destroy.rb

@@ -0,0 +1,27 @@
+require "rails-embryo/ruby_template/action"
+
+module Embryo
+  class RubyTemplate::Action::Destroy < RubyTemplate::Action
+    def controller_method_code
+      method_code :destroy,
+        "if @#{model.singular}.destroy",
+        indent("redirect_to #{@model.plural_symbol}_path, notice: \"#{model.singular.capitalize} deleted.\""),
+        "else",
+        indent("redirect_to #{@model.plural_symbol}_path, alert: \"Couldn't delete #{model.singular}.\""),
+        "end"
+    end
+
+    def controller_spec_code
+      spec_group_code "#destroy",
+        spec_context_code("when successful",
+          spec_before_code(
+            "@#{model.singular} = create :#{model.symbol}",
+            "delete :destroy, id: @#{model.singular}.id"
+          ),
+          spec_code("destroys the #{model.singular}",
+            "expect(#{model.class_name}.all).not_to include @#{model.singular}"),
+          spec_code("redirects to the index",
+            "expect(response).to redirect_to #{model.plural_symbol}_path"))
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/action/index.rb

@@ -0,0 +1,18 @@
+require "rails-embryo/ruby_template/action"
+
+module Embryo
+  class RubyTemplate::Action::Index < RubyTemplate::Action
+    def controller_method_code
+      method_code :index, "@#{model.plural} = #{model.class_name}.all"
+    end
+
+    def controller_spec_code
+      spec_group_code "#index",
+        spec_code("assigns the collection of #{model.plural}",
+          "#{model.singular} = create :#{model.symbol}",
+          "get :index",
+          "expect(assigns :#{model.plural}).to eq [#{model.singular}]"),
+        spec_code("succeeds", "get :index", "expect(response).to be_success")
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/action/new.rb

@@ -0,0 +1,17 @@
+require "rails-embryo/ruby_template/action"
+
+module Embryo
+  class RubyTemplate::Action::New < RubyTemplate::Action
+    def controller_method_code
+      method_code :new, "@#{model.singular} = #{model.class_name}.new"
+    end
+
+    def controller_spec_code
+      spec_group_code "#new",
+        spec_code("assigns a new #{model.singular}",
+          "get :new",
+          "expect(assigns :#{model.singular}).to be_a_new #{model.class_name}"),
+        spec_code("succeeds", "get :new", "expect(response).to be_success")
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/action/show.rb

@@ -0,0 +1,20 @@
+require "rails-embryo/ruby_template/action"
+
+module Embryo
+  class RubyTemplate::Action::Show < RubyTemplate::Action
+    def controller_method_code
+      method_code :show
+    end
+
+    def controller_spec_code
+      spec_group_code "#show",
+        spec_before_code(
+          "@#{model.singular} = create :#{model.symbol}",
+          "get :show, id: @#{model.singular}.id"),
+        spec_code("assigns the widget",
+          "expect(assigns :#{model.singular}).to eq @#{model.singular}"),
+        spec_code("succeeds",
+          "expect(response).to be_success")
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/action/update.rb

@@ -0,0 +1,23 @@
+require "rails-embryo/ruby_template/action"
+
+module Embryo
+  class RubyTemplate::Action::Update < RubyTemplate::Action
+    def controller_method_code
+      method_code :update,
+        "if @#{model.singular}.update_attributes #{model.singular}_params",
+        indent("redirect_to #{@model.plural_symbol}_path, notice: \"#{model.singular.capitalize} updated.\""),
+        "else",
+        indent("render :show"),
+        "end"
+    end
+
+    def controller_spec_code
+      spec_group_code "#update",
+        spec_context_code("with valid attributes",
+          spec_code("redirects to the index",
+            "@#{model.singular} = create :#{model.symbol}",
+            "post :update, id: @#{model.singular}.id, #{model.singular}: attributes_for(:#{model.symbol})",
+            "expect(response).to redirect_to #{model.plural_symbol}_path"))
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/action.rb

@@ -0,0 +1,31 @@
+require "rails-embryo/ruby_template"
+
+module Embryo
+  class RubyTemplate::Action < RubyTemplate
+    def initialize(model)
+      @model = model
+    end
+
+    protected
+
+    def model
+      @model
+    end
+
+    def spec_group_code(name, *specs)
+      ["describe #{name.inspect} do", *indent_separated(specs), "end"]
+    end
+
+    def spec_context_code(name, *specs)
+      ["context #{name.inspect} do", *indent_separated(specs), "end"]
+    end
+
+    def spec_before_code(*code)
+      ["before do", *indent(code), "end"]
+    end
+
+    def spec_code(name, *code)
+      ["it #{name.inspect} do", *indent(code), "end"]
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/controller.rb

@@ -0,0 +1,44 @@
+require "rails-embryo/ruby_template"
+
+module Embryo
+  class RubyTemplate::Controller < RubyTemplate
+    def initialize(model, action_templates)
+      @model = model
+      @action_templates = action_templates
+    end
+
+    def path
+      "app/controllers/#{@model.plural_path}_controller.rb"
+    end
+
+    protected
+
+    def code
+      [
+       "class #{@model.plural_class_name}Controller < ApplicationController",
+       indent("before_action :find_#{@model.singular}, only: [:show, :update, :destroy]"),
+       *indented_action_methods,
+       indent_section("private"),
+       indent_section(finder_method),
+       indent_section(params_method),
+       "end"
+      ]
+    end
+
+    def indented_action_methods
+      @action_templates.map do |action|
+        indent_section action.controller_method_code
+      end
+    end
+
+    def finder_method
+      method_code "find_#{@model.singular}",
+        "@#{@model.singular} = #{@model.class_name}.find params[:id]"
+    end
+
+    def params_method
+      method_code "#{@model.singular}_params",
+        "params.fetch(:#{@model.singular})"
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/controller_spec.rb

@@ -0,0 +1,26 @@
+require "rails-embryo/ruby_template"
+
+module Embryo
+  class RubyTemplate::ControllerSpec < RubyTemplate
+    def initialize(model, action_templates)
+      @model = model
+      @action_templates = action_templates
+    end
+
+    def path
+      "spec/controllers/#{@model.plural_path}_controller_spec.rb"
+    end
+
+    protected
+
+    def code
+      [
+       "require 'rails_helper'",
+       "",
+       "RSpec.describe #{@model.plural_class_name}Controller do",
+       *indent_separated(@action_templates.map(&:controller_spec_code)),
+       "end"
+      ]
+    end
+  end
+end

data/lib/rails-embryo/ruby_template/model.rb

@@ -0,0 +1,43 @@
+require "active_support/core_ext/string"
+
+module Embryo
+  class RubyTemplate
+    class Model
+      def initialize(name)
+        @name = name.singularize
+      end
+
+      def path
+        @name.underscore
+      end
+
+      def plural_path
+        path.pluralize
+      end
+
+      def singular
+        path.split("/").last
+      end
+
+      def plural
+        singular.pluralize
+      end
+
+      def class_name
+        @name.camelize
+      end
+
+      def plural_class_name
+        class_name.pluralize
+      end
+
+      def symbol
+        path.gsub("/", "_")
+      end
+
+      def plural_symbol
+        symbol.pluralize
+      end
+    end
+  end
+end

data/lib/rails-embryo/ruby_template.rb

@@ -0,0 +1,39 @@
+module Embryo
+  class RubyTemplate
+    def text
+      code.join("\n") + "\n"
+    end
+
+    protected
+
+    def indent(code)
+      if code.is_a? Array
+        code.map { |sub_code| indent sub_code }
+      elsif code == ""
+        ""
+      else
+        "  " + code
+      end
+    end
+
+    def indent_section(code)
+      if code.is_a? Array
+        [""] + indent(code)
+      else
+        ["", indent(code)]
+      end
+    end
+
+    def indent_separated(code)
+      if code.is_a? Array
+        code.flat_map { |c| [indent(c), ""] }[0...-1]
+      else
+        indent code
+      end
+    end
+
+    def method_code(name, *code)
+      ["def #{name}", *indent(code), "end"]
+    end
+  end
+end

data/lib/rails-embryo/version.rb

@@ -1,5 +1,5 @@
 module Rails
   module Embryo
-    VERSION = "0.3.0"
+    VERSION = "0.3.1"
   end
 end

data/lib/rails-embryo.rb

@@ -2,6 +2,7 @@ require "rails-embryo/version"
 require "rails-embryo/generator_helpers/hidden"
 require "rails-embryo/generator_helpers/files"
 require "generators/embryo"
+require "generators/embryo/controller"
 require "generators/embryo/model"
 require "generators/embryo/model/authenticated"
 require "rails/railtie"

metadata

@@ -1,18 +1,20 @@
 --- !ruby/object:Gem::Specification
 name: rails-embryo
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
+  prerelease: 
 platform: ruby
 authors:
 - Brian Auton
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-14 00:00:00.000000000 Z
+date: 2014-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
@@ -20,6 +22,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
@@ -27,6 +30,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
@@ -34,6 +38,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
@@ -41,6 +46,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
@@ -48,6 +54,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
@@ -60,48 +67,61 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- History.md
-- License.txt
-- README.md
-- bin/rails-embryo
-- lib/generators/embryo.rb
+- lib/rails-embryo/ruby_template/controller.rb
+- lib/rails-embryo/ruby_template/controller_spec.rb
+- lib/rails-embryo/ruby_template/model.rb
+- lib/rails-embryo/ruby_template/action.rb
+- lib/rails-embryo/ruby_template/action/create.rb
+- lib/rails-embryo/ruby_template/action/new.rb
+- lib/rails-embryo/ruby_template/action/destroy.rb
+- lib/rails-embryo/ruby_template/action/show.rb
+- lib/rails-embryo/ruby_template/action/index.rb
+- lib/rails-embryo/ruby_template/action/update.rb
+- lib/rails-embryo/generator_helpers/files.rb
+- lib/rails-embryo/generator_helpers/hidden.rb
+- lib/rails-embryo/version.rb
+- lib/rails-embryo/ruby_template.rb
+- lib/rails-embryo.rb
+- lib/generators/embryo/controller.rb
+- lib/generators/embryo/model/authenticated.rb
+- lib/generators/embryo/factory_girl.rb
 - lib/generators/embryo/application.rb
 - lib/generators/embryo/capybara.rb
 - lib/generators/embryo/default_view.rb
-- lib/generators/embryo/devise.rb
-- lib/generators/embryo/factory_girl.rb
 - lib/generators/embryo/model.rb
-- lib/generators/embryo/model/authenticated.rb
-- lib/generators/embryo/poltergeist.rb
 - lib/generators/embryo/postgres.rb
-- lib/generators/embryo/rspec.rb
 - lib/generators/embryo/template_support.rb
-- lib/rails-embryo.rb
-- lib/rails-embryo/generator_helpers/files.rb
-- lib/rails-embryo/generator_helpers/hidden.rb
-- lib/rails-embryo/version.rb
+- lib/generators/embryo/devise.rb
+- lib/generators/embryo/poltergeist.rb
+- lib/generators/embryo/rspec.rb
+- lib/generators/embryo.rb
+- README.md
+- History.md
+- License.txt
+- bin/rails-embryo
 homepage: http://github.com/brianauton/rails-embryo
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 1.8.29
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Generators for quick setup of advanced Rails practices
 test_files: []

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: e3f4ad3fec63bed5cd7163c4e0324cdf91ff68a5
-  data.tar.gz: f84aec31ccfaa312d3e3a11224770863e757c9dc
-SHA512:
-  metadata.gz: e035eb9df84d3977804a7a9bacc5263bd4978bc234c0b87678a2ff80930332104adb5ef3e0497f7f3317200885637c4092d7df22e4e5c55f20bbb511f46e0768
-  data.tar.gz: 10e4aa4adef14787d8c83983e84c1b0b177fac2bc9167a836ffed6c721859e713e925ff2338ab894ad80179bb8b0075f04ba4ac8925a2c336f3831a7f0bd40d7