rails-dom-testing 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 61edc9fa5e40088f189be03e372c57a555e4794f
-  data.tar.gz: 6c0cde2f592e0fb52435d686c814907ef203ed97
+  metadata.gz: ecf036ed0fe5b943276e875fe22bdbd0cd892393
+  data.tar.gz: f11502f55645a79cade3028f47d0b83ae19db6c4
 SHA512:
-  metadata.gz: 529f62430db89db452a82c13ee2aa575c8e288a50923c6e954941805589431d4bb03a228eb6b9828afbe0ffb26f796d3007a948abaa08fc2b07b1364b5953526
-  data.tar.gz: 574f7c7d88a42632d46efa89ac038d0f154584aef74dc314075f09e9327d33e8d7fa42304864b74fa466bc01aa8eb3fe80112d3f094d02344d79b618d376117a
+  metadata.gz: e4defef0a38057db0d5f8b0864cfb81aa4c25f6af1d4f392c03287689d8c3a7e9d13e00eb796d3c48d7f23e52028edf8cf1f74f995ff588838222d84a6ece940
+  data.tar.gz: 31a3ccadafc9a27f12024a69b16f1cac994780f64ba43c1cf6932c4824f88a24ceba1e314904c131b8c103e3094ccb2329c7c7bb0c6b13f2967e0c3ddd6f477b

data/README.md

@@ -5,13 +5,9 @@ Doms are compared via `assert_dom_equal` and `assert_dom_not_equal`.
 Elements are asserted via `assert_select`, `assert_select_encoded`, `assert_select_email` and a subset of the dom can be selected with `css_select`.
 The gem is developed for Rails 4.2 and above, and will not work on previous versions.
 
-## Deprecation warnings when upgrading to Rails 4.2:
+## Nokogiri::CSS::SyntaxError exceptions when upgrading to Rails 4.2:
 
-Nokogiri is slightly more strict about the format of css selectors than the previous implementation. That's why you have warnings like:
-
-```
-DEPRECATION WARNING: The assertion was not run because of an invalid css selector.
-```
+Nokogiri is slightly stricter about the format of CSS selectors than the previous implementation.
 
 Check the 4.2 release notes [section on `assert_select`](http://edgeguides.rubyonrails.org/4_2_release_notes.html#assert-select) for help.
 

data/lib/rails/dom/testing/assertions/selector_assertions.rb

@@ -62,9 +62,6 @@ module Rails
           root = args.size == 1 ? document_root_element : args.shift
 
           nodeset(root).css(args.first)
-        rescue Nokogiri::CSS::SyntaxError => e
-          ActiveSupport::Deprecation.warn("The assertion was not run because of an invalid css selector.\n#{e}", caller(2))
-          return
         end
 
         # An assertion that selects elements and makes one or more equality tests.
@@ -177,9 +174,6 @@ module Rails
 
             nest_selection(matches, &block) if block_given? && !matches.empty?
           end
-        rescue Nokogiri::CSS::SyntaxError => e
-          ActiveSupport::Deprecation.warn("The assertion was not run because of an invalid css selector.\n#{e}", caller(2))
-          return
         end
 
         # Extracts the content of an element, treats it as encoded HTML and runs

data/lib/rails/dom/testing/version.rb

@@ -1,7 +1,7 @@
 module Rails
   module Dom
     module Testing
-      VERSION = "2.0.0"
+      VERSION = "2.0.1"
     end
   end
 end

data/test/selector_assertions_test.rb

@@ -220,15 +220,15 @@ class AssertSelectTest < ActiveSupport::TestCase
   # testing invalid selectors
   def test_assert_select_with_invalid_selector
     render_html '<a href="http://example.com">hello</a>'
-    assert_deprecated do
-      assert_nil assert_select("[href=http://example.com]")
+    assert_raises Nokogiri::CSS::SyntaxError do
+      assert_select("[href=http://example.com]")
     end
   end
 
   def test_css_select_with_invalid_selector
     render_html '<a href="http://example.com">hello</a>'
-    assert_deprecated do
-      assert_nil css_select("[href=http://example.com]")
+    assert_raises Nokogiri::CSS::SyntaxError do
+      css_select("[href=http://example.com]")
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-dom-testing
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Rafael Mendonça França
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-08 00:00:00.000000000 Z
+date: 2016-06-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri