rails-cache-tags 1.0.0 → 1.1.0

data/.gitignore

@@ -15,4 +15,5 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
-.idea
+.idea
+gemfiles

data/Appraisals

@@ -0,0 +1,11 @@
+appraise "rails3.0" do
+  gem "rails", "~> 3.0.0"
+end
+
+appraise "rails3.1" do
+  gem "rails", "~> 3.1.0"
+end
+
+appraise "rails3.2" do
+  gem "rails", "~> 3.2.0"
+end

data/Rakefile

@@ -1,5 +1,6 @@
 #!/usr/bin/env rake
 require "bundler/gem_tasks"
+require 'appraisal'
 
 desc 'Run tests'
 task :test do

data/lib/rails/cache/tag.rb

@@ -1,12 +1,14 @@
+require "active_support/cache"
+
 module Rails
   module Cache
     class Tag #:nodoc:all:
       KEY_PREFIX = '_tags'
 
       class << self
-        # {:post => ['1', '2', '3']} => [Tag(post:1), Tag(post:2), Tag(post:3)]
-        # {:post => 1, :user => 2} => [Tag(post:1), Tag(user:2)]
-        # ['post:1', 'post:2', 'post:3'] => [Tag(post:1), Tag(post:2), Tag(post:3)]
+        # {:post => ['1', '2', '3']} => [Tag(post/1), Tag(post/2), Tag(post/3)]
+        # {:post => 1, :user => 2} => [Tag(post/1), Tag(user/2)]
+        # ['post/1', 'post/2', 'post/3'] => [Tag(post/1), Tag(post/2), Tag(post/3)]
         def build_tags(names)
           case names
             when NilClass then nil
@@ -22,13 +24,9 @@ module Rails
 
       attr_reader :name
 
-      # Tag constructor, accepts String, Symbol and Array
+      # Tag constructor
       def initialize(name)
-        @name = case name
-          when String, Symbol then name
-          when Array then name.join(':')
-          else raise ArgumentError
-        end
+        @name = ActiveSupport::Cache.expand_cache_key name
       end
 
       # real cache key

data/lib/rails/cache/tags/store.rb

@@ -1,3 +1,5 @@
+# coding: utf-8
+
 module Rails
   module Cache
     module Tags

data/lib/rails/cache/tags/version.rb

@@ -1,7 +1,7 @@
 module Rails
   module Cache
     module Tags
-      VERSION = "1.0.0"
+      VERSION = "1.1.0"
     end
   end
 end

data/lib/rails-cache-tags.rb

@@ -1,5 +1,7 @@
 require "active_support/cache"
 
+require "action_controller"
+
 require "rails/cache/tag"
 require "rails/cache/tags/store"
 
@@ -15,13 +17,11 @@ module ActiveSupport
   end
 end
 
-if defined?(ActionController::Base)
-  class ActionController::Base < ActionController::Metal
-    def expire_fragments_by_tags *args
-      return unless cache_configured?
+class ActionController::Base < ActionController::Metal
+  def expire_fragments_by_tags *args
+    return unless cache_configured?
 
-      cache_store.delete_tag *args
-    end
-    alias expire_fragments_by_tag expire_fragments_by_tags
+    cache_store.delete_tag *args
   end
+  alias expire_fragments_by_tag expire_fragments_by_tags
 end

data/rails-cache-tags.gemspec

@@ -14,9 +14,9 @@ Gem::Specification.new do |gem|
   gem.require_paths = %W(lib)
   gem.version       = Rails::Cache::Tags::VERSION
 
-  gem.add_dependency "activesupport", ">= 3.0"
-  gem.add_dependency "actionpack", ">= 3.0"
+  gem.add_dependency "rails", ">= 3.0"
 
+  gem.add_development_dependency 'appraisal'
   gem.add_development_dependency 'minitest', '~> 3.2'
   gem.add_development_dependency 'memcache-client'
   gem.add_development_dependency 'rack'

data/test/cache_tags_test.rb

@@ -57,6 +57,8 @@ module CacheTagsBehavior
 
   def test_exists_with_tags
     @cache.write("foo", "bar", :tags => "baz")
+    assert_equal @cache.exist?("foo"), true
+
     @cache.delete_tag("baz")
 
     assert_equal @cache.exist?("foo"), false
@@ -67,12 +69,26 @@ module CacheTagsBehavior
     assert_equal 'bar', @cache.read('foo')
   end
 
-  def test_read_and_write_with_tags_hash_after_expiration
+  def test_read_and_write_with_hash_of_tags
     @cache.write("foo", "bar", :tags => {:baz => 1})
+    assert_equal 'bar', @cache.read('foo')
+
     @cache.delete_tag :baz => 1
 
     assert_nil @cache.read('foo')
   end
+
+  def test_read_and_write_with_tags_array_of_objects
+    tag1 = 1.day.ago
+    tag2 = 2.days.ago
+
+    @cache.write("foo", "bar", :tags => [tag1, tag2])
+    assert_equal 'bar', @cache.read('foo')
+
+    @cache.delete_tag tag2
+
+    assert_nil @cache.read('foo')
+  end
 end
 
 [FileStoreTest, MemoryStoreTest, MemCacheStoreTest].each do |klass|

data/test/caching_test.rb

@@ -14,10 +14,8 @@ class CacheKeyTest < ActiveSupport::TestCase
       ENV['RAILS_CACHE_ID'] = 'c99'
       assert_equal 'c99/foo', ActiveSupport::Cache.expand_cache_key(:foo)
       assert_equal 'c99/foo', ActiveSupport::Cache.expand_cache_key([:foo])
-      assert_equal 'c99/foo/bar', ActiveSupport::Cache.expand_cache_key([:foo, :bar])
       assert_equal 'nm/c99/foo', ActiveSupport::Cache.expand_cache_key(:foo, :nm)
       assert_equal 'nm/c99/foo', ActiveSupport::Cache.expand_cache_key([:foo], :nm)
-      assert_equal 'nm/c99/foo/bar', ActiveSupport::Cache.expand_cache_key([:foo, :bar], :nm)
     ensure
       ENV['RAILS_CACHE_ID'] = nil
     end
@@ -43,7 +41,7 @@ class CacheKeyTest < ActiveSupport::TestCase
     end
   end
 
-  def test_expand_cache_key_respond_to_cache_key
+  def test_respond_to_cache_key
     key = 'foo'
     def key.cache_key
       :foo_key
@@ -51,25 +49,6 @@ class CacheKeyTest < ActiveSupport::TestCase
     assert_equal 'foo_key', ActiveSupport::Cache.expand_cache_key(key)
   end
 
-  def test_expand_cache_key_array_with_something_that_responds_to_cache_key
-    key = 'foo'
-    def key.cache_key
-      :foo_key
-    end
-    assert_equal 'foo_key', ActiveSupport::Cache.expand_cache_key([key])
-  end
-
-  def test_expand_cache_key_of_nil
-    assert_equal '', ActiveSupport::Cache.expand_cache_key(nil)
-  end
-
-  def test_expand_cache_key_of_false
-    assert_equal 'false', ActiveSupport::Cache.expand_cache_key(false)
-  end
-
-  def test_expand_cache_key_of_true
-    assert_equal 'true', ActiveSupport::Cache.expand_cache_key(true)
-  end
 end
 
 class CacheStoreSettingTest < ActiveSupport::TestCase
@@ -142,8 +121,8 @@ class CacheStoreNamespaceTest < ActiveSupport::TestCase
     cache.write("foo", "bar")
     cache.write("fu", "baz")
     cache.delete_matched(/^fo/)
-    assert !cache.exist?("foo")
-    assert cache.exist?("fu")
+    assert_equal false, cache.exist?("foo")
+    assert_equal true, cache.exist?("fu")
   end
 
   def test_delete_matched_key
@@ -151,15 +130,15 @@ class CacheStoreNamespaceTest < ActiveSupport::TestCase
     cache.write("foo", "bar")
     cache.write("fu", "baz")
     cache.delete_matched(/OO/i)
-    assert !cache.exist?("foo")
-    assert cache.exist?("fu")
+    assert_equal false, cache.exist?("foo")
+    assert_equal true, cache.exist?("fu")
   end
 end
 
 # Tests the base functionality that should be identical across all cache stores.
 module CacheStoreBehavior
   def test_should_read_and_write_strings
-    assert @cache.write('foo', 'bar')
+    assert_equal true, @cache.write('foo', 'bar')
     assert_equal 'bar', @cache.read('foo')
   end
 
@@ -194,40 +173,20 @@ module CacheStoreBehavior
   end
 
   def test_should_read_and_write_hash
-    assert @cache.write('foo', {:a => "b"})
+    assert_equal true, @cache.write('foo', {:a => "b"})
     assert_equal({:a => "b"}, @cache.read('foo'))
   end
 
   def test_should_read_and_write_integer
-    assert @cache.write('foo', 1)
+    assert_equal true, @cache.write('foo', 1)
     assert_equal 1, @cache.read('foo')
   end
 
   def test_should_read_and_write_nil
-    assert @cache.write('foo', nil)
+    assert_equal true, @cache.write('foo', nil)
     assert_equal nil, @cache.read('foo')
   end
 
-  def test_should_read_and_write_false
-    assert @cache.write('foo', false)
-    assert_equal false, @cache.read('foo')
-  end
-
-  def test_should_read_cached_numeric_from_previous_rails_versions
-    @old_cache = ActiveSupport::Cache::Entry.create( 1, Time.now )
-    assert_equal( 1, @old_cache.value )
-  end
-
-  def test_should_read_cached_hash_from_previous_rails_versions
-    @old_cache = ActiveSupport::Cache::Entry.create( {}, Time.now )
-    assert_equal( {}, @old_cache.value )
-  end
-
-  def test_should_read_cached_string_from_previous_rails_versions
-    @old_cache = ActiveSupport::Cache::Entry.create( 'string', Time.now )
-    assert_equal( 'string', @old_cache.value )
-  end
-
   def test_read_multi
     @cache.write('foo', 'bar')
     @cache.write('fu', 'baz')
@@ -243,13 +202,6 @@ module CacheStoreBehavior
     assert_equal({"fu" => "baz"}, @cache.read_multi('foo', 'fu'))
   end
 
-  def test_read_and_write_compressed_small_data
-    @cache.write('foo', 'bar', :compress => true)
-    raw_value = @cache.send(:read_entry, 'foo', {}).raw_value
-    assert_equal 'bar', @cache.read('foo')
-    assert_equal 'bar', Marshal.load(raw_value)
-  end
-
   def test_read_and_write_compressed_large_data
     @cache.write('foo', 'bar', :compress => true, :compress_threshold => 2)
     raw_value = @cache.send(:read_entry, 'foo', {}).raw_value
@@ -297,30 +249,22 @@ module CacheStoreBehavior
 
   def test_exist
     @cache.write('foo', 'bar')
-    assert @cache.exist?('foo')
-    assert !@cache.exist?('bar')
+    assert_equal true, @cache.exist?('foo')
+    assert_equal false, @cache.exist?('bar')
   end
 
   def test_nil_exist
     @cache.write('foo', nil)
-    assert @cache.exist?('foo')
+    assert_equal true, @cache.exist?('foo')
   end
 
   def test_delete
     @cache.write('foo', 'bar')
     assert @cache.exist?('foo')
-    assert @cache.delete('foo')
+    assert_equal true, @cache.delete('foo')
     assert !@cache.exist?('foo')
   end
 
-  def test_read_should_return_a_different_object_id_each_time_it_is_called
-    @cache.write('foo', 'bar')
-    assert_not_equal @cache.read('foo').object_id, @cache.read('foo').object_id
-    value = @cache.read('foo')
-    value << 'bingo'
-    assert_not_equal value, @cache.read('foo')
-  end
-
   def test_original_store_objects_should_not_be_immutable
     bar = 'bar'
     @cache.write('foo', bar)
@@ -381,10 +325,10 @@ module CacheStoreBehavior
 
   def test_crazy_key_characters
     crazy_key = "#/:*(<+=> )&$%@?;'\"\'`~-"
-    assert @cache.write(crazy_key, "1", :raw => true)
+    assert_equal true, @cache.write(crazy_key, "1", :raw => true)
     assert_equal "1", @cache.read(crazy_key)
     assert_equal "1", @cache.fetch(crazy_key)
-    assert @cache.delete(crazy_key)
+    assert_equal true, @cache.delete(crazy_key)
     assert_equal "2", @cache.fetch(crazy_key, :raw => true) { "2" }
     assert_equal 3, @cache.increment(crazy_key)
     assert_equal 2, @cache.decrement(crazy_key)
@@ -392,50 +336,13 @@ module CacheStoreBehavior
 
   def test_really_long_keys
     key = ""
-    900.times{key << "x"}
-    assert @cache.write(key, "bar")
+    1000.times{key << "x"}
+    assert_equal true, @cache.write(key, "bar")
     assert_equal "bar", @cache.read(key)
     assert_equal "bar", @cache.fetch(key)
     assert_nil @cache.read("#{key}x")
     assert_equal({key => "bar"}, @cache.read_multi(key))
-    assert @cache.delete(key)
-  end
-end
-
-# https://rails.lighthouseapp.com/projects/8994/tickets/6225-memcachestore-cant-deal-with-umlauts-and-special-characters
-# The error is caused by charcter encodings that can't be compared with ASCII-8BIT regular expressions and by special
-# characters like the umlaut in UTF-8.
-module EncodedKeyCacheBehavior
-  if defined?(Encoding)
-    Encoding.list.each do |encoding|
-      define_method "test_#{encoding.name.underscore}_encoded_values" do
-        key = "foo".force_encoding(encoding)
-        assert @cache.write(key, "1", :raw => true)
-        assert_equal "1", @cache.read(key)
-        assert_equal "1", @cache.fetch(key)
-        assert @cache.delete(key)
-        assert_equal "2", @cache.fetch(key, :raw => true) { "2" }
-        assert_equal 3, @cache.increment(key)
-        assert_equal 2, @cache.decrement(key)
-      end
-    end
-
-    def test_common_utf8_values
-      key = "\xC3\xBCmlaut".force_encoding(Encoding::UTF_8)
-      assert @cache.write(key, "1", :raw => true)
-      assert_equal "1", @cache.read(key)
-      assert_equal "1", @cache.fetch(key)
-      assert @cache.delete(key)
-      assert_equal "2", @cache.fetch(key, :raw => true) { "2" }
-      assert_equal 3, @cache.increment(key)
-      assert_equal 2, @cache.decrement(key)
-    end
-
-    def test_retains_encoding
-      key = "\xC3\xBCmlaut".force_encoding(Encoding::UTF_8)
-      assert @cache.write(key, "1", :raw => true)
-      assert_equal Encoding::UTF_8, key.encoding
-    end
+    assert_equal true, @cache.delete(key)
   end
 end
 
@@ -446,10 +353,10 @@ module CacheDeleteMatchedBehavior
     @cache.write("foo/bar", "baz")
     @cache.write("fu/baz", "bar")
     @cache.delete_matched(/oo/)
-    assert !@cache.exist?("foo")
-    assert @cache.exist?("fu")
-    assert !@cache.exist?("foo/bar")
-    assert @cache.exist?("fu/baz")
+    assert_equal false, @cache.exist?("foo")
+    assert_equal true, @cache.exist?("fu")
+    assert_equal false, @cache.exist?("foo/bar")
+    assert_equal true, @cache.exist?("fu/baz")
   end
 end
 
@@ -478,7 +385,7 @@ module LocalCacheBehavior
     retval = @cache.with_local_cache do
       @cache.write('foo', 'bar')
     end
-    assert retval
+    assert_equal true, retval
     assert_equal 'bar', @cache.read('foo')
   end
 
@@ -566,7 +473,6 @@ class FileStoreTest < ActiveSupport::TestCase
     Dir.mkdir(cache_dir) unless File.exist?(cache_dir)
     @cache = ActiveSupport::Cache.lookup_store(:file_store, cache_dir, :expires_in => 60)
     @peek = ActiveSupport::Cache.lookup_store(:file_store, cache_dir, :expires_in => 60)
-    @cache_with_pathname = ActiveSupport::Cache.lookup_store(:file_store, Pathname.new(cache_dir), :expires_in => 60)
   end
 
   def teardown
@@ -586,83 +492,17 @@ class FileStoreTest < ActiveSupport::TestCase
     key = @cache.send(:key_file_path, "views/index?id=1")
     assert_equal "views/index?id=1", @cache.send(:file_path_key, key)
   end
-
-  def test_key_transformation_with_pathname
-    FileUtils.touch(File.join(cache_dir, "foo"))
-    key = @cache_with_pathname.send(:key_file_path, "views/index?id=1")
-    assert_equal "views/index?id=1", @cache_with_pathname.send(:file_path_key, key)
-  end
-
-  # Because file systems have a maximum filename size, filenames > max size should be split in to directories
-  # If filename is 'AAAAB', where max size is 4, the returned path should be AAAA/B
-  def test_key_transformation_max_filename_size
-    key = "#{'A' * ActiveSupport::Cache::FileStore::FILENAME_MAX_SIZE}B"
-    path = @cache.send(:key_file_path, key)
-    assert path.split('/').all? { |dir_name| dir_name.size <= ActiveSupport::Cache::FileStore::FILENAME_MAX_SIZE}
-    assert_equal 'B', File.basename(path)
-  end
-
-  # If nothing has been stored in the cache, there is a chance the cache directory does not yet exist
-  # Ensure delete_matched gracefully handles this case
-  def test_delete_matched_when_cache_directory_does_not_exist
-    assert_nothing_raised(Exception) do
-      ActiveSupport::Cache::FileStore.new('/test/cache/directory').delete_matched(/does_not_exist/)
-    end
-  end
 end
 
 class MemoryStoreTest < ActiveSupport::TestCase
   def setup
-    @record_size = Marshal.dump("aaaaaaaaaa").bytesize
-    @cache = ActiveSupport::Cache.lookup_store(:memory_store, :expires_in => 60, :size => @record_size * 10)
+    @cache = ActiveSupport::Cache.lookup_store(:memory_store, :expires_in => 60, :size => 100)
   end
 
   include CacheStoreBehavior
   include CacheDeleteMatchedBehavior
   include CacheIncrementDecrementBehavior
 
-  def test_prune_size
-    @cache.write(1, "aaaaaaaaaa") && sleep(0.001)
-    @cache.write(2, "bbbbbbbbbb") && sleep(0.001)
-    @cache.write(3, "cccccccccc") && sleep(0.001)
-    @cache.write(4, "dddddddddd") && sleep(0.001)
-    @cache.write(5, "eeeeeeeeee") && sleep(0.001)
-    @cache.read(2) && sleep(0.001)
-    @cache.read(4)
-    @cache.prune(@record_size * 3)
-    assert @cache.exist?(5)
-    assert @cache.exist?(4)
-    assert !@cache.exist?(3)
-    assert @cache.exist?(2)
-    assert !@cache.exist?(1)
-  end
-
-  def test_prune_size_on_write
-    @cache.write(1, "aaaaaaaaaa") && sleep(0.001)
-    @cache.write(2, "bbbbbbbbbb") && sleep(0.001)
-    @cache.write(3, "cccccccccc") && sleep(0.001)
-    @cache.write(4, "dddddddddd") && sleep(0.001)
-    @cache.write(5, "eeeeeeeeee") && sleep(0.001)
-    @cache.write(6, "ffffffffff") && sleep(0.001)
-    @cache.write(7, "gggggggggg") && sleep(0.001)
-    @cache.write(8, "hhhhhhhhhh") && sleep(0.001)
-    @cache.write(9, "iiiiiiiiii") && sleep(0.001)
-    @cache.write(10, "kkkkkkkkkk") && sleep(0.001)
-    @cache.read(2) && sleep(0.001)
-    @cache.read(4) && sleep(0.001)
-    @cache.write(11, "llllllllll")
-    assert @cache.exist?(11)
-    assert @cache.exist?(10)
-    assert @cache.exist?(9)
-    assert @cache.exist?(8)
-    assert @cache.exist?(7)
-    assert !@cache.exist?(6)
-    assert !@cache.exist?(5)
-    assert @cache.exist?(4)
-    assert !@cache.exist?(3)
-    assert @cache.exist?(2)
-    assert !@cache.exist?(1)
-  end
 
   def test_pruning_is_capped_at_a_max_time
     def @cache.delete_entry (*args)
@@ -675,14 +515,26 @@ class MemoryStoreTest < ActiveSupport::TestCase
     @cache.write(4, "dddddddddd") && sleep(0.001)
     @cache.write(5, "eeeeeeeeee") && sleep(0.001)
     @cache.prune(30, 0.001)
-    assert @cache.exist?(5)
-    assert @cache.exist?(4)
-    assert @cache.exist?(3)
-    assert @cache.exist?(2)
-    assert !@cache.exist?(1)
+    assert_equal true, @cache.exist?(5)
+    assert_equal true, @cache.exist?(4)
+    assert_equal true, @cache.exist?(3)
+    assert_equal true, @cache.exist?(2)
+    assert_equal false, @cache.exist?(1)
   end
 end
 
+class SynchronizedStoreTest < ActiveSupport::TestCase
+  def setup
+    ActiveSupport::Deprecation.silence do
+      @cache = ActiveSupport::Cache.lookup_store(:memory_store, :expires_in => 60)
+    end
+  end
+
+  include CacheStoreBehavior
+  include CacheDeleteMatchedBehavior
+  include CacheIncrementDecrementBehavior
+end
+
 uses_memcached 'memcached backed store' do
   class MemCacheStoreTest < ActiveSupport::TestCase
     def setup
@@ -697,7 +549,6 @@ uses_memcached 'memcached backed store' do
     include CacheStoreBehavior
     include LocalCacheBehavior
     include CacheIncrementDecrementBehavior
-    include EncodedKeyCacheBehavior
 
     def test_raw_values
       cache = ActiveSupport::Cache.lookup_store(:mem_cache_store, :raw => true)
@@ -706,13 +557,6 @@ uses_memcached 'memcached backed store' do
       assert_equal "2", cache.read("foo")
     end
 
-    def test_raw_values_with_marshal
-      cache = ActiveSupport::Cache.lookup_store(:mem_cache_store, :raw => true)
-      cache.clear
-      cache.write("foo", Marshal.dump([]))
-      assert_equal [], cache.read("foo")
-    end
-
     def test_local_cache_raw_values
       cache = ActiveSupport::Cache.lookup_store(:mem_cache_store, :raw => true)
       cache.clear
@@ -721,73 +565,6 @@ uses_memcached 'memcached backed store' do
         assert_equal "2", cache.read("foo")
       end
     end
-
-    def test_local_cache_raw_values_with_marshal
-      cache = ActiveSupport::Cache.lookup_store(:mem_cache_store, :raw => true)
-      cache.clear
-      cache.with_local_cache do
-        cache.write("foo", Marshal.dump([]))
-        assert_equal [], cache.read("foo")
-      end
-    end
-  end
-end
-
-class NullStoreTest < ActiveSupport::TestCase
-  def setup
-    @cache = ActiveSupport::Cache.lookup_store(:null_store)
-  end
-
-  def test_clear
-    @cache.clear
-  end
-
-  def test_cleanup
-    @cache.cleanup
-  end
-
-  def test_write
-    assert_equal true, @cache.write("name", "value")
-  end
-
-  def test_read
-    @cache.write("name", "value")
-    assert_nil @cache.read("name")
-  end
-
-  def test_delete
-    @cache.write("name", "value")
-    assert_equal false, @cache.delete("name")
-  end
-
-  def test_increment
-    @cache.write("name", 1, :raw => true)
-    assert_nil @cache.increment("name")
-  end
-
-  def test_decrement
-    @cache.write("name", 1, :raw => true)
-    assert_nil @cache.increment("name")
-  end
-
-  def test_delete_matched
-    @cache.write("name", "value")
-    @cache.delete_matched(/name/)
-  end
-
-  def test_local_store_strategy
-    @cache.with_local_cache do
-      @cache.write("name", "value")
-      assert_equal "value", @cache.read("name")
-      @cache.delete("name")
-      assert_nil @cache.read("name")
-      @cache.write("name", "value")
-    end
-    assert_nil @cache.read("name")
-  end
-
-  def test_setting_nil_cache_store
-    assert ActiveSupport::Cache.lookup_store.class.name, ActiveSupport::Cache::NullStore.name
   end
 end
 
@@ -816,31 +593,24 @@ class CacheEntryTest < ActiveSupport::TestCase
     entry = ActiveSupport::Cache::Entry.create("raw", time, :compress => false, :expires_in => 300)
     assert_equal "raw", entry.raw_value
     assert_equal time.to_f, entry.created_at
-    assert !entry.compressed?
+    assert_nil entry.compressed?.presence
     assert_equal 300, entry.expires_in
   end
 
   def test_expired
     entry = ActiveSupport::Cache::Entry.new("value")
-    assert !entry.expired?, 'entry not expired'
+    assert_nil entry.expired?.presence
     entry = ActiveSupport::Cache::Entry.new("value", :expires_in => 60)
-    assert !entry.expired?, 'entry not expired'
+    assert_nil entry.expired?.presence
     time = Time.now + 61
     Time.stubs(:now).returns(time)
-    assert entry.expired?, 'entry is expired'
+    assert_equal true, entry.expired?
   end
 
   def test_compress_values
     entry = ActiveSupport::Cache::Entry.new("value", :compress => true, :compress_threshold => 1)
     assert_equal "value", entry.value
-    assert entry.compressed?
+    assert_equal true, entry.compressed?
     assert_equal "value", Marshal.load(Zlib::Inflate.inflate(entry.raw_value))
   end
-
-  def test_non_compress_values
-    entry = ActiveSupport::Cache::Entry.new("value")
-    assert_equal "value", entry.value
-    assert_equal "value", Marshal.load(entry.raw_value)
-    assert !entry.compressed?
-  end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-cache-tags
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-08 00:00:00.000000000Z
+date: 2012-07-09 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: &80939770 !ruby/object:Gem::Requirement
+  name: rails
+  requirement: &20365460 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,21 +21,21 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *80939770
+  version_requirements: *20365460
 - !ruby/object:Gem::Dependency
-  name: actionpack
-  requirement: &80939520 !ruby/object:Gem::Requirement
+  name: appraisal
+  requirement: &20364680 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: '3.0'
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
-  version_requirements: *80939520
+  version_requirements: *20364680
 - !ruby/object:Gem::Dependency
   name: minitest
-  requirement: &80939250 !ruby/object:Gem::Requirement
+  requirement: &20363940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: '3.2'
   type: :development
   prerelease: false
-  version_requirements: *80939250
+  version_requirements: *20363940
 - !ruby/object:Gem::Dependency
   name: memcache-client
-  requirement: &80938990 !ruby/object:Gem::Requirement
+  requirement: &20363440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80938990
+  version_requirements: *20363440
 - !ruby/object:Gem::Dependency
   name: rack
-  requirement: &80938690 !ruby/object:Gem::Requirement
+  requirement: &20362660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80938690
+  version_requirements: *20362660
 - !ruby/object:Gem::Dependency
   name: mocha
-  requirement: &80938320 !ruby/object:Gem::Requirement
+  requirement: &20361940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80938320
+  version_requirements: *20361940
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &80937860 !ruby/object:Gem::Requirement
+  requirement: &20361520 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,7 +87,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *80937860
+  version_requirements: *20361520
 description: Tagged caching support for Rails
 email:
 - amikhailov83@gmail.com
@@ -96,6 +96,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- Appraisals
 - Gemfile
 - LICENSE
 - README.md
@@ -120,12 +121,18 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1686496298142022939
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: -1686496298142022939
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.17