rails-auth 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 91890f235f52285df442021821f7cafe571d159d
-  data.tar.gz: 317be3357a00fe49de1e6f6e35e143887c6cd8ab
+  metadata.gz: 5b48234e95be0db7806d0126d60590261a585409
+  data.tar.gz: 02ae7923ef2a6f12da93fbe0ecea10818c167fb5
 SHA512:
-  metadata.gz: 5d922c273e1ea6bcc90c9dbd7b4c46a44e4d26f350162ecc48cfd5b9412b98242f5ce51a4191729a68c9d86d83bee0879c4e7c407393b8bff309ee30be0cc7bb
-  data.tar.gz: 50c8da3ad9fada2f4347f42090e685103b851771f58d61d14e3d4939937a062017fdf107c57c4ede0ef4c2f392f5b0522c08f493e516c486e6682a2672939c74
+  metadata.gz: ffac862f2da1d9054751ba8bdcd05cc292851ce87bf0fea120eb9ec001003bee782b7740f400ef9e02e0a6dd634ab668a96f347e3313391f1bbdd6e7c3b82a39
+  data.tar.gz: 1a6a4ed4a30071156042b36755ae8db7ae1b8cc749ba5fad792970ab588e9f051be9199a90af78a60ef0abc59f4befb092785d6e8256872e9ea0ae3401f59c07

data/.travis.yml

@@ -1,16 +1,21 @@
 language: ruby
 sudo: false
+branches:
+  only:
+    - master
 
 before_install:
   - gem install bundler
 
+bundler_args: --without development
+
 rvm:
   - 2.0.0
-  - 2.1.8
+  - 2.1.10
   - 2.2.4
   - 2.3.0
 matrix:
   include:
-    - rvm: jruby-9.0.4.0
+    - rvm: jruby-9.0.5.0
       env: JRUBY_OPTS="--debug" # for simplecov
   fast_finish: true

data/CHANGES.md

@@ -1,3 +1,13 @@
+### 0.4.1 (2016-04-23)
+
+* [#17](https://github.com/square/rails-auth/pull/17)
+  Use PATH_INFO instead of REQUEST_PATH.
+  ([@tarcieri])
+
+* [#15](https://github.com/square/rails-auth/pull/15)
+  Check types more thoroughly when parsing ACLs.
+  ([@tarcieri])
+
 ### 0.4.0 (2016-03-14)
 
 * [#14](https://github.com/square/rails-auth/pull/14)

data/Gemfile

@@ -4,7 +4,8 @@ group :development do
   gem "guard-rspec"
 end
 
-group :test do
+group :development, :test do
+  gem "rake"
   gem "rspec"
   gem "rubocop", "0.38.0"
   gem "coveralls", require: false

data/README.md

@@ -73,7 +73,7 @@ policies around them.
 Below is a comparison of how Rails::Auth relates to the existing landscape
 of Rails AuthN and AuthZ libraries. These are grouped into two different
 categories: libraries Rails::Auth replaces, and libraries with which 
-Rails::Auth can be used in a complimentary fashion.
+Rails::Auth can be used in a complementary fashion.
 
 ### Replaces:
 
@@ -93,7 +93,7 @@ Rails::Auth can be used in a complimentary fashion.
   easily support [claims-based identity] systems where user identity
   is outsourced to a separate microservice.
 
-### Compliments:
+### Complements:
 
 * [Pundit]: Domain object-centric fine-grained authorization using clean
   object-oriented APIs. Pundit makes authorization decisions around particular

data/lib/rails/auth/acl.rb

@@ -22,9 +22,13 @@ module Rails
       # @param [Hash] :matchers predicate matchers for use with this ACL
       #
       def initialize(acl, matchers: {})
+        raise TypeError, "expected Array for acl, got #{acl.class}" unless acl.is_a?(Array)
+
         @resources = []
 
-        acl.each_with_index do |entry|
+        acl.each do |entry|
+          raise TypeError, "expected Hash for acl entry, got #{entry.class}" unless entry.is_a?(Hash)
+
           resources = entry["resources"]
           raise ParseError, "no 'resources' key present in entry: #{entry.inspect}" unless resources
 

data/lib/rails/auth/acl/resource.rb

@@ -58,7 +58,7 @@ module Rails
         #
         def match!(env)
           return false unless @http_methods.nil? || @http_methods.include?(env["REQUEST_METHOD".freeze])
-          return false unless @path =~ env["REQUEST_PATH".freeze]
+          return false unless @path =~ env["PATH_INFO".freeze]
           return false unless @host.nil? || @host =~ env["HTTP_HOST".freeze]
           true
         end

data/lib/rails/auth/error_page/debug_page.html.erb

@@ -72,7 +72,7 @@
         </tr>
         <tr>
           <td class="label">Path</td>
-          <td><%= h(env["REQUEST_PATH"]) %></td>
+          <td><%= h(env["PATH_INFO"]) %></td>
         </tr>
         <tr>
           <td class="label">Host</td>

data/lib/rails/auth/rspec/helper_methods.rb

@@ -35,7 +35,7 @@ module Rails
 
             env = {
               "REQUEST_METHOD" => method,
-              "REQUEST_PATH"   => self.class.description
+              "PATH_INFO"      => self.class.description
             }
 
             certificates.each do |type, value|

data/lib/rails/auth/version.rb

@@ -3,6 +3,6 @@
 module Rails
   # Pluggable authentication and authorization for Rack/Rails
   module Auth
-    VERSION = "0.4.0".freeze
+    VERSION = "0.4.1".freeze
   end
 end

data/spec/rails/auth/acl_spec.rb

@@ -11,6 +11,12 @@ RSpec.describe Rails::Auth::ACL do
     )
   end
 
+  describe "#initialize" do
+    it "raises TypeError if given a non-Array ACL type" do
+      expect { described_class.new(:bogus) }.to raise_error(TypeError)
+    end
+  end
+
   describe "#match" do
     it "matches routes against the ACL" do
       expect(example_acl.match(env_for(:get, "/"))).to eq true

data/spec/spec_helper.rb

@@ -18,9 +18,10 @@ def fixture_path(*args)
   Pathname.new(File.expand_path("../fixtures", __FILE__)).join(*args)
 end
 
-def env_for(method, path)
+def env_for(method, path, host = "127.0.0.1")
   {
     "REQUEST_METHOD" => method.to_s.upcase,
-    "REQUEST_PATH"   => path
+    "PATH_INFO"      => path,
+    "HTTP_HOST"      => host
   }
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rails-auth
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Tony Arcieri
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-03-15 00:00:00.000000000 Z
+date: 2016-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack