rails-ai-context 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e7442b6a28d089867479cba4a99d6f0fcf64e34f692d8c47b576de8e7ec4ffd
-  data.tar.gz: 0b8b21e8c1581a056afbb03e3ef6b3c45a62c7fbb61d345bbec49d370c4fd191
+  metadata.gz: 5d0ee652e69687c50687cd1b13209688aa5eecc24cf892fa807f9a3d03c7f2de
+  data.tar.gz: e689153ebb668ead61eb375c551a4724c73ce9338ae78a48b6acae63b9a63266
 SHA512:
-  metadata.gz: e1bd3b280678917a3b94576cef271669fc6892ca32cfd522b88a4c7cee93d73d4301b6d995bd75e78fd64bb448f5e226013b8678411bfd56e68de0a59ccba35b
-  data.tar.gz: a57fed3f44c4e1599854caf8243a35f62476f487e8b14a41489bcaee1efb4e8398935211ea9073ca70f9a1e34c16a6fa13d79cdaa5cf943d6f0d5d2e82ea100c
+  metadata.gz: 415542e44483875ce828fb3476d7d76a84d3df8a3ad3b4a8e512b649563e74bbc570244c5669d16fad7af574d2eb60c8e07fc743dc0126cfcdb4d728fd5b55f5
+  data.tar.gz: e8bc26c2edf09e86eee60b70adeee830b4ed9df130a5da5b658f721077d50cb21d496e677fae0dec7059d7416192b9c0ed27727f786ef76a2522aa63be16a025

data/CHANGELOG.md

@@ -5,6 +5,20 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.2.1] - 2026-03-23
+
+### Fixed
+
+- **New models now discovered via filesystem fallback** — when `ActiveRecord::Base.descendants` misses a newly created model, the introspector scans `app/models/*.rb` and constantizes them. Fixes model invisibility until MCP restart.
+- **Devise meta-methods no longer fill class/instance method caps** — filtered 40+ Devise-generated methods (authentication_keys=, email_regexp=, password_required?, etc.). Source-defined methods now prioritized over reflection-discovered ones.
+- **Controller `unless:`/`if:` conditions now extracted** — filters like `before_action :authenticate_user!, unless: :devise_controller?` now show the condition. Previously silently dropped.
+- **Empty string defaults shown as `""`** — schema tool now renders `""` instead of a blank cell for empty string defaults. AI can distinguish "no default" from "empty string default".
+- **Implicit belongs_to validations labeled** — `presence on user` from `belongs_to :user` now shows `_(implicit from belongs_to)_` and filters phantom `(message: required)` options.
+- **Array columns shown as `type[]`** in generated rules — `string` columns with `array: true` now render as `string[]` in schema rules.
+- **External ID columns no longer hidden** — columns like `paymongo_checkout_id` and `stripe_payment_id` are now shown in schema rules. Only conventional Rails FK columns (matching a table name) are filtered.
+- **Column defaults shown in generated rules** — columns with non-nil defaults now show `(=value)` inline.
+- **`analyze_feature` matches models by table name and underscore form** — `feature:"share"` now finds `CookShare` (via `cook_shares` table and `cook_share` underscore form), not just exact model name substring.
+
 ## [1.2.0] - 2026-03-23
 
 ### Added

data/lib/rails_ai_context/introspectors/controller_introspector.rb

@@ -167,6 +167,8 @@ module RailsAiContext
               if (sc = source_constraints[f[:name]])
                 f[:only] = sc[:only] if sc[:only]&.any?
                 f[:except] = sc[:except] if sc[:except]&.any?
+                f[:unless] = sc[:unless] if sc[:unless]
+                f[:if] = sc[:if] if sc[:if]
               end
             end
             return reflection_filters
@@ -221,6 +223,15 @@ module RailsAiContext
           except = parse_action_constraint(line, "except")
           filter[:only] = only if only&.any?
           filter[:except] = except if except&.any?
+
+          # Extract conditional modifiers (unless:, if:)
+          if (unless_match = line.match(/unless:\s*:(\w+[?!]?)/))
+            filter[:unless] = unless_match[1]
+          end
+          if (if_match = line.match(/\bif:\s*:(\w+[?!]?)/))
+            filter[:if] = if_match[1]
+          end
+
           filters << filter
         end
         filters

data/lib/rails_ai_context/introspectors/model_introspector.rb

@@ -47,11 +47,33 @@ module RailsAiContext
       def discover_models
         return [] unless defined?(ActiveRecord::Base)
 
-        ActiveRecord::Base.descendants.reject do |model|
+        models = ActiveRecord::Base.descendants.reject do |model|
           model.abstract_class? ||
             model.name.nil? ||
             config.excluded_models.include?(model.name)
-        end.sort_by(&:name)
+        end
+
+        # Filesystem fallback — discover model files not yet loaded by descendants
+        models_dir = File.join(app.root.to_s, "app", "models")
+        if Dir.exist?(models_dir)
+          known = models.map(&:name).to_set
+          Dir.glob(File.join(models_dir, "**", "*.rb")).each do |path|
+            relative = path.sub("#{models_dir}/", "").sub(/\.rb\z/, "")
+            class_name = relative.camelize
+            next if known.include?(class_name)
+            next if config.excluded_models.include?(class_name)
+
+            begin
+              klass = class_name.constantize
+              next unless klass < ActiveRecord::Base && !klass.abstract_class?
+              models << klass
+            rescue NameError, LoadError
+              # Not a valid model class
+            end
+          end
+        end
+
+        models.uniq.sort_by(&:name)
       end
 
       def extract_model_details(model)
@@ -196,29 +218,116 @@ module RailsAiContext
         RailsAiContext.configuration.excluded_concerns.any? { |pattern| name.match?(pattern) }
       end
 
+      DEVISE_CLASS_METHOD_PATTERNS = %w[
+        authentication_keys= case_insensitive_keys= strip_whitespace_keys=
+        reset_password_keys= confirmation_keys= unlock_keys=
+        email_regexp= password_length= timeout_in= remember_for=
+        sign_in_after_reset_password= sign_in_after_change_password=
+        reconfirmable= extend_remember_period= pepper=
+        stretches= allow_unconfirmed_access_for=
+        confirm_within= remember_for= unlock_in=
+        lock_strategy= unlock_strategy= maximum_attempts=
+        paranoid= last_attempt_warning=
+      ].to_set.freeze
+
       def extract_public_class_methods(model)
         scope_names = extract_scopes(model).map(&:to_s)
-        (model.methods - ActiveRecord::Base.methods - Object.methods)
+
+        # Prioritize methods defined in the model's own source file
+        source_methods = extract_source_class_methods(model)
+
+        all_methods = (model.methods - ActiveRecord::Base.methods - Object.methods)
           .reject { |m|
             ms = m.to_s
-            ms.start_with?("_", "autosave") || scope_names.include?(ms)
+            ms.start_with?("_", "autosave") ||
+              scope_names.include?(ms) ||
+              DEVISE_CLASS_METHOD_PATTERNS.include?(ms) ||
+              ms.end_with?("=") && ms.length > 20 # Devise setter-like methods
           }
-          .sort
-          .first(30) # Cap to avoid noise
           .map(&:to_s)
+          .sort
+
+        # Source-defined methods first, then reflection-discovered ones
+        ordered = source_methods + (all_methods - source_methods)
+        ordered.first(30)
       end
 
+      def extract_source_class_methods(model)
+        path = model_source_path(model)
+        return [] unless path && File.exist?(path)
+
+        source = File.read(path)
+        methods = []
+        in_class_methods = false
+        source.each_line do |line|
+          in_class_methods = true if line.match?(/\A\s*(?:class << self|def self\.)/)
+          if line.match?(/\A\s*def self\.(\w+)/)
+            methods << line.match(/def self\.(\w+)/)[1]
+          end
+          if in_class_methods && line.match?(/\A\s*def (\w+)/)
+            methods << line.match(/def (\w+)/)[1]
+          end
+          in_class_methods = false if in_class_methods && line.match?(/\A\s*end\s*$/) && !line.match?(/def/)
+        end
+        methods.uniq
+      rescue
+        []
+      end
+
+      DEVISE_INSTANCE_PATTERNS = %w[
+        password_required? email_required? confirmation_required?
+        active_for_authentication? inactive_message authenticatable_salt
+        after_database_authentication send_devise_notification
+        send_confirmation_instructions send_reset_password_instructions
+        send_unlock_instructions send_on_create_confirmation_instructions
+        devise_mailer clean_up_passwords skip_confirmation!
+        skip_reconfirmation! valid_password? update_with_password
+        destroy_with_password remember_me! forget_me!
+        unauthenticated_message confirmation_period_valid?
+        pending_reconfirmation? reconfirmation_required?
+        send_email_changed_notification send_password_change_notification
+      ].to_set.freeze
+
       def extract_public_instance_methods(model)
         generated = generated_association_methods(model)
 
-        (model.instance_methods - ActiveRecord::Base.instance_methods - Object.instance_methods)
+        # Prioritize source-defined methods
+        source_methods = extract_source_instance_methods(model)
+
+        all_methods = (model.instance_methods - ActiveRecord::Base.instance_methods - Object.instance_methods)
           .reject { |m|
             ms = m.to_s
-            ms.start_with?("_", "autosave", "validate_associated") || generated.include?(ms)
+            ms.start_with?("_", "autosave", "validate_associated") ||
+              generated.include?(ms) ||
+              DEVISE_INSTANCE_PATTERNS.include?(ms) ||
+              ms.match?(/\Awill_save_change_to_|_before_last_save\z|_in_database\z|_before_type_cast\z/)
           }
-          .sort
-          .first(30)
           .map(&:to_s)
+          .sort
+
+        # Source-defined methods first
+        ordered = source_methods + (all_methods - source_methods)
+        ordered.first(30)
+      end
+
+      def extract_source_instance_methods(model)
+        path = model_source_path(model)
+        return [] unless path && File.exist?(path)
+
+        source = File.read(path)
+        methods = []
+        in_private = false
+        source.each_line do |line|
+          in_private = true if line.match?(/\A\s*private\s*$/)
+          next if in_private
+          next if line.match?(/\A\s*def self\./)
+          if (match = line.match(/\A\s*def (\w+[?!]?)/))
+            methods << match[1] unless match[1] == "initialize"
+          end
+        end
+        methods.uniq
+      rescue
+        []
       end
 
       # Build list of AR-generated association helper method names to exclude

data/lib/rails_ai_context/serializers/claude_rules_serializer.rb

@@ -128,15 +128,31 @@ module RailsAiContext
           pk_display = pk.is_a?(Array) ? pk.join(", ") : (pk || "id").to_s
 
           # Show column names WITH types for key columns
+          # Skip standard Rails FK columns (like user_id, account_id) but keep
+          # external ID columns (like paymongo_checkout_id, stripe_payment_id)
+          fk_columns = (data[:foreign_keys] || []).map { |f| f[:column] }.to_set
+          all_table_names = tables.keys.to_set
           key_cols = columns.select do |c|
             next true if keep_cols.include?(c[:name])
             next true if c[:name].end_with?("_type")
             next false if skip_cols.include?(c[:name])
-            next false if c[:name].end_with?("_id")
+            if c[:name].end_with?("_id")
+              # Skip if it's a known FK or matches a table name (conventional Rails FK)
+              ref_table = c[:name].sub(/_id\z/, "").pluralize
+              next false if fk_columns.include?(c[:name]) || all_table_names.include?(ref_table)
+            end
             true
           end
 
-          col_sample = key_cols.map { |c| "#{c[:name]}:#{c[:type]}" }
+          col_sample = key_cols.map do |c|
+            col_type = c[:array] ? "#{c[:type]}[]" : c[:type].to_s
+            entry = "#{c[:name]}:#{col_type}"
+            if c.key?(:default) && !c[:default].nil?
+              default_display = c[:default] == "" ? '""' : c[:default]
+              entry += "(=#{default_display})"
+            end
+            entry
+          end
           col_str = col_sample.any? ? " — #{col_sample.join(', ')}" : ""
 
           # Foreign keys

data/lib/rails_ai_context/tools/analyze_feature.rb

@@ -27,7 +27,13 @@ module RailsAiContext
 
         # --- Models ---
         models = ctx[:models] || {}
-        matched_models = models.select { |name, data| !data[:error] && name.downcase.include?(pattern) }
+        matched_models = models.select do |name, data|
+          next false if data[:error]
+          # Match on model name, table name, or underscore form
+          name.downcase.include?(pattern) ||
+            data[:table_name]&.downcase&.include?(pattern) ||
+            name.underscore.include?(pattern)
+        end
 
         if matched_models.any?
           lines << "## Models (#{matched_models.size} matched)"

data/lib/rails_ai_context/tools/get_model_details.rb

@@ -137,17 +137,29 @@ module RailsAiContext
         # Validations — compress repeated inclusion lists, deduplicate same kind+attribute
         if data[:validations]&.any?
           lines << "" << "## Validations"
-          # Deduplicate validations with same kind and attributes (e.g. implicit belongs_to + explicit validates :user, presence)
+          # Identify belongs_to association names for labeling implicit validations
+          belongs_to_names = (data[:associations] || [])
+            .select { |a| a[:type] == "belongs_to" && a[:optional] != true }
+            .map { |a| a[:name] }
+            .to_set
+
+          # Deduplicate validations with same kind and attributes
           seen_validations = Set.new
-          # Track seen inclusion arrays to avoid repeating long lists
           seen_inclusions = {}
           data[:validations].each do |v|
             dedup_key = "#{v[:kind]}:#{v[:attributes].sort.join(',')}"
             next if seen_validations.include?(dedup_key)
             seen_validations << dedup_key
             attrs = v[:attributes].join(", ")
+
+            # Label implicit belongs_to presence validations
+            implicit = v[:kind] == "presence" && v[:attributes].size == 1 && belongs_to_names.include?(v[:attributes].first)
+            implicit_label = implicit ? " _(implicit from belongs_to)_" : ""
+
             if v[:options]&.any?
-              compressed_opts = v[:options].map do |k, val|
+              # Filter out message: "required" from implicit belongs_to validations
+              filtered_opts = v[:options].reject { |k, val| implicit && k.to_s == "message" && val.to_s == "required" }
+              compressed_opts = filtered_opts.map do |k, val|
                 if k.to_s == "in" && val.is_a?(Array) && val.size > 3
                   key = val.sort.join(",")
                   if seen_inclusions[key]
@@ -160,11 +172,11 @@ module RailsAiContext
                   "#{k}: #{val}"
                 end
               end
-              opts = " (#{compressed_opts.join(', ')})"
+              opts = compressed_opts.any? ? " (#{compressed_opts.join(', ')})" : ""
             else
               opts = ""
             end
-            lines << "- `#{v[:kind]}` on #{attrs}#{opts}"
+            lines << "- `#{v[:kind]}` on #{attrs}#{opts}#{implicit_label}"
           end
         end
 

data/lib/rails_ai_context/tools/get_schema.rb

@@ -149,7 +149,11 @@ module RailsAiContext
           nullable = col.key?(:null) ? (col[:null] ? "yes" : "**NO**") : "yes"
           col_type = col[:array] ? "#{col[:type]}[]" : col[:type].to_s
           line = "| #{col[:name]} | #{col_type} | #{nullable}"
-          line += " | #{col[:default]}" if has_defaults
+          if has_defaults
+            default_val = col[:default]
+            display_default = default_val == "" ? '""' : default_val
+            line += " | #{display_default}"
+          end
           lines << "#{line} |"
         end
 

data/lib/rails_ai_context/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsAiContext
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-ai-context
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - crisnahine