rails-ai-bridge 3.5.0 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c78af79aba88ce31b9ea2d0f0c2de1e14782f5a0d2fbc9ccae9a879c86020ad8
-  data.tar.gz: 736de35b4fa3413752e77b3ebc37abf5628c697c7855561985031d7a06b53783
+  metadata.gz: 86847cb1d8613336bb1538fdde0c64461dcc69d2423b48939629695f40c99688
+  data.tar.gz: 65d9c1a4f11b3edc80a077e66c41e339ca845e4d10993d63cddef79be7ef9c5d
 SHA512:
-  metadata.gz: f7204bde6b731db642cedb0d3748e413f3c8f6496633328f1450412fdce6aa1127ca7fbaef443b061068f8d66177c5878f35e72a4bd75b21f8ec20f496e6c261
-  data.tar.gz: 93f710a0ceeba7a6b55fe6323b22ae1b980424ac301877b13a9d8e2f8e63a064500e5db86db30330b7347649f2774ca9d0655e82704008d568fe4e858e2b33b2
+  metadata.gz: c6ae4378aa2f3321b0753fb7e111a4d6777bd4de63e5ade3bcf38047affac48ce86630490dcacd33610021f299833bc5d7dd24f9dc238614f60786d8fac42ea4
+  data.tar.gz: 22caf59cc05827c7a5824f17c2dd1a5715b8ba62b70930ef300835bdbdc96506bdae1f2ec8590391272576c097363b45debb605f195e0e7c7b43c227f8a75289

data/CHANGELOG.md

@@ -5,7 +5,17 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [Unreleased]
+## [3.5.1]
+
+### Security
+
+- Harden `DefaultGitRunner` git commands against option injection by validating clone URL/destination and using `--` separators for `git clone`; add `nosemgrep` suppressions for documented false positives in `git pull` and `git checkout`.
+- Add `protect_from_forgery` to all test/fixture `ApplicationController` classes.
+- Replace `content_tag` with `tag.h1` in the internal test `ApplicationHelper` and rename the misleading `raw` variable in `Config::Mcp`.
+- Add `nosemgrep` comments with explanatory notes for unscoped-find false positives in internal test controllers.
+- Harden `rails_search_code` ripgrep command with a `--` separator and replace shell-based `which rg` detection with direct `rg --version` checks.
+
+## [3.5.0]
 
 ### Added
 

data/SECURITY.md

@@ -39,7 +39,7 @@ please report it responsibly:
   credentials are omitted from introspection and the `rails://config` resource by
   default; set `config.expose_credentials_key_names = true` only if you accept
   that metadata exposure.
-- The gem does not make any outbound network requests.
+- The gem does not make outbound network requests except when the skill-pack registry is configured with a git source, in which case `git clone` / `git pull` fetches remote pack repositories.
 - The main risk is **information exposure**, not mutation: schema names, routes,
   controller structure, and code excerpts may still be sensitive in some environments.
 

data/lib/rails_ai_bridge/config/mcp.rb

@@ -87,19 +87,19 @@ module RailsAiBridge
       #
       # @return [Integer]
       def effective_http_rate_limit_max_requests
-        raw = @rate_limit_max_requests
+        configured_value = @rate_limit_max_requests
 
-        case raw
+        case configured_value
         when Integer
-          return 0 if raw <= 0
+          return 0 if configured_value <= 0
 
-          raw
+          configured_value
         when nil
           return 0 if http_rate_limit_implicitly_suppressed?
 
           security_profile_rate_limit_max
         else
-          n = raw.to_i
+          n = configured_value.to_i
           return 0 if n <= 0
 
           n

data/lib/rails_ai_bridge/doctor/checkers/ripgrep_checker.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'open3'
+
 module RailsAiBridge
   class Doctor
     module Checkers
@@ -7,9 +9,15 @@ module RailsAiBridge
       class RipgrepChecker < BaseChecker
         # @return [Doctor::Check] +:pass+ when +rg+ is found; +:warn+ otherwise
         def call
+          available = begin
+            Open3.capture2('rg', '--version').last.success?
+          rescue Errno::ENOENT
+            false
+          end
+
           check(
             'ripgrep',
-            system('which rg > /dev/null 2>&1'),
+            available,
             pass: { message: 'rg available for code search' },
             fail: { status: :warn, message: 'ripgrep not installed (code search will use slower Ruby fallback)',
                     fix: 'Install with `brew install ripgrep` or `apt install ripgrep`' }

data/lib/rails_ai_bridge/registry/skill_source_resolver.rb

@@ -63,8 +63,11 @@ module RailsAiBridge
       # @raise [RuntimeError] if git clone command fails, returns non-zero, or times out
       # @return [void]
       def clone_repo(url, dest)
+        raise ArgumentError, "Invalid git URL #{url.inspect}: URLs must not start with '-'" if url.start_with?('-')
+        raise ArgumentError, "Invalid destination #{dest.inspect}: paths must not start with '-'" if dest.to_s.start_with?('-')
+
         with_timeout('git clone') do
-          _stdout, stderr, status = Open3.capture3('git', 'clone', url, dest)
+          _stdout, stderr, status = Open3.capture3('git', 'clone', '--', url, dest)
           fail_with_sanitized_error!('git clone', stderr) unless status.success?
         end
       end
@@ -76,7 +79,8 @@ module RailsAiBridge
       # @return [void]
       def pull_repo(path)
         with_timeout('git pull') do
-          _stdout, stderr, status = Open3.capture3('git', 'pull', chdir: path)
+          # Command is fully static; only the chdir option is a validated directory path.
+          _stdout, stderr, status = Open3.capture3('git', 'pull', chdir: path) # nosemgrep: ruby.lang.security.dangerous-exec.dangerous-exec
           fail_with_sanitized_error!('git pull', stderr) unless status.success?
         end
       end
@@ -92,7 +96,8 @@ module RailsAiBridge
         raise ArgumentError, "Invalid ref #{ref.inspect}: refs must not start with '-'" if ref.start_with?('-')
 
         with_timeout('git checkout') do
-          _stdout, stderr, status = Open3.capture3('git', 'checkout', ref, chdir: path)
+          # The ref is validated above before being passed to git.
+          _stdout, stderr, status = Open3.capture3('git', 'checkout', ref, chdir: path) # nosemgrep: ruby.lang.security.dangerous-exec.dangerous-exec
           fail_with_sanitized_error!('git checkout', stderr) unless status.success?
         end
       end

data/lib/rails_ai_bridge/tools/search_code/ripgrep_search.rb

@@ -78,7 +78,7 @@ module RailsAiBridge
             cmd.concat(excluded_path_flags)
             cmd.concat(secret_exclude_flags)
             cmd.concat(file_type_filters)
-            cmd.push(@pattern, @path)
+            cmd.push('--', @pattern, @path)
           end
 
           private

data/lib/rails_ai_bridge/tools/search_code.rb

@@ -71,8 +71,11 @@ module RailsAiBridge
       end
 
       def self.ripgrep_available?
-        @ripgrep_available = system('which rg > /dev/null 2>&1') unless instance_variable_defined?(:@ripgrep_available)
-        @ripgrep_available
+        return @ripgrep_available if instance_variable_defined?(:@ripgrep_available)
+
+        @ripgrep_available = Open3.capture2('rg', '--version').last.success?
+      rescue Errno::ENOENT
+        @ripgrep_available = false
       end
 
       def self.with_search_timeout(&)

data/lib/rails_ai_bridge/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module RailsAiBridge
-  VERSION = '3.5.0'
+  VERSION = '3.5.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rails-ai-bridge
 version: !ruby/object:Gem::Version
-  version: 3.5.0
+  version: 3.5.1
 platform: ruby
 authors:
 - Ismael Marin