radius-spec 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c4d652e44593c618e03b3ca8af97a587b84dfce66b10aeab8645352bd1117ae
-  data.tar.gz: 25d44a7fe4bdbd35795ffdb5455e0efbc88238c2c7d1397fcc6b36d8ee3d6428
+  metadata.gz: 39d958bd163dfff166917fa80d417ccf9afcfe576ec63e18863a75b5fdd46781
+  data.tar.gz: '0722783dcba93751f3b78462b9c7f75c468532b1d3f1bc929316859ed2ba3825'
 SHA512:
-  metadata.gz: 9e58dc69f52bcadab27204339804aee3fc7a72596670ddb7ecb04a2b35ccec67c188f14361dcbd29ac18fbed75dbdf89bf8cf4e85c9fc3f50d9086b6a33f1978
-  data.tar.gz: dd9113b30d8447bb372b0ed9edc68b57041f9252a10bc556a72724768f6e4bec9304ff93114953a77ea5b191fb171e86456f78c409e25dc3a33db9ae6923ba3f
+  metadata.gz: 5ecde76170420bfd8af1f96e7430a771ac2ded9f033f4cdb509f5abe74e523ee9e9f8df8a308062f6dd6a4ba8f5f50387fdeb83fb5abb0cea1265fcbb4431f1a
+  data.tar.gz: 4e88ba079d4c3e64a810ec77dc0d88ab7129e7c870c473cf2ab94029a4ff2c7db69f485f44e949e0a2630aa2db86bbef5426987cb28e23ef99e50c2bd330957a

data/CHANGELOG.md

@@ -1,5 +1,22 @@
+## 0.1.1 (March 16, 2018)
+
+[Full Changelog](https://github.com/RadiusNetworks/radius-spec/compare/v0.1.0...v0.1.1)
+
+### Bug Fixes
+
+- Fix `NameError: undefined local variable or method `config` for Rails RSpec
+  configuration (Aaron Kromer, #1)
+- Fix model factory build issue in which registered template attributes, which
+  use symbol keys, are not replaced by custom attributes using string keys
+  (Aaron Kromer, #1)
+- Exclude `spec/support/model_factories.rb` from `Metrics/BlockLength` in
+  common Rubocop config (Aaron Kromer, 714b9b3)
+
+
 ## 0.1.0 (March 14, 2018)
 
+[Full Changelog](https://github.com/RadiusNetworks/radius-spec/compare/0fb9d553f493c7ba454f13c9d4332d62a336f0a4...v0.1.0)
+
 ### Initial release:
 
 - Common Rubocop configuration

data/README.md

@@ -52,10 +52,19 @@ custom RSpec configuration in a `RSpec.configure` block as usual:
 require 'radius/spec'
 
 RSpec.configure do |config|
+  # Project's with noisy dependencies, and Rails app, include this line to
+  # disable warnings.
+  config.warnings = false
+
   # Your project specific custom settings here
 end
 ```
 
+**NOTE:** By default warnings are enabled by this gem. Enabling Ruby warnings
+is generally recommended. However, for large projects, and including most Rails
+apps, with lots of noisy dependencies this can be an issue. For these projects,
+we suggest disabling warnings per the above method.
+
 For Rails apps, we suggest a similar approach to your Rails helper:
 
 ```ruby

data/common_rubocop.yml

@@ -67,6 +67,7 @@ Metrics/BlockLength:
     - '**/*.rake'
     - 'spec/spec_helper.rb'
     - 'spec/**/*_spec.rb'
+    - 'spec/support/model_factories.rb'
 
 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
 # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS

data/lib/radius/spec/model_factory.rb

@@ -253,6 +253,17 @@ module Radius
         end
         alias_method :factory, :define_factory
 
+        # @private
+        def merge_attrs(template, custom_attrs)
+          template_only = template.keys - custom_attrs.keys
+          template.slice(*template_only)
+                  .delete_if { |_, v| :optional == v }
+                  .transform_values! { |v|
+                    ::Radius::Spec::ModelFactory.safe_transform(v)
+                  }
+                  .merge(custom_attrs)
+        end
+
         # @private
         def safe_transform(value)
           return value.call if value.is_a?(Proc)
@@ -407,13 +418,8 @@ module Radius
       def build(name, custom_attrs = {}, &block)
         name = name.to_s
         template = ::Radius::Spec::ModelFactory.template(name)
-        template_only = template.keys - custom_attrs.keys
-        attrs = template.slice(*template_only)
-                        .delete_if { |_, v| :optional == v }
-                        .transform_values! { |v|
-                          ::Radius::Spec::ModelFactory.safe_transform(v)
-                        }
-                        .merge(custom_attrs)
+        custom_attrs = custom_attrs.transform_keys(&:to_sym)
+        attrs = ::Radius::Spec::ModelFactory.merge_attrs(template, custom_attrs)
         # TODO: Always yield to the provided block even if new doesn't
         ::Object.const_get(name).new(attrs, &block)
       end

data/lib/radius/spec/rails.rb

@@ -5,7 +5,7 @@ require 'radius/spec'
 require 'radius/spec/rspec'
 require 'rspec/rails'
 
-RSpec.configure do
+RSpec.configure do |config|
   # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
   config.fixture_path = ::Rails.root.join("spec", "fixtures")
 

data/lib/radius/spec/version.rb

@@ -2,6 +2,6 @@
 
 module Radius
   module Spec
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: radius-spec
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Radius Networks
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-14 00:00:00.000000000 Z
+date: 2018-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec