radar-app 0.10.1 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0fc7c23d9c244a3aa5effcf0c10b5db8f0e90a79c5078fca953226ca0f4957e5
-  data.tar.gz: 4a47ba93d9e888d3248a5ee5fe32175ee419a4c97af7220d5cae2a42bfbd8e98
+  metadata.gz: 4f8b5eb2ee9036a6bc9dad92320b9e837dcb2829577e8e00e30d3e407916345d
+  data.tar.gz: 599ab1c560a809e1ba9d093df8b154a8eecc72fa834349452eefcc7fc49d0b08
 SHA512:
-  metadata.gz: fb4ef8f00116fb78644094a7d1181c0f4de2bd5aa6090c0a2b0b317ad07becffdc489221cd3e079a662b0d95998d004944b5da63f6f75065a6b9d2d6cf26ddd4
-  data.tar.gz: 1190365b21e65d99940dfe0cfca2aeffed244ccb4a2b85a8e09f091948f954368199af609393bf56467d958a44f50a32858c9c7955b44b33124fe39921020a47
+  metadata.gz: 887fc9bafe9bb8cd0cc71b0c103886cf58cffac7b2d1a4c6e664e01c76ab2b8df235ddb26b9c73da43c2735f093185e7709a2e53bc57e657a916dee9ef5501e3
+  data.tar.gz: 324ef90a6f60bf67375f602560812b23a760cfe4141313c5335e9c1d7a2d58f37442ec6df0e6a16990dd73b322812fe09af01fd994690103f6449f62583feaaa

data/lib/radar/app/processor_factory.rb

@@ -1,10 +1,34 @@
 require 'thrift/exceptions'
+require 'radar-api'
 
 module Radar
   module App
     module ProcessorFactory
+
+      class AppErrorHandler
+        def initialize(target)
+          @target = target
+        end
+
+        def method_missing(m, *args, &block)
+          begin
+            @target.send(m, *args, &block)
+          rescue => e
+            if e.kind_of?(Thrift::Exception)
+              raise e
+            else
+              raise Radar::API::ApplicationError.new(message: e.message, stacktrace: e.backtrace)
+            end
+          end
+        end
+      end
+
       def self.create_processor(superclass)
         Class.new(superclass) do
+          def initialize(handler)
+            super(AppErrorHandler.new(handler))
+          end
+
           def write_error(err, oprot, name, seqid)
             super
             raise if err.type == Thrift::ApplicationException::INTERNAL_ERROR

data/lib/radar/app/version.rb

@@ -1,5 +1,5 @@
 module Radar
   module App
-    VERSION = "0.10.1"
+    VERSION = "0.11.0"
   end
 end

data/spec/lib/radar/app/processor_factory_spec.rb

@@ -1,11 +1,31 @@
 require 'radar/app/processor_factory'
 
 describe Radar::App::ProcessorFactory do
+  let(:handler_class) do
+    Class.new do
+    end
+  end
 
   let(:parent_processor_class) do
     Class.new do
       attr_reader :write_error_called
 
+      def raise_an_error
+        raise 'an error'
+      end
+
+      def initialize(handler)
+      end
+
+      def process_an_error
+        begin
+          raise 'an error'
+        rescue => e
+          x = Thrift::ApplicationException.new(Thrift::ApplicationException::INTERNAL_ERROR, 'Internal error')
+          write_error(x, nil, nil, nil)
+        end
+      end
+
       def process_an_error
         begin
           raise 'an error'
@@ -29,7 +49,7 @@ describe Radar::App::ProcessorFactory do
 
   describe '#create_processor' do
     describe 'it creates a processor that' do
-      let(:processor) { Radar::App::ProcessorFactory.create_processor(parent_processor_class).new }
+      let(:processor) { Radar::App::ProcessorFactory.create_processor(parent_processor_class).new(nil) }
       it 'raises the exception on error' do
         expect { processor.process_an_error }.to raise_error 'an error'
       end
@@ -48,4 +68,22 @@ describe Radar::App::ProcessorFactory do
       end
     end
   end
+  describe 'AppErrorHandler' do
+    let(:error_handler) { Radar::App::ProcessorFactory::AppErrorHandler.new }
+    let(:target) { double() }
+    context 'then target raises a non-Thrift exception' do
+      it 'raises an ApplicationError' do
+        allow(target).to receive(:raise_an_error).and_raise 'an error'
+        error_handler = Radar::App::ProcessorFactory::AppErrorHandler.new(target)
+        expect { error_handler.raise_an_error }.to raise_error(Radar::Api::ApplicationError)
+      end
+      context 'then target raises a Thrift exception' do
+        it 'raises the original error' do
+          allow(target).to receive(:raise_an_error).and_raise Radar::Api::AuthenticationError.new
+          error_handler = Radar::App::ProcessorFactory::AppErrorHandler.new(target)
+          expect { error_handler.raise_an_error }.to raise_error(Radar::Api::AuthenticationError)
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: radar-app
 version: !ruby/object:Gem::Version
-  version: 0.10.1
+  version: 0.11.0
 platform: ruby
 authors:
 - Leonardo Mendonca
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-06 00:00:00.000000000 Z
+date: 2019-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -233,7 +233,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: radar-app generator