ractor-cache 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 377a50819a1cba2fe238c388c7d493cddf0260f97edaa88952bdfde0bb46f8f9
-  data.tar.gz: 4723d13d9e5b3a41cb84be4aff50061d67e2bf9850275c098cc05197b6c549c1
+  metadata.gz: c2fb8ce98adad688d2ff0e150265154ba963c62a4c7cd88e87bb09ab366db535
+  data.tar.gz: fda4eb8307bb638e87841f418895c4f57297c975349c9502026b3346ad570256
 SHA512:
-  metadata.gz: 7e7ed096e89d921bbd30bfb3884a29c4ec4d83fe56d38865394f85b8eb5e88806a41f06dcf061a6370450f06e9249b7ef4c70dcddf64c4015ba7d1ba2e379a2d
-  data.tar.gz: 3bf00fd952e7f8dbe610160c1d34320181821d6bb5aaecbe89866f64e2239e909a5e499f81ed12bdb8746e887013b23411dbc4089f437a16c4c22554bc61bb73
+  metadata.gz: 38ad35d50bf189e0dc9f0da88f91f484664811824f1310e2e4a040f49b19d3f9f079c826d9667956d5d3ec4949e440583f7f38d74c6f6841af40a9f65b672453
+  data.tar.gz: fa23e9e4cebd2891ba3bfdfe81e8d88fe693e2efd770e2f08cc1be576bb3a46ddae543562c95c760e917f39f895ba64bb5e039fff6a68ea9e4eccb690194a8db

data/README.md

@@ -41,7 +41,7 @@ f.freeze
 f.long_calc # => FrozenError, can't set `@long_calc`
 ```
 
-Some techniques could include storing the cache in a mutable data structures:
+Some techniques could include storing the cache in a mutable data structure:
 
 ```ruby
 class Foo
@@ -76,6 +76,8 @@ This gem will:
 - not write to the cache,
 - (or maybe use a separate Ractor / `SharedHash`)
 
+Implementation details pexplained here](hacker_guide.md)
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/marcandre/ractor-cache. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/marcandre/ractor-cache/blob/master/CODE_OF_CONDUCT.md).

data/lib/ractor/cache/strategy.rb

@@ -2,6 +2,8 @@
 
 class Ractor
   module Cache
+    EMPTY_CACHE = Class.new.freeze # lazy way to get a name
+
     module Strategy
       class Base
         attr_reader :parameters, :method_name
@@ -12,7 +14,8 @@ class Ractor
         end
 
         def compile_store_init
-          "@#{method_name} = {}" if @has_arguments
+          init = @has_arguments ? "Hash.new { #{EMPTY_CACHE} }" : EMPTY_CACHE
+          "@#{method_name} = #{init}"
         end
 
         private def analyse_parameters(parameters) # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength
@@ -53,7 +56,7 @@ class Ractor
       class Prebuild < Base
         def initialize(*)
           super
-          raise "Can not cache method #{method_name} by prebuilding because it accepts arguments" if @has_arguments
+          raise ArgumentError, "Can not cache method #{method_name} by prebuilding because it accepts arguments" if @has_arguments
         end
 
         def deep_freeze_callback(instance)
@@ -63,7 +66,10 @@ class Ractor
         def compile_accessor
           <<~RUBY
             def #{method_name}(#{signature})
-              ractor_cache.#{method_name} ||= super
+              r = ractor_cache.#{method_name}
+              return r unless r == EMPTY_CACHE
+
+              ractor_cache.#{method_name} = super
             end
           RUBY
         end
@@ -73,11 +79,12 @@ class Ractor
         def compile_accessor
           <<~RUBY
             def #{method_name}(#{signature})
-              ractor_cache.#{method_name}#{compile_lookup} || begin
-                result = super
-                ractor_cache.#{method_name}#{compile_lookup} = result unless ractor_cache.frozen?
-                result
-              end
+              r = ractor_cache.#{method_name}#{compile_lookup}
+              return r unless r == EMPTY_CACHE
+
+              r = super
+              ractor_cache.#{method_name}#{compile_lookup} = r unless ractor_cache.frozen?
+              r
             end
           RUBY
         end
@@ -104,7 +111,7 @@ class Ractor
         )                    # => Strategy
           self[strategy || :prebuild].new(to_cache)
         rescue ArgumentError
-          return new(:prebuild, to_cache: to_cache) if strategy == nil
+          return new(:disable, to_cache: to_cache) if strategy == nil
 
           raise
         end

data/lib/ractor/cache/version.rb

@@ -2,6 +2,6 @@
 
 class Ractor
   module Cache
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ractor-cache
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Marc-Andre Lafortune
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-11-10 00:00:00.000000000 Z
+date: 2020-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: require_relative_dir