rack_hoptoad 0.1.3 → 0.1.4

data/lib/rack/hoptoad.rb

@@ -6,9 +6,11 @@ module Rack
   # Catches all exceptions raised from the app it wraps and
   # posts the results to hoptoad.
   class Hoptoad
-    VERSION = '0.1.3'
+    VERSION = '0.1.4'
 
-    attr_accessor :api_key, :environment_filters, :report_under, :rack_environment
+    class Error < StandardError; end
+
+    attr_accessor :api_key, :environment_filters, :report_under, :rack_environment, :notifier_class, :failsafe
 
     def initialize(app, api_key = nil, rack_environment = 'RACK_ENV')
       @app                 = app
@@ -16,6 +18,8 @@ module Rack
       @report_under        = %w(staging production)
       @rack_environment    = rack_environment
       @environment_filters = %w(AWS_ACCESS_KEY  AWS_SECRET_ACCESS_KEY AWS_ACCOUNT SSH_AUTH_SOCK)
+      @notifier_class      = Toadhopper
+      @failsafe            = $stderr
       yield self if block_given?
     end
 
@@ -24,8 +28,6 @@ module Rack
         begin
           @app.call(env)
         rescue StandardError, LoadError, SyntaxError => boom
-          # TODO don't allow exceptions from send_notification to
-          # propogate
           notified = send_notification boom, env
           env['hoptoad.notified'] = notified
           raise
@@ -56,8 +58,22 @@ module Rack
         :session           => env['rack.session']
       }
 
-      result = toadhopper.post!(exception, options, {'X-Hoptoad-Client-Name' => 'Rack::Hoptoad'})
-      result.errors.empty?
+      if result = toadhopper.post!(exception, options, {'X-Hoptoad-Client-Name' => 'Rack::Hoptoad'})
+        if result.errors.empty?
+          true
+        else
+          raise Error, "Status: #{result.status} #{result.errors.inspect}"
+        end
+      else
+        raise Error, "No response from Toadhopper"
+      end
+    rescue Exception => e
+      return unless @failsafe
+      @failsafe.puts "Fail safe error caught: #{e.class}: #{e.message}"
+      @failsafe.puts e.backtrace
+      @failsafe.puts "Exception is #{exception.class}: #{exception.message}"
+      @failsafe.puts exception.backtrace
+      false
     end
 
     def rack_env
@@ -65,7 +81,7 @@ module Rack
     end
 
     def toadhopper
-      toad         = Toadhopper(api_key)
+      toad         = @notifier_class.new(api_key)
       toad.filters = environment_filter_keys
       toad
     end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack_hoptoad
 version: !ruby/object:Gem::Version 
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Corey Donohoe
@@ -14,35 +15,39 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-23 00:00:00 -07:00
+date: 2010-06-12 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: rack
   prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
+  requirement: *id001
   type: :runtime
-  version_requirements: *id001
+  name: rack
 - !ruby/object:Gem::Dependency 
-  name: toadhopper
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 21
         segments: 
         - 1
         - 0
         - 1
         version: 1.0.1
+  requirement: *id002
   type: :runtime
-  version_requirements: *id002
+  name: toadhopper
 description: A gem that provides hoptoad notifications from rack
 email: atmos@atmos.org
 executables: []
@@ -68,23 +73,27 @@ rdoc_options: []
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.6
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: A gem that provides hoptoad notifications from rack