rack 1.5.0 → 1.5.1

data/README.rdoc

@@ -506,6 +506,11 @@ run on port 11211) and memcache-client installed.
   * Updated HTTP status codes
   * Ruby 1.8.6 likely no longer passes tests, and is no longer fully supported
 
+* January 28th, 2013: Thirty fourth public release 1.5.1
+  * Rack::Lint check_hijack now conforms to other parts of SPEC
+  * Added hash-like methods to Abstract::ID::SessionHash for compatibility
+  * Various documentation corrections
+
 == Contact
 
 Please post bugs, suggestions and patches to

data/Rakefile

@@ -52,7 +52,9 @@ task :changelog => %w[ChangeLog]
 file '.git/index'
 file "ChangeLog" => '.git/index' do
   File.open("ChangeLog", "w") { |out|
-    `git log -z`.split("\0").map { |chunk|
+    log = `git log -z`
+    log.force_encoding(Encoding::BINARY) if log.respond_to?(:force_encoding)
+    log.split("\0").map { |chunk|
       author = chunk[/Author: (.*)/, 1].strip
       date = chunk[/Date: (.*)/, 1].strip
       desc, detail = $'.strip.split("\n", 2)

data/SPEC

@@ -53,7 +53,7 @@ below.
                            RFC3875 section 4.1.18</a> for specific behavior.
 In addition to this, the Rack environment must include these
 Rack-specific variables:
-<tt>rack.version</tt>:: The Array [1,1], representing this version of Rack.
+<tt>rack.version</tt>:: The Array representing this version of Rack. See Rack::VERSION, that corresponds to the version of this SPEC.
 <tt>rack.url_scheme</tt>:: +http+ or +https+, depending on the request URL.
 <tt>rack.input</tt>:: See below, the input stream.
 <tt>rack.errors</tt>:: See below, the error stream.

data/lib/rack/lint.rb

@@ -118,7 +118,7 @@ module Rack
       ## In addition to this, the Rack environment must include these
       ## Rack-specific variables:
 
-      ## <tt>rack.version</tt>:: The Array [1,1], representing this version of Rack.
+      ## <tt>rack.version</tt>:: The Array representing this version of Rack. See Rack::VERSION, that corresponds to the version of this SPEC.
       ## <tt>rack.url_scheme</tt>:: +http+ or +https+, depending on the request URL.
       ## <tt>rack.input</tt>:: See below, the input stream.
       ## <tt>rack.errors</tt>:: See below, the error stream.
@@ -500,6 +500,11 @@ module Rack
     ## It is also possible to hijack a response after the status and headers
     ## have been sent.
     def check_hijack_response(headers, env)
+
+      # this check uses headers like a hash, but the spec only requires
+      # headers respond to #each
+      headers = Rack::Utils::HeaderHash.new(headers)
+
       ## In order to do this, an application may set the special header
       ## <tt>rack.hijack</tt> to an object that responds to <tt>call</tt>
       ## accepting an argument that conforms to the <tt>rack.hijack_io</tt>

data/lib/rack/session/abstract/id.rb

@@ -24,6 +24,10 @@ module Rack
         include Enumerable
         attr_writer :id
 
+        def self.set_options(env, options)
+          env[ENV_SESSION_OPTIONS_KEY] = options.dup
+        end
+
         def initialize(store, env)
           @store = store
           @env = env
@@ -117,6 +121,14 @@ module Rack
           @data.empty?
         end
 
+        def keys
+          @data.keys
+        end
+
+        def values
+          @data.values
+        end
+
       private
 
         def load_for_read!
@@ -359,8 +371,8 @@ module Rack
         end
 
         # All thread safety and session storage proceedures should occur here.
-        # Should return true or false dependant on whether or not the session
-        # was saved or not.
+        # Must return the session id if the session was saved successfully, or
+        # false if the session could not be saved.
 
         def set_session(env, sid, session, options)
           raise '#set_session not implemented.'

data/rack.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name            = "rack"
-  s.version         = "1.5.0"
+  s.version         = "1.5.1"
   s.platform        = Gem::Platform::RUBY
   s.summary         = "a modular Ruby webserver interface"
 

data/test/spec_lint.rb

@@ -231,6 +231,13 @@ describe Rack::Lint do
                        [200, {"Foo-Bar" => "one\ntwo\nthree", "Content-Length" => "0", "Content-Type" => "text/plain" }, []]
                      }).call(env({}))
     }.should.not.raise(Rack::Lint::LintError)
+
+    # non-Hash header responses should be allowed
+    lambda {
+      Rack::Lint.new(lambda { |env|
+                       [200, [%w(Content-Type text/plain), %w(Content-Length 0)], []]
+                     }).call(env({}))
+    }.should.not.raise(TypeError)
   end
 
   should "notice content-type errors" do

data/test/spec_request.rb

@@ -932,6 +932,11 @@ EOF
       'HTTP_X_FORWARDED_FOR' => '3.4.5.6'
     res.body.should.equal '1.2.3.4'
 
+    res = mock.get '/',
+      'REMOTE_ADDR' => '1.2.3.4',
+      'HTTP_X_FORWARDED_FOR' => 'unknown'
+    res.body.should.equal '1.2.3.4'
+
     res = mock.get '/',
       'REMOTE_ADDR' => '127.0.0.1',
       'HTTP_X_FORWARDED_FOR' => '3.4.5.6'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.5.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-22 00:00:00.000000000 Z
+date: 2013-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bacon