rack 0.4.0 → 0.9.0

data/RDOX

@@ -29,6 +29,8 @@
 * chains apps by default
 * has implicit #to_app
 * supports blocks on use
+* has explicit #to_app
+* apps are initialized once
 
 == Rack::Adapter::Camping
 * works with GET
@@ -55,12 +57,28 @@
 * should log to rack.errors by default
 * should log to anything with <<
 
+== Rack::ConditionalGet
+* should set a 304 status and truncate body when If-Modified-Since hits
+* should set a 304 status and truncate body when If-None-Match hits
+* should not affect non-GET/HEAD requests
+
+== Rack::ContentLength
+* sets Content-Length on String bodies if none is set
+* sets Content-Length on Array bodies if none is set
+* does not set Content-Length on variable length bodies
+* does not change Content-Length if it is already set
+* does not set Content-Length on 304 responses
+* does not set Content-Length when Transfer-Encoding is chunked
+
 == Rack::Deflater
 * should be able to deflate bodies that respond to each
 * should be able to deflate String bodies
 * should be able to gzip bodies that respond to each
 * should be able to fallback to no deflation
+* should be able to skip when there is no response entity body
 * should handle the lack of an acceptable encoding
+* should handle gzip response with Last-Modified header
+* should do nothing when no-transform Cache-Control directive present
 
 == Rack::Directory
 * serves directory indices
@@ -86,12 +104,18 @@
 * serves files with URL encoded filenames
 * does not allow directory traversal
 * 404s if it can't find the file
+* detects SystemCallErrors
 
 == Rack::Handler
 * has registered default handlers
 * should get unregistered handler by name
 * should register custom handler
 
+== Rack::Head
+* response (empty)
+* passes GET, POST, PUT, DELETE, OPTIONS, TRACE requests
+* removes body from HEAD requests
+
 == Rack::Lint
 * passes valid request
 * notices fatal errors
@@ -101,9 +125,15 @@
 * notices status errors
 * notices header errors
 * notices content-type errors
+* notices content-length errors
 * notices body errors
 * notices input handling errors
 * notices error handling errors
+* notices HEAD errors
+
+== Rack::Lint::InputWrapper
+* delegates :size to underlying IO object
+* delegates :rewind to underlying IO object
 
 == Rack::Lobster::LambdaLobster
 * should be a single lambda
@@ -115,6 +145,14 @@
 * should be flippable
 * should provide crashing for testing purposes
 
+== Rack::MethodOverride
+* should not affect GET requests
+* _method parameter should modify REQUEST_METHOD for POST requests
+* X-HTTP-Method-Override header should modify REQUEST_METHOD for POST requests
+* should not modify REQUEST_METHOD if the method is unknown
+* should not modify REQUEST_METHOD when _method is nil
+* should store the original REQUEST_METHOD prior to overriding
+
 == Rack::MockRequest
 * should return a MockResponse
 * should be able to only return the environment
@@ -143,6 +181,7 @@
 * should provide a .run that maps a hash
 * should provide a .run that maps a urlmap
 * should provide a .run that maps a urlmap restricting by host
+* should stream #each part of the response
 
 == Rack::Recursive
 * should allow for subrequests
@@ -156,6 +195,8 @@
 * can parse POST data
 * can parse POST data with explicit content type
 * does not parse POST data when media type is not form-data
+* rewinds input after parsing POST data
+* does not rewind unwindable CGI input
 * can get value by key from params with #[]
 * can set value to key on params with #[]=
 * values_at answers values by keys in order given
@@ -175,6 +216,7 @@
 * should work around buggy 1.8.* Tempfile equality
 * does conform to the Rack spec
 * should parse Accept-Encoding correctly
+* should provide ip information
 
 == Rack::Response
 * has sensible default values
@@ -182,6 +224,7 @@
 * can set and read headers
 * can set cookies
 * formats the Cookie expiration date accordingly to RFC 2109
+* can set secure cookies
 * can delete cookies
 * has a useful constructor
 * has a constructor that can take a block
@@ -195,6 +238,9 @@
 * loads from a cookie
 * survives broken cookies
 * barks on too big cookies
+* creates a new cookie with integrity hash
+* loads from a cookie wih integrity hash
+* ignores tampered with session cookies
 
 == Rack::Session::Memcache
 * startup (empty)
@@ -228,6 +274,15 @@
 * 404s if url root is known but it can't find the file
 * calls down the chain if url root is not known
 
+== Rack::Handler::Thin
+* should respond
+* should be a Thin
+* should have rack headers
+* should have CGI headers on GET
+* should have CGI headers on POST
+* should support HTTP auth
+* should set status
+
 == Rack::URLMap
 * dispatches paths correctly
 * dispatches hosts correctly
@@ -242,8 +297,10 @@
 * should figure out which encodings are acceptable
 
 == Rack::Utils::HeaderHash
-* should capitalize on all accesses
-* should capitalize correctly
+* should retain header case
+* should check existence of keys case insensitively
+* should merge case-insensitively
+* should overwrite case insensitively and assume the new key's case
 * should be converted to real Hash
 
 == Rack::Utils::Context
@@ -260,6 +317,7 @@
 * should have CGI headers on POST
 * should support HTTP auth
 * should set status
+* should correctly set cookies
 * should provide a .run
 
-197 specifications, 3 empty (886 requirements), 0 failures
+243 specifications, 4 empty (1008 requirements), 0 failures

data/README

@@ -9,38 +9,23 @@ middleware) into a single method call.
 The exact details of this are described in the Rack specification,
 which all Rack applications should conform to.
 
-== Future specification changes
-
-PLEASE NOTE: In versions of Rack LATER than 0.4, the following
-changes will be commited to the Rack specification:
-
-* 1xx, 204 and 304 status codes MUST not contain a Content-Type.
-* A valid Content-Length header MUST be provided for non 1xx, 204 and 304
-  responses with a Transfer-Encoding of "identity" (default).
-  The Content-Length MUST be the same as the sum of the byte-sizes of
-  the chunks.
-* The REQUEST_METHOD may be any HTTP token.
-
-Internal Rack modules have been updated to follow this behavior, but
-the Rack 0.4 Lint does NOT check it yet for compatibility reasons.
-Please update your libraries accordingly.
-
 == Supported web servers
 
 The included *handlers* connect all kinds of web servers to Rack:
 * Mongrel
 * EventedMongrel
+* SwiftipliedMongrel
 * WEBrick
 * FCGI
 * CGI
 * SCGI
 * LiteSpeed
+* Thin
 
 These web servers include Rack handlers in their distributions:
 * Ebb
 * Fuzed
 * Phusion Passenger (which is mod_rack for Apache)
-* Thin
 
 Any valid Rack app will run the same on all these handlers, without
 changing anything.
@@ -58,13 +43,12 @@ These frameworks include Rack adapters in their distributions:
 * Merb
 * Racktools::SimpleApplication
 * Ramaze
+* Ruby on Rails
 * Sinatra
+* Sin
 * Vintage
 * Waves
 
-Ruby on Rails can be run with the adapter included with Thin, which
-will be merged into a later Rack version.
-
 Current links to these projects can be found at
 http://ramaze.net/#other-frameworks
 
@@ -96,6 +80,14 @@ over:
 * Rack::MockRequest and Rack::MockResponse for efficient and quick
   testing of Rack application without real HTTP round-trips.
 
+== rack-contrib
+
+The plethora of useful middleware created the need for a project that
+collects fresh Rack middleware.  rack-contrib includes a variety of
+add-on components for Rack and it is easy to contribute new modules.
+
+* http://github.com/rack/rack-contrib
+
 == rackup
 
 rackup is a useful tool for running Rack applications, which uses the
@@ -129,7 +121,7 @@ A Gem of Rack is available.  You can install it with:
 I also provide a local mirror of the gems (and development snapshots)
 at my site:
 
-    gem install rack --source http://chneukirchen.org/releases/gems
+    gem install rack --source http://chneukirchen.org/releases/gems/
 
 == Running the tests
 
@@ -204,7 +196,7 @@ run on port 11211) and memcache-client installed.
   * HTTP status 201 can contain a Content-Type and a body now.
   * Many bugfixes, especially related to Cookie handling.
 
-* August 21th, 2008: Fourth public release 0.4.
+* August 21st, 2008: Fourth public release 0.4.
   * New middleware, Rack::Deflater, by Christoffer Sawicki.
   * OpenID authentication now needs ruby-openid 2.
   * New Memcache sessions, by blink.
@@ -216,37 +208,63 @@ run on port 11211) and memcache-client installed.
   * Improved tests.
   * Rack moved to Git.
 
+* January 6th, 2009: Fifth public release 0.9.
+  * Rack is now managed by the Rack Core Team.
+  * Rack::Lint is stricter and follows the HTTP RFCs more closely.
+  * Added ConditionalGet middleware.
+  * Added ContentLength middleware.
+  * Added Deflater middleware.
+  * Added Head middleware.
+  * Added MethodOverride middleware.
+  * Rack::Mime now provides popular MIME-types and their extension.
+  * Mongrel Header now streams.
+  * Added Thin handler.
+  * Official support for swiftiplied Mongrel.
+  * Secure cookies.
+  * Made HeaderHash case-preserving.
+  * Many bugfixes and small improvements.
+
 == Contact
 
 Please mail bugs, suggestions and patches to
 <mailto:rack-devel@googlegroups.com>.
 
 Mailing list archives are available at
-<http://groups.google.com/group/rack-devel>
+<http://groups.google.com/group/rack-devel>.
+
+There is a bug tracker at <http://rack.lighthouseapp.com/>.
 
-Git repository (branches rebased on master are most welcome):
-* http://github.com/chneukirchen/rack
+Git repository (patches rebased on master are most welcome):
+* http://github.com/rack/rack
 * http://git.vuxu.org/cgi-bin/gitweb.cgi?p=rack.git
 
 You are also welcome to join the #rack channel on irc.freenode.net.
 
-== Thanks to
+== Thanks
+
+The Rack Core Team, consisting of
+
+* Christian Neukirchen (chneukirchen)
+* James Tucker (raggi)
+* Josh Peek (josh)
+* Michael Fellinger (manveru)
+* Ryan Tomayko (rtomayko)
+* Scytrin dai Kinthra (scytrin)
+
+would like to thank:
 
-* blink for the Pool sessions, Memcache sessions, OpenID support, many
-  tweaks, patches and bugreports.
-* Michael Fellinger, for the helpful discussion, bugfixes and a better
-  Rack::Request interface.
 * Adrian Madrid, for the LiteSpeed handler.
 * Christoffer Sawicki, for the first Rails adapter and Rack::Deflater.
 * Tim Fletcher, for the HTTP authentication code.
 * Luc Heinrich for the Cookie sessions, the static file handler and bugfixes.
 * Armin Ronacher, for the logo and racktools.
-* Aredridel, for bug fixing.
+* Aredridel, Ben Alpert, Dan Kubb, Daniel Roethlisberger, Matt Todd, and
+  Phil Hagelberg for bug fixing and other improvements.
 * Stephen Bannasch, for bug reports and documentation.
 * Gary Wright, for proposing a better Rack::Response interface.
 * Jonathan Buch, for improvements regarding Rack::Response.
 * Armin Röhrl, for tracking down bugs in the Cookie generator.
-* Alexander Kellett for testing the Gem and reviewing the announce.
+* Alexander Kellett for testing the Gem and reviewing the announcement.
 * Marcus Rückert, for help with configuring and debugging lighttpd.
 * The WSGI team for the well-done and documented work they've done and
   Rack builds up on.
@@ -254,7 +272,7 @@ You are also welcome to join the #rack channel on irc.freenode.net.
 
 == Copyright
 
-Copyright (C) 2007, 2008 Christian Neukirchen <http://purl.org/net/chneukirchen>
+Copyright (C) 2007, 2008, 2009 Christian Neukirchen <http://purl.org/net/chneukirchen>
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to
@@ -277,11 +295,8 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 Rack:: <http://rack.rubyforge.org/>
 Rack's Rubyforge project:: <http://rubyforge.org/projects/rack>
+Official Rack repositories:: <http://github.com/rack>
 rack-devel mailing list:: <http://groups.google.com/group/rack-devel>
 
-Camping:: <http://camping.rubyforge.org/>
-Ramaze:: <http://ramaze.rubyforge.org/>
-Maveric:: <http://maveric.rubyforge.org/>
-
 Christian Neukirchen:: <http://chneukirchen.org/>
 

data/Rakefile

@@ -133,6 +133,15 @@ Also see http://rack.rubyforge.org.
     s.email           = 'chneukirchen@gmail.com'
     s.homepage        = 'http://rack.rubyforge.org'
     s.rubyforge_project = 'rack'
+
+    s.add_development_dependency 'test-spec'
+
+    s.add_development_dependency 'camping'
+    s.add_development_dependency 'fcgi'
+    s.add_development_dependency 'memcache-client'
+    s.add_development_dependency 'mongrel'
+    s.add_development_dependency 'ruby-openid', '~> 2.0.0'
+    s.add_development_dependency 'thin'
   end
 
   Rake::GemPackageTask.new(spec) do |p|

data/SPEC

@@ -71,8 +71,7 @@ There are the following restrictions:
 * <tt>rack.url_scheme</tt> must either be +http+ or +https+.
 * There must be a valid input stream in <tt>rack.input</tt>.
 * There must be a valid error stream in <tt>rack.errors</tt>.
-* The <tt>REQUEST_METHOD</tt> must be one of +GET+, +POST+, +PUT+,
-  +DELETE+, +HEAD+, +OPTIONS+, +TRACE+.
+* The <tt>REQUEST_METHOD</tt> must be a valid token.
 * The <tt>SCRIPT_NAME</tt>, if non-empty, must start with <tt>/</tt>
 * The <tt>PATH_INFO</tt>, if non-empty, must start with <tt>/</tt>
 * The <tt>CONTENT_LENGTH</tt>, if given, must consist of digits only.
@@ -111,7 +110,11 @@ The values passed on #each must be Strings
 and not contain characters below 037.
 === The Content-Type
 There must be a <tt>Content-Type</tt>, except when the
-+Status+ is 204 or 304, in which case there must be none
++Status+ is 1xx, 204 or 304, in which case there must be none
+given.
+=== The Content-Length
+There must be a <tt>Content-Length</tt>, except when the
++Status+ is 1xx, 204 or 304, in which case there must be none
 given.
 === The Body
 The Body must respond to #each

data/lib/rack.rb

@@ -1,4 +1,4 @@
-# Copyright (C) 2007, 2008 Christian Neukirchen <purl.org/net/chneukirchen>
+# Copyright (C) 2007, 2008, 2009 Christian Neukirchen <purl.org/net/chneukirchen>
 #
 # Rack is freely distributable under the terms of an MIT-style license.
 # See COPYING or http://www.opensource.org/licenses/mit-license.php.
@@ -23,18 +23,23 @@ module Rack
 
   # Return the Rack release as a dotted string.
   def self.release
-    "0.4"
+    "0.9"
   end
 
   autoload :Builder, "rack/builder"
   autoload :Cascade, "rack/cascade"
   autoload :CommonLogger, "rack/commonlogger"
+  autoload :ConditionalGet, "rack/conditionalget"
+  autoload :ContentLength, "rack/content_length"
   autoload :File, "rack/file"
   autoload :Deflater, "rack/deflater"
   autoload :Directory, "rack/directory"
   autoload :ForwardRequest, "rack/recursive"
   autoload :Handler, "rack/handler"
+  autoload :Head, "rack/head"
   autoload :Lint, "rack/lint"
+  autoload :MethodOverride, "rack/methodoverride"
+  autoload :Mime, "rack/mime"
   autoload :Recursive, "rack/recursive"
   autoload :Reloader, "rack/reloader"
   autoload :ShowExceptions, "rack/showexceptions"

data/lib/rack/adapter/camping.rb

@@ -15,7 +15,7 @@ module Rack
             h[k] = v.to_s
           end
         end
-        [controller.status, controller.headers, controller.body]
+        [controller.status, controller.headers, [controller.body.to_s]]
       end
     end
   end

data/lib/rack/auth/openid.rb

@@ -343,7 +343,7 @@ module Rack
           session['authenticated'] = false
           req.env['rack.errors'].puts oid.message
 
-          goto = @options[:login_fail] if @option.key? :login_fail
+          goto = @options[:login_fail] if @options.key? :login_fail
           body << "Authentication unsuccessful.\n"
         when ::OpenID::Consumer::SUCCESS
           session.clear
@@ -367,7 +367,7 @@ module Rack
           session.clear
           session['authenticated'] = false
 
-          goto = @options[:login_fail] if @option.key? :login_fail
+          goto = @options[:login_fail] if @options.key? :login_fail
           body << "Authentication cancelled.\n"
         when ::OpenID::Consumer::SETUP_NEEDED
           session[:setup_needed] = true
@@ -402,7 +402,8 @@ module Rack
       def add_extension ext, *args
         if not ext.is_a? Module
           raise TypeError, "#{ext.inspect} is not a module"
-        elsif not (m = %w'Request Response NS_URI' - ext.constants).empty?
+        elsif !(m = %w'Request Response NS_URI' -
+                ext.constants.map{ |c| c.to_s }).empty?
           raise ArgumentError, "#{ext.inspect} missing #{m*', '}"
         end