rack-zippy 3.0.0 → 3.0.1

data/CHANGELOG.md

@@ -1,5 +1,9 @@
+## 3.0.1 / 2015-05-19
+- Allow paths with periods in the middle, but not if they immediately follow slash ([#46](https://github.com/eliotsykes/rack-zippy/pull/46)) @ssemakov
+
 ## 3.0.0 / 2015-04-18
-- Make static extensions list configurable ([#45](https://github.com/eliotsykes/rack-zippy/pull/45/files)) Anton Petrunich
+- POTENTIAL BREAKING CHANGE! `STATIC_EXTENSION_REGEX` has been removed and replaced with a `static_extensions` array. If your app monkey patched `STATIC_EXTENSTION_REGEX` to change the file extension whitelist, then you will need to update your app to use rack-zippy 3.x. Depending on how you patched, and your test coverage, your app could silently fail. Search your codebase for `STATIC_EXTENSION_REGEX` to ensure it is not used. If it is used, then migrate your patch to use the new `Rack::Zippy.config` method for configuring `static_extensions`: https://github.com/eliotsykes/rack-zippy#static_extensions 
+- Make static extensions list configurable ([#45](https://github.com/eliotsykes/rack-zippy/pull/45)) Anton Petrunich
 
 ## 2.0.2 / 2014-12-15
 - Remove binstub bin/rake permanently, may be causing Heroku issues

data/README.md

@@ -87,16 +87,17 @@ Cache-Control: public, max-age=600
 
 ### Configuration
 
-#### static_extensions
+#### Supported Extensions Whitelist
 
-rack-zippy handles only files with whitelisted extensions. Default extensions list: 
+rack-zippy handles only files with whitelisted extensions. Default extensions are stored in the `static_extensions` array with an entry for each of these: 
 `css js html htm txt ico png jpg jpeg gif pdf svg zip gz eps psd ai woff woff2 ttf eot otf swf`
 
-You can modify this list:
+You can modify this list to support other extensions by appending the lowercased file extension to the `static_extensions` array:
 
 ```ruby
 Rack::Zippy.configure do |config|
-  config.static_extensions << 'csv'
+  # Add support for the given extensions:
+  config.static_extensions.push('csv', 'xls', 'rtf', ...EXTENSIONS TO ADD...)
 end
 ```
 
@@ -155,6 +156,7 @@ Cleanup time! When you’re finished testing, delete the local override and set
 - Kieran Topping https://github.com/ktopping
 - Luke Wendling https://github.com/lukewendling
 - Anton Petrunich https://github.com/solenko
+- ssemakov https://github.com/ssemakov
 
 ## Releasing a new gem
 

data/lib/rack-zippy.rb

@@ -63,7 +63,7 @@ module Rack
 
       ACCEPTS_GZIP_REGEX = /\bgzip\b/
 
-      ILLEGAL_PATH_REGEX = /(\.\.|\/\.)/
+      ILLEGAL_PATH_REGEX = /(\/\.\.?)/
 
       def client_accepts_gzip?(rack_env)
         rack_env['HTTP_ACCEPT_ENCODING'] =~ ACCEPTS_GZIP_REGEX

data/lib/rack-zippy/version.rb

@@ -1,5 +1,5 @@
 module Rack
   module Zippy
-    VERSION = '3.0.0'
+    VERSION = '3.0.1'
   end
 end

data/test/asset_server_test.rb

@@ -192,12 +192,19 @@ module Rack
       end
 
       def test_responds_not_found_if_path_contains_consecutive_periods
-        ["/hello/../sensitive/file", "/..", "/..."].each do |dotty_path|
+        ["/hello/../sensitive/file", "/..", "/...", "../sensitive"].each do |dotty_path|
           get dotty_path
           assert_not_found
         end
       end
 
+      def test_responds_ok_if_path_contains_periods_that_not_follow_slash
+         ["/hello/path..with....periods/file", "/hello/path/with.a.period"].each do |dotty_path|
+          get dotty_path
+          assert_underlying_app_responded
+        end
+      end
+
       def test_serves_html
         assert_responds_with_html_file '/thanks.html', 'public/thanks.html'
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-zippy
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 3.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-18 00:00:00.000000000 Z
+date: 2015-05-19 00:00:00.000000000 Z
 dependencies: []
 description: Rack middleware for serving static gzipped assets generated by the Rails
   asset pipeline
@@ -65,18 +65,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1760946869363206133
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: -1760946869363206133
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23.2