rack-tracker 1.11.1 → 1.11.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4f58fd678ef800ce1fb874899514a49c8e5c50ab58297cb5fffddb4da8e6eea4
-  data.tar.gz: 02304e75ff11256123303d2dd393f0dcd393a918cb04f1d65ae5220cd6510083
+  metadata.gz: a22c7f5dec27b8abd60ab5a9cbd1161e336c0063fa2d0171db5d7795a3b79024
+  data.tar.gz: 41d811bf5ee13c120791703df76b805a2095a5c517cb763338cf807d0c776e6a
 SHA512:
-  metadata.gz: ee39c4be171e10aec3e319b55bea51663a479263c13aeb2274c630d560511f27ee3c4533e911c305728b0399a99a118388b184af9f79383d00a4342a6e774f8a
-  data.tar.gz: db3ab55fead72f230b48f1e9785853f3dae007561ba5bd311d1d6a41d0aa9d7978313993dbdf96519f357bc82b9300c0f953fb5f28e39296d40972d3d4677189
+  metadata.gz: b2d88b11dc5d33c7639dc41058832ef5e8ca8b06121e46b72dfe08697e7b990b8588f3c50b6f30aa9fe094cd37bbcd42cfa87de71d769c2e8d2c088417149366
+  data.tar.gz: 6067ba21908d7724eaf70a77d06887af81486315604dca450ea8740039625d4858f517ef4791617eb03918b250bd59e82a5122a982ebeba7f0d15dd1cfdc2639

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.12.0
+
+ * [ENHANCEMENT] Allows disabling the Google Analytics pageview send. Defaults to true #131 (thx @ChrisCoffey)
+
 # 1.11.1
 
  * [BUGFIX] Uncaught ReferenceError Fix: wrap Drift account ID in quotes #140 (thx @sassela)

data/README.md

@@ -140,6 +140,7 @@ end
 * `:enhanced_ecommerce` - Enables [Enhanced Ecommerce Tracking](https://developers.google.com/analytics/devguides/collection/analyticsjs/enhanced-ecommerce)
 * `:optimize` - pass [Google Optimize container ID](https://support.google.com/360suite/optimize/answer/6262084#example-combined-snippet) as value (e.g. `optimize: 'GTM-1234'`).
 * `:pageview_url_script` - a String containing a custom js script evaluating to the url that shoudl be given to the pageview event. Default to `window.location.pathname + window.location.search`.
+* `:explicit_pageview` - A boolean that controls whether to send the `pageview` event on pageload. This defaults to true.
 
 #### Events
 

data/lib/rack/tracker/google_analytics/google_analytics.rb

@@ -2,6 +2,11 @@ class Rack::Tracker::GoogleAnalytics < Rack::Tracker::Handler
 
   self.allowed_tracker_options = [:cookie_domain, :user_id]
 
+  def initialize(env, options = {})
+    options[:explicit_pageview] = true if !options.has_key?(:explicit_pageview)
+    super(env, options)
+  end
+
   class Send < OpenStruct
     def initialize(attrs = {})
       attrs.reverse_merge!(type: 'event')

data/lib/rack/tracker/google_analytics/template/google_analytics.erb

@@ -38,7 +38,7 @@
 <% if options[:ecommerce] && ecommerce_events.any? %>
   ga('ecommerce:send');
 <% end %>
-<% if tracker %>
+<% if tracker && options[:explicit_pageview] %>
   ga('send', 'pageview', <%= pageview_url_script %>);
 <% end %>
 </script>

data/lib/rack/tracker/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Tracker
-    VERSION = '1.11.1'
+    VERSION = '1.11.2'
   end
 end

data/spec/handler/google_analytics_spec.rb

@@ -284,5 +284,21 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
         expect(subject.pageview_url_script).to eql ("{ 'page': location.pathname + location.search + location.hash }")
       end
     end
+
+    context 'with explicit_pageview disabled' do
+      subject { described_class.new(env, {tracker: 'afake', explicit_pageview: false }).render }
+
+      it 'does not send a pageview event' do
+        expect(subject).not_to include %q{ga('send', 'pageview',}
+      end
+    end
+
+    context 'defaults to sending the pageview event' do
+      subject { described_class.new(env, {tracker: 'afake'}).render }
+
+      it 'does not send a pageview event' do
+        expect(subject).to include "ga('send', 'pageview'"
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-tracker
 version: !ruby/object:Gem::Version
-  version: 1.11.1
+  version: 1.11.2
 platform: ruby
 authors:
 - Lars Brillert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-01 00:00:00.000000000 Z
+date: 2019-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack