rack-tracker 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9e06fd93da7b2594ba21af4171a47a389f2ffb1e
-  data.tar.gz: 73edb90317f7a22edd542ab35ec423e3c2fc6d68
+  metadata.gz: b7d3f0a731a9473254d058fda92f9e088a255470
+  data.tar.gz: 897423fe72752a8dc9a7a49513b6554b70245f53
 SHA512:
-  metadata.gz: fb4613641c9e9702f74910113054b3790e735af819d3e8a1deb375084e4600ca4153f714156619fc216d55134aea0042af5f16a1b76bf4ac42da79a4c244b0f1
-  data.tar.gz: 8bd52e40757e7a90187093db950825cc37d4f13d376b68c142e02f6a4a9c0bde81c8a9eb9052f41666ae37c45b914b6b465d8380900eef7b8e60391edd57224d
+  metadata.gz: d298b6b90718d9fbe380dc47c8408b1c9a7e987b2d85b2eafb98b69fb922289e5797e581891304c23f53dd5b9a0c26600a9cea4982ec7147c36f6f8e230cf6c9
+  data.tar.gz: 8480c1144c530cb3ba33739e4c5ecba55e5bcfa036bc14ced3633097590e936464899a49c31011380d1a9be90a8bd126d2034b5fc795aa96160c6de68196069a

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.2.5
+
+  * [BUGFIX] stringify google analytics event values to be api compliant
+
 # 0.2.4
 
   * [ENHANCEMENT] support all the rack versions >= 1.5.2

data/lib/rack/tracker/extensions.rb

@@ -6,3 +6,12 @@ class OpenStruct
     @table.dup
   end unless method_defined? :to_h
 end
+
+class Hash
+  def stringify_values
+    inject({}) do |options, (key, value)|
+      options[key] = value.to_s
+      options
+    end
+  end
+end

data/lib/rack/tracker/google_analytics/google_analytics.rb

@@ -10,7 +10,7 @@ class Rack::Tracker::GoogleAnalytics < Rack::Tracker::Handler
     end
 
     def event
-      { hitType: self.type }.merge(attributes).compact
+      { hitType: self.type }.merge(attributes.stringify_values).compact
     end
 
     def attributes
@@ -20,7 +20,7 @@ class Rack::Tracker::GoogleAnalytics < Rack::Tracker::Handler
 
   class Ecommerce < OpenStruct
     def write
-      ["ecommerce:#{self.type}", self.to_h.except(:type).compact].to_json.gsub(/\[|\]/, '')
+      ["ecommerce:#{self.type}", self.to_h.except(:type).compact.stringify_values].to_json.gsub(/\[|\]/, '')
     end
   end
 

data/lib/rack/tracker/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Tracker
-    VERSION = "0.2.4"
+    VERSION = '0.2.5'
   end
 end

data/spec/handler/google_analytics_spec.rb

@@ -48,13 +48,13 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
     describe "with a event value" do
       def env
         {'tracker' => { 'google_analytics' => [
-          Rack::Tracker::GoogleAnalytics::Send.new(category: "Users", action: "Login", label: "Standard", value: 5)
+          Rack::Tracker::GoogleAnalytics::Send.new(category: "Users", action: "Login", label: "Standard", value: "5")
         ]}}
       end
 
       subject { described_class.new(env, tracker: 'somebody').render }
       it "will show events with values" do
-        expect(subject).to match(%r{ga\(\"send\",{\"hitType\":\"event\",\"eventCategory\":\"Users\",\"eventAction\":\"Login\",\"eventLabel\":\"Standard\",\"eventValue\":5}\)},)
+        expect(subject).to match(%r{ga\(\"send\",{\"hitType\":\"event\",\"eventCategory\":\"Users\",\"eventAction\":\"Login\",\"eventLabel\":\"Standard\",\"eventValue\":\"5\"}\)},)
       end
     end
   end
@@ -75,7 +75,7 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
         expect(subject).to match(%r{ga\(\"ecommerce:addItem\",#{{id: '1234', name: 'Fluffy Pink Bunnies', sku: 'DD23444', category: 'Party Toys', price: '11.99', quantity: '1'}.to_json}})
       end
       it "will add transaction" do
-        expect(subject).to match(%r{ga\(\"ecommerce:addTransaction\",#{{id: '1234', affiliation: 'Acme Clothing', revenue: 11.99, shipping: '5', tax: '1.29', currency: 'EUR'}.to_json}})
+        expect(subject).to match(%r{ga\(\"ecommerce:addTransaction\",#{{id: '1234', affiliation: 'Acme Clothing', revenue: '11.99', shipping: '5', tax: '1.29', currency: 'EUR'}.to_json}})
       end
       it "will submit cart" do
         expect(subject).to match(%r{ga\('ecommerce:send'\);})

data/spec/integration/google_analytics_integration_spec.rb

@@ -11,7 +11,8 @@ RSpec.describe "Facebook Integration" do
   subject { page }
 
   it "embeds the script tag with tracking event from the controller action" do
-    expect(page).to have_content('ga("ecommerce:addItem",{"id":"1234","affiliation":"Acme Clothing","revenue":"11.99","shipping":"5","tax":"1.29"})')
+    expect(page).to have_content('ga("ecommerce:addItem",{"id":"1234","name":"Fluffy Pink Bunnies","sku":"DD23444","category":"Party Toys","price":"11.99","quantity":"1"})')
+    expect(page).to have_content('ga("ecommerce:addTransaction",{"id":"1234","affiliation":"Acme Clothing","revenue":"11.99","shipping":"5","tax":"1.29"})')
     expect(page).to have_content('ga("send",{"hitType":"event","eventCategory":"button","eventAction":"click","eventLabel":"nav-buttons","eventValue":"X"})')
   end
 end

data/spec/support/metal_controller.rb

@@ -24,7 +24,8 @@ class MetalController < ActionController::Metal
 
   def google_analytics
     tracker do |t|
-      t.google_analytics :ecommerce, { type: 'addItem', id: '1234', affiliation: 'Acme Clothing', revenue: '11.99', shipping: '5', tax: '1.29' }
+      t.google_analytics :ecommerce, { type: 'addTransaction', id: 1234, affiliation: 'Acme Clothing', revenue: 11.99, shipping: 5, tax: 1.29 }
+      t.google_analytics :ecommerce, { type: 'addItem', id: 1234, name: 'Fluffy Pink Bunnies', sku: 'DD23444', category: 'Party Toys', price: 11.99, quantity: 1 }
       t.google_analytics :send, { type: 'event', category: 'button', action: 'click', label: 'nav-buttons', value: 'X' }
     end
     render "metal/index"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-tracker
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Lars Brillert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-10-09 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack