rack-tracker 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 97f035e08e02fd6f5927ecee4b6b45f5399c2ff1
-  data.tar.gz: b306ab023b986bdc7c310db0235015f96771b4b8
+  metadata.gz: ee9ff19b84fd4c1015a6fcb45ed4058730690a18
+  data.tar.gz: bee999355979d360bd8304cfd874ef9fb17fe905
 SHA512:
-  metadata.gz: 539880d620907a7858aa85295662e5241525986ddd7927c1cd21184673892a6e01bfd9770959e14fc5ecee67a32ac38f33538caa532421c56f33e62a49eb408d
-  data.tar.gz: b1db441f749f803be06d87aa987f36fcd9f1ff84811ae00f12ded89cad038db94fb32066d3809958b38194c86fd0c37f2617f37227f1b4939c864aab71a9bd58
+  metadata.gz: fa80a05b10f7fbd960127453a5c83deb0888c1b04f57164a70a78cb12edf986d96ea8957af416951c9daa86e07f00c10593babe2aa08bee8bdfec43c3e904c72
+  data.tar.gz: dc886bd2cbd1c9ee963bf94a14d54e43c89cf5497ac1f4fa83d41b2c3c78d5cf62ab242e0aa2d2ac1ca7608444a5c65b3755eba19794558ca91afa8502d39ecf

data/CHANGELOG.md

@@ -0,0 +1,21 @@
+# 0.1.3
+
+  * [BUGFIX] ecommerce events weren't created properly
+
+# 0.1.2
+
+  * cart is now auto submitted to when ecommerce is turned on and items or transactions are in the queue
+
+# 0.1.1
+
+  * [BUGFIX] return value of the `tracker`-block is kinda unpredictabel, so we skip further processing
+
+# 0.1.0
+
+  * README
+  * unified facebook and google handler `#track`-signature (3009b3834ad07caf8818484ddd86d8a0eb128fe5)
+
+# 0.0.4
+
+  * keep events over multiple redirectes
+  * allow multiple calls of the same handler in one `tracker` block

data/README.md

@@ -4,6 +4,8 @@
 
 [![Build Status](https://travis-ci.org/railslove/rack-tracker.svg?branch=master)](https://travis-ci.org/railslove/rack-tracker)
 
+
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -57,7 +59,7 @@ To issue [Events](https://developers.google.com/analytics/devguides/collection/a
 It will render the following to the site source:
 
 ```javascript
-  ga('send', { 'hitType': 'event', 'eventCategory': 'button', 'eventAction': 'click', 'eventLabel': 'X' })
+  ga('send', { 'hitType': 'event', 'eventCategory': 'button', 'eventAction': 'click', 'eventLabel': 'nav-buttons', 'value': 'X' })
 ```
 
 #### Ecommerce
@@ -67,7 +69,7 @@ You can even trigger ecommerce directly from within your controller:
 ```ruby
   def show
     tracker do |t|
-      t.google_analytics :ecommerce, { type: 'addItem', 'id': '1234', 'affiliation': 'Acme Clothing', 'revenue': '11.99', 'shipping': '5', 'tax': '1.29' }
+      t.google_analytics :ecommerce, { type: 'addItem', id: '1234', affiliation: 'Acme Clothing', revenue: '11.99', shipping: '5', tax: '1.29' }
     end
   end
 ```
@@ -93,7 +95,7 @@ take care of the plugin on your own.
 
 * `custom_audience` - adds the [Custom audience](https://developers.facebook.com/docs/reference/ads-api/custom-audience-website-faq) segmentation pixel
 
-#### Events
+#### Conversions
 
 To track [Conversions](https://www.facebook.com/help/435189689870514) from the server side just call the `tracker` method in your controller.
 
@@ -111,7 +113,7 @@ Will result in the following:
   window._fbq.push(["track", "123456789", {'value': 1, 'currency': 'EUR'}]);
 ```
 
-## Custom Handlers
+#### Custom Handlers
 
 Tough we give you Google Analytics and Facebook right out of the box, you might
 be interested adding support for your custom tracking/analytics service.
@@ -132,7 +134,7 @@ template.
 
 ```ruby
 def render
-  Tilt.new( File.join( File.dirname(__FILE__), 'template' 'my_handler.erb') ).render(self)
+  Tilt.new( File.join( File.dirname(__FILE__), 'template', 'my_handler.erb') ).render(self)
 end
 ```
 
@@ -168,7 +170,7 @@ class MyHandler <  Rack::Tracker::Handler
 end
 ```
 
-The snippot will then be rendered right before `</body>`.
+The snippit will then be rendered right before `</body>`.
 
 
 ## Contributing

data/lib/rack/tracker/google_analytics/google_analytics.rb

@@ -32,7 +32,11 @@ class Rack::Tracker::GoogleAnalytics < Rack::Tracker::Handler
     Tilt.new( File.join( File.dirname(__FILE__), 'template', 'google_analytics.erb') ).render(self)
   end
 
+  def ecommerce_events
+    events.select{|e| e.kind_of?(Ecommerce) }
+  end
+
   def self.track(name, *event)
-    { name.to_s => [Send.new(event.last)] }
+    { name.to_s => [const_get(event.first.to_s.capitalize).new(event.last)] }
   end
 end

data/lib/rack/tracker/google_analytics/template/google_analytics.erb

@@ -36,6 +36,10 @@
   ga(<%= var.write() %>);
 <% end %>
 
+<% if options[:ecommerce] && ecommerce_events.any? %>
+  ga('send:ecommerce');
+<% end %>
+
 <% if tracker %>
   ga('send', 'pageview');
 <% end %>

data/lib/rack/tracker/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class Tracker
-    VERSION = "0.1.1"
+    VERSION = "0.1.3"
   end
 end

data/spec/handler/google_analytics_spec.rb

@@ -9,6 +9,26 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
     expect(described_class.new(env).position).to eq(:head)
   end
 
+  describe '#ecommerce_events' do
+    subject { described_class.new(env) }
+
+    describe 'with stored ecommerce events' do
+      before { allow(subject).to receive(:events).and_return([Rack::Tracker::GoogleAnalytics::Send.new, Rack::Tracker::GoogleAnalytics::Ecommerce.new]) }
+
+      it 'will just return the ecommerce events' do
+        expect(subject.ecommerce_events).to match_array(Rack::Tracker::GoogleAnalytics::Ecommerce)
+      end
+    end
+
+    describe 'without stored ecommerce events' do
+      before { allow(subject).to receive(:events).and_return([Rack::Tracker::GoogleAnalytics::Send.new]) }
+
+      it 'will be empty' do
+        expect(subject.ecommerce_events).to be_empty
+      end
+    end
+  end
+
   describe "with events" do
     describe "default" do
       def env
@@ -19,7 +39,7 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
         }}
       end
 
-      subject { described_class.new(env, tracker: 'somebody', cookieDomain: "railslabs.com").render }
+      subject { described_class.new(env, tracker: 'somebody').render }
       it "will show events" do
         expect(subject).to match(%r{ga\(\"send\",{\"hitType\":\"event\",\"eventCategory\":\"Users\",\"eventAction\":\"Login\",\"eventLabel\":\"Standard\"}\)})
       end
@@ -32,7 +52,7 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
         ]}}
       end
 
-      subject { described_class.new(env, tracker: 'somebody', cookieDomain: "railslabs.com").render }
+      subject { described_class.new(env, tracker: 'somebody').render }
       it "will show events with values" do
         expect(subject).to match(%r{ga\(\"send\",{\"hitType\":\"event\",\"eventCategory\":\"Users\",\"eventAction\":\"Login\",\"eventLabel\":\"Standard\",\"eventValue\":5}\)},)
       end
@@ -49,10 +69,13 @@ RSpec.describe Rack::Tracker::GoogleAnalytics do
         }}
       end
 
-      subject { described_class.new(env, tracker: 'somebody', cookieDomain: "railslabs.com").render }
-      it "will show events" do
+      subject { described_class.new(env, tracker: 'somebody', ecommerce: true).render }
+      it "will add items" do
         expect(subject).to match(%r{ga\(\"ecommerce:addItem\",#{{id: '1234', affiliation: 'Acme Clothing', revenue: 11.99, shipping: '5', tax: '1.29', currency: 'EUR'}.to_json}})
       end
+      it "will submit cart" do
+        expect(subject).to match(%r{ga\('send:ecommerce'\);})
+      end
     end
   end
 

data/spec/integration/google_analytics_integration_spec.rb

@@ -0,0 +1,22 @@
+require 'support/metal_controller'
+require 'support/fake_handler'
+
+RSpec.describe "Facebook Integration" do
+  before do
+    Capybara.app = Rack::Builder.new do
+      use Rack::Tracker do
+        handler :google_analytics, { tracker: 'U-XXX-Y' }
+      end
+      run MetalController.action(:google_analytics)
+    end
+
+    visit '/'
+  end
+
+  subject { page }
+
+  it "embeds the script tag with tracking event from the controller action" do
+    expect(page).to have_content('ga("ecommerce:addItem",{"id":"1234","affiliation":"Acme Clothing","revenue":"11.99","shipping":"5","tax":"1.29"})')
+    expect(page).to have_content('ga("send",{"hitType":"event","eventCategory":"button","eventAction":"click","eventLabel":"nav-buttons","eventValue":"X"})')
+  end
+end

data/spec/support/metal_controller.rb

@@ -21,4 +21,12 @@ class MetalController < ActionController::Metal
     end
     render "metal/index"
   end
+
+  def google_analytics
+    tracker do |t|
+      t.google_analytics :ecommerce, { type: 'addItem', id: '1234', affiliation: 'Acme Clothing', revenue: '11.99', shipping: '5', tax: '1.29' }
+      t.google_analytics :send, { type: 'event', category: 'button', action: 'click', label: 'nav-buttons', value: 'X' }
+    end
+    render "metal/index"
+  end
 end

data/spec/tracker/controller_spec.rb

@@ -11,29 +11,17 @@ end
 
 RSpec.describe Rack::Tracker::Controller do
   describe '#tracker' do
-    pending
-    # let(:event) { Rack::Tracker::GoogleAnalytics::Send.new(category: 'foo') }
-    # let(:controller) { TestController.new({}) }
+    let(:event) { Rack::Tracker::GoogleAnalytics::Send.new(category: 'foo') }
+    let(:controller) { TestController.new({}) }
 
-    # context 'controller' do
-    #   it 'writes the event into env' do
-    #     expect {
-    #       controller.index
-    #     }.to change {
-    #       controller.env
-    #     }.from({}).to('tracker' => {'google_analytics' => [event]})
-    #   end
-
-    #   it 'returns only the handlers' do
-    #     expect(
-    #       controller.tracker do |t|
-    #         t.google_analytics category: 'foo'
-    #         2.times do
-    #           t.facebook some: 'thing'
-    #         end
-    #       end
-    #     ).to eql([:google_analytics, :facebook])
-    #   end
-    # end
+    context 'controller' do
+      it 'writes the event into env' do
+        expect {
+          controller.index
+        }.to change {
+          controller.env
+        }.from({}).to('tracker' => {'google_analytics' => [event]})
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-tracker
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - Lars Brillert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-01 00:00:00.000000000 Z
+date: 2014-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -149,6 +149,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -173,6 +174,7 @@ files:
 - spec/handler/facebook_spec.rb
 - spec/handler/google_analytics_spec.rb
 - spec/integration/facebook_integration_spec.rb
+- spec/integration/google_analytics_integration_spec.rb
 - spec/integration/rails_integration_spec.rb
 - spec/spec_helper.rb
 - spec/support/fake_handler.rb
@@ -214,6 +216,7 @@ test_files:
 - spec/handler/facebook_spec.rb
 - spec/handler/google_analytics_spec.rb
 - spec/integration/facebook_integration_spec.rb
+- spec/integration/google_analytics_integration_spec.rb
 - spec/integration/rails_integration_spec.rb
 - spec/spec_helper.rb
 - spec/support/fake_handler.rb