rack-track 0.1.1 → 0.1.2

data/Gemfile

@@ -1,9 +1,3 @@
 source "http://rubygems.org"
-gem "rack"
 
-group :development do
-  gem "bundler", "~> 1.0.0"
-  gem "jeweler", "~> 1.6.4"
-  gem "rcov", ">= 0"
-  gem "rack-test"
-end
+gemspec

data/README.markdown

@@ -4,11 +4,13 @@ On too many projects I've worked on, nobody actually know every tracking pixel w
 becomes a massive headache when you need to do work around them. This is where Rack::Track comes in to play, providing a DSL to define tracking pixels
 and the areas they should appear on. It's all in one place, instead of across layouts and pages and it's self documenting. 
 
+The only option on pixel is :on, where you identify an area of the site to appear on. Other options are ignored, making it useful to track owners, departments etc who 'own' the pixel.
+
 ```ruby
 MyApp::Application.config.middleware.use(Rack::Track) do
   area :confirmation_pages, "/checkout/order_confirmation", "/basket/complete"
   
-  pixel "Generic GA", :on => :all_pages do
+  pixel "Generic GA", :on => :all_pages, :owner => "Anna Lyst" do
     %Q{
       <!-- GOOGLE ANALYTICS --> 
       blah
@@ -16,7 +18,7 @@ MyApp::Application.config.middleware.use(Rack::Track) do
     }
   end
   
-  pixel "Goal GA", :on => :confirmation_pages do
+  pixel "Goal GA", :on => :confirmation_pages, :owner => "Anna Lyst" do
     %Q{
       <!-- GOOGLE ANALYTICS --> 
       blah
@@ -25,6 +27,7 @@ MyApp::Application.config.middleware.use(Rack::Track) do
   end
 end
 ```
+
 These tracking pixels will be inserted in to the page before the body tag closes. This is what most tracking pixels expect. If you require a pixel
 to be placed in the head tag, or anywhere else, let me know and I'll extend it (or you could clone and submit a pull request with your changes!)
 

data/Rakefile

@@ -15,7 +15,7 @@ require 'jeweler'
 Jeweler::Tasks.new do |gem|
   # gem is a Gem::Specification... see http://docs.rubygems.org/read/chapter/20 for more options
   gem.name = "rack-track"
-  gem.version = "0.1.1"
+  gem.version = "0.1.2"
   gem.homepage = "http://github.com/michaelbaldry/rack-track"
   gem.license = "MIT"
   gem.summary = %Q{Taking all the pain away from managing Tracking Pixels}

data/VERSION

@@ -1 +1 @@
-0.1.1
+0.1.2

data/lib/rack/track.rb

@@ -13,6 +13,7 @@ module Rack
         response_body = ""
         response.each { |p| response_body += p }
         response = [@rules.apply(request, response_body)] if response_body.include? "</body>"
+        headers["Content-Length"] = response.inject{|sum,x| sum + x }
       end
       
       [status, headers, response]

data/rack-track.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rack-track}
-  s.version = "0.1.1"
+  s.version = "0.1.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.authors = [%q{Michael Baldry}]
-  s.date = %q{2011-08-03}
+  s.authors = ["Michael Baldry"]
+  s.date = %q{2011-08-24}
   s.description = %q{A rack middleware that allows you to define and document tracking pixels in one location}
   s.email = %q{clockwize@gmail.com}
   s.extra_rdoc_files = [
@@ -19,7 +19,6 @@ Gem::Specification.new do |s|
   s.files = [
     ".document",
     "Gemfile",
-    "Gemfile.lock",
     "LICENSE.txt",
     "README.markdown",
     "Rakefile",
@@ -31,30 +30,30 @@ Gem::Specification.new do |s|
     "test/test_rack-track.rb"
   ]
   s.homepage = %q{http://github.com/michaelbaldry/rack-track}
-  s.licenses = [%q{MIT}]
-  s.require_paths = [%q{lib}]
-  s.rubygems_version = %q{1.8.6}
+  s.licenses = ["MIT"]
+  s.require_paths = ["lib"]
+  s.rubygems_version = %q{1.6.2}
   s.summary = %q{Taking all the pain away from managing Tracking Pixels}
 
   if s.respond_to? :specification_version then
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<rack>, [">= 0"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_runtime_dependency(%q<rack-track>, [">= 0"])
+      s.add_development_dependency(%q<bundler>, ["~> 1.0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.6.4"])
       s.add_development_dependency(%q<rcov>, [">= 0"])
       s.add_development_dependency(%q<rack-test>, [">= 0"])
     else
-      s.add_dependency(%q<rack>, [">= 0"])
-      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<rack-track>, [">= 0"])
+      s.add_dependency(%q<bundler>, ["~> 1.0"])
       s.add_dependency(%q<jeweler>, ["~> 1.6.4"])
       s.add_dependency(%q<rcov>, [">= 0"])
       s.add_dependency(%q<rack-test>, [">= 0"])
     end
   else
-    s.add_dependency(%q<rack>, [">= 0"])
-    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<rack-track>, [">= 0"])
+    s.add_dependency(%q<bundler>, ["~> 1.0"])
     s.add_dependency(%q<jeweler>, ["~> 1.6.4"])
     s.add_dependency(%q<rcov>, [">= 0"])
     s.add_dependency(%q<rack-test>, [">= 0"])

data/test/test_rack-track.rb

@@ -9,9 +9,9 @@ class TestRackTrack < Test::Unit::TestCase
     @app_class = SimpleApp
   end
   
-  FAIL_RULE = Proc.new do
+  SAMPLE_RULE = Proc.new do 
     pixel "Test pixel", :on => :all do
-      "FAIL"
+      "THIS-IS-A-TEST"
     end
   end
   
@@ -39,11 +39,7 @@ class TestRackTrack < Test::Unit::TestCase
   end
   
   def test_psudo_area_all
-    @rules = Proc.new do 
-      pixel "Test pixel", :on => :all do
-        "THIS-IS-A-TEST"
-      end
-    end
+    @rules = SAMPLE_RULE
     get '/'
     assert last_response.body.include? "THIS-IS-A-TEST</body>"
     get '/poatoes'
@@ -73,10 +69,10 @@ class TestRackTrack < Test::Unit::TestCase
       end
     end
     
-    @rules = FAIL_RULE
+    @rules = SAMPLE_RULE
     
     get '/'
-    assert last_response.body != "<html><head><title></title></head><body>hello this is the bodyFAIL</body></html>"
+    assert last_response.body != "<html><head><title></title></head><body>hello this is the bodyTHIS-IS-A-TEST</body></html>"
   end
   
   def test_only_works_on_html_pages_with_charset
@@ -86,10 +82,10 @@ class TestRackTrack < Test::Unit::TestCase
       end
     end
     
-    @rules = FAIL_RULE
+    @rules = SAMPLE_RULE
     
     get '/'
-    assert last_response.body == "<html><head><title></title></head><body>hello this is the bodyFAIL</body></html>"
+    assert last_response.body == "<html><head><title></title></head><body>hello this is the bodyTHIS-IS-A-TEST</body></html>"
   end
   
   def test_only_works_on_pages_with_closing_body
@@ -99,9 +95,22 @@ class TestRackTrack < Test::Unit::TestCase
       end
     end
     
-    @rules = FAIL_RULE
+    @rules = SAMPLE_RULE
     
     get '/'
     assert last_response.body == "<html><head><title></title></head><body>hello this is the body</html>"
   end
+  
+  def test_fixes_content_length_header
+    @app_class = Class.new do
+      def call(env)
+        [200, {'Content-Type' => "text/html; charset=utf-8"}, ["<html><head><title></title></head><body>hello this is the body</body></html>"]]
+      end
+    end
+    
+    @rules = SAMPLE_RULE
+    
+    get '/'
+    assert_equal "<html><head><title></title></head><body>hello this is the bodyTHIS-IS-A-TEST</body></html>".length, last_response.headers["Content-Length"].to_i
+  end
 end

metadata

@@ -1,8 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack-track
 version: !ruby/object:Gem::Version 
+  hash: 31
   prerelease: 
-  version: 0.1.1
+  segments: 
+  - 0
+  - 1
+  - 2
+  version: 0.1.2
 platform: ruby
 authors: 
 - Michael Baldry
@@ -10,62 +15,81 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-08-03 00:00:00 Z
+date: 2011-08-24 00:00:00 +01:00
+default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: rack
+  prerelease: false
+  type: :runtime
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
         version: "0"
-  type: :runtime
-  prerelease: false
+  name: rack-track
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
-  name: bundler
+  prerelease: false
+  type: :development
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
-        version: 1.0.0
-  type: :development
-  prerelease: false
+        hash: 15
+        segments: 
+        - 1
+        - 0
+        version: "1.0"
+  name: bundler
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: jeweler
+  prerelease: false
+  type: :development
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 6
+        - 4
         version: 1.6.4
-  type: :development
-  prerelease: false
+  name: jeweler
   version_requirements: *id003
 - !ruby/object:Gem::Dependency 
-  name: rcov
+  prerelease: false
+  type: :development
   requirement: &id004 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
         version: "0"
-  type: :development
-  prerelease: false
+  name: rcov
   version_requirements: *id004
 - !ruby/object:Gem::Dependency 
-  name: rack-test
+  prerelease: false
+  type: :development
   requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
         version: "0"
-  type: :development
-  prerelease: false
+  name: rack-test
   version_requirements: *id005
 description: A rack middleware that allows you to define and document tracking pixels in one location
 email: clockwize@gmail.com
@@ -79,7 +103,6 @@ extra_rdoc_files:
 files: 
 - .document
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.markdown
 - Rakefile
@@ -89,6 +112,7 @@ files:
 - rack-track.gemspec
 - test/helper.rb
 - test/test_rack-track.rb
+has_rdoc: true
 homepage: http://github.com/michaelbaldry/rack-track
 licenses: 
 - MIT
@@ -102,7 +126,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 3383668994400887941
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -111,11 +135,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.8.6
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Taking all the pain away from managing Tracking Pixels

data/Gemfile.lock

@@ -1,23 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    git (1.2.5)
-    jeweler (1.6.4)
-      bundler (~> 1.0)
-      git (>= 1.2.5)
-      rake
-    rack (1.3.2)
-    rack-test (0.5.7)
-      rack (>= 1.0)
-    rake (0.9.2)
-    rcov (0.9.9)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (~> 1.0.0)
-  jeweler (~> 1.6.4)
-  rack
-  rack-test
-  rcov