rack-timeout 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3011645170de523349a1928ac09ee55825019f0b
-  data.tar.gz: 17fcae3abe9f9cf37391a6381a795c142791cde5
+  metadata.gz: c9ae29d987db68c611785883420553a2f6f40ee7
+  data.tar.gz: 1c1785b62a64d3a6cf5b5937baae4dec0a092ddd
 SHA512:
-  metadata.gz: 6eac121daa70934e450db7320a92544840bcc0adba0a38539af380394ac239b546fb428daefa0544a372bff20627f704dfe1ae4415ee99085de1b987b7af35c8
-  data.tar.gz: 7db38b0f4e1b4d9e2678de2efc867efd2b3381cb615dccf1d365f766576b08107a4d8bc7c2e1fdaf18846a912e88c8ba07862999a86002d7aa1046121b3e886b
+  metadata.gz: 22dd8d23074301936134273f9dd3763c1dfb03a42ad49ea0e63f53f0db64095135e00b33fdcc08f9b10fb9a8d43ad94c3dc94bf527e054e6e0376c65a8c6d131
+  data.tar.gz: 114c9f37b4b435d213eb33fa4596cc18b0949f1c670fd2c9c25b3a4a061666ffb7a1bd52540d46b752d1795b224455ab9399b8d496e8e5f62cfb9812c0a8270a

data/CHANGELOG

@@ -1,3 +1,7 @@
+0.3.2
+=====
+- Fixes calling timeout with a value of 0 (issue #90)
+
 0.3.1
 =====
 - Rollbar module improvements

data/README.markdown

@@ -213,7 +213,6 @@ You can remove an observer with `unregister_state_change_observer`:
 Rack::Timeout.unregister_state_change_observer(:a_unique_name)
 ```
 
-
 rack-timeout's logging is implemented using an observer; see `Rack::Timeout::StateChangeLoggingObserver` in logging-observer.rb for the implementation.
 
 Custom observers might be used to do cleanup, store statistics on request length, timeouts, etc., and potentially do performance tuning on the fly.

data/lib/rack/timeout/rollbar.rb

@@ -1,22 +1,25 @@
 require_relative "core"
 
 # Groups timeout exceptions in rollbar by exception class, http method, and url.
-# Usage: after requiring rollbar, call:
+#
+# Usage: after requiring rollbar (say, in your rollbar initializer file), call:
+#
 #   require "rack/timeout/rollbar"
 #
 # This is somewhat experimental and very lightly tested.
 #
-# Ruby 2.0 is required as we use Module.prepend
+# Ruby 2.0 is required as we use `Module.prepend`.
 
 module Rack::Timeout::Rollbar
   def build_payload(level, message, exception, extra)
     payload = super(level, message, exception, extra)
 
-    return payload unless exception.is_a? ::Rack::Timeout::ExceptionWithEnv
-    return payload unless payload.respond_to? :[]
+    return payload unless exception.is_a?(::Rack::Timeout::ExceptionWithEnv) \
+                       && payload.respond_to?(:[])                           \
+                       && payload.respond_to?(:[]=)
 
     data = payload["data"]
-    return payload unless data.respond_to? :[]=
+    return payload unless data.respond_to?(:[]=)
 
     request = ::Rack::Request.new(exception.env)
     payload = payload.dup

data/lib/rack/timeout/support/timeout.rb

@@ -18,7 +18,7 @@ class Rack::Timeout::Scheduler::Timeout
     job = @scheduler.run_in(secs) { @on_timeout.call thr }  # schedule this thread to be timed out; should get cancelled if block completes on time
     return block.call                                       # do what you gotta do
   ensure                                                    #
-    job.cancel!                                             # cancel the scheduled timeout job; if the block completed on time, this
+    job.cancel! if job                                      # cancel the scheduled timeout job; if the block completed on time, this
   end                                                       # will get called before the timeout code's had a chance to run.
 
   # timeout method on singleton instance for when a custom on_timeout is not required

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-timeout
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Caio Chassot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-03 00:00:00.000000000 Z
+date: 2015-09-07 00:00:00.000000000 Z
 dependencies: []
 description: Rack middleware which aborts requests that have been running for longer
   than a specified timeout.