rack-test 0.8.3 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 98d93b9da867444521efc5c2d82d14b37c2b5743324865f96d2f6c0603ad8256
-  data.tar.gz: 3f78a90b58f6de6582088185f995195841995e9b2a0a9518a93ecee081eb8416
+  metadata.gz: ffbb291753487a29727c09ba1b0b96cf873564798ef6f984931256b54043eadd
+  data.tar.gz: e9f40c35a2578f36cfbfffb17efc796543455c2617961350790f1742653566c0
 SHA512:
-  metadata.gz: 3bd23e7ffcfa4ab19ad2966f36bcab31f49f3ea7f819fb81f15ce874437d8c6b96c6844f40499512042166b007d940b819b44e8d978ba4001f77fe515225f529
-  data.tar.gz: 9d0479de503ae1a74f2aa9263b39dfdabf1745c17bed3fc18e6aaf757bf0b7428510f26a08c0021090ec98f8125eca74fb19e9f7f19eef41a94dd9847a441472
+  metadata.gz: 3c2735a0f2564b979b9b5fcd9f5f952e7c0bf0b3f31071271089b8df2b34e18436e516a38bf3d708082b07169bbd79612a6286610b072970bb1c79636c31d1e9
+  data.tar.gz: aa3444f42ebb904a6b33c03cfdb3787cef34acbe96171569395123483b5b0df66401d959576990d90ced9e587fdbfbba049f42884cec2696549ea685b6643baa

data/History.md

@@ -1,3 +1,17 @@
+## 1.0.0 / 2018-03-27
+
+* Breaking changes:
+  * Always set CONTENT_TYPE for non-GET requests
+    (Per Lundberg #223)
+
+* Minor enhancements / bug fixes:
+  * Create tempfile using the basename without extension
+    (Edouard Chin #201)
+  * Save `session` during `follow_redirect!`
+    (Alexander Popov #218)
+  * Document how to use URL params with DELETE method
+    (Timur Platonov #220)
+
 ## 0.8.3 / 2018-02-27
 
 * Bug fixes:

data/README.md

@@ -28,6 +28,10 @@ to build on.
 
 If you are using Ruby 1.8, 1.9 or JRuby 1.7, use rack-test 0.6.3.
 
+## Known incompatibilites
+
+* `rack-test >= 0.71` _does not_ work with older Capybara versions (`< 2.17`). See [#214](https://github.com/rack-test/rack-test/issues/214) for more details.
+
 ## Examples
 (The examples use `Test::Unit` but it's equally possible to use `rack-test` with other testing frameworks like `rspec`.)
 
@@ -72,6 +76,10 @@ class HomepageTest < Test::Unit::TestCase
     # parameters, so make sure that `json` below is already a JSON-serialized string.
     post(uri, json, { 'CONTENT_TYPE' => 'application/json' })
   end
+  
+  def delete_with_url_params_and_body
+    delete '/?foo=bar', JSON.generate('baz' => 'zot')
+  end
 end
 ```
 
@@ -106,7 +114,7 @@ gem install rack-test
 Or via Bundler:
 
 ```
-gem 'rack-test', require: 'rack/test'
+gem 'rack-test'
 ```
 
 Or to install unreleased version via Bundler:

data/lib/rack/test.rb

@@ -188,11 +188,17 @@ module Rack
         unless last_response.redirect?
           raise Error, 'Last response was not a redirect. Cannot follow_redirect!'
         end
-        if last_response.status == 307
-          send(last_request.request_method.downcase.to_sym, last_response['Location'], last_request.params, 'HTTP_REFERER' => last_request.url)
-        else
-          get(last_response['Location'], {}, 'HTTP_REFERER' => last_request.url)
-        end
+        request_method, params =
+          if last_response.status == 307
+            [last_request.request_method.downcase.to_sym, last_request.params]
+          else
+            [:get, {}]
+          end
+        send(
+          request_method, last_response['Location'], params,
+          'HTTP_REFERER' => last_request.url,
+          'rack.session' => last_request.session
+        )
       end
 
       private
@@ -227,7 +233,7 @@ module Rack
             uri.query = [uri.query, build_nested_query(params)].compact.reject { |v| v == '' }.join('&')
           end
         elsif !env.key?(:input)
-          env['CONTENT_TYPE'] ||= 'application/x-www-form-urlencoded' unless params.nil?
+          env['CONTENT_TYPE'] ||= 'application/x-www-form-urlencoded'
 
           if params.is_a?(Hash)
             if data = build_multipart(params)
@@ -235,6 +241,8 @@ module Rack
               env['CONTENT_LENGTH'] ||= data.length.to_s
               env['CONTENT_TYPE'] = "multipart/form-data; boundary=#{MULTIPART_BOUNDARY}"
             else
+              # NB: We do not need to set CONTENT_LENGTH here;
+              # Rack::ContentLength will determine it automatically.
               env[:input] = params_to_string(params)
             end
           else

data/lib/rack/test/cookie_jar.rb

@@ -106,6 +106,8 @@ module Rack
     end
 
     class CookieJar # :nodoc:
+      DELIMITER = '; '.freeze
+
       # :api: private
       def initialize(cookies = [], default_host = DEFAULT_HOST)
         @default_host = default_host
@@ -158,7 +160,7 @@ module Rack
 
       # :api: private
       def for(uri)
-        hash_for(uri).values.map(&:raw).join(';')
+        hash_for(uri).values.map(&:raw).join(DELIMITER)
       end
 
       def to_hash

data/lib/rack/test/uploaded_file.rb

@@ -71,8 +71,9 @@ module Rack
         raise "#{path} file does not exist" unless ::File.exist?(path)
 
         @original_filename = ::File.basename(path)
+        extension = ::File.extname(@original_filename)
 
-        @tempfile = Tempfile.new([@original_filename, ::File.extname(path)])
+        @tempfile = Tempfile.new([::File.basename(@original_filename, extension), extension])
         @tempfile.set_encoding(Encoding::BINARY) if @tempfile.respond_to?(:set_encoding)
 
         ObjectSpace.define_finalizer(self, self.class.finalize(@tempfile))

data/lib/rack/test/version.rb

@@ -1,5 +1,5 @@
 module Rack
   module Test
-    VERSION = '0.8.3'.freeze
+    VERSION = '1.0.0'.freeze
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-test
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 1.0.0
 platform: ruby
 authors:
 - Bryan Helmkamp
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-27 00:00:00.000000000 Z
+date: 2018-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack