rack-test 0.5.2 → 0.5.3

data/History.txt

@@ -1,3 +1,9 @@
+== 0.5.3 / 2009-11-27
+
+* Bug fixes
+
+  * Fix cookie matching for subdomains (Marcin Kulik)
+
 == 0.5.2 / 2009-11-13
 
 * Bug fixes

data/lib/rack/test.rb

@@ -9,7 +9,7 @@ require "rack/test/uploaded_file"
 
 module Rack
   module Test
-    VERSION = "0.5.2"
+    VERSION = "0.5.3"
 
     DEFAULT_HOST = "example.org"
     MULTIPART_BOUNDARY = "----------XnJLe9ZIbbGUYtzPQJ16u1"

data/lib/rack/test/cookie_jar.rb

@@ -71,8 +71,9 @@ module Rack
           uri.host = @default_host
         end
 
+        real_domain = domain =~ /^\./ ? domain[1..-1] : domain
         (!secure? || (secure? && uri.scheme == "https")) &&
-        uri.host =~ Regexp.new("#{Regexp.escape(domain)}$", Regexp::IGNORECASE) &&
+        uri.host =~ Regexp.new("#{Regexp.escape(real_domain)}$", Regexp::IGNORECASE) &&
         uri.path =~ Regexp.new("^#{Regexp.escape(path)}")
       end
 

data/rack-test.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rack-test}
-  s.version = "0.5.2"
+  s.version = "0.5.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Bryan Helmkamp"]
-  s.date = %q{2009-11-13}
+  s.date = %q{2009-11-27}
   s.description = %q{Rack::Test is a small, simple testing API for Rack apps. It can be used on its
 own or as a reusable starting point for Web frameworks and testing libraries
 to build on. Most of its initial functionality is an extraction of Merb 1.0's

data/spec/fixtures/fake_app.rb

@@ -81,6 +81,14 @@ module Rack
         new_value
       end
 
+      get "/cookies/subdomain" do
+        old_value = request.cookies["count"].to_i || 0
+        new_value = (old_value + 1).to_s
+
+        response.set_cookie("count", :value => new_value, :domain => ".example.org")
+        new_value
+      end
+
       get "/cookies/set-uppercase" do
         raise if params["value"].nil?
 

data/spec/rack/test/cookie_spec.rb

@@ -133,6 +133,15 @@ describe Rack::Test::Session do
       last_request.cookies.should == { "value" => "example" }
     end
 
+    it "keeps one cookie jar for domain and its subdomains" do
+      get "http://example.org/cookies/subdomain"
+      get "http://example.org/cookies/subdomain"
+      last_request.cookies.should == { "count" => "1" }
+
+      get "http://foo.example.org/cookies/subdomain"
+      last_request.cookies.should == { "count" => "2" }
+    end
+
     it "allows cookies to be cleared" do
       get "/cookies/set", "value" => "1"
       clear_cookies

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rack-test
 version: !ruby/object:Gem::Version 
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors: 
 - Bryan Helmkamp
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-11-13 00:00:00 -05:00
+date: 2009-11-27 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency