rack-test 0.5.1 → 0.5.2

data/History.txt

@@ -1,3 +1,10 @@
+== 0.5.2 / 2009-11-13
+
+* Bug fixes
+
+  * Call close on response body after iteration, not before (Simon Rozet)
+  * Add missing require for time in cookie_jar.rb (Jerry West)
+
 == 0.5.1 / 2009-10-27
 
 * Bug fixes

data/lib/rack/mock_session.rb

@@ -28,9 +28,10 @@ module Rack
       env["HTTP_COOKIE"] ||= cookie_jar.for(uri)
       @last_request = Rack::Request.new(env)
       status, headers, body = @app.call(@last_request.env)
-      body.close if body.respond_to?(:close)
 
       @last_response = MockResponse.new(status, headers, body, env["rack.errors"].flush)
+      body.close if body.respond_to?(:close)
+
       cookie_jar.merge(last_response.headers["Set-Cookie"], uri)
 
       @after_request.each { |hook| hook.call }

data/lib/rack/test.rb

@@ -9,7 +9,7 @@ require "rack/test/uploaded_file"
 
 module Rack
   module Test
-    VERSION = "0.5.1"
+    VERSION = "0.5.2"
 
     DEFAULT_HOST = "example.org"
     MULTIPART_BOUNDARY = "----------XnJLe9ZIbbGUYtzPQJ16u1"

data/lib/rack/test/cookie_jar.rb

@@ -1,4 +1,5 @@
 require "uri"
+require "time"
 
 module Rack
   module Test

data/rack-test.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rack-test}
-  s.version = "0.5.1"
+  s.version = "0.5.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Bryan Helmkamp"]
-  s.date = %q{2009-10-27}
+  s.date = %q{2009-11-13}
   s.description = %q{Rack::Test is a small, simple testing API for Rack apps. It can be used on its
 own or as a reusable starting point for Web frameworks and testing libraries
 to build on. Most of its initial functionality is an extraction of Merb 1.0's

data/spec/rack/test_spec.rb

@@ -106,13 +106,43 @@ describe Rack::Test::Session do
       last_request.env["rack.input"].read.should == "foo[bar]=1"
     end
 
-    it "closes response's body" do
-      body = "Hello, World!"
-      body.should_receive(:close)
-      app = lambda {|env| 
-        [200, {"Content-Type" => "text/html", "Content-Length" => "13"}, body]
-      }
-      Rack::Test::Session.new(Rack::MockSession.new(app)).request("/")
+    context "when the response body responds_to?(:close)" do
+      class CloseableBody
+        def initialize
+          @closed = false
+        end
+
+        def each
+          return if @closed
+          yield "Hello, World!"
+        end
+
+        def close
+          @closed = true
+        end
+      end
+
+      it "closes response's body" do
+        body = CloseableBody.new
+        body.should_receive(:close)
+
+        app = lambda do |env|
+          [200, {"Content-Type" => "text/html", "Content-Length" => "13"}, body]
+        end
+
+        session = Rack::Test::Session.new(Rack::MockSession.new(app))
+        session.request("/")
+      end
+
+      it "closes response's body after iteration" do
+        app = lambda do |env|
+          [200, {"Content-Type" => "text/html", "Content-Length" => "13"}, CloseableBody.new]
+        end
+
+        session = Rack::Test::Session.new(Rack::MockSession.new(app))
+        session.request("/")
+        session.last_response.body.should == "Hello, World!"
+      end
     end
 
     context "when input is given" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rack-test
 version: !ruby/object:Gem::Version 
-  version: 0.5.1
+  version: 0.5.2
 platform: ruby
 authors: 
 - Bryan Helmkamp
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-10-27 00:00:00 -04:00
+date: 2009-11-13 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency