rack-steady_etag 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d3047cb500ace97518e12a5667bad5602d27b493f24d6a8a6c8236372fe7ca36
-  data.tar.gz: d9c3afe27e063227577e1921f6f4ce4e170f7f5627be0126096f1ed846ad7d1e
+  metadata.gz: 8caa8d352b72433a6659f50b6c9216cf03b265b19016134fa259719d24c46b4e
+  data.tar.gz: 74f01fc86755933b87361615bd6cb62568e44bfa404565261c0c180dcd5b399c
 SHA512:
-  metadata.gz: b86c5ec23d0d27170406530421acea4a54be83caf4c0513de01004136e92d2842aa771927f9ab8074bd918b83f3f10efc651b3e815dc8c5c2036769767c28077
-  data.tar.gz: b28cddf4577f20d1c0c75cdcf7c58d9ce5765f2148ab6fde4b9c0533725d09aa4c596b1624cab70c4e36a5b909e67153fd14ff95a272e9ef8fa0ee5ac81800c8
+  metadata.gz: 3cbd8de00297924f758d0c32151d17991fe8e235d943969544cdad632f50cca43eba12ef133c1a7690d91def4d8f997ab48535417457f62c8cb9d36a07a7e9d9
+  data.tar.gz: c2df595d03a3e3f46b2be21f4da14f76460556a0b8e6628959d7156d1a5285c79eb9c1a45415ad343904ed388c4645320ddc94a2422184727798d4b432eecd2e

data/CHANGELOG.md

@@ -5,13 +5,17 @@ This project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html
 
 ## Unreleased
 
+## 0.2.2 - 2022-05-12
+
+- Don't raise an error when processing binary content.
+
 ## 0.2.1 - 2022-05-12
 
 - Only strip patterns for HTML and XHTML responses.
 
 ## 0.2.0 - 2022-05-12
 
-- Be more compatible with Rack 2.2.2:
+- Be more compatible with Rack 2.2.3:
   - Always set a `Cache-Control` header, even for responses that we don't try to digest.
 - Strip patterns for responses with `Cache-Control: public`
 - Requires Rack 2.x (we want to break with Rack 3)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    rack-steady_etag (0.2.1)
+    rack-steady_etag (0.2.2)
       activesupport (>= 3.2)
       rack (~> 2.0)
 
@@ -14,9 +14,9 @@ GEM
       minitest (>= 5.1)
       tzinfo (~> 2.0)
     byebug (11.1.3)
-    concurrent-ruby (1.1.9)
+    concurrent-ruby (1.1.10)
     diff-lcs (1.4.4)
-    i18n (1.8.11)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
     minitest (5.15.0)
     rack (2.2.3)

data/README.md

@@ -35,10 +35,12 @@ Transformations are only applied for the `ETag` hash. The response body will not
 
 This middleware will process responses that match all of the following: 
 
-- Responses with a HTTP status of 200 or 201
-- Responses with a `Content-Type` of `text/html` or `application/xhtml+xml`
+- Responses with a HTTP status of 200 or 201.
+- Responses with a `Content-Type` of `text/html` or `application/xhtml+xml`.
 - Responses with a body. 
 
+Responses should also have an UTF-8 encoding (not checked by the middleware).
+
 This middleware can also add a default `Cache-Control` header for responses it *didn't* process. This is passed as an argument during middleware initialization (see *Installation* below). 
 
 ## Covered edge cases

data/lib/rack/steady_etag/version.rb

@@ -2,6 +2,6 @@
 
 module Rack
   class SteadyEtag
-    VERSION = "0.2.1"
+    VERSION = "0.2.2"
   end
 end

data/lib/rack/steady_etag.rb

@@ -6,8 +6,8 @@ require_relative "steady_etag/version"
 
 module Rack
 
-  # Based on Rack::Etag from rack 2.2.2
-  # https://github.com/rack/rack/blob/v2.2.2/lib/rack/etag.rb
+  # Based on Rack::Etag from rack 2.2.3
+  # https://github.com/rack/rack/blob/v2.2.3/lib/rack/etag.rb
   #
   # Automatically sets the ETag header on all String bodies.
   #
@@ -87,7 +87,7 @@ module Rack
     def etag_body?(body)
       # Rack main branch checks for `:to_ary` here to exclude streaming responses,
       # but that had other issues for me in testing. Maybe recheck when there is a
-      # new Rack release after 2.2.2.
+      # new Rack release after 2.2.3.
       !body.respond_to?(:to_path)
     end
 
@@ -104,7 +104,10 @@ module Rack
       body.each do |part|
         parts << part
 
-        if part.present?
+        # Note that `part` can be a string with binary data here.
+        # It's important to check emptiness with #empty? instead of #blank?, since #blank?
+        # internally calls String#match? and that explodes if the string is not valid UTF-8.
+        unless part.empty?
           digest ||= initialize_digest(session)
           part = strip_patterns(part) if strippable_response
           digest << part

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-steady_etag
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Henning Koch