rack-simple_logger 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: cdeacb05b7b9ef32c4ca054b779605f82fb2735b
-  data.tar.gz: 403ca7a567112c8e266223b1f3d850ee570f4fdb
-SHA512:
-  metadata.gz: f8bbf3633a24a4f93c6720af50ace4f5bd33667944fae194a0a7553ceda5fd896cfe14ebb920fb04ccd505970f80bb61c4d8707524720cdb1bcd68a230eea29e
-  data.tar.gz: 3ebbc796fceb3015091c4f080b1e1df3c6c9c55f6c85a1b088bd4f3d7c51806d34af4b5634d21292d33a574c3093c71361389717555d1906694a908f9790defc
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    ZTM2NzNlNDRiYmNiNGZlZjcyM2U3YzEwN2NjMDlkZTM5YzZmZDIxMQ==
+  data.tar.gz: !binary |-
+    ZDM0Mjg4Mjc3NjZmOGEwMTljNWQ4ZjRlZmZjMTQyYTgyNTU4ZDBiYQ==
+!binary "U0hBNTEy":
+  metadata.gz: !binary |-
+    MTgxYTcyZjEyZGVmOTRiZjZmNDQ5MGU3Nzg3ZWI3OTQ3NmNkZmRjYzU1YzU1
+    NWJkOWU0M2U0MDJiOTBmODIwYjU2YjcxZTI2YmUwMDE4NDM4ZWMzOGYyYjMw
+    MWUxNjBlZmFlMjE5OGY1YTI0NjMxNTg0N2I3NjA0Y2Y2Njg0NGY=
+  data.tar.gz: !binary |-
+    NzEyZTI2OTk2Yjk0NDE3MzFlNzFjNDA0YWVhYjEyYmQxNTI3NDNlMTE0ZTU3
+    ZTk3ZWM0NTkyMjY5ZDkyYjA5N2Y5ZGZjYmQ5ZWI1NTEyYTgzOWM2NmY4Mzdj
+    MmUxODI1YjNkMzZjYTk2ZTIzZGE5N2Y0ODMwNGEzMDBmZGU2MjA=

data/.coveralls.yml

@@ -0,0 +1 @@
+repo_token: aUWKzMB87Ndks1lvyCKgD2WVPwqwiYoXN

data/.travis.yml

@@ -0,0 +1,13 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - 2.0.0
+gemfile:
+  - Gemfile
+script: bundle exec rake spec
+branches:
+  only:
+    - master
+notifications:
+  mails:
+    - i2bskn@gmail.com

data/README.md

@@ -1,5 +1,10 @@
 # Rack::SimpleLogger
 
+[![Gem Version](https://badge.fury.io/rb/rack-simple_logger.png)](http://badge.fury.io/rb/rack-simple_logger)
+[![Build Status](https://travis-ci.org/i2bskn/rack-simple_logger.png?branch=master)](https://travis-ci.org/i2bskn/rack-simple_logger)
+[![Coverage Status](https://coveralls.io/repos/i2bskn/rack-simple_logger/badge.png?branch=master)](https://coveralls.io/r/i2bskn/rack-simple_logger?branch=master)
+[![Code Climate](https://codeclimate.com/github/i2bskn/rack-simple_logger.png)](https://codeclimate.com/github/i2bskn/rack-simple_logger)
+
 Simple logger for rack.
 
 ## Installation

data/lib/rack/simple_logger/log_proxy.rb

@@ -21,12 +21,6 @@ module Rack
       logger_formatter if @log_type == :logger
     end
 
-    def logger_formatter
-      @logger.formatter = Proc.new do |severity, datetime, progname, msg|
-        "#{msg}\n"
-      end
-    end
-
     def write(log_hash)
       send("write_#{@log_type}", log_hash)
     end
@@ -42,5 +36,12 @@ module Rack
     def write_other(log_hash)
       @logger.write log_hash
     end
+
+    private
+    def logger_formatter
+      @logger.formatter = Proc.new do |severity, datetime, progname, msg|
+        "#{msg}\n"
+      end
+    end
   end
 end

data/lib/rack/simple_logger/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class SimpleLogger
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/rack-simple_logger.gemspec

@@ -21,6 +21,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
-
-  spec.add_dependency "rack"
+  spec.add_development_dependency "rack"
+  spec.add_development_dependency "rack-test"
 end

data/spec/rack/simple_logger/log_proxy_spec.rb

@@ -0,0 +1,161 @@
+# coding: utf-8
+
+require "spec_helper"
+
+describe Rack::LogProxy do
+  let(:logger_mock) {double("logger mock", class: "Logger").as_null_object}
+  let(:io_mock) {double("IO mock", class: "IO").as_null_object}
+  let(:mongo_mock) {double("mongo mock", class: "Mongo::Collection").as_null_object}
+  let(:custom_mock) {double("custom logger mock", class: "Other").as_null_object}
+
+
+  describe "#initialize" do
+    context "with Logger object" do
+      let(:proxy) {Rack::LogProxy.new(logger_mock)}
+
+      it "@logger should be a specified logger" do
+        expect(proxy.instance_eval{@logger}).to eq(logger_mock)
+      end
+
+      it "@log_type should be a :logger" do
+        expect(proxy.instance_eval{@log_type}).to eq(:logger)
+      end
+
+      it "should call logger_formatter method" do
+        Rack::LogProxy.any_instance.should_receive(:logger_formatter)
+        expect{proxy}.not_to raise_error
+      end
+    end
+
+    context "with String object" do
+      before {::Logger.should_receive(:new).with("str").and_return(logger_mock)}
+      let(:proxy) {Rack::LogProxy.new("str")}
+
+      it "create new logger object" do
+        expect(proxy.instance_eval{@logger}).to eq(logger_mock)
+      end
+
+      it "@log_type should be a :logger" do
+        expect(proxy.instance_eval{@log_type}).to eq(:logger)
+      end
+
+      it "should call logger_formatter method" do
+        Rack::LogProxy.any_instance.should_receive(:logger_formatter)
+        expect{proxy}.not_to raise_error
+      end
+    end
+
+    context "with IO object" do
+      before {::Logger.should_receive(:new).with(io_mock).and_return(logger_mock)}
+      let(:proxy) {Rack::LogProxy.new(io_mock)}
+
+      it "create new logger object" do
+        expect(proxy.instance_eval{@logger}).to eq(logger_mock)
+      end
+
+      it "@log_type should be a :logger" do
+        expect(proxy.instance_eval{@log_type}).to eq(:logger)
+      end
+
+      it "should call logger_formatter method" do
+        Rack::LogProxy.any_instance.should_receive(:logger_formatter)
+        expect{proxy}.not_to raise_error
+      end
+    end
+
+    context "with Mongo::Connection object" do
+      let(:proxy) {Rack::LogProxy.new(mongo_mock)}
+
+      it "@logger should be a connection of mongodb" do
+        expect(proxy.instance_eval{@logger}).to eq(mongo_mock)
+      end
+
+      it "@log_type should be a :mongo" do
+        expect(proxy.instance_eval{@log_type}).to eq(:mongo)
+      end
+
+      it "should not call logger_formatter method" do
+        Rack::LogProxy.any_instance.should_not_receive(:logger_formatter)
+        expect{proxy}.not_to raise_error
+      end
+    end
+
+    context "with custom logger object" do
+      let(:proxy) {Rack::LogProxy.new(custom_mock)}
+
+      it "@logger should be a custom logger object" do
+        expect(proxy.instance_eval{@logger}).to eq(custom_mock)
+      end
+
+      it "@log_type should be a :mongo" do
+        expect(proxy.instance_eval{@log_type}).to eq(:other)
+      end
+
+      it "should not call logger_formatter method" do
+        Rack::LogProxy.any_instance.should_not_receive(:logger_formatter)
+        expect{proxy}.not_to raise_error
+      end
+    end
+  end
+
+  describe "#write" do
+    it "dispatch to write_logger" do
+      Rack::LogProxy.any_instance.should_receive(:write_logger)
+      expect{Rack::LogProxy.new(logger_mock).write(k: "v")}.not_to raise_error
+    end
+
+    it "dispatch to write_mongo" do
+      Rack::LogProxy.any_instance.should_receive(:write_mongo)
+      expect{Rack::LogProxy.new(mongo_mock).write(k: "v")}.not_to raise_error
+    end
+
+    it "dispatch to write_other" do
+      Rack::LogProxy.any_instance.should_receive(:write_other)
+      expect{Rack::LogProxy.new(custom_mock).write(k: "v")}.not_to raise_error
+    end
+  end
+
+  describe "#write_logger" do
+    it "output ltsv format log" do
+      proxy = Rack::LogProxy.new(logger_mock)
+      logger_mock.should_receive(:info).with("k1:v1\tk2:v2")
+      expect{proxy.write(k1: "v1", k2: "v2")}.not_to raise_error
+    end
+  end
+
+  describe "#write_mongo" do
+    it "insert log of Hash" do
+      proxy = Rack::LogProxy.new(mongo_mock)
+      mongo_mock.should_receive(:insert).with(k: "v")
+      expect{proxy.write(k: "v")}.not_to raise_error
+    end
+  end
+
+  describe "#write_other" do
+    it "write custom format log" do
+      proxy = Rack::LogProxy.new(custom_mock)
+      custom_mock.should_receive(:write).with(k: "v")
+      expect{proxy.write(k: "v")}.not_to raise_error
+    end
+  end
+
+  describe "#logger_formatter" do
+    let(:proxy) {Rack::LogProxy.new(STDOUT)}
+
+    it "should call logger_formatter method" do
+      Rack::LogProxy.any_instance.should_receive(:logger_formatter)
+      expect{proxy}.not_to raise_error
+    end
+
+    it "format is the only message" do
+      expect(
+        proxy.instance_eval{@logger}.formatter.call(
+          "severity",
+          "datetime",
+          "progname",
+          "msg"
+        )
+      ).to eq("msg\n")
+    end
+  end
+end

data/spec/rack/simple_logger_spec.rb

@@ -1,3 +1,42 @@
 # coding: utf-8
 
 require "spec_helper"
+
+describe Rack::SimpleLogger do
+  let(:logger) {double("logger mock", class: "Logger").as_null_object}
+  let(:app) {Rack::SimpleLogger.new(TestApp.new, log: logger)}
+
+  describe "#initialize" do
+    it "@app should be a TestApp object" do
+      expect(app.instance_eval{@app}.is_a? TestApp).to be_true
+    end
+
+    it "@logger should be a LogPorxy object" do
+      expect(app.instance_eval{@logger}.is_a? Rack::LogProxy).to be_true
+    end
+
+    it "@logger is STDOUT if not specified" do
+      Rack::LogProxy.should_receive(:new).with(STDOUT)
+      Rack::SimpleLogger.new(TestApp.new)
+    end
+  end
+
+  describe "#call" do
+    it "should call log method" do
+      Rack::SimpleLogger.any_instance.should_receive(:log)
+      get "/"
+    end
+  end
+
+  describe "#log" do
+    after {get "/"}
+
+    it "should call LogProxy#write" do
+      Rack::LogProxy.any_instance.should_receive(:write)
+    end
+
+    it "should call logger#info" do
+      logger.should_receive(:info)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -9,7 +9,11 @@ SimpleCov.start do
 end
 
 require "rack/simple_logger"
+require "rack/test"
+
+Dir[File.expand_path("../support/*.rb", __FILE__)].each {|f| require f}
 
 RSpec.configure do |config|
+  config.include Rack::Test::Methods
   config.order = "random"
 end

data/spec/support/test_app.rb

@@ -0,0 +1,11 @@
+# coding: utf-8
+
+class TestApp
+  def call(env)
+    [
+      200,
+      {"Content-Type" => "text/plain"},
+      ["Hello Rack Middleware"]
+    ]
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: rack-simple_logger
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - i2bskn
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-06-23 00:00:00.000000000 Z
+date: 2013-06-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,42 +28,56 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack-test
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Simple logger for rack
@@ -73,7 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -82,8 +98,10 @@ files:
 - lib/rack/simple_logger/log_proxy.rb
 - lib/rack/simple_logger/version.rb
 - rack-simple_logger.gemspec
+- spec/rack/simple_logger/log_proxy_spec.rb
 - spec/rack/simple_logger_spec.rb
 - spec/spec_helper.rb
+- spec/support/test_app.rb
 homepage: https://github.com/i2bskn/rack-simple_logger
 licenses:
 - MIT
@@ -94,20 +112,22 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Simple logger for rack
 test_files:
+- spec/rack/simple_logger/log_proxy_spec.rb
 - spec/rack/simple_logger_spec.rb
 - spec/spec_helper.rb
+- spec/support/test_app.rb