rack-request-profiler 0.1.1 → 0.1.2

data/CHANGES.md

@@ -0,0 +1,4 @@
+## 0.1.2
+
+* [Bugfix] Fixed #2. Handle BSON id's that begin with more than one number.
+* Allow the id matching pattern to be over-ridden via `Rack::Util::UrlStripper.id_pattern=`

data/README.md

@@ -18,6 +18,12 @@ Simply include one of the profiler middlewares into the middleware stack in any
 use Rack::Profilers::Statsd, Statsd.new('localhost'), :ignore_path => /^\/assets/
 ```
 
+Be default, we match URL's that look like BSON ids. You can over-ride this regular expression like this:
+
+```ruby
+Rack::Utils::UrlStripper.id_pattern = /some_other_pattern/
+```
+
 ## Profilers
 
 * Statsd - Uses the [statsd ruby client](https://github.com/reinh/statsd-ruby) to send data to statsd / graphite.

data/lib/rack/request-profiler/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class RequestProfiler
-    VERSION = '0.1.1'
+    VERSION = '0.1.2'
   end
 end

data/lib/rack/utils/url_stripper.rb

@@ -1,10 +1,19 @@
 module Rack
   module Utils
     class UrlStripper
-      ID_PATTERN = /([0-9][a-z][^\/]+)/
+      class << self
+        def id_pattern
+          # A crude attempt at matching a BSON id format (http://bsonspec.org/)
+          @id_pattern ||= /[0-9]+[a-zA-Z]+[^\/]*/
+        end
 
-      def self.replace_id(url)
-        url.gsub(ID_PATTERN, 'ID')
+        def id_pattern=(pattern)
+          @id_pattern = pattern
+        end
+
+        def replace_id(url)
+          url.gsub(id_pattern, 'ID')
+        end
       end
     end
   end

data/spec/rack/profilers/statsd_spec.rb

@@ -3,6 +3,15 @@ require 'spec_helper'
 describe Rack::Profilers::Statsd do
   include Rack::Test::Methods
 
+  class MockApp < Sinatra::Base
+    use Rack::Profilers::Statsd, Statsd.new('localhost')
+    post '/posts/:id/update' do
+      [200, "post content"]
+    end
+  end
+
+  def app; @app ||= Rack::Builder.app { run MockApp }; end
+
   it "sends stuff to statsd" do
     statsd = Statsd.new 'localhost'
     app = Rack::Builder.app do
@@ -36,4 +45,9 @@ describe Rack::Profilers::Statsd do
     statsd.expects(:timing).with('namespace.me.GET.', 200)
     Rack::MockRequest.new(app).get('/')
   end
+
+  it "subs out ids" do
+    Statsd.any_instance.expects(:timing).with("POST.posts.1.update", any_parameters)
+    Rack::MockRequest.new(app).post('/posts/1/update')
+  end
 end

data/spec/rack/utils/url_stripper_spec.rb

@@ -3,7 +3,10 @@ require 'spec_helper'
 describe Rack::Utils::UrlStripper do
   describe '.replace_id' do
     it 'replaces BSON-like ids with ID' do
-      Rack::Utils::UrlStripper.replace_id("/resource/4f07931e3641417a88000002").should == '/resource/ID'
+      ids = %w(5005536b28330e5a8800005f 4f07931e3641417a88000002)
+      ids.each do |id|
+        Rack::Utils::UrlStripper.replace_id("/resource/#{id}").should == '/resource/ID'
+      end
     end
 
     it "replaces ids with sub-resources" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-request-profiler
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-10 00:00:00.000000000 Z
+date: 2012-07-17 00:00:00.000000000 Z
 dependencies: []
 description: Provides a framework for sending wall time statistics to external services,
   such as statsd, stathat, etc.
@@ -21,6 +21,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .travis.yml
+- CHANGES.md
 - Gemfile
 - README.md
 - Rakefile