rack-request-profiler 0.1.0 → 0.1.1

data/.gitignore

@@ -1,2 +1,3 @@
 .rspec
 Gemfile.lock
+pkg

data/.travis.yml

@@ -0,0 +1,7 @@
+rvm:
+  - 1.8.7
+  - 1.9.2
+  - 1.9.3
+  - ree
+  - ruby-head
+  - rbx

data/Gemfile

@@ -1,9 +1,13 @@
 source :rubygems
 
+gem 'rake'
+
 group :test do
   gem 'em-stathat'
+  gem 'mocha'
   gem 'rack'
   gem 'rspec', '>= 2.7'
   gem 'rack-test', :require => 'rack/test'
+  gem 'sinatra', :require => 'sinatra/base'
   gem 'statsd-ruby', :require => 'statsd'
 end

data/README.md

@@ -1,3 +1,5 @@
+[![Build Status](http://travis-ci.org/ajsharp/rack-request-profiler.png)](http://travis-ci.org/ajsharp/rack-request-profiler)
+
 This project provides a simple "framework" for profiling request / response times, and sending the data to another service. It includes a base class `Rack::RequestProfiler` for handling the logic of wrapping and timing the request / response cycle in a rack app.
 
 By default, the `Rack::RequestProfiler` middleware does not do anything with the profiling data. Instead, this logic must be implemented by subclasses by defining the `handle_results` instance method. For example, you might send profiling data to an external web service (stathat, papertrail, loggly, etc), statsd, write to a logfile on disk, put it in a persistent store like redis or mongo, or really anything else your heart desires.

data/Rakefile

@@ -0,0 +1,4 @@
+require 'rspec/core/rake_task'
+RSpec::Core::RakeTask.new(:spec)
+
+task :default => :spec

data/lib/rack/request-profiler.rb

@@ -27,7 +27,9 @@ module Rack
 
       status, headers, body = @app.call(env)
 
-      handle_results(env, request)
+      unless status == 404
+        handle_results(env, request)
+      end
       [status, headers, body]
     end
 

data/lib/rack/request-profiler/version.rb

@@ -1,5 +1,5 @@
 module Rack
   class RequestProfiler
-    VERSION = '0.1.0'
+    VERSION = '0.1.1'
   end
 end

data/spec/rack/profilers/stathat_spec.rb

@@ -4,11 +4,16 @@ describe Rack::Profilers::Stathat do
   it "accepts callbacks" do
     EM.run {
       app = Rack::Builder.app do
-        use Rack::Profilers::Stathat, :callback => lambda { |req| puts("hey"); EM.stop }
+        use Rack::Profilers::Stathat, :callback => lambda { |req| }
 
         run lambda { |env| [200, {'Content-Type' => 'text/plain'}, ['']]}
       end
-      req = Rack::MockRequest.new(app).get('/')
+
+      deferrable = mock("Deferrable")
+      deferrable.expects(:callback).returns(EM.stop)
+      EM::StatHat.any_instance.expects(:ez_value).returns(deferrable)
+
+      Rack::MockRequest.new(app).get('/zomg/this/is/a/test')
     }
   end
 end

data/spec/rack/profilers/statsd_spec.rb

@@ -2,26 +2,38 @@ require 'spec_helper'
 
 describe Rack::Profilers::Statsd do
   include Rack::Test::Methods
-  $statsd = Statsd.new 'localhost'
 
   it "sends stuff to statsd" do
+    statsd = Statsd.new 'localhost'
     app = Rack::Builder.app do
-      use Rack::Profilers::Statsd, $statsd
+      use Rack::Profilers::Statsd, statsd
       run lambda { |env| [200, {}, ['']]}
     end
 
-    obj = mock("object", :timing => true)
-    $statsd.should_receive(:timing)
+    statsd.expects(:timing)
     response = Rack::MockRequest.new(app).get('/')
   end
 
   it "does not send stuff for ignored paths" do
+    statsd = Statsd.new 'localhost'
     app = Rack::Builder.app do
-      use Rack::Profilers::Statsd, $statsd, :ignore_path => /ignore-me/
+      use Rack::Profilers::Statsd, statsd, :ignore_path => /ignore-me/
       run lambda { |env| [200, {}, ['']]}
     end
 
-    $statsd.should_not_receive(:timing)
+    statsd.expects(:timing).never
     Rack::MockRequest.new(app).get('/ignore-me')
   end
+
+  it "prepends the namespace if passed in" do
+    statsd = Statsd.new 'localhost'
+    app = Rack::Builder.app do
+      use Rack::Profilers::Statsd, statsd, :namespace => 'namespace.me.'
+      run lambda { |env| [200, {}, ['']]}
+    end
+
+    Rack::Profilers::Statsd.any_instance.stubs(:run_time => 200)
+    statsd.expects(:timing).with('namespace.me.GET.', 200)
+    Rack::MockRequest.new(app).get('/')
+  end
 end

data/spec/rack/request-profiler_spec.rb

@@ -2,34 +2,39 @@ require 'spec_helper'
 
 describe Rack::RequestProfiler do
   include Rack::Test::Methods
+  class MockApp < Sinatra::Base
+    use Rack::RequestProfiler, :ignore_path => /ignore_me/
+    get '/' do
+      [200, "Hello, world"]
+    end
 
-  it "implements the handle_results interface" do
-    Rack::RequestProfiler.new(lambda {}).should respond_to :handle_results
+    get '/ignore_me' do
+      [200, "Ignore me"]
+    end
   end
 
-  it "invokes the handle_results interface" do
-    class Rack::CustomProfiler < Rack::RequestProfiler
-      def handle_results(env)
-      end
+  def app
+    @app ||= Rack::Builder.app do
+      run MockApp
     end
-    app = Rack::Builder.app do
-      use Rack::CustomProfiler
+  end
 
-      run lambda { |env| [200, {'Content-Type' => 'text/plain'}, ['']]}
-    end
+  it "implements the handle_results interface" do
+    Rack::RequestProfiler.new(lambda {}).should respond_to :handle_results
+  end
 
-    Rack::CustomProfiler.any_instance.should_receive(:handle_results)
+  it "invokes the handle_results interface" do
+    Rack::RequestProfiler.any_instance.expects(:handle_results).once
     Rack::MockRequest.new(app).get('/')
   end
 
   it "does not invoke handle_results if ignore_path matches" do
-    app = Rack::Builder.app do
-      use Rack::RequestProfiler, :ignore_path => /ignore_me/
-
-      run lambda { |env| [200, {'Content-Type' => 'text/plain'}, ['']]}
-    end
-
-    Rack::RequestProfiler.any_instance.should_not_receive(:handle_results)
+    Rack::RequestProfiler.any_instance.expects(:handle_results).never
     Rack::MockRequest.new(app).get('/ignore_me')
   end
+
+  it "does not invoke handlers if the status is 404" do
+    Rack::RequestProfiler.any_instance.expects(:handle_results).never
+    Rack::MockRequest.new(app).get('/does/not/exist')
+  end
 end

data/spec/spec_helper.rb

@@ -4,6 +4,7 @@ require File.join(File.expand_path(File.dirname(__FILE__)), '..', 'lib', 'rack-r
 
 require 'rack/test'
 require 'em-stathat'
+require 'sinatra/base'
 
 EventMachine::StatHat.config do |c|
   c.ukey  = 'key'
@@ -11,4 +12,5 @@ EventMachine::StatHat.config do |c|
 end
 
 RSpec.configure do |config|
+  config.mock_with :mocha
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: rack-request-profiler
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-01-09 00:00:00.000000000 Z
+date: 2012-02-10 00:00:00.000000000 Z
 dependencies: []
 description: Provides a framework for sending wall time statistics to external services,
   such as statsd, stathat, etc.
@@ -20,8 +20,10 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - README.md
+- Rakefile
 - lib/rack-request-profiler.rb
 - lib/rack/profilers/stathat.rb
 - lib/rack/profilers/statsd.rb
@@ -54,7 +56,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Rack middleware for profiling request / response cycles.