rack-pagespeed 1.0.3 → 1.0.4

data/VERSION

@@ -1 +1 @@
-1.0.3
+1.0.4

data/lib/rack/pagespeed/filters/base.rb

@@ -21,7 +21,7 @@ module Rack::PageSpeed::Filters
       def requires_store
         instance_eval do
           def new options = {}
-            options[:store] ? super(options) : false
+            options[:store] ? super(options) : raise("#{name} requires :store to be specified.")
           end
         end
       end

data/rack-pagespeed.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{rack-pagespeed}
-  s.version = "1.0.3"
+  s.version = "1.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Julio Cesar Ody"]
-  s.date = %q{2011-01-24}
+  s.date = %q{2011-03-25}
   s.description = %q{Web page speed optimizations at the Rack level}
   s.email = %q{julio@awesomebydesign.com}
   s.extra_rdoc_files = [

data/spec/config_spec.rb

@@ -83,12 +83,11 @@ describe 'rack-pagespeed configuration' do
       config.filters.count.should == 2
     end
 
-    it "won't add a filter if it's call returns false" do
+    it "calling a filter that requires storage without specifying one raises an error" do
       class NeedsStore < Rack::PageSpeed::Filter
         requires_store
       end
-      config = Rack::PageSpeed::Config.new do needs_store end
-      config.filters.should be_empty
+      expect { Rack::PageSpeed::Config.new do needs_store end }.to raise_error
     end
     
     it 'raises a NoSuchFilter error when a non-existing filter is called ' do

data/spec/filters/combine_css_spec.rb

@@ -6,7 +6,7 @@ describe 'the combine_css filter' do
   end
 
   it "requires a store mechanism to be passed via :store when initializing" do
-    Rack::PageSpeed::Filters::CombineCSS.new.should be_false
+    expect { Rack::PageSpeed::Filters::CombineCSS.new }.to raise_error
   end
   
   it "is a priority 9 filter" do

data/spec/filters/combine_javascripts_spec.rb

@@ -10,8 +10,8 @@ describe 'the combine_javascripts filter' do
   end
 
   context "requires a store mechanism to be passed via :store when initializing" do
-    specify { Rack::PageSpeed::Filters::CombineJavaScripts.new.should be_false }
-    specify { Rack::PageSpeed::Filters::CombineJavaScripts.new(:store => {}).should_not be_false }
+    specify { expect { Rack::PageSpeed::Filters::CombineJavaScripts.new }.to raise_error }
+    specify { expect { Rack::PageSpeed::Filters::CombineJavaScripts.new(:store => {}) }.to_not raise_error }
   end
 
   context 'execute!' do

data/spec/filters/filter_spec.rb

@@ -11,7 +11,7 @@ describe 'the base filter class' do
     class Moo < Rack::PageSpeed::Filter; end
     Rack::PageSpeed::Filters::Base.available_filters.should include(Moo)
   end
-
+  
   context 'the #name declaration, which can be used to declare a name which the filter can be called upon' do
     it 'can be called from inside the class' do
       class Boo < Rack::PageSpeed::Filter

data/spec/filters/minify_javascript_spec.rb

@@ -10,8 +10,8 @@ describe 'the minify_javascript filter' do
   end
 
   context "requires a storage mechanism to be passed via :store when initializing" do
-    specify { Rack::PageSpeed::Filters::MinifyJavaScripts.new.should be_false }
-    specify { Rack::PageSpeed::Filters::MinifyJavaScripts.new(:store => {}).should_not be_false }
+    specify { expect { Rack::PageSpeed::Filters::MinifyJavaScripts.new }.to raise_error }
+    specify { expect { Rack::PageSpeed::Filters::MinifyJavaScripts.new(:store => {}) }.to_not be_false }
   end
 
   context "#execute!" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: rack-pagespeed
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: false
   segments: 
   - 1
   - 0
-  - 3
-  version: 1.0.3
+  - 4
+  version: 1.0.4
 platform: ruby
 authors: 
 - Julio Cesar Ody
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-24 00:00:00 +11:00
+date: 2011-03-25 00:00:00 +11:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency