rack-mount 0.4.6 → 0.4.7

data/lib/rack/mount/analysis/splitting.rb

@@ -5,7 +5,11 @@ module Rack::Mount
     module Splitting
       NULL = "\0".freeze
 
-      class Key < Struct.new(:method, :index, :separators)
+      class Key < Array
+        def initialize(method, index, separators)
+          replace([method, index, separators])
+        end
+
         def self.split(value, separator_pattern)
           keys = value.split(separator_pattern)
           keys.shift if keys[0] == ''
@@ -14,15 +18,11 @@ module Rack::Mount
         end
 
         def call(cache, obj)
-          (cache[method] ||= self.class.split(obj.send(method), separators))[index]
+          (cache[self[0]] ||= self.class.split(obj.send(self[0]), self[2]))[self[1]]
         end
 
         def call_source(cache, obj)
-          "(#{cache}[:#{method}] ||= Analysis::Splitting::Key.split(#{obj}.#{method}, #{separators.inspect}))[#{index}]"
-        end
-
-        def inspect
-          "#{method}[#{index}]"
+          "(#{cache}[:#{self[0]}] ||= Analysis::Splitting::Key.split(#{obj}.#{self[0]}, #{self[2].inspect}))[#{self[1]}]"
         end
       end
 

data/lib/rack/mount/mixover.rb

@@ -4,12 +4,6 @@ module Rack::Mount
   # metaclass. This allows mixins to be stacked ontop of the instance
   # methods.
   module Mixover
-    def self.extended(klass)
-      klass.instance_eval do
-        @extended_modules = []
-      end
-    end
-
     module InstanceMethods #:nodoc:
       def dup
         obj = super
@@ -21,40 +15,33 @@ module Rack::Mount
 
     # Replaces include with a lazy version.
     def include(*mod)
-      extended_modules.push(*mod)
-    end
-
-    def extended_modules
-      Thread.current[extended_modules_thread_local_key] || @extended_modules
+      (@included_modules ||= []).push(*mod)
     end
 
     def new(*args, &block) #:nodoc:
       obj = allocate
       obj.extend(InstanceMethods)
-      extended_modules.each { |mod| obj.extend(mod) }
+      (@included_modules ||= []).each { |mod| obj.extend(mod) }
       obj.send(:initialize, *args, &block)
       obj
     end
 
     # Create a new class without an included module.
     def new_without_module(mod, *args, &block)
-      (Thread.current[extended_modules_thread_local_key] = extended_modules.dup).delete(mod)
+      old_included_modules = (@included_modules ||= []).dup
+      @included_modules.delete(mod)
       new(*args, &block)
     ensure
-      Thread.current[extended_modules_thread_local_key] = nil
+      @included_modules = old_included_modules
     end
 
     # Create a new class temporarily with a module.
     def new_with_module(mod, *args, &block)
-      (Thread.current[extended_modules_thread_local_key] = extended_modules.dup).push(*mod)
+      old_included_modules = (@included_modules ||= []).dup
+      include(mod)
       new(*args, &block)
     ensure
-      Thread.current[extended_modules_thread_local_key] = nil
+      @included_modules = old_included_modules
     end
-
-    private
-      def extended_modules_thread_local_key
-        "mixover_extended_modules_#{object_id}"
-      end
   end
 end

data/lib/rack/mount/prefix.rb

@@ -7,29 +7,23 @@ module Rack::Mount
     SCRIPT_NAME  = 'SCRIPT_NAME'.freeze
     SLASH        = '/'.freeze
 
-    KEY = 'rack.mount.prefix'.freeze
-
-    def initialize(app, prefix = nil)
+    def initialize(app, prefix)
       @app, @prefix = app, prefix.freeze
       freeze
     end
 
     def call(env)
-      if prefix = env[KEY] || @prefix
-        old_path_info = env[PATH_INFO].dup
-        old_script_name = env[SCRIPT_NAME].dup
+      old_path_info = env[PATH_INFO].dup
+      old_script_name = env[SCRIPT_NAME].dup
 
-        begin
-          env[PATH_INFO] = Utils.normalize_path(env[PATH_INFO].sub(prefix, EMPTY_STRING))
-          env[PATH_INFO] = EMPTY_STRING if env[PATH_INFO] == SLASH
-          env[SCRIPT_NAME] = Utils.normalize_path(env[SCRIPT_NAME].to_s + prefix)
-          @app.call(env)
-        ensure
-          env[PATH_INFO] = old_path_info
-          env[SCRIPT_NAME] = old_script_name
-        end
-      else
+      begin
+        env[PATH_INFO] = Utils.normalize_path(env[PATH_INFO].sub(@prefix, EMPTY_STRING))
+        env[PATH_INFO] = EMPTY_STRING if env[PATH_INFO] == SLASH
+        env[SCRIPT_NAME] = Utils.normalize_path(env[SCRIPT_NAME].to_s + @prefix)
         @app.call(env)
+      ensure
+        env[PATH_INFO] = old_path_info
+        env[SCRIPT_NAME] = old_script_name
       end
     end
   end

data/lib/rack/mount/recognition/code_generation.rb

@@ -39,7 +39,6 @@ module Rack::Mount
 
           container.each_with_index { |route, i|
             body << "route = self[#{i}]"
-            body << 'matches = {}'
             body << 'params = route.defaults.dup'
 
             conditions = []
@@ -47,11 +46,10 @@ module Rack::Mount
               b = []
               if condition.is_a?(Regexp)
                 b << "if m = obj.#{method}.match(#{condition.inspect})"
-                b << "matches[:#{method}] = m"
                 if (named_captures = route.named_captures[method]) && named_captures.any?
-                  b << 'captures = m.captures'
+                  b << 'matches = m.captures'
                   b << 'p = nil'
-                  b << named_captures.map { |k, j| "params[#{k.inspect}] = p if p = captures[#{j}]" }.join('; ')
+                  b << named_captures.map { |k, j| "params[#{k.inspect}] = p if p = matches[#{j}]" }.join('; ')
                 end
               else
                 b << "if m = obj.#{method} == route.conditions[:#{method}]"
@@ -63,7 +61,7 @@ module Rack::Mount
 
             body << <<-RUBY
               if #{conditions.join(' && ')}
-                yield route, matches, params
+                yield route, params
               end
             RUBY
           }
@@ -78,7 +76,7 @@ module Rack::Mount
 
         def optimize_recognize!
           keys = @recognition_keys.map { |key|
-            if key.respond_to?(:call_source)
+            if key.is_a?(Array)
               key.call_source(:cache, :obj)
             else
               "obj.#{key}"
@@ -96,12 +94,12 @@ module Rack::Mount
               optimize_container_iterator(container) unless container.respond_to?(:optimized_each)
 
               if block_given?
-                container.optimized_each(obj) do |route, matches, params|
-                  yield route, matches, params
+                container.optimized_each(obj) do |route, params|
+                  yield route, params
                 end
               else
-                container.optimized_each(obj) do |route, matches, params|
-                  return route, matches, params
+                container.optimized_each(obj) do |route, params|
+                  return route, params
                 end
               end
 

data/lib/rack/mount/recognition/route.rb

@@ -17,31 +17,16 @@ module Rack::Mount
           }.freeze
         }
         @named_captures.freeze
-
-        if @conditions.has_key?(:path_info) &&
-            !Utils.regexp_anchored?(@conditions[:path_info])
-          @prefix = true
-          @app = Prefix.new(@app)
-        else
-          @prefix = false
-        end
-      end
-
-      def prefix?
-        @prefix
       end
 
       def recognize(obj)
-        matches = {}
-        params  = @defaults.dup
-
+        params = @defaults.dup
         if @conditions.all? { |method, condition|
           value = obj.send(method)
           if condition.is_a?(Regexp) && (m = value.match(condition))
-            matches[method] = m
-            captures = m.captures
+            matches = m.captures
             @named_captures[method].each { |k, i|
-              if v = captures[i]
+              if v = matches[i]
                 params[k] = v
               end
             }
@@ -52,7 +37,7 @@ module Rack::Mount
             false
           end
         }
-          return matches, params
+          params
         else
           nil
         end

data/lib/rack/mount/recognition/route_set.rb

@@ -26,19 +26,18 @@ module Rack::Mount
 
         cache = {}
         keys = @recognition_keys.map { |key|
-          if key.respond_to?(:call_source)
+          if key.is_a?(Array)
             key.call(cache, obj)
           else
             obj.send(key)
           end
         }
         @recognition_graph[*keys].each do |route|
-          matches, params = route.recognize(obj)
-          if matches && params
+          if params = route.recognize(obj)
             if block_given?
-              yield route, matches, params
+              yield route, params
             else
-              return route, matches, params
+              return route, params
             end
           end
         end
@@ -63,14 +62,10 @@ module Rack::Mount
 
         request = nil
         req = @request_class.new(env)
-        recognize(req) do |route, matches, params|
+        recognize(req) do |route, params|
           # TODO: We only want to unescape params from uri related methods
           params.each { |k, v| params[k] = Utils.unescape_uri(v) if v.is_a?(String) }
 
-          if route.prefix?
-            env[Prefix::KEY] = matches[:path_info].to_s
-          end
-
           env[@parameters_key] = params
           result = route.app.call(env)
           return result unless result[1][X_CASCADE] == PASS
@@ -86,15 +81,6 @@ module Rack::Mount
         super
       end
 
-      protected
-        def recognition_stats
-          { :keys => @recognition_keys,
-            :keys_size => @recognition_keys.size,
-            :graph_size => @recognition_graph.size,
-            :graph_height => @recognition_graph.height,
-            :graph_average_height => @recognition_graph.average_height }
-        end
-
       private
         def expire!
           @recognition_keys = @recognition_graph = nil

data/lib/rack/mount/strexp.rb

@@ -21,14 +21,13 @@ module Rack::Mount
     #
     #   Strexp.compile('src/*files')
     #     # => %r{\Asrc/(?<files>.+)\Z}
-    def initialize(str, requirements = {}, separators = [], anchor = true)
+    def initialize(str, requirements = {}, separators = [])
       return super(str) if str.is_a?(Regexp)
 
       requirements = requirements ? requirements.dup : {}
       normalize_requirements!(requirements, separators)
 
       parser = StrexpParser.new
-      parser.anchor = anchor
       parser.requirements = requirements
 
       begin

data/lib/rack/mount/strexp/parser.rb

@@ -20,7 +20,7 @@ else
   REGEXP_NAMED_CAPTURE = '(?:<%s>%s)'.freeze
 end
 
-attr_accessor :anchor, :requirements
+attr_accessor :requirements
 ##### State transition tables begin ###
 
 racc_action_table = [
@@ -114,7 +114,7 @@ Racc_debug_parser = false
 # reduce 0 omitted
 
 def _reduce_1(val, _values, result)
- result = anchor ? "\\A#{val.join}\\Z" : "\\A#{val.join}" 
+ result = "\\A#{val.join}\\Z" 
     result
 end
 

data/lib/rack/mount/utils.rb

@@ -88,17 +88,6 @@ module Rack::Mount
     end
     module_function :build_nested_query
 
-    # Determines whether the regexp must match the entire string.
-    #
-    #   regexp_anchored?(/^foo$/) # => true
-    #   regexp_anchored?(/foo/)   # => false
-    #   regexp_anchored?(/^foo/)  # => false
-    #   regexp_anchored?(/foo$/)  # => false
-    def regexp_anchored?(regexp)
-     regexp.source =~ /\A(\\A|\^).*(\\Z|\$)\Z/ ? true : false
-    end
-    module_function :regexp_anchored?
-
     def normalize_extended_expression(regexp)
       return regexp unless regexp.options & Regexp::EXTENDED != 0
       source = regexp.source

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: rack-mount
 version: !ruby/object:Gem::Version 
-  version: 0.4.6
+  version: 0.4.7
 platform: ruby
 authors: 
 - Joshua Peek
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-02-08 00:00:00 -06:00
+date: 2010-02-09 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency